Re: [PATCHES] Patch that deals with that AtCommit_Portals encounters

Tom Lane wrote: Thomas Hallgren [EMAIL PROTECTED] writes: I'm not sure what you mean. Earlier you rejected my bug-report on the iterator because you it was the callers responsability to deal with it (hence this patch). Are you now suggesting that we fix that bug instead? Quite honestly,

Re: [PATCHES] [pgsql-hackers-win32] [HACKERS] snprintf causes regression tests to fail

On Wed, 16 Mar 2005 01:00:21 -0500 (EST), Bruce Momjian pgman@candle.pha.pa.us wrote: I have applied a modified version of your patch, attached. I am so sorry, I sent untested patch again. Thank you very much for patience in fixing it. The patch looks perfectly fine and works under Solaris.

Re: [PATCHES] COPY CSV header line feature

ammended patch attached. sorry for the oversight. I agree with Tom's remark - it's far too easy to miss this. cheers andrew Alvaro Herrera wrote: On Tue, Mar 15, 2005 at 08:55:36PM -0600, Andrew Dunstan wrote: Alvaro Herrera said: On Sun, Mar 13, 2005 at 06:32:20PM -0500, Andrew

Re: [PATCHES] [pgsql-hackers-win32] [HACKERS] snprintf causes regression tests

Nicolai Tufar wrote: On Wed, 16 Mar 2005 01:00:21 -0500 (EST), Bruce Momjian pgman@candle.pha.pa.us wrote: I have applied a modified version of your patch, attached. Here is a patch that fixes the %*$ case. FYI, I am going to pgindent snprintf.c to make it consistent so please us CVS

Re: [PATCHES] [INTERFACES] libecpg (8.0 and CVS) hits a gcc bug on powerpc

Christof Petig schrieb: So I propose the following hack (feel free to improve it!) to go into mainline. Since only powerpc and amd64 are affected (and the old method does not work at all here at all) the patch should not be controversial. I failed to mention that call by reference is the default

Re: [PATCHES] [pgsql-hackers-win32] [HACKERS] snprintf causes regression

Nicolai Tufar wrote: On Wed, 16 Mar 2005 01:00:21 -0500 (EST), Bruce Momjian pgman@candle.pha.pa.us wrote: I have applied a modified version of your patch, attached. I am so sorry, I sent untested patch again. Thank you very much for patience in fixing it. The patch looks perfectly

Re: [PATCHES] Sort psql output

Christopher Kings-Lynne wrote: This patch makes \d on tables and views sort fk constraints, triggers and rules alphabetically in the output. This makes it the same as for indexes and stops the irritating random or reverse ordering it currently has. Thanks, applied. -Neil

Re: [PATCHES] Improvement to charset docs

Christopher Kings-Lynne wrote: This just adds a link to the pattern_ops operator class section from the part of the locale docs that mentions that indexes don't work for LIKE under a non-C locale. Patch applied, with some changes. We can't assume that the reader can follow hyperlinks, since

Re: [PATCHES] [HACKERS] contrib/pg_buffercache

Andrew Dunstan wrote: It fixes the build error on Windows - haven't tried because i don't have time, but I know it won't work on Cygwin, because WIN32 isn't (usually) defined on Cygwin - see previous almost endless discussions. Yes - I recall that discussion a while ago. This patch should sort the

Re: [PATCHES] [HACKERS] contrib/pg_buffercache

Mark Kirkwood wrote: Andrew Dunstan wrote: It fixes the build error on Windows - haven't tried because i don't have time, but I know it won't work on Cygwin, because WIN32 isn't (usually) defined on Cygwin - see previous almost endless discussions. Yes - I recall that discussion a while

[PATCHES] refactor preprocess_targetlist

This patch moves some code for preprocessing FOR UPDATE from grouping_planner() to preprocess_targetlist(), according to a comment in grouping_planner(). I think the refactoring makes sense, and moves some extraneous details out of grouping_planner(). Barring any objections, I'll apply this to