Re: [PATCHES] hash index work

2005-05-28 Thread Neil Conway
Bruce Momjian wrote: Neil, I have added these item to the TODO list. Do you plan on applying this? No, I don't have any immediate plans to apply it, as unfortunately I didn't see a performance win :-( It's also possible I'm just not measuring the right workload, although I don't have time to

Re: [PATCHES] psql backslash consistency

2005-05-28 Thread Robert Treat
On Friday 27 May 2005 20:45, Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > On Fri, May 27, 2005 at 04:16:15PM -0400, Tom Lane wrote: > >> There seems to be a distinct lack of unanimity about that judgment ;-) > > > > Well, yes, _across Postgres hackers_. But if we were to ask >

Re: [PATCHES] psql backslash consistency

2005-05-28 Thread Tom Lane
Robert Treat <[EMAIL PROTECTED]> writes: > I'm not against the idea of a config variable, but this is what, the > third or fourth go around on this? It seems rather unfair to put this > burden upon the current patch writer at this stage of the game... The fact that objections keep being raised sh

Re: [PATCHES] hash index work

2005-05-28 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > The patch does two things: (1) change hash indexes to only store the > key's hash value, not the entire key (2) store index elements within a > hash bucket in order of hash key and search for matches via binary > search. #1 is definitely a win in some in

Re: [PATCHES] psql backslash consistency

2005-05-28 Thread Robert Treat
On Saturday 28 May 2005 11:12, Tom Lane wrote: > Robert Treat <[EMAIL PROTECTED]> writes: > > I'm not against the idea of a config variable, but this is what, the > > third or fourth go around on this? It seems rather unfair to put this > > burden upon the current patch writer at this stage of the

Re: [PATCHES] [HACKERS] patches for items from TODO list

2005-05-28 Thread Bruce Momjian
Here is an updated version of the COPY \x patch. It is the first patch attached. Also, I realized that if we support \x in COPY, we should also support \x in strings to the backend. This is the second patch. Third, I found out that psql has some unusual handling of escaped numbers. Instead of

Re: [PATCHES] [HACKERS] patches for items from TODO list

2005-05-28 Thread Tom Lane
Bruce Momjian writes: > Here is an updated version of the COPY \x patch. It is the first patch > attached. > Also, I realized that if we support \x in COPY, we should also support > \x in strings to the backend. This is the second patch. Do we really want to do any of these things? We've been