Re: [PATCHES] [HACKERS] LDAP auth

2006-03-06 Thread Albe Laurenz
> > Was there ever a decision in "the libcurl thread"? > > No, not yet. > > Personally I'm unconvinced that we should depend on libcurl: if it's > going to use openldap to do LDAP work, then the only good > reason to use libcurl rather than openldap directly is if there's some > clear use-case

Re: [PATCHES] [HACKERS] LDAP auth

2006-03-06 Thread Magnus Hagander
> > > Was there ever a decision in "the libcurl thread"? > > > > No, not yet. > > > > Personally I'm unconvinced that we should depend on > libcurl: if it's > > going to use openldap to do LDAP work, then the only good reason to > > use libcurl rather than openldap directly is if there's some

Re: [PATCHES] LDAP auth

2006-03-06 Thread Magnus Hagander
> Andrew Dunstan wrote: > > I suggested libcurl in another context, and not so much as > a means of > > getting at LDAP data as a means of getting config data from > non-LDAP > > as well as LDAP sources. If all we want is LDAP then using libcurl > > would indeed be introducing an unnecessary d

Re: [PATCHES] implement prepared queries in plperl

2006-03-06 Thread Dmitry Karasik
> >OK, I'll take another look. I'm still curious to know why pltcl > >doesn't need to call spi_free_plan. Maybe it does need to ... > I have committed the patch and docs for this - it's an important feature > and I would like people banging on it. > I'd like to review the API we provide to plperl

Re: [PATCHES] LDAP auth

2006-03-06 Thread Bruce Momjian
Patch applied. Thanks. --- Magnus Hagander wrote: > This patch adds native LDAP auth, for those platforms that don't have > PAM (such as Win32, but also unixen without PAM). On Unix, uses > OpenLDAP. On win32, uses the bui

Re: [PATCHES] TODO item: remove postmaster -o option

2006-03-06 Thread Peter Eisentraut
Markus Bertheau wrote: > The docs say > > "The use of this option is obsolete; all command-line options > for server processes can be specified directly on the > postmaster command line" First, note the use of "obsolete" -- there are better ways to achieve what you want -- as opposed to "deprecat

Re: [PATCHES] [HACKERS] Backslashes in string literals

2006-03-06 Thread Bruce Momjian
Great patch. Applied. Thanks. --- Kevin Grittner wrote: > The attached patch combines work from two patches recently posted by > Bruce Momjian, along with a necessary change to guc.c which is missing > from those patches.

Re: [PATCHES] [HACKERS] Zeroing damaged pages

2006-03-06 Thread Tom Lane
Bruce Momjian writes: > + /* Even if zero_damaged_pages is true, we don't want autovacuum > zeroing. */ > + zero_damaged_pages = false; This is completely incorrect; you need to set the variable via GUC, else it will still be overridden from postgresql.conf if a SIGHUP arrives. I beli

Re: [PATCHES] [HACKERS] Zeroing damaged pages

2006-03-06 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > > + /* Even if zero_damaged_pages is true, we don't want autovacuum > > zeroing. */ > > + zero_damaged_pages = false; > > This is completely incorrect; you need to set the variable via GUC, else > it will still be overridden from postgresql.conf