Re: [PATCHES] xlog directory at initdb time

2007-01-03 Thread Peter Eisentraut
Am Mittwoch, 27. Dezember 2006 02:56 schrieb Euler Taveira de Oliveira: > This simple patch lets someone specifies the xlog directory at initdb > time. It uses symlinks to do it, and create and/or set permissions at > the directory as appropriate. On the name of the option, it's not actually a "da

Re: [HACKERS] [PATCHES] Patch to log usage of temporary files

2007-01-03 Thread Simon Riggs
On Tue, 2007-01-02 at 18:20 -0500, Tom Lane wrote: > Bill Moran <[EMAIL PROTECTED]> writes: > > In response to Alvaro Herrera <[EMAIL PROTECTED]>: > >> Please change things to save the stat() syscall when the feature is not > >> in use. > > > Do you have a suggestion on how to do that and still ha

Re: [HACKERS] [PATCHES] Patch to log usage of temporary files

2007-01-03 Thread Andrew Dunstan
Bill Moran wrote: + if (trace_temp_files != -1) Might be more robust to say if (trace_temp_files >= 0) cheers andrew ---(end of broadcast)--- TIP 6: explain analyze is your friend

Re: [HACKERS] [PATCHES] Patch to log usage of temporary files

2007-01-03 Thread Bill Moran
In response to "Simon Riggs" <[EMAIL PROTECTED]>: > On Tue, 2007-01-02 at 18:20 -0500, Tom Lane wrote: > > Bill Moran <[EMAIL PROTECTED]> writes: > > > In response to Alvaro Herrera <[EMAIL PROTECTED]>: > > >> Please change things to save the stat() syscall when the feature is not > > >> in use. >

Re: [HACKERS] [PATCHES] Patch to log usage of temporary files

2007-01-03 Thread Bill Moran
Andrew Dunstan <[EMAIL PROTECTED]> wrote: > > Bill Moran wrote: > > + if (trace_temp_files != -1) > > > > Might be more robust to say > > if (trace_temp_files >= 0) Because it would allow for the easy addition of more negative numbers with magic value? -

Re: [HACKERS] [PATCHES] Patch to log usage of temporary files

2007-01-03 Thread Andrew Dunstan
Bill Moran wrote: > Andrew Dunstan <[EMAIL PROTECTED]> wrote: >> >> Bill Moran wrote: >> > + if (trace_temp_files != -1) >> > >> >> Might be more robust to say >> >> if (trace_temp_files >= 0) > > Because it would allow for the easy addition of more negative numbers > with magic value?

Re: [PATCHES] xlog directory at initdb time

2007-01-03 Thread Euler Taveira de Oliveira
Peter Eisentraut wrote: > On the name of the option, it's not actually a "data" directory, so I'd just > call it --xlogdir, parallel to --datadir. > Seems reasonable. Patch modified is attached. -- Euler Taveira de Oliveira http://www.timbira.com/ *** ./doc/src/sgml/ref/initdb.sgml.orig 2

Re: [PATCHES] Tablespace for temporary objects and sort files

2007-01-03 Thread Jaime Casanova
On 12/27/06, Albert Cervera Areny <[EMAIL PROTECTED]> wrote: Hi, here's a new version of the patch against HEAD with both, table and sort files working correctly for me. Regression tests work too. I'd like to ask again the question I made on the first post as no answer was given at