Tom Lane wrote:
Tom Dunstan <[EMAIL PROTECTED]> writes:
Here's the current version of the enums patch.
Applied with revisions --- some cosmetic, some not so much.
Attached is the patch-as-applied if you care to compare; feel free
to ask questions about anything not obvious.
There's a little
On Mon, Apr 02, 2007 at 04:27:33PM +, FAST PostgreSQL wrote:
> On Sat, 31 Mar 2007 14:09, you wrote:
> > FAST PostgreSQL wrote:
> > >> Am Dienstag, 3. April 2007 20:33 schrieb FAST PostgreSQL:
> > >>> Attached is the completed patch for the COPY-able sql log outputs.
> > >>
> > >> Could you ple
Heikki Linnakangas wrote:
Tom Lane wrote:
Tom Dunstan <[EMAIL PROTECTED]> writes:
Here's the current version of the enums patch.
Applied with revisions --- some cosmetic, some not so much.
Attached is the patch-as-applied if you care to compare; feel free
to ask questions about anything not o
> Looks like we need to check the length on type creation
> too.
>
> I'll fix later if not beaten to it.
It works for me (ie fails with an appropriate error) locally
on Linux FC6 x86-64. Perhaps this platform initializes
memory to zero on allocation? I dunno. Anyway, if you can
reproduce it, plea
On Sun, 2007-04-01 at 19:40 +0200, Magnus Hagander wrote:
> Simon Riggs wrote:
> > I've sent through v10 of my patch for transaction guarantee = off twice
> > now and it hasn't shown up on-list. I don't appear to be blocked, so I'm
> > not sure what the problem is?
> >
> > Sent: 31 Mar 22:09 TZ+01
On Mon, Apr 02, 2007 at 03:08:08PM +0100, Simon Riggs wrote:
> On Sun, 2007-04-01 at 19:40 +0200, Magnus Hagander wrote:
> > Simon Riggs wrote:
> > > I've sent through v10 of my patch for transaction guarantee = off twice
> > > now and it hasn't shown up on-list. I don't appear to be blocked, so I'
Once more, with feeling.
On Sun, 2007-04-01 at 12:11 +0100, Simon Riggs wrote:
> Resending...
>
> Forwarded Message
> From: Simon Riggs <[EMAIL PROTECTED]>
> To: pgsql-patches@postgresql.org
> Cc: pgsql-hackers@postgresql.org
> Subject: Deferred Transactions, Transaction Guarant
"Tom Dunstan" <[EMAIL PROTECTED]> writes:
>> Looks like we need to check the length on type creation
>> too.
> It works for me (ie fails with an appropriate error) locally
> on Linux FC6 x86-64. Perhaps this platform initializes
> memory to zero on allocation?
Sounds more like you're testing with
Heikki Linnakangas <[EMAIL PROTECTED]> writes:
> There's a little bug:
> postgres=# CREATE TYPE aenum AS ENUM ('a','b','c'); CREATE TYPE
> postgres=# CREATE TABLE t (e aenum); CREATE TABLE postgres=# INSERT
> INTO t VALUES
> ('fo
Simon Riggs wrote:
> I've sent through v10 of my patch for transaction guarantee = off twice
> now and it hasn't shown up on-list. I don't appear to be blocked, so I'm
> not sure what the problem is?
>
> Sent: 31 Mar 22:09 TZ+01:00
> Sent: 1 Apr 12:11 TZ+01:00
What an obvious ploy to get more ti
Tom Lane wrote:
Heikki Linnakangas <[EMAIL PROTECTED]> writes:
There's a little bug:
postgres=# CREATE TYPE aenum AS ENUM ('a','b','c'); CREATE TYPE
postgres=# CREATE TABLE t (e aenum); CREATE TABLE postgres=# INSERT
INTO t VALUES
('f
Hm, I suppose we should apply truncate_identifier rather than letting
the strings be blindly truncated (perhaps in mid-character). Should we
have it throw the truncation NOTICE, or not? First thought is to do so
during CREATE TYPE but not during plain enum_in().
I don't see much point in tr
Tom Dunstan <[EMAIL PROTECTED]> writes:
> I was about to suggest that we just truncate the value in the input
> function and look it up on the basis that if it's too long, the lookup
> will fail and we can just tell the user that it wasn't a valid value.
> But if there's a valid value that has t
"Magnus Hagander" <[EMAIL PROTECTED]> writes:
>> Plaintext patch, plus two plaintext .c files.
>
> Then I have no clue.
Actually I've had more success with .tar.gz than plain text attachments.
--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com
---
Tom Lane wrote:
While all this reasoning is perfectly OK on its own terms, it ignores
the precedents of SQL identifier handling. Maybe we should revisit the
question of whether the labels are identifiers.
If we do that can we still cache the values in the syscache? My
impression fr
Bruce Momjian wrote:
> Simon Riggs wrote:
>> I've sent through v10 of my patch for transaction guarantee = off twice
>> now and it hasn't shown up on-list. I don't appear to be blocked, so I'm
>> not sure what the problem is?
>>
>> Sent: 31 Mar 22:09 TZ+01:00
>> Sent: 1 Apr 12:11 TZ+01:00
>
> Wha
Tom Lane wrote:
While all this reasoning is perfectly OK on its own terms, it ignores
the precedents of SQL identifier handling. Maybe we should revisit the
question of whether the labels are identifiers.
Implying that they shouldn't be quoted like text (or should be
double-quoted if required
Andrew Dunstan <[EMAIL PROTECTED]> writes:
> Tom Lane wrote:
>> While all this reasoning is perfectly OK on its own terms, it ignores
>> the precedents of SQL identifier handling. Maybe we should revisit the
>> question of whether the labels are identifiers.
> If we do that can we still cache the
Tom Dunstan wrote:
Tom Lane wrote:
While all this reasoning is perfectly OK on its own terms, it ignores
the precedents of SQL identifier handling. Maybe we should revisit the
question of whether the labels are identifiers.
Implying that they shouldn't be quoted like text (or should be
doubl
Gregory Stark <[EMAIL PROTECTED]> writes:
> "Magnus Hagander" <[EMAIL PROTECTED]> writes:
>>> Plaintext patch, plus two plaintext .c files.
>>
>> Then I have no clue.
> Actually I've had more success with .tar.gz than plain text attachments.
I think the filter is not on the name or actual conte
Tom Lane wrote:
But probably making them act like identifiers is not a good idea,
because I doubt we want automatic downcasing in enum_in. People
wouldn't be happy if they had to write WHERE color = '"Red"' or
> something like that to get at a mixed-case enum label.
Ah, that's what you had in
Dave Page wrote:
> Bruce Momjian wrote:
> > Simon Riggs wrote:
> >> I've sent through v10 of my patch for transaction guarantee = off twice
> >> now and it hasn't shown up on-list. I don't appear to be blocked, so I'm
> >> not sure what the problem is?
> >>
> >> Sent: 31 Mar 22:09 TZ+01:00
> >> Sen
Bruce Momjian wrote:
> Dave Page wrote:
>> Bruce Momjian wrote:
>>> Simon Riggs wrote:
I've sent through v10 of my patch for transaction guarantee = off twice
now and it hasn't shown up on-list. I don't appear to be blocked, so I'm
not sure what the problem is?
Sent: 31 Mar
Tom Lane wrote:
> Gregory Stark <[EMAIL PROTECTED]> writes:
>> "Magnus Hagander" <[EMAIL PROTECTED]> writes:
Plaintext patch, plus two plaintext .c files.
>>> Then I have no clue.
>
>> Actually I've had more success with .tar.gz than plain text attachments.
>
> I think the filter is not on
Dave Page wrote:
> Bruce Momjian wrote:
> > Dave Page wrote:
> >> Bruce Momjian wrote:
> >>> Simon Riggs wrote:
> I've sent through v10 of my patch for transaction guarantee = off twice
> now and it hasn't shown up on-list. I don't appear to be blocked, so I'm
> not sure what the pro
Tom Dunstan wrote:
Let's just throw the error instead. (I agree that enum_in can just fail
with "no such label", but CREATE TYPE ought to give a specific
error about it.)
Agreed.
Andrew, you said you had a mostly-working patch already?
Working patch attached. If everyone's happy I'll appl
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
---
Si
On Fri, Mar 30, 2007 at 05:08:42PM -0400, Tom Lane wrote:
> David Fetter <[EMAIL PROTECTED]> writes:
> > After several rounds of patches, it appears that it might be easier to
> > create a new typtype entry, which I'll tentatively call 'a' because it
> > seems a little fragile and a lot inelegant a
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
---
st
Andrew Dunstan <[EMAIL PROTECTED]> writes:
> Working patch attached. If everyone's happy I'll apply it.
Why not put the create-time length test into EnumValuesCreate's loop,
which has to grovel through the list already?
I'm wondering why bother with the temp variable in cstring_enum,
as opposed t
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
---
IT
Tom Lane wrote:
Andrew Dunstan <[EMAIL PROTECTED]> writes:
Working patch attached. If everyone's happy I'll apply it.
Why not put the create-time length test into EnumValuesCreate's loop,
which has to grovel through the list already?
My idea was to do the error check before callin
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
---
IT
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
---
Gr
Added to TODO:
o Allow PL/Python to return boolean rather than 1/0
http://archives.postgresql.org/pgsql-patches/2007-01/msg00596$
---
Guido Goldstein wrote:
> Peter Eisentraut wrote:
> > Guido Goldstein w
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
---
Ko
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
---
Gr
Andrew Dunstan <[EMAIL PROTECTED]> writes:
> Tom Lane wrote:
>> Why not put the create-time length test into EnumValuesCreate's loop,
>> which has to grovel through the list already?
> My idea was to do the error check before calling TypeCreate. If that
> doesn't matter I can move it - it just se
Tom Lane wrote:
> "Greg Sabino Mullane" <[EMAIL PROTECTED]> writes:
> > I'll save the full rant for my blog :), but wanted to submit this
> > documentation
> > patch for this listen gotcha that's been bugging me for a while. I'd like
> > to see LISTEN and NOTIFY changed to use a simple text stri
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
---
FA
I assume this replaces all your earlier multi-byte LIKE patches.
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
--
This has been saved for the 8.4 release:
http://momjian.postgresql.org/cgi-bin/pgpatches_hold
---
Bruce Momjian wrote:
>
> OK, patch reverted. Authors, would you please resubmit with fixes?
> Thanks.
>
> ---
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
---
Tr
Where is the final version of this patch? What patches are stuck in the
patch moderator queue?
---
Simon Riggs wrote:
> On Sat, 2007-03-10 at 07:59 +, Simon Riggs wrote:
> > On Fri, 2007-03-09 at 18:05 -0500, Tom Lane w
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
---
Pa
I assume this patch is not ready for 8.3, so I added a URL to the TODO
list for it.
---
Tom Lane wrote:
> Joachim Wieland <[EMAIL PROTECTED]> writes:
> > On Tue, Mar 13, 2007 at 11:52:38AM -0400, Tom Lane wrote:
> >> Why do
Nikolay Samokhvalov wrote:
> On 3/22/07, Peter Eisentraut <[EMAIL PROTECTED]> wrote:
> > Bruce Momjian wrote:
> > > Patch applied.
> >
> > This code seems to think that if an xml datum starts with " > document. That is completely bogus.
>
> Agreed. I'll fix it.
Nikolay, it has been a week, and I
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
---
Ma
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
---
Da
Michael, is there any progress on this?
---
Michael Meskes wrote:
> On Mon, Mar 19, 2007 at 09:48:19AM +0100, Magnus Hagander wrote:
> > > Q2. Do we need to use PQescapeStringConn() instead of PQescapeString()?
> > >PQes
Heikki Linnakangas wrote:
> Alvaro Herrera wrote:
> > Heikki Linnakangas wrote:
> >> Here's an update, fixing conflict by Tom's recent commit of Simon's
> >> patch to skip WAL-inserts when archiving is not enabled.
> >
> > Hmm, wouldn't it be better if the rewriteheap.c file was in
> > access/hea
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
---
Te
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
---
Gr
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
---
Gr
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
---
FA
Bruce Momjian wrote:
>
> Your patch has been added to the PostgreSQL unapplied patches list at:
>
> http://momjian.postgresql.org/cgi-bin/pgpatches
>
> It will be applied as soon as one of the PostgreSQL committers reviews
> and approves it.
>
So, hum, what happened to the idea of creati
Nikolay Samokhvalov wrote:
> I apologize for it. I was extremely busy that week.
> Fixes will follow ASAP, I'm working on it. 2 days are enough, it's good
> deadline for me.
> Sorry for delay.
Yes, that is fine. Thanks.
---
On Mon, Apr 02, 2007 at 10:01:44PM -0400, Alvaro Herrera wrote:
> Bruce Momjian wrote:
> >
> > Your patch has been added to the PostgreSQL unapplied patches list
> > at:
> >
> > http://momjian.postgresql.org/cgi-bin/pgpatches
> >
> > It will be applied as soon as one of the PostgreSQL commit
Greg Smith wrote:
> This patch puts entries in the log file around some backend events
> that regularly cause client pauses, most of which are visible only
> when running with log_min_messages = debug2.
Something that is aimed at a user should not be enabled at a "debug"
level. Debug levels are
David Fetter <[EMAIL PROTECTED]> writes:
> On Mon, Apr 02, 2007 at 10:01:44PM -0400, Alvaro Herrera wrote:
>> So, hum, what happened to the idea of creating the array types only
>> on demand?
> Scotched, as far as I could tell,
More like "you submitted a patch that entirely ignores multiple peopl
60 matches
Mail list logo
