Re: [PATCHES] tsearch refactorings

2007-09-07 Thread Heikki Linnakangas
Tom Lane wrote: > Any portion of a binary value that is considered textual should be > converted to and from client encoding --- cf textsend/textrecv. > This should be pretty trivial to fix, just call a different support > routine. You do need to adjust length and position fields in the structs as

[PATCHES] SET TRANSACTION conformance to SQL:2003

2007-09-07 Thread Simon Riggs
Short patch to implement SQL standard behaviour of the SET TRANSACTION command. According to their publically accessible docs, I note that MySQL and Ingres correctly implement this behaviour, SQLServer does this also (and more), while Oracle and DB2 do so since they use implicit transaction blocks.

Re: [PATCHES] SET TRANSACTION conformance to SQL:2003

2007-09-07 Thread Simon Riggs
On Fri, 2007-09-07 at 14:00 +0100, Simon Riggs wrote: > Short patch -- Simon Riggs 2ndQuadrant http://www.2ndQuadrant.com Index: doc/src/sgml/ref/set_transaction.sgml === RCS file: /projects/cvsroot/pgsql/doc/src/sgml/ref/set_t

Re: [PATCHES] tsearch refactorings

2007-09-07 Thread Teodor Sigaev
BTW, Teodor, are you intending to review/apply Heikki's tsearch fixes, or do you want someone else to do it? I'll do it. -- Teodor Sigaev E-mail: [EMAIL PROTECTED] WWW: http://www.sigaev.ru/ ---

Re: [PATCHES] tsearch refactorings

2007-09-07 Thread Teodor Sigaev
I am getting confused with the patches and version I have lying around here... I think I'll have to wait for review of the patches I've posted this far before I continue hacking. Sorry for delay - I was busy by another. All your patches are committed with very small changes. -- Teodor Sigaev

XML binary I/O (was Re: [PATCHES] tsearch refactorings)

2007-09-07 Thread Heikki Linnakangas
Heikki Linnakangas wrote: > BTW, the encoding of the XML datatype looks pretty funky. xml_recv first > reads the xml string with pq_getmsgtext, which applies a client->server > conversion. Then the xml declaration is parsed, extracting the encoding > attribute. Then the string is converted again fr

Re: [PATCHES] tsearch refactorings

2007-09-07 Thread Heikki Linnakangas
Teodor Sigaev wrote: >> I am getting confused with the patches and version I have lying around >> here... I think I'll have to wait for review of the patches I've posted >> this far before I continue hacking. > Sorry for delay - I was busy by another. All your patches are committed > with very smal

[PATCHES] WIP - MSVC build script replacements

2007-09-07 Thread Andrew Dunstan
Here after much tedious testing are some perl replacements for src/tools/msvc/build.bat and src/tools/msvc/vcregress.bat, as previouslty discussed on -hackers. They do not exhibit the error reporting problems I have had on XP, and they work nicely with a slightly modified buildfarm script. Th

[PATCHES] WIP patch for latestCompletedXid method of computing snapshot xmax

2007-09-07 Thread Tom Lane
This patch implements Florian's idea about how to manage snapshot xmax without the ugly and performance-losing tactic of taking XidGenLock and ProcArrayLock at the same time. I had to do a couple of slightly klugy things to get bootstrap and prepared transactions to work, but on the whole it seems

Re: [PATCHES] WIP patch for latestCompletedXid method of computing snapshot xmax

2007-09-07 Thread Gregory Stark
"Tom Lane" <[EMAIL PROTECTED]> writes: > This patch implements Florian's idea about how to manage snapshot xmax > without the ugly and performance-losing tactic of taking XidGenLock and > ProcArrayLock at the same time. I had to do a couple of slightly klugy > things to get bootstrap and prepared

Re: [PATCHES] HOT patch - version 15

2007-09-07 Thread Bruce Momjian
Heikki Linnakangas wrote: > Tom Lane wrote: > > I wrote: > >> Hmm ... also check commit status (pg_clog access). I've always thought > >> that those things couldn't be done in bgwriter, because it wasn't > >> running real transactions, but right at the moment I can't see that > >> there is any obs

Re: [PATCHES] HOT patch - version 15

2007-09-07 Thread Bruce Momjian
Simon Riggs wrote: > > We could begin pruning only when the chain is N long. Currently N=2, but > > we could set N=3+ easily enough. There's no code yet to actually count > > that, but we can do that easily as we do each lookup. We should also be > > able to remember the visibility result for each

Re: [PATCHES] WIP patch for latestCompletedXid method of computing snapshot xmax

2007-09-07 Thread Tom Lane
Gregory Stark <[EMAIL PROTECTED]> writes: > "Tom Lane" <[EMAIL PROTECTED]> writes: >> This patch implements Florian's idea about how to manage snapshot xmax >> without the ugly and performance-losing tactic of taking XidGenLock and >> ProcArrayLock at the same time. I had to do a couple of slightl

Re: [PATCHES] HOT patch - version 15

2007-09-07 Thread Simon Riggs
On Fri, 2007-09-07 at 22:08 -0400, Bruce Momjian wrote: > Simon Riggs wrote: > > > We could begin pruning only when the chain is N long. Currently N=2, but > > > we could set N=3+ easily enough. There's no code yet to actually count > > > that, but we can do that easily as we do each lookup. We sho