Re: [PATCHES] [GENERAL] Temporary tables and miscellaneous schemas

2003-12-20 Thread Sean Chittenden
> > so that's what I did, but I think now I have to add a test so only > > non-visible temp schemas are suppressed, > > You are complicating something that could be simple. Why not just > suppress schemas named 'pg_temp_XXX', period? Because that's what I originally did and you shot it down as a

Re: [PATCHES] [GENERAL] Temporary tables and miscellaneous schemas

2003-12-20 Thread Tom Lane
Sean Chittenden <[EMAIL PROTECTED]> writes: > Because that's what I originally did and you shot it down as a bad > patch because you thought it wasn't in PostgreSQL's interest to filter > what we showed the user. I'm still unconvinced on that, actually ... but it beats the heck out of filtering

Re: [PATCHES] [GENERAL] Temporary tables and miscellaneous schemas

2003-12-20 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Also, how do we know something is a temp schema? Just the prefix > > pg_temp_*? > > Yeah. Remember that all schemas named pg_XXX are reserved for system > use. For the moment, testing for pg_temp_XXX is a bulletproof test, > and we

Re: [PATCHES] [GENERAL] Temporary tables and miscellaneous schemas

2003-12-20 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> Oh, okay. I would not object to suppressing pg_temp_NNN schemas from > >> the \dn display. That isn't what this patch does, however. > > > OK. I read the TODO and it says only: > > * Have psql \dn show only

Re: [PATCHES] [GENERAL] Temporary tables and miscellaneous schemas

2003-12-20 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Also, how do we know something is a temp schema? Just the prefix > pg_temp_*? Yeah. Remember that all schemas named pg_XXX are reserved for system use. For the moment, testing for pg_temp_XXX is a bulletproof test, and we can certainly adapt psql's te

Re: [PATCHES] [GENERAL] Temporary tables and miscellaneous schemas

2003-12-20 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> Oh, okay. I would not object to suppressing pg_temp_NNN schemas from >> the \dn display. That isn't what this patch does, however. > OK. I read the TODO and it says only: > * Have psql \dn show only visible schemas using curre

[PATCHES] fork/exec patch: pgstat + BootstrapMain

2003-12-20 Thread Claudio Natoli
For application to HEAD, pending community review. Continued rearrangement to permit pgstat + BootstrapMain processes to be fork/exec'd, in the same mode as the previous patch for backends. Cheers, Claudio --- Certain disclaimers and policies apply to all email sent from Memetrics. For the ful

Re: [PATCHES] psql \i handling ~ in specified file name

2003-12-20 Thread Tom Lane
Zach Irmen <[EMAIL PROTECTED]> writes: > A reviewable patch that could handle tilde expansion for > psql \i ~/filename Needs a bit of work. What happens if getenv("HOME") returns NULL? You also need to think about Windows (dunno if the whole thing is even meaningful there, but if it is then you n

Re: [PATCHES] [GENERAL] Temporary tables and miscellaneous schemas

2003-12-20 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Agreed showing just search path and implicit schemas is pretty dumb. I > > think the issue was that every backend with a temp table was showing up, > > pretty much swamping the actual schemas he is using. > > Oh, okay. I would not o

Re: [PATCHES] [GENERAL] Temporary tables and miscellaneous schemas

2003-12-20 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Agreed showing just search path and implicit schemas is pretty dumb. I > think the issue was that every backend with a temp table was showing up, > pretty much swamping the actual schemas he is using. Oh, okay. I would not object to suppressing pg_temp

Re: [PATCHES] [GENERAL] Temporary tables and miscellaneous schemas

2003-12-20 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > This patch uses current_schemas('true') to display only the schemas in > > the current search path and implicit schemas. > > The more I look at this, the sillier it looks. It converts \dn into > an expensive substitute for "select cu

Re: [PATCHES] [COMMITTERS] pgsql-server/ oc/src/sgml/datatype.sgml rc/bac ...

2003-12-20 Thread Bruce Momjian
Tom Lane wrote: > [EMAIL PROTECTED] (Bruce Momjian) writes: > > Attached is a patch that addressed all the discussed issues that > > did not break backward compatability, > > Was this patch actually agreed to? I hadn't gotten around to looking > at it because I thought Peter was still obj

Re: [PATCHES] [GENERAL] Temporary tables and miscellaneous schemas

2003-12-20 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > This patch uses current_schemas('true') to display only the schemas in > the current search path and implicit schemas. The more I look at this, the sillier it looks. It converts \dn into an expensive substitute for "select current_schemas(true)". In pr

[PATCHES] psql \i handling ~ in specified file name

2003-12-20 Thread Zach Irmen
refers to following item on TODO Have psql '\i ~/' actually load files it displays from home dir A reviewable patch that could handle tilde expansion for psql \i ~/filename or psql \i ~username/filename -- Zach Irmen cvs server: Diffing . Index: command.c ===

Re: [PATCHES] [GENERAL] Temporary tables and miscellaneous schemas

2003-12-20 Thread Bruce Momjian
pgman wrote: > Tom Lane wrote: > > Bruce Momjian <[EMAIL PROTECTED]> writes: > > > How about if we add a UNION that does: > > > UNION > > > SELECT 'non-local temp schemas skipped', NULL > > > > I think showing that would only be appropriate if we actually *did* skip > > some. Finding that out

Re: [PATCHES] fork/exec patch

2003-12-20 Thread Bruce Momjian
Patch applied. Thanks. I had a little trouble patching shmem.c but got it fixed. --- Claudio Natoli wrote: > > Resubmission, incorporating Neil Conway's comments and some minor > corrections. > > > -Original Message

Re: [PATCHES] ISO 8601 "Time Intervals" of the "format with time-unit

2003-12-20 Thread Bruce Momjian
Patch applied. Thanks. --- Ron Mayer wrote: > > -Original Message- > > > > Is this ready for application? It looks good to me. However, there is > > an "Open issues" section. > > In my mind there were two categ