Re: [PATCHES] eventlog fix

The purpose of this patch is to fix an error when log_destination is set to 'eventlog' value in postgresql.conf files. Looks good to me, just a couple of tiny things: snip After discussion on win32 mailing list, I suggest to store source under src/bin/pg_event I assume you mean

Re: [PATCHES] pg_ctl.c

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Bruce Momjian wrote: | Gaetano Mendola wrote: | |Bruce Momjian wrote: | | |Here is the C version of pg_ctl.c written by Andrew Dunstan and updated |by me. | |You can use it by creating a src/bin/pg_ctl_test directory and putting |the C and Makefile

Re: [PATCHES] [HACKERS] Configuration patch

Here is an updated version of your patch. I removed the tablespace part because we are going to have real tablespaces in 7.5 rather than initlocation hacks. I added documention of the new guc parameters, and a paragraph in the postmaster manual page describing the new -D/PGDATA behavior. (Is

Re: [PATCHES] Small change in link order

Patch applied. Thanks. --- Magnus Hagander wrote: This patch changes the order of libraries on the link command when linking things with pgport. This is required for win32 to build when modules in libpgport refer to

Re: [PATCHES] Cancel/Kill backend functions

Patch applied. Thanks. Not sure where to document them. I think we talked about this already. I updated the system catalog version. --- Magnus Hagander wrote: Arrgh, when will I ever learn :-( Attached. //Magnus

Re: [PATCHES] Small doc patch for area() function...

Doc patch applied. The geometry diff you attached is related to negative zeros. I think you will find geometry_1.out will be a better match for you. I thought our code now automatically picked the proper geometry file. However, I can't find out how that file is used.

Re: [PATCHES] eventlog fix

Hello magnus, I assume you mean src/bin/pgevent, to be consistent with the naming used inside the program. OK, I Modify Makefile subdir value. In fact I name it pg_event because many directory under src/bin began with pg_ . Second, I'd register the source as PostgreSQL, not PostGreSQL. I

Re: [PATCHES] Relocatable locale

With no one coming up with a better idea, this applied patch adds PGETC (for pg_service.conf) and PGLOCALE (for locale dir) environment variable processing to libpq. The patch also adds code to our client apps so we set the environment variable directly based on our binary location, unless it is

Re: [PATCHES] Compiling libpq with VisualC

Bruce Momjian wrote: I noticed that SYSCONFDIR will also be an issue for relocatable installs just like localedir. I will address them in the same way either as an environment variable or libpq function call to set the location. Fixed. fe-connect.c: - pg_config_paths.h isn't

Re: [PATCHES] Libpq ssl fix

Patch applied. Thanks. --- Andreas Pflug wrote: init_ssl_system will return 0 on success and -1 on failure, which will be interpreted just the other way round in initialize_SSL. Patch appended. Regards, Andreas

Re: [PATCHES] fix for pg_regress.sh on mingw

Patch applied. Thanks. --- Andrew Dunstan wrote: With the attached patch make check runs cleanly for me under MSys/Mingw. Description of changes: . only use the -W flag on pwd for $pkglibdir. All the other paths