Re: [PATCHES] rtree: improve performance, tuple killing

2004-11-23 Thread Neil Conway
On Tue, 2004-11-23 at 23:40 -0500, Tom Lane wrote: > Please hold this for the 8.1 cycle. I think we are past the time for > non-bug-fix changes in the 8.0 release. Sorry, I should have mentioned that explicitly: I have (and had) no intention of applying this for 8.0. -Neil ---

Re: [PATCHES] rtree: improve performance, tuple killing

2004-11-23 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > This patch makes some improvements to the rtree index implementation: Please hold this for the 8.1 cycle. I think we are past the time for non-bug-fix changes in the 8.0 release. regards, tom lane ---(end

Re: [PATCHES] minor bufmgr cleanup

2004-11-23 Thread Neil Conway
On Wed, 2004-11-24 at 11:18 +1100, Neil Conway wrote: > This patch makes a trivial improvement to IncrBufferRefCount(): rather > than asserting that BufferIsValid() and then manually asserting its pin > count is > 0, we can just assert BufferIsPinned(). Applied. -Neil -

Re: [PATCHES] htmlhelp generation

2004-11-23 Thread Christopher Kings-Lynne
Um ... what's an htmlhelp? It's the kind of format the Windows'ish programs use for their internal help browsers. It consists of regular HTML plus some index files. pgAdmin needs it, and maybe the Windows binary package would like it as well. I've trivially generated them from docbook xml using

[PATCHES] minor bufmgr cleanup

2004-11-23 Thread Neil Conway
This patch makes a trivial improvement to IncrBufferRefCount(): rather than asserting that BufferIsValid() and then manually asserting its pin count is > 0, we can just assert BufferIsPinned(). I'll apply to HEAD before end of day, barring any objections. -Neil --- src/backend/storage/buffer/buf

[PATCHES] rtree: improve performance, tuple killing

2004-11-23 Thread Neil Conway
This patch makes some improvements to the rtree index implementation: (1) Keep a pin on the scan's current buffer and mark buffer. This avoids the need to do a ReadBuffer() for each tuple produced by the scan. (2) Convert a ReleaseBuffer() ; ReadBuffer() pair into ReleaseAndReadBuffer(). Surely n

Re: [PATCHES] pgcrypto: Makefile check

2004-11-23 Thread Neil Conway
On Tue, 2004-11-23 at 11:24 +1100, Neil Conway wrote: > Attached is a revised patch. Will apply in a few hours barring any > objections. Applied. -Neil ---(end of broadcast)--- TIP 8: explain analyze is your friend

Re: [PATCHES] SQL Conformance introductory section

2004-11-23 Thread Simon Riggs
On Tue, 2004-11-23 at 23:15, Peter Eisentraut wrote: > Simon Riggs wrote: > > I've re-written the start of the SQL Conformance section to update > > things for the SQL2003 standard. > > This has got to be a mistake: > > Overall, PostgreSQL Global Development Group > (PGDG) supports open

Re: [PATCHES] SQL:2003 keyword additions

2004-11-23 Thread Simon Riggs
On Tue, 2004-11-23 at 23:08, Peter Eisentraut wrote: > Simon Riggs wrote: > > as per SQL:2003 Annex E pp.1173-1175 "Incompatibilities with > > SQL:1999", specifically point 17, pp.1174-1175: > > > > "A number of additional s have been added to the > > language". > > I think you are confusing keywo

Re: [PATCHES] SQL:2003 keyword additions

2004-11-23 Thread Simon Riggs
On Tue, 2004-11-23 at 23:22, Tom Lane wrote: > For future reference, the patch as proposed is broken anyway because it > doesn't add the keywords to the appropriate list in gram.y. OK, thanks. -- Best Regards, Simon Riggs ---(end of broadcast)---

Re: [PATCHES] SQL:2003 keyword additions

2004-11-23 Thread Tom Lane
Simon Riggs <[EMAIL PROTECTED]> writes: > as per SQL:2003 Annex E pp.1173-1175 "Incompatibilities with SQL:1999", > specifically point 17, pp.1174-1175: > "A number of additional s have been added to the > language". We are not going to reserve words simply because they are reserved in the standar

Re: [PATCHES] SQL:2003 keyword additions

2004-11-23 Thread Peter Eisentraut
Simon Riggs wrote: > as per SQL:2003 Annex E pp.1173-1175 "Incompatibilities with > SQL:1999", specifically point 17, pp.1174-1175: > > "A number of additional s have been added to the > language". I think you are confusing keywords.c with the SQL standard. -- Peter Eisentraut http://developer.p

Re: [PATCHES] SQL Conformance introductory section

2004-11-23 Thread Peter Eisentraut
Simon Riggs wrote: > I've re-written the start of the SQL Conformance section to update > things for the SQL2003 standard. This has got to be a mistake: Overall, PostgreSQL Global Development Group (PGDG) supports open standards, particularly the SQL standard. By what norm is the SQ

Re: [PATCHES] Romanian translation for 8.0: new files (pg_config-ro, pg_ctl-ro, pg_resetxlog-ro)

2004-11-23 Thread Peter Eisentraut
Alin Vaida wrote: > Please update the corresponding nls.mk files. Done. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]

[PATCHES] SQL:2003 keyword additions

2004-11-23 Thread Simon Riggs
as per SQL:2003 Annex E pp.1173-1175 "Incompatibilities with SQL:1999", specifically point 17, pp.1174-1175: "A number of additional s have been added to the language". Enjoy. -- Best Regards, Simon Riggs Index: keywords.c === RCS

[PATCHES] Romanian translation for 8.0: new files (pg_config-ro, pg_ctl-ro, pg_resetxlog-ro)

2004-11-23 Thread Alin Vaida
Please update the corresponding nls.mk files. Thank you, Alin Vaida pg_resetxlog-ro.po Description: application/gettext pg_config-ro.po Description: application/gettext pg_ctl-ro.po Description: application/gettext ---(end of broadcast)--- TIP

Re: [PATCHES] Translation updates for 8.0: initdb-ro, pg_dump-ro, psql-ro

2004-11-23 Thread Peter Eisentraut
Alin Vaida wrote: > Please update these files. Done. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister command (send "unregister YourEmailAddressH

Re: [PATCHES] htmlhelp generation

2004-11-23 Thread Peter Eisentraut
Magnus Hagander wrote: > Hmm. Never seen that in any of the XSL systems I've used. There is > certainly no such system in the XSLT processors that are included in > Windows these days. I don't know what's "included" in Windows, but all the usual ones you can download from the net support XML cata

Re: [PATCHES] htmlhelp generation

2004-11-23 Thread Magnus Hagander
>> From what I can tell, this XSL will download and import another XSL >> from docbook.sourceforge.net every time you run "make" on it. > >Normally, you or your operating system should set up an XML catalog >that maps that URI to a local copy. For example, my system has > >/etc/xml/catalog: >...

Re: [PATCHES] htmlhelp generation

2004-11-23 Thread Peter Eisentraut
Magnus Hagander wrote: > From what I can tell, this XSL will download and import another XSL > from docbook.sourceforge.net every time you run "make" on it. Normally, you or your operating system should set up an XML catalog that maps that URI to a local copy. For example, my system has /etc/xml

Re: [PATCHES] htmlhelp generation

2004-11-23 Thread Andrew Dunstan
Magnus Hagander wrote: From what I can tell, this XSL will download and import another XSL from docbook.sourceforge.net every time you run "make" on it. Perhaps a copy of this file should be included in cvs to make sure we can still build when sourceforge is down? Using xsl:import here is not a

Re: [PATCHES] htmlhelp generation

2004-11-23 Thread Magnus Hagander
>> The attached Makefile patch together with stylesheet-hh.xsl >allows "make >> htmlhelp". stylesheet-hh.xsl is derived from stylesheet.xsl, >after some >> advise from PeterE. > >Installed. From what I can tell, this XSL will download and import another XSL from docbook.sourceforge.net every tim

Re: [PATCHES] htmlhelp generation

2004-11-23 Thread Tom Lane
Peter Eisentraut <[EMAIL PROTECTED]> writes: > Am Montag, 22. November 2004 18:34 schrieb Andreas Pflug: >> The attached Makefile patch together with stylesheet-hh.xsl allows "make >> htmlhelp". stylesheet-hh.xsl is derived from stylesheet.xsl, after some >> advise from PeterE. > Installed. It wo

Re: [PATCHES] htmlhelp generation

2004-11-23 Thread Peter Eisentraut
Am Montag, 22. November 2004 18:34 schrieb Andreas Pflug: > The attached Makefile patch together with stylesheet-hh.xsl allows "make > htmlhelp". stylesheet-hh.xsl is derived from stylesheet.xsl, after some > advise from PeterE. Installed. -- Peter Eisentraut http://developer.postgresql.org/~pet

Re: [PATCHES] htmlhelp generation

2004-11-23 Thread Peter Eisentraut
Am Montag, 22. November 2004 22:23 schrieb Tom Lane: > Um ... what's an htmlhelp? It's the kind of format the Windows'ish programs use for their internal help browsers. It consists of regular HTML plus some index files. pgAdmin needs it, and maybe the Windows binary package would like it as we