Re: [PATCHES] WIP: pl/pgsql cleanup

2005-01-20 Thread Neil Conway
On Thu, 2005-01-20 at 07:57 -0500, Tom Lane wrote: > Not sure, but it seems like at least as straightforward a translation > as the other way. More to the point, it makes clear the difference > between what is meant to be a long-lived data structure and what isn't. The latter point is sound, I th

Re: [PATCHES] uptime function to postmaster

2005-01-20 Thread Euler Taveira de Oliveira
Bruce Momjian wrote: > > This has been saved for the 8.1 release: > > http:/momjian.postgresql.org/cgi-bin/pgpatches2 > > --- > Hi, I redo this patch adding the funcionality that Matthias implemented (starttime). B

Re: [PATCHES] WIP: pl/pgsql cleanup

2005-01-20 Thread Neil Conway
On Thu, 2005-01-20 at 15:48 +1100, Neil Conway wrote: > Attached is a revised patch (no major changes, just grammar cleanup). > While rewriting some cruft in PL/PgSQL's gram.y, I noticed that we will > overflow a heap-allocated array if the user specifies more than 1024 > parameters to a refcursor

[PATCHES] regression: pass with no default WITH OIDS

2005-01-20 Thread Neil Conway
This patch updates the regression tests to allow "make installcheck" to pass if "default_with_oids" is set to false. I took the approach of explicitly adding WITH OIDS to the CREATE TABLEs where necessary, rather than tweaking the default_with_oids GUC var. Barring any objections, I intend to appl

Re: [PATCHES] [pgsql-hackers-win32] pg_autovacuum fails to start - 8.0 Release

2005-01-20 Thread Dave Page
> -Original Message- > From: Harald Massa [mailto:[EMAIL PROTECTED] > Sent: 20 January 2005 16:17 > To: Dave Page > Cc: [EMAIL PROTECTED]; pgsql-patches@postgresql.org > Subject: RE: [pgsql-hackers-win32] pg_autovacuum fails to > start - 8.0 Release > > Dave, > > > You probably need

Re: [PATCHES] [pgsql-hackers-win32] pg_autovacuum fails to start - 8.0 Release

2005-01-20 Thread Harald Massa
Dave, > You probably need to restart after editting it so that the SCM reloads > it. I am not quite sure if that really helped. Either way, I found a workaround and want to have it within googling space: at the moment the rest of the command-line after -E is stored within the DependOnService Pr

Re: [PATCHES] [pgsql-hackers-win32] pg_autovacuum fails to start - 8.0 Release

2005-01-20 Thread Dave Page
> -Original Message- > From: Harald Massa [mailto:[EMAIL PROTECTED] > Sent: 20 January 2005 16:07 > To: Dave Page > Cc: [EMAIL PROTECTED]; pgsql-patches@postgresql.org > Subject: RE: [pgsql-hackers-win32] pg_autovacuum fails to > start - 8.0 Release > > Dave, > > thank you very much

Re: [PATCHES] [pgsql-hackers-win32] pg_autovacuum fails to start - 8.0 Release

2005-01-20 Thread Harald Massa
Dave, thank you very much for fixing the problem. Just to have it in the googleable space: > you should be able to use the current version if > you cleanup the >HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\pg_autovacuum\DependOnService >registry key. That is of no use. The service fails

Re: [PATCHES] [pgsql-hackers-win32] pg_autovacuum fails to start - 8.0 Release

2005-01-20 Thread Dave Page
> -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf > Of Harald Massa > Sent: 20 January 2005 13:30 > To: [EMAIL PROTECTED] > Subject: [pgsql-hackers-win32] pg_autovacuum fails to start - > 8.0 Release > > I am trying to install pg_autovacuum as a win

Re: [PATCHES] WIP: pl/pgsql cleanup

2005-01-20 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > On Tue, 2005-01-18 at 01:02 -0500, Tom Lane wrote: >> It might be better to keep CurrentMemoryContext pointing at a temp >> context, and translate malloc() to MemoryContextAlloc(function_context) >> rather than just palloc(). (Of course you could hide this