This patch makes two minor fixes to the docs: (1) fixes a
spelling mistake in the PREPARE ref page (2) Makes some
English more consistent, in the ref pages for some of the
client apps (3) Adds a link to the libpq docs in the
vacuumdb ref page.
-Neil
Index: doc/src/sgml/ref/clusterdb.sgml
This patch adds a new regression test for the UPDATE command. Right
now all that is tested is Rod Taylor's recent addition to allow
this syntax:
UPDATE ... SET = DEFAULT;
If anyone else would like to add more UPDATE tests, go ahead --
I just wanted to write a test for the above functionality
On Sun, Aug 10, 2003 at 06:19:05PM -0400, Andrew Dunstan wrote:
> Neil Conway wrote:
> >On Sat, Aug 09, 2003 at 07:22:56PM -0400, Andrew Dunstan wrote:
> Sure. Very easy. Nobody suggested it when I floated the idea of logging
> session end on the hackers list, but it's a sim
I get the following warning when I compile src/bin/pg_id/pg_id.c:
gcc -pipe -g -Wall -Wmissing-prototypes -Wmissing-declarations -I../../../src/include
-c -o pg_id.o pg_id.c -MMD
pg_id.c: In function `main':
pg_id.c:35: warning: unused variable `optarg'
The attached trivial patch fixes the war
On Sat, Aug 09, 2003 at 07:22:56PM -0400, Andrew Dunstan wrote:
> The attached patch does 3 things:
>
> . logs connection ends if log_connections = true
Should this be a separate GUC variable? Personally, I'd rather not have
my log files bloated with info on both the beginning *and* the end of
ea
There is a misstatement in the CLOSE reference page, now that we
have cursors that might outlive their creating transactions. A
patch is attached that fixes this (suggestions on better wording
are welcome).
-Neil
Index: doc/src/sgml/ref/close.sgml
=
Minor SGML gripes...
On Fri, Aug 22, 2003 at 10:00:00AM -0400, Andrew Dunstan wrote:
> ! To avoid this situation, run postgres on a machine where you
"postgres" should be "PostgreSQL".
> ! altering the system's default behaviour. This can be determined
> ! by examining the function
This patch makes a number of improvements to the runtime config
documentation.
-Neil
Index: doc/src/sgml/runtime.sgml
===
RCS file: /var/lib/cvs/pgsql-server/doc/src/sgml/runtime.sgml,v
retrieving revision 1.201
diff -c -r1.201 runti
This patch makes a few minor improvements to the docs: make the
conventions more consistent, and improve the ANALYZE ref page.
-Neil
Index: doc/src/sgml/perform.sgml
===
RCS file: /var/lib/cvs/pgsql-server/doc/src/sgml/perform.sgml,
This patch fixes a trivial typo in the CREATE FUNCTION ref page.
-Neil
Index: doc/src/sgml/ref/create_function.sgml
===
RCS file: /var/lib/cvs/pgsql-server/doc/src/sgml/ref/create_function.sgml,v
retrieving revision 1.49
diff -c -r1.
On Fri, 2003-09-05 at 17:16, Peter Eisentraut wrote:
> Currently, the documentation contains about 2 GUC variable names in upper
> case, the rest is lower case.
There are significantly more than 2 uses of upper-case GUC names in the
docs (more like 10 by my guess), but in any case, the current usa
On Mon, 2003-09-08 at 11:09, Gaetano Mendola wrote:
> "Tom Lane" <[EMAIL PROTECTED]> wrote:
> > I see no value at all in an assert. The code will dump core just fine
> > with or without an assert ...
>
> Right but an assert can display information about the file and line number
> without debug t
On Thu, 2003-09-11 at 17:41, Bruce Momjian wrote:
> Patch applied. Thanks. Your documentation changes can be viewed in
> 5 minutes using links at the bottom of the developer's page.
Right (... although I always build a copy of the docs locally while I'm
making changes, to double-check that they
On Thu, 2003-09-11 at 11:58, Bruce Momjian wrote:
> Uh, how do you force the stats collector to 'on' before the test is
> run?
The stats collector is on by default (of course, that doesn't apply to
"make installcheck"...)
But this reminds me: I think it would be cool to extend the language we
us
This patch makes a few incremental improvements to geqo.sgml and
arch-dev.sgml
-Neil
Index: doc/src/sgml/arch-dev.sgml
===
RCS file: /var/lib/cvs/pgsql-server/doc/src/sgml/arch-dev.sgml,v
retrieving revision 2.21
diff -c -r2.21 arch-
This patch fixes an obvious bug in the "should I print the duration of
this query?" logic in postgres.c
I also don't particularly like the format of the log message (for one
thing, the "duration_statement" prefix in the log message shouldn't
include an underscore, it's not a variable or anything -
This patch adds a new GUC var, "default_use_oids", which follows the
proposal for eventually deprecating OIDs on user tables that I posted
earlier to pgsql-hackers. pg_dump now always specifies WITH OIDS or
WITHOUT OIDS when dumping a table. The documentation has been updated.
Comments are welcome
On Sun, 2003-10-05 at 19:58, Tom Lane wrote:
> That's a fairly useless place to put it, though, since someone would
> only think to look at sort_mem if they already had a clue. It should
> be mentioned under bulk data load (in performance tips chapter)
Attached is a doc patch that does this. The
On Tue, 2003-10-14 at 15:00, Manfred Spraul wrote:
> I think we must either add -fno-strict-aliasing, or switch to the c
> compiler memset functions for gcc.
The last time we did some benchmarking, using the builtin memset()
imposes a significant performance penalty on plenty of different
platfor
On Tue, 2003-10-14 at 16:29, Peter Eisentraut wrote:
> The last time I did some testing, the builtin memset() was significantly
> faster on plenty of different platforms.
Oh? Which platforms are you referring to, and what tests were performed?
You can find the benchmark results I'm referring to i
This patch adds another item to the "migration to 7.4" list in the
HISTORY file, and attributes the shared-buffer-alignment change to
Manfred Spraul.
-Neil
Index: HISTORY
===
RCS file: /var/lib/cvs/pgsql-server/HISTORY,v
retrieving r
On Fri, 2003-10-10 at 05:56, Manfred Koizar wrote:
> On Tue, 30 Sep 2003 20:00:22 -0400, Neil Conway <[EMAIL PROTECTED]>
> wrote:
> >This patch adds a new GUC var, "default_use_oids"
>
> Shouldn't it be honoured by CREATE TABLE AS SELECT ... ?
Good catch.
This patch fixes a small memory leak in libpq: the 'pstatus' field of
PGconn is a linked list of malloc'ed nodes, so it should be freed on
PQfinish().
-Neil
Index: src/interfaces/libpq/fe-connect.c
===
RCS file: /var/lib/cvs/pgsql-se
This patch reduces some unsightly #ifdefs, and fixes two typos in
comments in the psql code. This doesn't make any functional change, so
feel free to save it for 7.5
-Neil
Index: src/bin/psql/command.c
===
RCS file: /var/lib/cvs/pgsq
This patch makes a bunch of improvements to the release notes. I only
modified release.sgml -- HISTORY will need to be regenerated.
I was able to remove almost all of the "Other uncategorized" release
note entries, but left a few that I wasn't sure what to do with. We
should remove this section, a
On Wed, 2003-10-22 at 13:26, Bruce Momjian wrote:
> > * Cause FETCH 1 to return the next cursor row, or zero if at
>
> >beginning/end of cursor, per SQL spec (Bruce)
That's better, but still wrong: what does it mean for FETCH 1 to "return
zero
On Sun, 2003-10-26 at 00:50, Bruce Momjian wrote:
> Make MOVE/FETCH 0 now does nothing
> (Bruce)
Still wrong :-) "Make ... now does nothing" is ungrammatical.
The other modified entry is incorrect for the same reason ("Cause ...
now returns").
-Neil
---(
This patch cleans up some of the bufmgr code:
- replace uses of
LockBuffer(buf, BUFFER_LOCK_UNLOCK);
ReleaseBuffer(buf);
with the equivalent, but more concise:
UnlockAndReleaseBuffer(buf);
- analogous changes were made by replacing LockBuffer() + WriteBuffer()
Currently, equal() does the following for List nodes:
case T_List:
{
List *la = (List *) a;
List *lb = (List *) b;
List *l;
/*
* Try to reject by length check before we grovel through
* all the elements...
*/
if
On Mon, 2003-11-03 at 10:04, Tom Lane wrote:
> You have effectively reverted the code to its previous slow state.
Erm, the original version of this code in CVS (from ~7 years ago) is the
following:
case T_List:
{
List *la = (List*)a;
List *lb = (List*)b;
On Mon, 2003-11-03 at 10:00, Tom Lane wrote:
> I do not actually agree with the "UnlockAndReleaseBuffer" changes
> anyway. I think this obscures the code by making resource grabbing
> and resource releasing code unsymmetrical
Hmm... fair enough, I see your point. In that case, should I remove the
On Mon, 2003-11-03 at 16:39, Tom Lane wrote:
> The point is that the elements of the lists could be large, complicated
> structures that will take noticeable amounts of time to compare.
Good point, I agree with your analysis. At the very least, I'll add a
comment to equal() explaining why the algo
On Mon, 2003-11-03 at 18:19, Tom Lane wrote:
> Hard to tell. Since I haven't seen any evidence that equal() on lists
> is a particular hotspot, I'd lean against adding complexity and
> maintenance burden here.
Ok, I agree -- probably not worth doing, then.
> I have already done something much li
Ok, I've attached new versions of list.c and pg_list.h -- this is just a
*rough sketch* of the new List code -- it definitely won't compile, the
intent is just to concretely specify the new List design. Also, I've
only updated the important list functions: I stopped at nth().
(I've attached the wh
Gaetano Mendola <[EMAIL PROTECTED]> writes:
> Why instead of reinvent the whell not use, or at least do a "C" port of
> stl::list ?
Because (a) implementing a linked list is pretty trivial (b) the only
difficult part is getting the semantics / API right. I don't see how
std::list would help with (
Gaetano Mendola <[EMAIL PROTECTED]> writes:
> An interesting think that stl::list do is to never do
> an "if" branch during an insert/remove phase
Why is this significant? Surely you're not claiming that avoid the
branch will affect performance in a meaningful way...
> What if you will never call
Tom Lane <[EMAIL PROTECTED]> writes:
> This does suggest that it might be worth making the struct layout be
>
> int NodeTag;
> int length;
> foo *head;
> foo *tail;
>
> since this would avoid some padding overhead on a machine where pointers
> are 8 bytes and need 8-byte ali
Rod Taylor <[EMAIL PROTECTED]> writes:
> In src/backend/utils/adt/inet_net_ntop.c and
> src/backend/utils/adt/inet_net_pton.c it would appear that the $Id$ tag
> is assigned to a variable (rcsid).
... which is never referenced AFAICT, even if the necessary
preprocessor definitions are set so that
Bruce Momjian <[EMAIL PROTECTED]> writes:
> Is there a TODO here?
I've been short on time recently, so I haven't had a chance to make
the suggested changes to the List patch. I'll send in an updated
version of the List changes, and if there aren't any gripes, I'll
begin making the changes to the L
Gaetano Mendola <[EMAIL PROTECTED]> writes:
> 10E6 INSERT => real 0m5.161s
> user 0m4.010s
> sys0m1.150s
What operation is this benchmarking? Only linked-list appends, or
something else?
-Neil
---(end of broad
This patch adds some primitive regression tests for the LISTEN,
NOTIFY, and UNLISTEN commands -- there were previously no regression
tests for this functionality.
There are currently two problems/caveats with the patch:
(1) The regression test can never pass, because the message that
This patch makes some minor improvements to a few release note
entries. Sorry for the late timing: if this doesn't make it into the
7.4.0 release, that's fine -- the changes aren't critical.
-Neil
Index: doc/src/sgml/release.sgml
===
This patch makes some improvements to the section of the documentation
that describes the Linux 2.4 memory overcommit behavior.
I removed the almost content-free assertion that "You will need enough
swap space to cover your memory needs." If this is intended to
communicate anything meaningful, can
Neil Conway <[EMAIL PROTECTED]> writes:
> There are currently two problems/caveats with the patch [...]
I just wanted to check that no one had any input or comments on the
issues described in the original email -- "Speak now, or forever..."
:-)
I'm thinking of solvin
This patch refactors CreateTupleDescCopy() and
CreateTupleDescCopyConstr() to remove some duplicated code, and clean
things up a little bit.
-Neil
Index: src/backend/access/common/tupdesc.c
===
RCS file: /var/lib/cvs/pgsql-server/src/
Bruce Momjian <[EMAIL PROTECTED]> writes:
> I have grabbed code from NetBSD before, and I just mention that fact at
> the top of the file. There is no need to repeat their license as it is
> the same as our license.
src/port/qsort.c is wrong, then: (a) it includes the full NetBSD
copyright/warran
Bruce Momjian <[EMAIL PROTECTED]> writes:
> I don't change the copyright, but I think we can take the copyright
> of the project rather than those of the individual files.
So can we remove the offending license clauses, then?
Also, it's worth noting that the license in 'COPYRIGHT' is not exactly
Bruce Momjian <[EMAIL PROTECTED]> writes:
> I think there was an updated BSD license approved by Berkeley that
> we are using.
I think this is an area where we need a higher degree of certainty
than that.
> If we took the file unchanged, I would not remove the copyright
> because it is the file _
This patch refactors execTuples.c in two ways:
(1) ExecInitXXXResultTupleSlot() used a macro to avoid some
duplicated code, whereas calling ExecInitExtraTupleSlot() would
make the code more clear.
(2) ExecTypeFromTL() and ExecCleanTypeFromTL() duplicated a bunch
Hans-Jürgen Schönig <[EMAIL PROTECTED]> writes:
> I have attaches a patch against 7.4.0 which contains the
> implementation of the following todo item.
I sent a proposal for this functionality to -hackers a month or so
ago, and implemented it a couple days later -- it was sent to
pgsql-patches, an
This patch fixes a trivial compiler warning introduced recently in
bufmgr.c
-Neil
Index: src/backend/storage/buffer/bufmgr.c
===
RCS file: /var/lib/cvs/pgsql-server/src/backend/storage/buffer/bufmgr.c,v
retrieving revision 1.145
diff
Tom Lane <[EMAIL PROTECTED]> writes:
> I think this is taking the "avoid duplicated code" mantra a little
> far. You've defined a subroutine that returns a TupleDesc that is
> internally inconsistent and cannot usefully be used for anything
> until it's fixed by the parent routines.
Fair enough.
Tom Lane <[EMAIL PROTECTED]> writes:
> That would be okay with me. It might be a good idea to change the
> name completely (perhaps CopyTupleDesc() ?) as a means of catching
> places that aren't correctly updated.
Done, and done -- a revised patch is attached.
-Neil
Index: src/backend/access/co
Tom Lane <[EMAIL PROTECTED]> writes:
> Please use names for the replacement routines that are more clear
> than "fooInternal". You can get away with that kind of name for a
> static function, but I think globally visible ones should have more
> meaningful names.
The only function I named "fooInte
There is an unused variable in an example function in the PL/PgSQL
documentation; this patch removes it.
-Neil
Index: doc/src/sgml/plpgsql.sgml
===
RCS file: /var/lib/cvs/pgsql-server/doc/src/sgml/plpgsql.sgml,v
retrieving revision 1.
Tom Lane <[EMAIL PROTECTED]> writes:
> We have previously speculated about setting up some sort of test
> harness program that can drive multiple backends through a
> coordinated series of operations.
It would also be useful to test other concurrent properties of the
backend: for example, "all int
Robert Treat <[EMAIL PROTECTED]> writes:
> Marcos Truchado <[EMAIL PROTECTED]> reported this on -docs
> yesterday.
I submitted a patch for this typo to -patches 5 days ago.
-Neil
---(end of broadcast)---
TIP 1: subscribe and unsubscribe commands g
This code is pretty awful, IMHO.
If you're going to copy code from a 3rd party (in this case, MSDN), it
is standard practise to include an attribution. Also, what
redistribution terms apply to MSDN sample code?
Assuming we don't remove or rewrite the MSDN sample code, it is
usually considered goo
Neil Conway <[EMAIL PROTECTED]> writes:
> This code is pretty awful, IMHO.
Also, why is this code still invoking psql manually? ISTM that linking
against libpq directly would be much better.
-Neil
---(end of broadcast)---
TIP 6: Have you
Bruce Momjian <[EMAIL PROTECTED]> writes:
> I am going to try to fill the queue tonight and apply it Monday. I
> leave for Japan on Tuesday.
Applying a load of patches and then promptly fleeing the country
doesn't sound so wise -- it sounds mighty suspicious, in fact :-)
(At the same time, I can
Bruce Momjian <[EMAIL PROTECTED]> writes:
> We need a solution to this.
I'm really not sure we do: the SQL produced by pg_dump was totally
non-portable before, and it is slightly less portable now. ISTM that
you will almost always need to do some post-processing of pg_dump's
output to have any hop
Bruce Momjian <[EMAIL PROTECTED]> writes:
> I assume this patch is to control this way of breaking out of a
> read-only transaction:
> [...]
> This seems like a valuable feature, as others have mentioned.
Why is this feature valuable?
A "read only user" is still able to easily DOS the server, con
Peter Eisentraut <[EMAIL PROTECTED]> writes:
> I'm sure there are other ways to phase out OIDs in dumps.
Okay, fair enough -- I'll submit a patch to change this.
-Neil
---(end of broadcast)---
TIP 4: Don't 'kill -9' the postmaster
A GUC variable in runtime.sgml had the wrong markup -- this patch
fixes that, and makes a few other tiny SGML improvements.
-Neil
Index: doc/src/sgml/runtime.sgml
===
RCS file: /var/lib/cvs/pgsql-server/doc/src/sgml/runtime.sgml,v
ret
At present, trying to build the documentation from outside the source
tree (i.e. a "vpath build") fails. This patch fixes that. Two changes
were required:
- in a vpath build, make sure that we look in the appropriate
directory in the build tree, not just the source tree (some
SG
This patch makes some editorial improvements to the bug reporting
guidelines and the LOCK reference page.
-Neil
Index: doc/src/sgml/problems.sgml
===
RCS file: /var/lib/cvs/pgsql-server/doc/src/sgml/problems.sgml,v
retrieving revision
I posted some bufmgr cleanup a few weeks ago, but it conflicted with
some concurrent changes Jan was making to the bufmgr. Here's an
updated version of the patch -- it should apply cleanly to CVS
HEAD and passes the regression tests.
This patch makes the following changes:
- remove the Unloc
This patch makes some improvements and adds some details to the
documentation on routine database maintenance activities. Any comments
on the new text would be appreciated. I decided not to mention the
FSM -- I haven't seen any reports that users have had to tweak FSM
settings in 7.4, and it is pro
Robert Treat <[EMAIL PROTECTED]> writes:
> Should be "TRUNCATE removes the entire content of
> the table immediately, without requiring a subsequent
> VACUUM or VACUUM FULL to
> reclaim the now-unused disk space."
I think the is overkill, but otherwise I've made this
change.
> Maybe better
The "wal_debug" GUC variable was of type "integer", but it was used in
the code effectively as a boolean: the code only tested whether it was
zero or non-zero. This patch makes it a proper boolean.
-Neil
Index: doc/src/sgml/runtime.sgml
=
Peter Eisentraut <[EMAIL PROTECTED]> writes:
> Looks good, but did you have a specific reason to prefer LOCK TABLE over
> plain LOCK?
None other than consistency: the majority of the usages in lock.sgml
already used LOCK TABLE, so I converted the rest over. I don't
particularly prefer one form ov
Tom Lane <[EMAIL PROTECTED]> writes:
> I agree. Having a special debug variable for WAL seems like a
> short-term thing whose time has passed.
ISTM that there is little distinguishing wal_debug and the following
GUC vars:
log_btree_build_stats
trace_notify
trace_locks
trace_userlocks
trace_lwloc
Peter Eisentraut <[EMAIL PROTECTED]> writes:
> It's kind of hard to see what you have really changed. Can you
> provide a summary?
The majority of the changes are in the 3rd patch hunk; ISTM it is
pretty easy to see what has been changed. I spent more time discussing
the differences between VACUU
Tom Lane <[EMAIL PROTECTED]> writes:
> The others are already #ifdef'd out by default, which is more or
> less what I was suggesting you do with the wal_debug code.
(FWIW, trace_notify is not #ifdef'd out.)
But I thought that you (and Peter) were suggesting that this shouldn't
be made a GUC varia
This patch fixes a few more uppercase GUC vars. I also removed an
example from the RESET reference page because it seemed completely
redundant.
-Neil
Index: doc/src/sgml/ref/analyze.sgml
===
RCS file: /var/lib/cvs/pgsql-server/doc/src
Neil Conway <[EMAIL PROTECTED]> writes:
> This patch makes some SGML markup more consistent and makes a small
> improvement to the SSL auth docs.
Patch applied to HEAD.
-Neil
---(end of broadcast)---
TIP 1: subscribe and unsubscribe
Neil Conway <[EMAIL PROTECTED]> writes:
> This patch makes some editorial improvements to the bug reporting
> guidelines and the LOCK reference page.
Patch applied to HEAD.
-Neil
---(end of broadcast)---
TIP 3: if posting/reading th
Neil Conway <[EMAIL PROTECTED]> writes:
> I've attached a revised patch that incorporates these
> changes. Thanks for the feedback!
Patch applied to HEAD. Thanks again, Robert & Peter.
-Neil
---(end of broadcast)---
TIP 4
Neil Conway <[EMAIL PROTECTED]> writes:
> This patch fixes a few more uppercase GUC vars. I also removed an
> example from the RESET reference page because it seemed completely
> redundant.
Patch applied to HEAD.
-Neil
---(e
Neil Conway <[EMAIL PROTECTED]> writes:
> I posted some bufmgr cleanup a few weeks ago, but it conflicted with
> some concurrent changes Jan was making to the bufmgr. Here's an
> updated version of the patch -- it should apply cleanly to CVS HEAD
> and passes the regressio
Bruce Momjian <[EMAIL PROTECTED]> writes:
> Let me add that Claudio is doing a fantastic job on this. The
> changes are minimal and clean. I think the writing of a per-backend
> temp file has allowed this patch to be smaller than it might have
> been.
Did we REALLY conclude that the best way to
Bruce Momjian <[EMAIL PROTECTED]> writes:
> I don't think we ever discussed it, but it seemed logical and a minimal
> change to the code. We already have a GUC write of non-default values
> for exec and no one had issues with that.
For the record, I think that is ugly as well :-)
Anyway, I'm not
Claudio Natoli <[EMAIL PROTECTED]> writes:
> This patch is the next step towards (re)allowing fork/exec.
I've included a few comments on the patch below. Unfortunately I only
had time to briefly look over the code...
Why did you change ShmemIndexLock from an LWLock to a spinlock?
The number of "
Tom Lane <[EMAIL PROTECTED]> writes:
> That one I can answer --- it's a bootstrapping issue: we can't use
> LWLocks until we have a PGProc (*MyProc), and we can't set that up
> without looking in the ShmemIndex for the related data structures.
> So ShmemIndex needs to use a more primitive lock type
Claudio Natoli <[EMAIL PROTECTED]> writes:
>> You should probably check the return value of unlink().
>
> No. This isn't necessary (and what action would it take in any
> case?).
It should write a log message. I'm not sure why this /shouldn't/ be
done: if an operation fails, we should log that fai
This patch removes the following unused typedefs from c.h:
bool8, bool16, bool32, word8, word16, word32, Offset
In order to remove "Offset" I had to update some code in
page/bufpage.c, but that shouldn't have been using Offset to begin
with, AFAICS.
Unless anyone complains, I'll apply this
This patch removes the remaining code for processing the '-C'
command-line option in the standalone backend. It no longer actually
functions (i.e. specifying the option does nothing), and I didn't
think it was interesting enough to be worth reviving, so I removed it.
Unless anyone objects, I inten
Tom Lane <[EMAIL PROTECTED]> writes:
> I think the combination of #ifdef and GUC variable is appropriate.
The attached patch implements this: the wal_debug GUC var is now a
boolean, and is encloded in `#ifdef WAL_DEBUG` blocks (and the
WAL_DEBUG symbol is present in pg_config_manual.h, just commen
This patch adds a few additional commands to the list of expressions
accepted by CREATE SCHEMA: CREATE INDEX, CREATE SEQUENCE, and CREATE
TRIGGER are now supported. The latter two are required by SQL 200x,
while the first is merely useful.
Unless anyone objects, I intend to apply this patch by the
In any modern dialect of C, casting the "NULL" pointer literal to a
specific pointer type is unnecessary. For example:
char *foo;
foo = malloc(...);
if (foo == (char *) NULL) {...}
The cast on the 3rd line serves no useful purpose. Hence, this patch
removes all such instances of NULL-
This patch cleans up some code in the smgr and elsewhere:
- Update comment in IsReservedName() to the present day, remove
"ugly coding for speed" as this is no longer a performance
critical function
- Improve some variable & function names in commands/vacuum.c. I
wa
Tom Lane <[EMAIL PROTECTED]> writes:
> BTW, I was planning to ask you where that stood. I've been writing
> new code on the assumption that I didn't have to bother with
> FastList
Yeah, I definitely plan to have the list rewrite finished in time for
7.5. After the bufmgr work, it's the next thing
Kurt Roeckx <[EMAIL PROTECTED]> writes:
> In src/backend/port/darwin/system.c you replaced:
>
> execl(_PATH_BSHELL, "sh", "-c", command, (char *) NULL);
>
> By:
> execl(_PATH_BSHELL, "sh", "-c", command, NULL);
>
> I think that is one of the exceptions where you do have to cast it,
> because the ty
Neil Conway <[EMAIL PROTECTED]> writes:
> Unless anyone objects, I intend to apply this in 24 hours or so.
Patch applied.
-Neil
---(end of broadcast)---
TIP 7: don't forget to increase your free space map settings
Neil Conway <[EMAIL PROTECTED]> writes:
> Unless anyone objects, I intend to apply this in 24 hours or so.
Patch applied.
-Neil
P.S. BTW, how does everyone feel about the methodology I've been using
for submitting and applying patches? The procedure I'm following is:
- for
Tom Lane <[EMAIL PROTECTED]> writes:
> This change is actually wrong (backwards), no? You want a true result
> on equality.
*sigh*, I'm an idiot. Thanks for catching my mistake!
> Pretending that the result of strcmp is a bool is a type pun, and
> one that can rise up to bite you. In the case a
This patch separates the 'Value' and 'List' nodes: now the Value node
has its own interface (i.e. header) and implementation files. This is
just house-keeping, in preparation for the list rewrite.
I renumbered a NodeTag: does that require a catalog version number
bump?
Unless anyone objects, I in
This patch adds a "WITH / WITHOUT OIDS" clause to CREATE TABLE
AS. This allows the user to explicitly specify whether OIDs should be
included in the newly-created relation (if form of this clause is
specified, the default_with_oids configuration variable is used). This
is useful because it provides
Bruce Momjian <[EMAIL PROTECTED]> writes:
> Does this deal with the fact we now emit WITH/WITHOUT OID in
> pg_dump?
No, that is an unrelated issue. I took a brief look at implementing
this over the break, but I couldn't see an easy way to do it properly:
if we pick a particular default for the GUC
Tom Lane <[EMAIL PROTECTED]> writes:
> This is just cleanup, right?
Right -- AFAICS, there is no reason for the two nodes to be in the
same file.
> Or were you intending that something will happen to Value in
> connection with the List changes? I can't think what offhand ...
Neither can I -- IS
1 - 100 of 1000 matches
Mail list logo
