Re: [PATCHES] ALTER TYPE RENAME

2007-09-29 Thread Petr Jelinek
me. And I also did a little cleanup in those functions (removed unused code and changed some hardcoded relkind types to globaly predefined constants) - RenameType now calls RenameRelationInternal for composite types (which calls RenameTypeInternal automatically) Any other comments ? -- Regards P

Re: [PATCHES] ALTER TYPE RENAME

2007-09-29 Thread Petr Jelinek
and I wouldn't want to forbid it. But if we provide ALTER TYPE RENAME then consistency would suggest requiring people to use that for composite types. I assume ALTER TYPE RENAME should rename associated relation too, then. -- Regards Petr Jelinek (PJMODOS) ---(end of

[PATCHES] ALTER TYPE RENAME

2007-09-28 Thread Petr Jelinek
for this but not in AlterTypeNamespace so I don't know). -- Regards Petr Jelinek (PJMODOS) Index: doc/src/sgml/ref/alter_type.sgml === RCS file: /projects/cvsroot/pgsql/doc/src/sgml/ref/alter_type.sgml,v retrieving revision 1.4 diff

[PATCHES] Add chklocale.c to msvc build

2007-09-28 Thread Petr Jelinek
Hi, attached patch adds chklocale.c to pgportfiles in Mkvcbuild perl module (not really worth the .diff :)) This fixes MSVC build (see buildfarm errors with unresolved reference for _pg_get_encoding_from_locale). -- Regards Petr Jelinek (PJMODOS) Index: Mkvcbuild.pm

Re: [PATCHES] Client build of MSVC6+ patch

2006-07-06 Thread Petr Jelinek
Andrew Dunstan wrote: Does the detection work at runtime, or is it static? IIRC we found that static detection broke the binary portability on Windows. It's runtime just like ours. -- Regards Petr Jelinek (PJMODOS) ---(end of broadcast)--

Re: [PATCHES] Client build of MSVC6+ patch

2006-07-06 Thread Petr Jelinek
C addrinfo is defined this way (as in patch) too. MSVC does even have IPv6 detection in its header files. -- Regards Petr Jelinek (PJMODOS) ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an

Re: [PATCHES] force C locale for temp regression installations

2005-08-26 Thread Petr Jelinek
0 failures with --no-locale Output from make cheks are at http://pjmodos.parba.cz/pgsql/locale/ and http://pjmodos.parba.cz/pgsql/no-locale/ (it's same as loris, I posted it just as evidence that --no-locale fixes all failures) -- Regards Petr Jelinek (PJMODOS) ---

Re: [PATCHES] [HACKERS] Proposed patch to getaddrinfo.c to support

2005-08-26 Thread Petr Jelinek
ke my locale because with initdb --no-locale it passes without prob). So I hope IPv6 episode is finally over :) -- Regards Petr Jelinek (PJMODOS) ---(end of broadcast)--- TIP 4: Have you searched our list archives?

Re: [PATCHES] [HACKERS] Proposed patch to getaddrinfo.c to support

2005-08-26 Thread Petr Jelinek
27;t know how to make HAVE_IPV6 and HAVE_STRUCT_ADDRINFO always defined under windows because I am not familiar with configure and thats why I haven't sent patch). -- Regards Petr Jelinek (PJMODOS) ---(end of broadcast)--- TIP 4: Have you searche

Re: [PATCHES] [HACKERS] Proposed patch to getaddrinfo.c to support

2005-08-25 Thread Petr Jelinek
ID wrap limit is 2147484144, limited by database "postgres" Looks ok, i don't know what IPv4 has to do with all of this though. -- Regards Petr Jelinek (PJMODOS) ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster

Re: [PATCHES] [HACKERS] Proposed patch to getaddrinfo.c to support

2005-08-25 Thread Petr Jelinek
ut I am not familiar with build system so somebody else will have to do it (I am not familiar with whole configure thingy at all). With those changes it should finally work. -- Regards Petr Jelinek (PJMODOS) ---(end of broadcast)--- TIP 4: H

Re: [PATCHES] [HACKERS] Proposed patch to getaddrinfo.c to support

2005-08-25 Thread Petr Jelinek
Dave Page wrote: It, or some related patch appears to have broken the build on buildfarm member snake. I haven't had time to investigate. /D Atached patch fixes it and also adds proper gai_strerror for windows. (It's patch against CVS *after* Chucks patch was aplied) -- Re

Re: [PATCHES] per user/database connections limit again

2005-08-03 Thread Petr Jelinek
Peter Eisentraut wrote: GUC supports per-user/per-db values. We already had discussion here about GUC for this and we agreed that catalog change is better than new GUC variable in this case. -- Regards Petr Jelinek (PJMODOS) ---(end of broadcast

Re: [PATCHES] per user/database connections limit again

2005-07-30 Thread Petr Jelinek
Here is promised documentation. Be warned that both my writing skills and my english are far from good :) -- Regards Petr Jelinek (PJMODOS) Index: doc/src/sgml/catalogs.sgml === RCS file: /projects/cvsroot/pgsql/doc/src/sgml

Re: [PATCHES] per user/database connections limit again

2005-07-29 Thread Petr Jelinek
. -- Regards Petr Jelinek (PJMODOS) ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match

Re: [PATCHES] per user/database connections limit again

2005-07-25 Thread Petr Jelinek
keyword at all? Yeah I have no problem with LIMIT CONNECTIONS, will you change it or should I do it ? btw where has new keyword to be added to not be added "at a fairly unreserved level" ? (MAX is also added to keywords.c in that patch) -- Regards Petr Jelinek (PJMODOS) -

Re: [PATCHES] per user/database connections limit again

2005-07-24 Thread Petr Jelinek
depends partly on roles doc so it will prolly have to wait. I also added limit to pg_roles and pg_shadow views when I was patching pg_dump so you can get it from them. -- Regards Petr Jelinek (PJMODOS) Index: src/backend/catalog/system_views.sql

Re: [PATCHES] per user/database connections limit again

2005-07-04 Thread Petr Jelinek
d in crypt.c for password verification) -- Regards Petr Jelinek (PJMODOS) ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match

Re: [PATCHES] per user/database connections limit again

2005-07-03 Thread Petr Jelinek
hich works with roles is attached (diffed against cvs), everything else is mostly same. I also had to readd roleid to flatfiles because I need it in InitProcess() function. -- Regards Petr Jelinek (PJMODOS) Index: src/backend/comman

[PATCHES] per user/database connections limit again

2005-06-28 Thread Petr Jelinek
I can't make diff against repository. -- Regards Petr Jelinek (PJMODOS) diff -Nacr my-cvs/src/backend/commands/dbcommands.c my-aproach2/src/backend/commands/dbcommands.c *** my-cvs/src/backend/commands/dbcommands.cSun Jun 26 00:47:30 2005 --- my-aproach2/src/backend/commands/dbcommands.c

Re: [PATCHES] [PATCH] fix for pg_stat_database (numbackends is always

2005-06-27 Thread Petr Jelinek
Petr Jelinek wrote: This patch fixes pg_stat_database which is broken since this commit: http://archives.postgresql.org/pgsql-committers/2005-05/msg00126.php Neilc forgot to add new db entry inicialization to pgstat_recv_bestart() when he removed it from pgstat_add_backend() function