Re: [PATCHES] [HACKERS] Cannot initdb in cvs tip

2004-08-01 Thread Bruce Momjian
Patch applied. Thanks. I made small adjustment for configure. --- Andrew Dunstan wrote: Bruce Momjian wrote: Andrew Dunstan wrote: I wanted to keep a solution that was as native to the OS as possible, but

Re: [PATCHES] [HACKERS] Cannot initdb in cvs tip

2004-07-30 Thread Bruce Momjian
Looks good. I will have to do a little adjustment because dirmod is currently only used by Win32. Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers

Re: [PATCHES] [HACKERS] Cannot initdb in cvs tip

2004-07-28 Thread Bruce Momjian
Dave, now that we are nearing beta, I think we need to correct the initdb problem with removing the directory on Win32. Would you code this up as something that sits in /port/dirmod.c and have both initdb and DROP DATABASE call the C routine rather than call rm -r/rmdir? (I think those are the

Re: [PATCHES] [HACKERS] Cannot initdb in cvs tip

2004-07-28 Thread Dave Page
-Original Message- From: Bruce Momjian [mailto:[EMAIL PROTECTED] Sent: 28 July 2004 09:29 To: Dave Page Cc: Tom Lane; PostgreSQL-development; [EMAIL PROTECTED] Subject: Re: [HACKERS] Cannot initdb in cvs tip Dave, now that we are nearing beta, I think we need to correct

Re: [PATCHES] [HACKERS] Cannot initdb in cvs tip

2004-07-28 Thread Bruce Momjian
Andrew Dunstan wrote: I wanted to keep a solution that was as native to the OS as possible, but because we can't do that on Win32 and few people like the unix system call to 'rm', it is time to clean it up. One question --- why is there a sleep loop needed for unlink in your patch?

Re: [PATCHES] [HACKERS] Cannot initdb in cvs tip

2004-07-28 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: The small wrinkle here is that rmtree needs to make a copy of the file names before it starts removing things. In the backend case that means calling palloc() and friends - am I correct in assuming it is reasonable to do this in whatever context

Re: [PATCHES] [HACKERS] Cannot initdb in cvs tip

2004-07-28 Thread Andrew Dunstan
Bruce Momjian wrote: Dave, now that we are nearing beta, I think we need to correct the initdb problem with removing the directory on Win32. Would you code this up as something that sits in /port/dirmod.c and have both initdb and DROP DATABASE call the C routine rather than call rm -r/rmdir? (I

Re: [PATCHES] [HACKERS] Cannot initdb in cvs tip

2004-07-28 Thread Andrew Dunstan
Bruce Momjian wrote: Andrew Dunstan wrote: I wanted to keep a solution that was as native to the OS as possible, but because we can't do that on Win32 and few people like the unix system call to 'rm', it is time to clean it up. One question --- why is there a sleep loop needed for unlink in

Re: [PATCHES] [HACKERS] Cannot initdb in cvs tip

2004-06-20 Thread Dave Page
-Original Message- From: John Hansen [mailto:[EMAIL PROTECTED] Sent: Sun 6/20/2004 2:27 AM To: Dave Page Cc: Tom Lane; PostgreSQL-development; [EMAIL PROTECTED] Subject: Re: [HACKERS] Cannot initdb in cvs tip you could of course rmdir /s /q $PGDATA mkdir $PGDATA if the purpose is

Re: [PATCHES] [HACKERS] Cannot initdb in cvs tip

2004-06-19 Thread Dave Page
-Original Message- From: Tom Lane [mailto:[EMAIL PROTECTED] Sent: 19 June 2004 00:22 To: Dave Page Cc: PostgreSQL-development Subject: Re: [HACKERS] Cannot initdb in cvs tip Dave Page [EMAIL PROTECTED] writes: I'm getting the following error when trying to initdb with CVS

Re: [PATCHES] [HACKERS] Cannot initdb in cvs tip

2004-06-19 Thread John Hansen
On Sun, 2004-06-20 at 08:04, Dave Page wrote: -Original Message- From: Tom Lane [mailto:[EMAIL PROTECTED] Sent: 19 June 2004 00:22 To: Dave Page Cc: PostgreSQL-development Subject: Re: [HACKERS] Cannot initdb in cvs tip Dave Page [EMAIL PROTECTED] writes: I'm