Re: [PATCHES] Implemented current_query

2008-04-04 Thread Bruce Momjian
I have applied a modified version of this patch, attached. I made a few changes: o You had current_query() returning 'void' so it didn't work o I removed the dblink regression tests for current_query() as it is now a backend function o Update documentation

Re: [PATCHES] Implemented current_query

2007-05-16 Thread Bruce Momjian
This has been saved for the 8.4 release: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- Tomas Doran wrote: On 10 May 2007, at 03:09, Alvaro Herrera wrote: FWIW I think you should still provide

Re: [PATCHES] Implemented current_query

2007-05-11 Thread Tomas Doran
On 10 May 2007, at 03:09, Alvaro Herrera wrote: FWIW I think you should still provide dblink_current_query, even if it's only a wrapper over current_query(), for backwards compatibility. Good point. Done as suggested (I think, or did you mean also the change of instances to use

Re: [PATCHES] Implemented current_query

2007-05-09 Thread Tomas Doran
On 7 May 2007, at 23:25, Neil Conway wrote: On Mon, 2007-07-05 at 19:48 +0100, Tomas Doran wrote: As suggested in the TODO list (and as I need the functionality myself), I have implemented the current_query interface to debug_query_string. * docs need a bit more detail (they should

Re: [PATCHES] Implemented current_query

2007-05-09 Thread Alvaro Herrera
Tomas Doran wrote: On 7 May 2007, at 23:25, Neil Conway wrote: On Mon, 2007-07-05 at 19:48 +0100, Tomas Doran wrote: As suggested in the TODO list (and as I need the functionality myself), I have implemented the current_query interface to debug_query_string. FWIW I think you should still

[PATCHES] Implemented current_query

2007-05-07 Thread Tomas Doran
As suggested in the TODO list (and as I need the functionality myself), I have implemented the current_query interface to debug_query_string. I'm not sure the best place to put this, suggestions welcome.. Please review the patch attached. Cheers Tom pgsql-current_query.patch

Re: [PATCHES] Implemented current_query

2007-05-07 Thread Neil Conway
On Mon, 2007-07-05 at 19:48 +0100, Tomas Doran wrote: As suggested in the TODO list (and as I need the functionality myself), I have implemented the current_query interface to debug_query_string. Comments: * docs need a bit more detail (they should emphasize that it is the current query