Re: [PATCHES] ON COMMIT and foreign keys

2005-06-10 Thread Bruce Momjian
FYI, this was already applied: 2005-01-26 22:17 tgl * doc/src/sgml/ref/truncate.sgml, src/backend/catalog/heap.c, src/backend/commands/tablecmds.c, src/backend/nodes/copyfuncs.c, src/backend/nodes/equalfuncs.c, src/backend/parser/g

Re: [PATCHES] ON COMMIT and foreign keys

2004-11-06 Thread Bruce Momjian
Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > >> Tom Lane wrote: > > I think this is a feature addition that you've cleverly managed to > > present as a bug fix ;-). While I like the feature, I've got very > > mixed emotions about applying it this late in beta. > > > Ok, you caug

Re: [PATCHES] ON COMMIT and foreign keys

2004-11-06 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: >> Tom Lane wrote: > I think this is a feature addition that you've cleverly managed to > present as a bug fix ;-). While I like the feature, I've got very > mixed emotions about applying it this late in beta. > Ok, you caught me :-) Actually, I develop

Re: [PATCHES] ON COMMIT and foreign keys

2004-11-06 Thread Alvaro Herrera
> Tom Lane wrote: > > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > > Incidentally ("collateral damage"), the patch modifies the TRUNCATE > > > command so that it can work on multiple tables. In particular, if > > > foreign key references are all internal to the group that's being > > > truncated

Re: [PATCHES] ON COMMIT and foreign keys

2004-11-05 Thread Bruce Momjian
Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > Incidentally ("collateral damage"), the patch modifies the TRUNCATE > > command so that it can work on multiple tables. In particular, if > > foreign key references are all internal to the group that's being > > truncated, the comman

Re: [PATCHES] ON COMMIT and foreign keys

2004-11-05 Thread Bruce Momjian
Bruce Momjian wrote: > Tom Lane wrote: > > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > > Incidentally ("collateral damage"), the patch modifies the TRUNCATE > > > command so that it can work on multiple tables. In particular, if > > > foreign key references are all internal to the group that's

Re: [PATCHES] ON COMMIT and foreign keys

2004-11-05 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Incidentally ("collateral damage"), the patch modifies the TRUNCATE > command so that it can work on multiple tables. In particular, if > foreign key references are all internal to the group that's being > truncated, the command is allowed. I think thi

[PATCHES] ON COMMIT and foreign keys

2004-11-05 Thread Alvaro Herrera
Hackers, There's a bug with temporary tables signalled ON COMMIT DELETE ROWS, when they contain foreign key references. An example: alvherre=# begin; BEGIN alvherre=# CREATE TEMP TABLE foo (a int PRIMARY KEY) ON COMMIT DELETE ROWS; NOTICE: CREATE TABLE / PRIMARY KEY will create implicit index "