Re: [PATCHES] Preliminary patch for FRONTEND

2004-10-01 Thread Bruce Momjian
Bruce Momjian wrote: > As many know, the FRONTEND usage of /src/port is very fragile. It > requires every binary that uses certain libpgport object files to create > its own version, which is very fragile, and could easily break if a > function call is added in a subrelease, especially on certain

Re: [PATCHES] Preliminary patch for FRONTEND

2004-10-01 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > >> + #include > >> > >> What is this change for? > > > My OS couldn't compile getaddrinfo when I tried, though my OS doesn't > > need getaddrinfo so maybe we shouldn't make that change. Comments? > > Don't put it in. That looks like

Re: [PATCHES] Preliminary patch for FRONTEND

2004-10-01 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: >> + #include >> >> What is this change for? > My OS couldn't compile getaddrinfo when I tried, though my OS doesn't > need getaddrinfo so maybe we shouldn't make that change. Comments? Don't put it in. That looks like the sort of file that isn't even

Re: [PATCHES] Preliminary patch for FRONTEND

2004-10-01 Thread Bruce Momjian
Neil Conway wrote: > Pasto: > > *** src/bin/pg_config/Makefile 1 Aug 2004 06:56:38 - 1.8 > --- src/bin/pg_config/Makefile 1 Oct 2004 04:04:06 - > *** > *** 1,18 > [...] > --- 1,23 > ! > #-

Re: [PATCHES] Preliminary patch for FRONTEND

2004-10-01 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > The following patch addresses this issue by making libpgport usable > > unchanged by client applications, and makes a special server version for > > the backend. > > This raises some alarm bells for me. Why does a "port support" libr

Re: [PATCHES] Preliminary patch for FRONTEND

2004-10-01 Thread Bruce Momjian
Magnus Hagander wrote: > > > The following patch addresses this issue by making libpgport usable > > > unchanged by client applications, and makes a special > > server version > > > for the backend. > > > > This raises some alarm bells for me. Why does a "port > > support" library need to dis

Re: [PATCHES] Preliminary patch for FRONTEND

2004-10-01 Thread Magnus Hagander
> > The following patch addresses this issue by making libpgport usable > > unchanged by client applications, and makes a special > server version > > for the backend. > > This raises some alarm bells for me. Why does a "port > support" library need to distinguish whether it is running in >

Re: [PATCHES] Preliminary patch for FRONTEND

2004-09-30 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > The following patch addresses this issue by making libpgport usable > unchanged by client applications, and makes a special server version for > the backend. This raises some alarm bells for me. Why does a "port support" library need to distinguish whet

Re: [PATCHES] Preliminary patch for FRONTEND

2004-09-30 Thread Neil Conway
Pasto: *** src/bin/pg_config/Makefile 1 Aug 2004 06:56:38 - 1.8 --- src/bin/pg_config/Makefile 1 Oct 2004 04:04:06 - *** *** 1,18 [...] --- 1,23 ! #- ! # ! # Makefile for src/bin/pg_contro

[PATCHES] Preliminary patch for FRONTEND

2004-09-30 Thread Bruce Momjian
As many know, the FRONTEND usage of /src/port is very fragile. It requires every binary that uses certain libpgport object files to create its own version, which is very fragile, and could easily break if a function call is added in a subrelease, especially on certain ports. The following patch a