Re: [PATCHES] plpython tracebacks

2006-06-16 Thread Bruce Momjian
URL added to TODO list. --- Neil Conway wrote: P. Scott DeVos wrote: I'm on it. Actually, don't worry about it -- I've made the corrections I had in mind myself. Attached is a revised patch. On looking closer, I

Re: [PATCHES] plpython tracebacks

2006-05-04 Thread Neil Conway
Bruce Momjian said: Neil, where are we on this patch? My apologies for forgetting about this -- there are a few details I need to finish off in the patch before I'd like to apply it. I'm on vacation at the moment and not really in a position to write any code, but I'll definitely be able to

Re: [PATCHES] plpython tracebacks

2006-04-28 Thread Bruce Momjian
Neil, where are we on this patch? --- Neil Conway wrote: P. Scott DeVos wrote: I'm on it. Actually, don't worry about it -- I've made the corrections I had in mind myself. Attached is a revised patch. On looking

Re: [PATCHES] plpython tracebacks

2006-02-22 Thread P. Scott DeVos
Neil Conway wrote: Context diffs are preferred. Also, diffs should be against the root of the source tree, and attached as MIME attachements if possible (it seems the mailing list software munges the patch somewhat otherwise). Minor nit: lowercase Append. Similarly, consistent capitalization

Re: [PATCHES] plpython tracebacks

2006-02-22 Thread Neil Conway
P. Scott DeVos wrote: I'm on it. Actually, don't worry about it -- I've made the corrections I had in mind myself. Attached is a revised patch. On looking closer, I didn't really like the way the patch accumulated the lines of the traceback: AFAICS _PyString_Join() is not an official Python

Re: [PATCHES] plpython tracebacks

2006-02-22 Thread P. Scott DeVos
Neil Conway wrote: Actually, don't worry about it -- I've made the corrections I had in mind myself. Attached is a revised patch. On looking closer, I didn't really like the way the patch accumulated the lines of the traceback: AFAICS _PyString_Join() is not an official Python C API

Re: [PATCHES] plpython tracebacks

2006-02-22 Thread P. Scott DeVos
P. Scott DeVos wrote: Are you sure this works: PyString_AsString(lno)? lno is a python integer object. Maybe we want, PyString_AsString(PyObject_Str(lno)) Wait, this is not the way to do it because PyObject_Str returns a new reference. I think you have to assign PyObject_Str(lno)

Re: [PATCHES] plpython tracebacks

2006-02-19 Thread Neil Conway
On Mon, 2006-02-06 at 16:05 -0600, P. Scott DeVos wrote: I have been working with plpython for several months and have been hampered by the lack of a traceback being logged when a plpython function raises an error. I have written a patch causes the PLy_traceback function to fully log the

Re: [PATCHES] plpython tracebacks

2006-02-19 Thread Harald Armin Massa
Neil,I have written a patch causes the PLy_traceback function to fully log the traceback.The output looks just like the traceback output provided by the python interpreter.Can any PL/Python folks comment on whether they want this patch?I am just a humble user of PL/Py, but tracebacks are very

Re: [PATCHES] plpython tracebacks

2006-02-19 Thread daveg
On Sun, Feb 19, 2006 at 08:09:09PM -0500, Neil Conway wrote: On Mon, 2006-02-06 at 16:05 -0600, P. Scott DeVos wrote: I have been working with plpython for several months and have been hampered by the lack of a traceback being logged when a plpython function raises an error. I have written

[PATCHES] plpython tracebacks

2006-02-06 Thread P. Scott DeVos
I have been working with plpython for several months and have been hampered by the lack of a traceback being logged when a plpython function raises an error. I have written a patch causes the PLy_traceback function to fully log the traceback. The output looks just like the traceback output