Re: [PATCHES] dbsize patch

2005-02-27 Thread Bruce Momjian
Patch applied. Thanks. I renamed aggregate_relation_size() to total_relation_size(). To me 'aggregate' was too closely associated with 'aggregates'. If you have improved wording please let me know. --- Ed L. wrote: > On

Re: [PATCHES] [HACKERS] UTF8 or Unicode

2005-02-27 Thread lsunley
The routines that do the conversion could have alternate names specified in the conversion_create.sql. There is not reason that I can see why you cannot have two function names pointing to the same routine. like CREATE OR REPLACE FUNCTION ascii_to_mic (INTEGER, INTEGER, CSTRING, CSTRING, INTEGER)

[PATCHES] int4 <-> bool casts

2005-02-27 Thread Neil Conway
I've applied a modified version of this patch from seanc: http://candle.pha.pa.us/mhonarc/patches2/msg00029.html (Sorry, I've lost the original thread.) The patch as I applied it is attached. Catalog version bumped. -Neil Index: src/backend/utils/adt/int.c

Re: [PATCHES] [HACKERS] UTF8 or Unicode

2005-02-27 Thread lsunley
In <[EMAIL PROTECTED]>, on 02/26/05 at 11:09 PM, Bruce Momjian said: >Here is an updated version that handles all cases. It does rename the >routine names so the primary encoding name is used for the routine names. >This will be documented in the release notes if anyone actually uses >tho

[PATCHES] array max() / min()

2005-02-27 Thread Neil Conway
Barring any objections, I'll apply this patch to HEAD tomorrow: http://candle.pha.pa.us/mhonarc/patches2/msg7.html (Sorry, lost track of this patch as well... :P) -Neil ---(end of broadcast)--- TIP 8: explain analyze is your friend

Re: [PATCHES] [HACKERS] UTF8 or Unicode

2005-02-27 Thread lsunley
Ignore previous e-mail... Missed the patch to the makefile Sorry about that -- --- [EMAIL PROTECTED] --- ---(end of broadcast)--- TIP

Re: [PATCHES] [BUGS] BUG #1466: #maintenace_work_mem = 16384

2005-02-27 Thread Magnus Hagander
Actually, I'd like it considered for 8.0.X as well. Right now if yuo change the config file in a way that it won't load, you get no error message. Which is cearly not very good. I'll certainly accept if you think it's not safe enough for 8.0.x, but please consider it. //Magnus >-Original Mes

Re: [PATCHES] Casting INT4 to BOOL...

2005-02-27 Thread Bruce Momjian
Patch applied by Neil. Thanks. --- Sean Chittenden wrote: > >> Is there any reason why the backend doesn't cast an unquoted integer > >> to > >> a boolean value? > > > > Hidden cross-category typecasts are evil. I'd acce

[PATCHES] Patch that deals with that AtCommit_Portals encounters deleted entries

2005-02-27 Thread Thomas Hallgren
This patch will ensure that the hash table iteration performed by AtCommit_Portals is restarted when a portal is deleted. This is necessary since the deletion of a portal may cause the deletion of another which on rare occations may cause the iterator to return a deleted portal an thus a renewe

Re: [PATCHES] A way to let Vacuum warn if FSM settings are low.

2005-02-27 Thread Simon Riggs
On Fri, 2005-02-25 at 16:48 -0800, Ron Mayer wrote: > Getting closer? For me, yes. I agree with Bruce's comment on the use of the word "needed", and I think your change reads better now. The not-warnings seem a little wordy for me, but they happen when and how I would hope for. So, for me, it

Re: [PATCHES] int4 <-> bool casts

2005-02-27 Thread Neil Conway
Peter Eisentraut wrote: - Casting back and forth does not preserve information. (This may be true for some other type pairs as well, but in this case it's true in almost every instance.) Right, there are many other explicit casts that lose information. In fact, I think that's somewhat the point

Re: [PATCHES] int4 <-> bool casts

2005-02-27 Thread Peter Eisentraut
Neil Conway wrote: > > I believe I would have objected to an int/bool cast. I do so now > > anyway. > > On what grounds? I can think of a couple of reasons: - Casting back and forth does not preserve information. (This may be true for some other type pairs as well, but in this case it's true in

[PATCHES] win32 libpq build broken

2005-02-27 Thread Magnus Hagander
by the change to gettext. Needs a bunch of new includes. Patch follows: diff -c -r1.13 win32.c *** win32.c 22 Feb 2005 04:42:20 - 1.13 --- win32.c 27 Feb 2005 17:36:06 - *** *** 19,26 /* Make stuff compile faster by excluding not used stuff */ - #defi

[PATCHES] snprintf.c on win32 does not compile..

2005-02-27 Thread Magnus Hagander
there is no sys/ioctl.h. Trivial patch below: diff -c -r1.6 snprintf.c *** snprintf.c 22 Feb 2005 04:57:24 - 1.6 --- snprintf.c 27 Feb 2005 17:05:54 - *** *** 40,46 --- 40,48 Your platform must have a thread-safe snprintf() to compile with threads. #en