Re: [PATCHES] Updated FSM display for VACUUM VERBOSE

2005-04-23 Thread Bruce Momjian
Bruce Momjian wrote: pgman wrote: INFO: free space map: 49 relations with free space, maximum of 1000 relations trackable INFO: 17266 pages stored, 18000 pages used (with overhead) INFO: 18768 pages required to store all freespace, maximum of 18000 pages allocatable

Re: [PATCHES] Updated FSM display for VACUUM VERBOSE

2005-04-23 Thread Tom Lane
Bruce Momjian pgman@candle.pha.pa.us writes: OK, I have simplified the patch. It doesn't use any new computations but just displays them differently. The output is now: INFO: free space map contains information about: INFO: 49 relations, limit 1000 relations INFO: 35

Re: [PATCHES] Updated FSM display for VACUUM VERBOSE

2005-04-23 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian pgman@candle.pha.pa.us writes: OK, I have simplified the patch. It doesn't use any new computations but just displays them differently. The output is now: INFO: free space map contains information about: INFO: 49 relations, limit 1000 relations

Re: [PATCHES] revise a comment in CreateCheckPoint()

2005-04-23 Thread Tom Lane
Qingqing Zhou [EMAIL PROTECTED] writes: The original comment of why we are safe without protection of critical section is confusing. I thought your version was even more so :-(. I've applied the attached patch instead. regards, tom lane Index: xlog.c

[PATCHES] VACUUM VERBOSE FSM info

2005-04-23 Thread Bruce Momjian
Here is a reformatting of the VACUUM VERBOSE FSM output so it outputs from a single INFO output command: INFO: free space map contains information about: 49 relations, limit 1000 relations 35 pages with free space, 784 pages (with overhead) 784 pages

Re: [PATCHES] VACUUM VERBOSE FSM info

2005-04-23 Thread Alvaro Herrera
On Sat, Apr 23, 2005 at 04:55:37PM -0400, Bruce Momjian wrote: One question, INFO: free space map contains information about: 49 relations, limit 1000 relations 35 pages with free space, 784 pages (with overhead) ^ 784 pages

Re: [PATCHES] VACUUM VERBOSE FSM info

2005-04-23 Thread Bruce Momjian
Alvaro Herrera wrote: On Sat, Apr 23, 2005 at 04:55:37PM -0400, Bruce Momjian wrote: One question, INFO: free space map contains information about: 49 relations, limit 1000 relations 35 pages with free space, 784 pages (with overhead)

Re: [PATCHES] VACUUM VERBOSE FSM info

2005-04-23 Thread Alvaro Herrera
On Sat, Apr 23, 2005 at 05:16:09PM -0400, Bruce Momjian wrote: Well, the number you highlighted might not equal the number on the next line if you don't have enough entries to store all the free space, e.g.: INFO: free space map contains information about: 49 relations, limit

Re: [PATCHES] VACUUM VERBOSE FSM info

2005-04-23 Thread Tom Lane
Alvaro Herrera [EMAIL PROTECTED] writes: What goes in the remaining 5276 (19300-14024) page entries anyway? That's overhead forced by the quantized allocation of FSM slots. regards, tom lane ---(end of broadcast)--- TIP 3:

Re: [PATCHES] VACUUM VERBOSE FSM info

2005-04-23 Thread Tom Lane
Bruce Momjian pgman@candle.pha.pa.us writes: Should the memory used line be a hint? Well, the main message should fit on one line, and the rest is either hint or detail. In this case detail since it's all facts, not advice. Could look like this: INFO: free space map contains N1 pages in N2

Re: [PATCHES] VACUUM VERBOSE FSM info

2005-04-23 Thread Bruce Momjian
OK, new text is: INFO: free space map contains 36 pages in 51 relations DETAIL: A total of 816 page slots are in use (including overhead). 816 page slots are required to track all free space. Current limits are: 18000 page slots, 1000 relations, using