On Mon, 9 May 2005, Dennis Bjorklund wrote:
The thing is that I don't care how it's implemented, it's the feature
itself that is more importent to decide if we want it or not. I'm sure the
code can be fixed so everybody is happy it in the end,
You could implement this on top of the current nextval
Heikki Linnakangas wrote:
On Mon, 9 May 2005, Dennis Bjorklund wrote:
The thing is that I don't care how it's implemented, it's the feature
itself that is more importent to decide if we want it or not. I'm
sure the
code can be fixed so everybody is happy it in the end,
You could implement this o
Dennis Bjorklund wrote:
Here is a small patch that implements a function lastval() that
works just like currval() except that it give the current
value of the last sequence used by nextval().
What do people think of this idea? (Tom seems opposed, I'm just
wondering if there are other opinions out
This patch makes some minor style cleanups to contrib/btree_gist: remove
the "extern" keyword for function definitions, reorganize some
PG_GETARG_XXX() usage, and similar.
Barring any objections, I'll apply this to HEAD tomorrow.
-Neil
Index: contrib/btree_gist/btree_bit.c
==
Neil Conway wrote:
Dennis Bjorklund wrote:
Here is a small patch that implements a function lastval() that
works just like currval() except that it give the current
value of the last sequence used by nextval().
What do people think of this idea? (Tom seems opposed, I'm just
wondering if there are
Neil Conway wrote:
Okay, apparently I'm the only person who doesn't like code like this :)
Attached is a revised patch that doesn't make this change.
Applied.
-Neil
---(end of broadcast)---
TIP 9: the planner will ignore your desire to choose an inde
Neil Conway wrote:
This patch reduces the size of the message header used by statistics
collector messages, per recent discussion.
Applied.
-Neil
---(end of broadcast)---
TIP 2: you can get off all lists at once with the unregister command
(send "
Neil Conway wrote:
> Dennis Bjorklund wrote:
> > Here is a small patch that implements a function lastval() that
> > works just like currval() except that it give the current
> > value of the last sequence used by nextval().
>
> What do people think of this idea? (Tom seems opposed, I'm just
> wo
I like the concept, but I haven't looked at the code -- I'd be happy to
review the implementation, although I won't waste my time if most people
are opposed to the idea itself.
It'd make implementing various PHP userland functions a real breeze...
Chris
---(end of broadcas
This patch refactors away some duplicated code in the index AM build
methods: they all invoke UpdateStats() since they have computed the
number of heap tuples, so I created a function in catalog/index.c that
each AM calls. This is per earlier discussion (it was included in the
GiST patches I su
At 2005-05-11 10:55:37 +1000, [EMAIL PROTECTED] wrote:
>
> > Here is a small patch that implements a function lastval() [...]
>
> What do people think of this idea? (Tom seems opposed, I'm just
> wondering if there are other opinions out there.)
For what it's worth, I think it's a bad idea.
In t
Neil Conway wrote:
> Sent: Wednesday, May 11, 2005 10:56 AM
> To: Dennis Bjorklund
> Cc: pgsql-patches@postgresql.org
> Subject: Re: [PATCHES] lastval()
>
> Dennis Bjorklund wrote:
> > Here is a small patch that implements a function lastval()
> that works
> > just like currval() except that it
Abhijit Menon-Sen said:
> At 2005-05-11 10:55:37 +1000, [EMAIL PROTECTED] wrote:
>>
>> > Here is a small patch that implements a function lastval() [...]
>>
>> What do people think of this idea? (Tom seems opposed, I'm just
>> wondering if there are other opinions out there.)
>
> For what it's wort
John Hansen wrote:
> Neil Conway wrote:
> > Sent: Wednesday, May 11, 2005 10:56 AM
> > To: Dennis Bjorklund
> > Cc: pgsql-patches@postgresql.org
> > Subject: Re: [PATCHES] lastval()
> >
> > Dennis Bjorklund wrote:
> > > Here is a small patch that implements a function lastval()
> > that works
>
Abhijit Menon-Sen wrote:
> At 2005-05-11 10:55:37 +1000, [EMAIL PROTECTED] wrote:
> >
> > > Here is a small patch that implements a function lastval() [...]
> >
> > What do people think of this idea? (Tom seems opposed, I'm just
> > wondering if there are other opinions out there.)
>
> For what i
At 2005-05-10 23:30:05 -0400, pgman@candle.pha.pa.us wrote:
>
> > By the way, what would lastval() do if an insert trigger inserts
> > a row into a table with another serial column?
>
> It fails, just like it would fail now if the trigger inserted into
> the same table that used the trigger, or a
Bruce Momjian wrote:
> Sent: Wednesday, May 11, 2005 1:27 PM
> To: John Hansen
> Cc: Neil Conway; Dennis Bjorklund; pgsql-patches@postgresql.org
> Subject: Re: [PATCHES] lastval()
>
> John Hansen wrote:
> > Neil Conway wrote:
> > > Sent: Wednesday, May 11, 2005 10:56 AM
> > > To: Dennis Bjorklund
John Hansen wrote:
> > > > What do people think of this idea? (Tom seems opposed, I'm just
> > > > wondering if there are other opinions out there.)
> > >
> > > I'm all for it. Even more so if the 'currval(void) called before
> > > nextval(seq_name)' error message could be supressed by a
> > GU
Abhijit Menon-Sen wrote:
> At 2005-05-10 23:30:05 -0400, pgman@candle.pha.pa.us wrote:
> >
> > > By the way, what would lastval() do if an insert trigger inserts
> > > a row into a table with another serial column?
> >
> > It fails, just like it would fail now if the trigger inserted into
> > the
Bruce Momjian wrote:
> Sent: Wednesday, May 11, 2005 1:45 PM
> To: John Hansen
> Cc: Neil Conway; Dennis Bjorklund; pgsql-patches@postgresql.org
> Subject: Re: [PATCHES] lastval()
>
> John Hansen wrote:
> > > > > What do people think of this idea? (Tom seems
> opposed, I'm just
> > > > > wonderi
John Hansen wrote:
Even more so if the 'currval(void) called before nextval(seq_name)'
error message could be supressed by a GUC variable and return 0
instead.
I don't think that's a good idea at all. It seems unnecessary, it
complicates the definition of the operation, and worse, "0" is a valid
Neil Conway wrote:
> Sent: Wednesday, May 11, 2005 2:13 PM
> To: John Hansen
> Cc: Dennis Bjorklund; pgsql-patches@postgresql.org
> Subject: Re: [PATCHES] lastval()
>
> John Hansen wrote:
> > Even more so if the 'currval(void) called before nextval(seq_name)'
> > error message could be supressed b
Neil Conway <[EMAIL PROTECTED]> writes:
> This patch refactors away some duplicated code in the index AM build
> methods: they all invoke UpdateStats() since they have computed the
> number of heap tuples, so I created a function in catalog/index.c that
> each AM calls. This is per earlier discu
Bruce Momjian writes:
> Abhijit Menon-Sen wrote:
>> By the way, what would lastval() do if an insert trigger inserts a row
>> into a table with another serial column?
> It fails, just like it would fail now if the trigger inserted into the
> same table that used the trigger, or a rule.
If it act
"John Hansen" <[EMAIL PROTECTED]> writes:
> I'm all for it. Even more so if the 'currval(void) called before
> nextval(seq_name)' error message could be supressed by a GUC variable
> and return 0 instead.
I really have a hard time seeing the argument why that condition
does not mean "your applicat
25 matches
Mail list logo
