Tom Lane wrote:
Sent: Wednesday, May 11, 2005 3:41 PM
To: John Hansen
Cc: Neil Conway; Dennis Bjorklund; pgsql-patches@postgresql.org
Subject: Re: [PATCHES] lastval()
John Hansen [EMAIL PROTECTED] writes:
I'm all for it. Even more so if the 'currval(void) called before
Dear list
I had submitter farsi translation of postgresql but I can not find its link in website?
would you please fix this problem.
Regards
Yahoo! Mail
Stay connected, organized, and protected. Take the tour
On Wed, May 11, 2005 at 02:08:16PM +1000, John Hansen wrote:
Take for instance this (overly simplified) function used in a program
that builds the query strings dynamically:
int64 runquery(char *query) {
PQexec(query);
result = Pqexec(SELECT lastval());
return result;
}
In SQL that executes aggregation, AllocSetReset is called many times and
spend a lot of cycles.
This patch saves the cycles spent by AllocSetReset.
An idea of the patch is to add a flag to AllocSetContext. This flag
shows whether AllocSetReset should work.
The effect of
Lionel Bouton wrote:
The following bug has been logged online:
Bug reference: 1588
Logged by: Lionel Bouton
Email address: [EMAIL PROTECTED]
PostgreSQL version: 8.0.1
Operating system: Linux 2.6, glibc 2.3.4
Description:pg_autovacuum sleep parameter overflow
The attached patch creates installcheck targets for plperl and pltcl
(plpython laready has one). This will help in getting buildfarm to test PLs.
Is it worth rearranging things for plpython so that it follows the same
test layout as the other 2 (i.e. a test subdir with all the test files
and a
Bruce Momjian wrote:
*/
! #ifndef WIN32
! sleep(sleep_secs); /* Unix sleep is seconds */
! #else
! sleep(sleep_secs * 1000); /* Win32 sleep() is milliseconds */
Shouldn't the be Sleep with a capital S? see
Andrew Dunstan wrote:
Bruce Momjian wrote:
*/
! #ifndef WIN32
!sleep(sleep_secs); /* Unix sleep is
seconds */
! #else
!sleep(sleep_secs * 1000); /* Win32 sleep() is
milliseconds */
Shouldn't the be Sleep with
Bruce Momjian wrote:
Andrew Dunstan wrote:
Bruce Momjian wrote:
*/
! #ifndef WIN32
! sleep(sleep_secs); /* Unix sleep is
seconds */
! #else
! sleep(sleep_secs * 1000); /* Win32 sleep() is
milliseconds */
Bruce Momjian pgman@candle.pha.pa.us writes:
However, I am now wondering if we should change pg_usleep() to take a
double rather than long. This would avoid such problems in the future
in other places in our code.
I'd leave it alone; there aren't any other places that need long sleeps,
and I
Andrew Dunstan wrote:
Strange ... as long as you #include windows.h it should be fine, and
pg_autovacuum.c already does include it.
Anyway, whatever works, I guess.
Ah, my test program did not include windows.h. I found it understood
sleep() with just the standard Unix includes. I did
Andrew Dunstan [EMAIL PROTECTED] writes:
Is it worth rearranging things for plpython so that it follows the same
test layout as the other 2 (i.e. a test subdir with all the test files
and a script called runtest that does the work)? Especially if we bring
in other PLs as has been discussed,
Patch applied to HEAD and 8.0.X. Thanks.
---
Robert Treat wrote:
This patch updates a number of urls in a number of files. Most are just
poinitng to the TODO list within the main website.
--
Robert Treat
Build
Thomas Hallgren wrote:
This patch will ensure that the hash table iteration performed by
AtCommit_Portals is restarted when a portal is deleted. This is
necessary since the deletion of a portal may cause the deletion of
another which on rare occations may cause the iterator to return a
Patch applied and backpatched to 8.0.X.
---
Bruce Momjian wrote:
Index: contrib/pg_autovacuum/pg_autovacuum.c
===
RCS file:
Patch applied. It will appear in 8.1. Thanks.
---
Cosimo Streppone wrote:
Here it is,
a small tweak to enable display in the log file
of database name before table name
when VACUUMing or ANALYZing a table.
--
Alvaro Herrera wrote:
Sent: Wednesday, May 11, 2005 10:46 PM
To: John Hansen
Cc: Bruce Momjian; Neil Conway; Dennis Bjorklund;
pgsql-patches@postgresql.org
Subject: Re: [PATCHES] lastval()
On Wed, May 11, 2005 at 02:08:16PM +1000, John Hansen wrote:
Take for instance this (overly
Bruce Momjian pgman@candle.pha.pa.us writes:
This patch will ensure that the hash table iteration performed by
AtCommit_Portals is restarted when a portal is deleted.
I have applied the following patch. I assume it is too risky for
backpatch to 8.0.X.
I don't think it's appropriate in HEAD
Tom Lane wrote:
Bruce Momjian pgman@candle.pha.pa.us writes:
This patch will ensure that the hash table iteration performed by
AtCommit_Portals is restarted when a portal is deleted.
I have applied the following patch. I assume it is too risky for
backpatch to 8.0.X.
I don't
Tom Lane wrote:
Andrew Dunstan [EMAIL PROTECTED] writes:
Aha. ok. should be fairly trivial. I'm thinking of something like
--load-languages=lang1,lang2,lang3
(in case we ever want more than one).
Might be a little easier as multiple switches:
--load-language=lang1
Andrew Dunstan wrote:
Tom Lane wrote:
Andrew Dunstan [EMAIL PROTECTED] writes:
Aha. ok. should be fairly trivial. I'm thinking of something like
--load-languages=lang1,lang2,lang3
(in case we ever want more than one).
Might be a little easier as multiple switches:
On Thu, May 12, 2005 at 04:58:54AM +1000, John Hansen wrote:
Alvaro Herrera wrote:
Actually, having it throw an error would be helpful, because
then you can find in the application which calls should be
replaced by the generic runquery() that has to return nothing
versus the one that
Andrew Dunstan [EMAIL PROTECTED] writes:
Ok. Here's a patch for that piece. With this, contrib regression
tests don't load plpgsql, but standard core tests do.
er this time with a patch attached.
Looks good to me, will apply shortly.
Are you planning to take a whack at fixing the PL tests
Tom Lane wrote:
Andrew Dunstan [EMAIL PROTECTED] writes:
Ok. Here's a patch for that piece. With this, contrib regression
tests don't load plpgsql, but standard core tests do.
er this time with a patch attached.
Looks good to me, will apply shortly.
Are you planning to take a
a_ogawa [EMAIL PROTECTED] writes:
In SQL that executes aggregation, AllocSetReset is called many times and
spend a lot of cycles.
This patch saves the cycles spent by AllocSetReset.
Hmm. It doesn't seem like this could be a big win overall. It's not
possible to save a whole lot of cycles
I have just been alerted to a bug in the 8.0 handling of embedded
newlines in CSV data. Basically it barfs on consecutive newlines. The
attached patch for 8.0 appears to fix it. The bug isn't present in the
HEAD branch, and I'm wondering if we should not backpatch the HEAD
multiline patch
Neil Conway wrote:
This patch makes some minor style cleanups to contrib/btree_gist: remove
the extern keyword for function definitions, reorganize some
PG_GETARG_XXX() usage, and similar.
Applied.
-Neil
---(end of broadcast)---
TIP 7: don't forget
Andrew Dunstan wrote:
I have just been alerted to a bug in the 8.0 handling of embedded
newlines in CSV data. Basically it barfs on consecutive newlines. The
attached patch for 8.0 appears to fix it. The bug isn't present in the
HEAD branch, and I'm wondering if we should not backpatch the HEAD
Neil Conway wrote:
Andrew Dunstan wrote:
I have just been alerted to a bug in the 8.0 handling of embedded
newlines in CSV data. Basically it barfs on consecutive newlines. The
attached patch for 8.0 appears to fix it. The bug isn't present in
the HEAD branch, and I'm wondering if we should
Simon Riggs wrote:
Following patch is a minor addition to postgres.c that allows the two
existing statement logging techniques to work with V3 exec. This then
allows statement logging with PostgreSQL 8.0+ for JDBC and other V3
connection types.
Good.
The rationale of this patch is to add
Andrew Dunstan [EMAIL PROTECTED] writes:
Is that what you had in mind?
Not entirely. We should move around the test sql script and the expected
result file so that the file structure looks exactly like one of the
test-enabled contrib modules. I realize that's a PITA to describe as a
patch ---
31 matches
Mail list logo
