Re: [PATCHES] Load Distributed Checkpoints, final patch

2007-07-03 Thread Heikki Linnakangas
Tom Lane wrote: Bruce Momjian <[EMAIL PROTECTED]> writes: Heikki Linnakangas wrote: For comparison, imola-328 has full_page_writes=off. Checkpoints last ~9 minutes there, and the graphs look very smooth. That suggests that spreading the writes over a longer time wouldn't make a difference, but

Re: [PATCHES] SPI-header-files safe for C++-compiler

2007-07-03 Thread Jacob Rief
Tom Lane writes: > That will have exactly zero effect. As was shown upthread, even > everyday C++ programmers don't remember what all the extra keywords are. > Guys who mainly code C are very unlikely to get this right if there's no > automatic check being applied. Just for curiosity, I would li

Re: [PATCHES] Load Distributed Checkpoints, final patch

2007-07-03 Thread Gregory Stark
"Heikki Linnakangas" <[EMAIL PROTECTED]> writes: > For 8.3, we should probably just do some simple compensation in the checkpoint > throttling code, if we want to do anything at all. But this is something to > think about in the future. Just as a stress test it might be interesting to run a quic

Re: [PATCHES] [DOCS] rename of a view

2007-07-03 Thread Tom Lane
Stefan Kaltenbrunner <[EMAIL PROTECTED]> writes: > Neil Conway wrote: >> On Mon, 2007-02-07 at 23:13 -0400, Tom Lane wrote: >>> Er, was this on the agenda for 8.3? >> >> Well, it seemed fairly harmless to me (no behavioral changes and very >> little new code, just syntax), so I didn't see a compel

Re: [PATCHES] Load Distributed Checkpoints, final patch

2007-07-03 Thread Tom Lane
Heikki Linnakangas <[EMAIL PROTECTED]> writes: > While thinking about this, I made an observation on full_page_writes. > Currently, we perform a full page write whenever LSN < RedoRecPtr. If > we're clever, we can skip or defer some of the full page writes: I'm not convinced this is safe; in par

Re: [PATCHES] SPI-header-files safe for C++-compiler

2007-07-03 Thread Tom Lane
"Jacob Rief" <[EMAIL PROTECTED]> writes: > Just for curiosity, I would like to ask something. > libpqxx is based on libpq, and thus includes headers-files from libpq. > These header-files are C++-safe, otherwise libpqxx would'nt compile. Well, if they are, it's only by chance, because there isn't

Re: [PATCHES] pgstat_drop_relation bugfix

2007-07-03 Thread Tom Lane
ITAGAKI Takahiro <[EMAIL PROTECTED]> writes: > I wrote: >>> pgstat_drop_relation() is expecting relid (pg_class.oid) as the argument, >>> but we pass it relfilenode. > Here is a patch to fix undropped entries in the runtime statistics table. > Now smgr records the relation oids and uses them to dr

Re: [PATCHES] [DOCS] rename of a view

2007-07-03 Thread Neil Conway
On Tue, 2007-07-03 at 09:56 -0400, Tom Lane wrote: > Neil, according to > http://developer.postgresql.org/index.php/Todo:PatchStatus > you have accepted two patches to review --- what is happening with > those? Yeah, sorry, forgot about those -- I'll take a look at them tonight. -Neil

[PATCHES] Compile error with MSVC

2007-07-03 Thread Yoshiyuki Asaba
Hi, I tried to compile using Visual C++ 2005. But I got the following errors. .\src\backend\parser\keywords.c(22) : fatal error C1083: 'parser/parse.h': No such file or directory I saw src/tools/msvc/pgbison.bat. Why does it copy src/backend/parser/parser.h to src/include/parser directory?