Re: XML binary I/O (was Re: [PATCHES] tsearch refactorings)

2007-09-14 Thread Heikki Linnakangas
Heikki Linnakangas wrote: > Heikki Linnakangas wrote: >> BTW, the encoding of the XML datatype looks pretty funky. xml_recv first >> reads the xml string with pq_getmsgtext, which applies a client->server >> conversion. Then the xml declaration is parsed, extracting the encoding >> attribute. Then

Re: XML binary I/O (was Re: [PATCHES] tsearch refactorings)

2007-09-14 Thread Alvaro Herrera
Heikki Linnakangas wrote: > + -- Basic test > + COPY xmltest TO > '/home/hlinnaka/pg_sandbox/pgsql.cvshead/src/test/regress/results/xmltest.data' > WITH BINARY; > + TRUNCATE xmltest; > + COPY xmltest FROM > '/home/hlinnaka/pg_sandbox/pgsql.cvshead/src/test/regress/results/xmltest.data' > WITH

Re: XML binary I/O (was Re: [PATCHES] tsearch refactorings)

2007-09-14 Thread Heikki Linnakangas
Alvaro Herrera wrote: > Heikki Linnakangas wrote: > >> + -- Basic test >> + COPY xmltest TO >> '/home/hlinnaka/pg_sandbox/pgsql.cvshead/src/test/regress/results/xmltest.data' >> WITH BINARY; >> + TRUNCATE xmltest; >> + COPY xmltest FROM >> '/home/hlinnaka/pg_sandbox/pgsql.cvshead/src/test/regre

Re: XML binary I/O (was Re: [PATCHES] tsearch refactorings)

2007-09-14 Thread Heikki Linnakangas
Heikki Linnakangas wrote: > Alvaro Herrera wrote: >> Heikki Linnakangas wrote: >> >>> + -- Basic test >>> + COPY xmltest TO >>> '/home/hlinnaka/pg_sandbox/pgsql.cvshead/src/test/regress/results/xmltest.data' >>> WITH BINARY; >>> + TRUNCATE xmltest; >>> + COPY xmltest FROM >>> '/home/hlinnaka/pg_

Re: [PATCHES] psql slash# command

2007-09-14 Thread Sibte Abbas
On 9/9/07, Sibte Abbas <[EMAIL PROTECTED]> wrote: > Attached is the patch for the TODO item mentioned at > http://archives.postgresql.org/pgsql-hackers/2007-09/msg00352.php > > The command has the following synopsis: > > \#: displays the command history. Like \s but prefixes the lines with line > n

Re: [PATCHES] psql slash# command

2007-09-14 Thread Bruce Momjian
This has been saved for the 8.4 release: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- Sibte Abbas wrote: > On 9/9/07, Sibte Abbas <[EMAIL PROTECTED]> wrote: > > Attached is the patch for the TODO item me

Re: [PATCHES] documentation patch for LDAP service lookup

2007-09-14 Thread Bruce Momjian
Patch applied. Thanks. Your documentation changes can be viewed in five minutes using links on the developer's page, http://www.postgresql.org/developer/testing. --- Albe Laurenz wrote: > Since nobody seemed to have objec

Re: [PATCHES] Linkage for escape strings

2007-09-14 Thread Bruce Momjian
Patch applied. Thanks. Your documentation changes can be viewed in five minutes using links on the developer's page, http://www.postgresql.org/developer/testing. --- Brendan Jurd wrote: > Just a minor doc upgrade. I've l

[PATCHES] adjust chr()/ascii() to prevent invalidly encoded data

2007-09-14 Thread Andrew Dunstan
The attached patch is intended to ensure that chr() does not produce invalidly encoded data, as recently discussed on -hackers. For UTF8, we treat its argument as a Unicode code point; for all other multi-byte encodings, we raise an error on any argument greater than 127. For all encodings we

Re: [PATCHES] GSS warnings

2007-09-14 Thread Bruce Momjian
Patch applied. Thanks. --- Kris Jurka wrote: > > > On Wed, 5 Sep 2007, Tom Lane wrote: > > > Kris Jurka <[EMAIL PROTECTED]> writes: > >> Parts of the GSS API want the object while others want pointers to the > >> object

Re: [PATCHES] SET TRANSACTION conformance to SQL:2003

2007-09-14 Thread Bruce Momjian
This has been saved for the 8.4 release: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- Simon Riggs wrote: > Short patch to implement SQL standard behaviour of the SET TRANSACTION > command. According to t

Re: [PATCHES] tsearch refactorings

2007-09-14 Thread Bruce Momjian
Done by Teodor. --- Heikki Linnakangas wrote: > Teodor Sigaev wrote: > >> I am getting confused with the patches and version I have lying around > >> here... I think I'll have to wait for review of the patches I've posted >

Re: XML binary I/O (was Re: [PATCHES] tsearch refactorings)

2007-09-14 Thread Tom Lane
"Heikki Linnakangas" <[EMAIL PROTECTED]> writes: > Oh, I see what you mean. Yeah, the absolute paths need to be fixed :). Easier to just remove the regression test altogether. Not every patch requires permanent memorialization in a regression test. regards, tom lane

Re: [PATCHES] PL/TCL Patch to prevent postgres from becoming multithreaded

2007-09-14 Thread Bruce Momjian
This has been saved for the 8.4 release: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- Marshall, Steve wrote: > There is a problem in PL/TCL that can cause the postgres backend to > become multithreaded.

Re: [PATCHES] PL/TCL Patch to prevent postgres from becoming multithreaded

2007-09-14 Thread Gregory Stark
"Bruce Momjian" <[EMAIL PROTECTED]> writes: > This has been saved for the 8.4 release: > > http://momjian.postgresql.org/cgi-bin/pgpatches_hold > > --- > > Marshall, Steve wrote: >> There is a problem in PL/TCL that can

Re: [PATCHES] PL/TCL Patch to prevent postgres from becoming multithreaded

2007-09-14 Thread Tom Lane
Gregory Stark <[EMAIL PROTECTED]> writes: > "Bruce Momjian" <[EMAIL PROTECTED]> writes: >>> There is a problem in PL/TCL that can cause the postgres backend to >>> become multithreaded. Postgres is not designed to be multithreaded, so >>> this causes downstream errors in signal handling. > U

Re: [PATCHES] PL/TCL Patch to prevent postgres from becoming multithreaded

2007-09-14 Thread Andrew Dunstan
Gregory Stark wrote: Do we have anyone actively maintaining pltcl these days? I'm intentionally quite unfamiliar with Tcl or I would be happy to verify it's reasonable. But the explanation seems pretty convincing. If we don't have anyone maintaining it then we're pretty much at the mercy of app

Re: [PATCHES] PL/TCL Patch to prevent postgres from becoming multithreaded

2007-09-14 Thread Bruce Momjian
OK, moved to patches list. --- Andrew Dunstan wrote: > > > Gregory Stark wrote: > > Do we have anyone actively maintaining pltcl these days? I'm intentionally > > quite unfamiliar with Tcl or I would be happy to verify it'

Re: [PATCHES] PL/TCL Patch to prevent postgres from becoming multithreaded

2007-09-14 Thread Stefan Kaltenbrunner
Tom Lane wrote: > Gregory Stark <[EMAIL PROTECTED]> writes: >> "Bruce Momjian" <[EMAIL PROTECTED]> writes: There is a problem in PL/TCL that can cause the postgres backend to become multithreaded. Postgres is not designed to be multithreaded, so this causes downstream errors in s

Re: [PATCHES] PL/TCL Patch to prevent postgres from becoming multithreaded

2007-09-14 Thread Tom Lane
Stefan Kaltenbrunner <[EMAIL PROTECTED]> writes: > hmm i wonder if that could be related to: > http://archives.postgresql.org/pgsql-hackers/2007-01/msg00377.php I had forgotten that thread, but it sure does look related doesn't it? Do you want to try Steve's proposed patch and see if it fixes it?