Tom Lane wrote:
BTW, one other stylistic nit: I don't think comments like
/* internal error */
elog(ERROR, "unrecognized OP tg_event: %u", tdata->tg_event);
are really necessary. In the brave new ereport world, any elog(ERROR)
call is an internal error by definitio
Joe Conway <[EMAIL PROTECTED]> writes:
> This patch includes pltcl and plpython, with the mentioned style issue
> fixed. Both PLs pass their scripted tests and my simple statement level
> trigger test.
Applied, thanks.
BTW, one other stylistic nit: I don't think comments like
/
Tom Lane wrote:
Joe Conway <[EMAIL PROTECTED]> writes:
Note that I also changed behavior in that when trigdata->tg_event
doesn't match anything known -- instead of pressing on with a value of
"UNKNOWN" it now throws an "elog(ERROR...". The previous behavior made
no sense to me, but you may not
Joe Conway <[EMAIL PROTECTED]> writes:
> Note that I also changed behavior in that when trigdata->tg_event
> doesn't match anything known -- instead of pressing on with a value of
> "UNKNOWN" it now throws an "elog(ERROR...". The previous behavior made
> no sense to me, but you may not want to c
Joe Conway wrote:
I'll try to submit a patch later tonight or tomorrow morning if no one
beats me to it.
Here's a patch for pltcl. It works for my test case:
CREATE OR REPLACE FUNCTION footrigfunc() RETURNS trigger AS 'return OK'
LANGUAGE pltcl;
CREATE TRIGGER footrig BEFORE INSERT OR UPDATE OR
