Peter Eisentraut schrieb:
Reini Urban wrote:
I think that LDFLAGS overriding is in some situations bad for newer
libtool, as it is used with some postgresql contrib makefiles and
interfaces.
We're not using libtool.
sorry. it conflicts with gnu ld.
LIBS are added to LDFLAGS where they really
Reini Urban [EMAIL PROTECTED] writes:
Peter Eisentraut schrieb:
Please point out where that happens so it can be corrected.
Something like this (against an older cvs snap), but I don't believe
that this is the best way to solve it. It just solved building under cygwin.
Peter asked to know
Reini Urban wrote:
I think that LDFLAGS overriding is in some situations bad for newer
libtool, as it is used with some postgresql contrib makefiles and
interfaces.
We're not using libtool.
LIBS are added to LDFLAGS where they really should be added to
LIBS, not LDFLAGS.
This causes
[ CC'ing Peter since this is usually his area ]
On Wed, 2004-09-29 at 02:10, Bruce Momjian wrote:
I think your 'override' fix is correct. Personally I think override
should be used in most cases in our code because we are usually careful
to add to any flags already supplied by the user.
Ok,
Neil Conway schrieb:
[ CC'ing Peter since this is usually his area ]
On Wed, 2004-09-29 at 02:10, Bruce Momjian wrote:
I think your 'override' fix is correct. Personally I think override
should be used in most cases in our code because we are usually careful
to add to any flags already supplied
On Thu, 2004-09-30 at 17:20, Neil Conway wrote:
Ok, I think 'override' is definitely correct for the instance the patch
fixes, since the build breaks otherwise. Therefore I intend to apply the
patch I posted earlier to HEAD shortly, barring any objections.
Patch applied. I haven't changed the
I think your 'override' fix is correct. Personally I think override
should be used in most cases in our code because we are usually careful
to add to any flags already supplied by the user.
---
Neil Conway wrote:
