Re: [PATCHES] add soundex difference function to contrib/fuzzystrmatch

2005-01-26 Thread Neil Conway
Kris Jurka wrote: I've attached two new patches. One revising my original patch to make the function creations consistent and the other to just fix the problem in the existing code (which should be backported as far as people would like to). Full patch applied to HEAD, fix for STRICT applied to 8.

Re: [PATCHES] add soundex difference function to contrib/fuzzystrmatch

2005-01-25 Thread Kris Jurka
On Tue, 25 Jan 2005, Andrew Dunstan wrote: > ISTM that given how soundex-specific this function is it should have a > less generic name than "difference". > > soundex_difference maybe? > Maybe, but difference is the name used by ms-sql, and it is also has the same meaning in the ODBC/JDBC e

Re: [PATCHES] add soundex difference function to contrib/fuzzystrmatch

2005-01-25 Thread Andrew Dunstan
Kris Jurka wrote: The attached patch implements the soundex difference function which compares two strings' soundex values for similarity. ISTM that given how soundex-specific this function is it should have a less generic name than "difference". soundex_difference maybe? cheers andrew ---

Re: [PATCHES] add soundex difference function to contrib/fuzzystrmatch

2005-01-24 Thread Kris Jurka
On Tue, 25 Jan 2005, Neil Conway wrote: > On Tue, 2005-01-25 at 01:13 -0500, Kris Jurka wrote: > > The attached patch implements the soundex difference function which > > compares two strings' soundex values for similarity. > > *** 19,24 > --- 19,28 > AS 'MODULE_PATHNAME', 'soundex