Re: [PATCHES] set_ps_display during recovery

2007-09-30 Thread Simon Riggs
On Sat, 2007-09-29 at 14:34 -0400, Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: Small patch to set ps display during recovery, so we can see the current WAL file being processed in both crash and archive recovery. Hmm, not right there, because we don't know that the file actually

Re: [PATCHES] set_ps_display during recovery

2007-09-30 Thread Tom Lane
Simon Riggs [EMAIL PROTECTED] writes: On Sat, 2007-09-29 at 14:34 -0400, Tom Lane wrote: Hmm, not right there, because we don't know that the file actually exists yet. Applied with modifications ... Double hmmm, that means when we are waiting for file X in pg_standby the ps display will

Re: [PATCHES] set_ps_display during recovery

2007-09-30 Thread Simon Riggs
On Sun, 2007-09-30 at 10:28 -0400, Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: On Sat, 2007-09-29 at 14:34 -0400, Tom Lane wrote: Hmm, not right there, because we don't know that the file actually exists yet. Applied with modifications ... Double hmmm, that means when we are

Re: [PATCHES] set_ps_display during recovery

2007-09-30 Thread Simon Riggs
On Sun, 2007-09-30 at 10:28 -0400, Tom Lane wrote: Perhaps fetching XXX vs restoring XXX? Not sure if I read you right, so one more time for clarity: IMHO wording should be restoring X before we send to archive to get file (archive only) recovering X once we have the file (archive or not)

Re: [PATCHES] set_ps_display during recovery

2007-09-30 Thread Tom Lane
Simon Riggs [EMAIL PROTECTED] writes: On Sun, 2007-09-30 at 10:28 -0400, Tom Lane wrote: Perhaps fetching XXX vs restoring XXX? Not sure if I read you right, so one more time for clarity: IMHO wording should be restoring X before we send to archive to get file (archive only)

Re: [PATCHES] set_ps_display during recovery

2007-09-30 Thread Simon Riggs
On Sun, 2007-09-30 at 11:16 -0400, Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: On Sun, 2007-09-30 at 10:28 -0400, Tom Lane wrote: Perhaps fetching XXX vs restoring XXX? Not sure if I read you right, so one more time for clarity: IMHO wording should be restoring X before

Re: [PATCHES] set_ps_display during recovery

2007-09-30 Thread Tom Lane
Simon Riggs [EMAIL PROTECTED] writes: On Sun, 2007-09-30 at 11:16 -0400, Tom Lane wrote: I like fetching or retrieving for the activity of getting a WAL segment from an archive, because in cases where the activity takes long enough to be noticeable, it's probably because you are physically

Re: [PATCHES] set_ps_display during recovery

2007-09-29 Thread Tom Lane
Simon Riggs [EMAIL PROTECTED] writes: Small patch to set ps display during recovery, so we can see the current WAL file being processed in both crash and archive recovery. Hmm, not right there, because we don't know that the file actually exists yet. Applied with modifications ...