On Fri, 2007-01-26 at 12:53 +0100, Magnus Hagander wrote:
> Ok, here's an updated patch per this.
Applied -- thanks for the patch.
-Neil
---(end of broadcast)---
TIP 6: explain analyze is your friend
On Thu, Jan 25, 2007 at 08:56:27PM +0100, Magnus Hagander wrote:
> Bruce Momjian wrote:
> > I need an updated version of this to apply. The suggested changes are
> > too extensive.
>
>
> I'll try to do this tomorrow. If I get it right, the changes needed are:
> NULL instead of cast of function p
Tom Lane wrote:
> Magnus Hagander <[EMAIL PROTECTED]> writes:
>> Not sure I understand.
>> The header had:
>> isort(int4 *a, const int len)
>> and the code had
>> isort(int4 *a, int len)
>
> Oh, I see. Yeah, that's inconsistent, though my thought would be to
> remove the (rather useless) const de
Bruce Momjian wrote:
> I need an updated version of this to apply. The suggested changes are
> too extensive.
I'll try to do this tomorrow. If I get it right, the changes needed are:
NULL instead of cast of function ptr, per Peter.
Do the const-change in the other direction in contrib/intarray.
I need an updated version of this to apply. The suggested changes are
too extensive.
---
Magnus Hagander wrote:
> Attached patch gets rid of most of the remaining warnings on a VC++
> build. Summary is:
> * A bunch of place
Magnus Hagander <[EMAIL PROTECTED]> writes:
> Not sure I understand.
> The header had:
> isort(int4 *a, const int len)
> and the code had
> isort(int4 *a, int len)
Oh, I see. Yeah, that's inconsistent, though my thought would be to
remove the (rather useless) const decoration in the header. I be
On Thu, 2007-01-25 at 17:11 +0100, Magnus Hagander wrote:
> The header had:
> isort(int4 *a, const int len)
> and the code had
> isort(int4 *a, int len)
ISTM that the "const" keyword to an "int" function argument is
pointless, so the right fix is to remove the "const" from the
declaration in the h
On Thu, Jan 25, 2007 at 10:57:29AM -0500, Tom Lane wrote:
> Magnus Hagander <[EMAIL PROTECTED]> writes:
> > bool
> > ! isort(int4 *a, int len)
> > {
> > bool
> > ! isort(int4 *a, const int len)
> > {
>
> If VC thinks that that is required to fix a warning, it's too broken to live.
> AFAICS
Magnus Hagander <[EMAIL PROTECTED]> writes:
> bool
> ! isort(int4 *a, int len)
> {
> bool
> ! isort(int4 *a, const int len)
> {
If VC thinks that that is required to fix a warning, it's too broken to live.
AFAICS what you've got there is a compiler that is being pedantically
strict about l
On Thu, Jan 25, 2007 at 03:29:50PM +0100, Peter Eisentraut wrote:
> Magnus Hagander wrote:
> > * NULL function pointer in SSL call cast to the correct pointer type
>
> Why not write NULL?
>
> In the alternative, declare the variable to have the right type to begin
> with.
I went down the path o
Magnus Hagander wrote:
> * NULL function pointer in SSL call cast to the correct pointer type
Why not write NULL?
In the alternative, declare the variable to have the right type to begin
with.
--
Peter Eisentraut
http://developer.postgresql.org/~petere/
---(end of broa
11 matches
Mail list logo
