Re: [Pharo-dev] Komitter SubscriptOutOfBounds: 1

2016-05-30 Thread stepharo

Hi hernan


do you have a reproducible scenario because I cannot reproduce it?

The problem we got before was that Komitter was publishing the previous 
version :(


Stef

Le 30/5/16 à 00:13, Hernán Morales Durand a écrit :
In Pharo 5.0 #50759 on Windows, whenever I try to commit any change 
through Versionner, an exception SubscriptOutOfBounds raise and then 
the package modification mark is lost.


Is this bug reported?
Screenshot attached.

Hernán






Re: [Pharo-dev] Komitter SubscriptOutOfBounds: 1

2016-05-29 Thread Cyril Ferlicot D.
Le 30/05/2016 00:13, Hernán Morales Durand a écrit :
> In Pharo 5.0 #50759 on Windows, whenever I try to commit any change
> through Versionner, an exception SubscriptOutOfBounds raise and then the
> package modification mark is lost.
> 
> Is this bug reported?
> Screenshot attached.
> 
> Hernán
> 

Hi,

I tried and before I could commit I got a MNU receiver of
#selectMorphList is nil.

I got it in Windows 7 in Pharo6.0 Latest update: #60042 when I
unselected a change.

http://puu.sh/p9C9b/3e8fe7787c.png

-- 
Cyril Ferlicot

http://www.synectique.eu

165 Avenue Bretagne
Lille 59000 France



signature.asc
Description: OpenPGP digital signature


[Pharo-dev] Komitter SubscriptOutOfBounds: 1

2016-05-29 Thread Hernán Morales Durand
In Pharo 5.0 #50759 on Windows, whenever I try to commit any change through
Versionner, an exception SubscriptOutOfBounds raise and then the package
modification mark is lost.

Is this bug reported?
Screenshot attached.

Hernán


Re: [Pharo-dev] Komitter in 30852?

2014-08-08 Thread Sean P. DeNigris
I think the issue got closed by mistake. I reopened, looks ready to integrate

https://pharo.fogbugz.com/default.asp?13680



-
Cheers,
Sean
--
View this message in context: 
http://forum.world.st/Komitter-in-30852-tp4769794p4772557.html
Sent from the Pharo Smalltalk Developers mailing list archive at Nabble.com.



[Pharo-dev] Komitter in 30852?

2014-07-24 Thread Stephan Eggermont
Anyone tried Komitter recently in Pharo 3? I get about 4 to 6 debugger windows 
per change.
Don't try on an image with lots of open changes...

Stephan





Re: [Pharo-dev] Komitter in 30852?

2014-07-24 Thread Marcus Denker

On 24 Jul 2014, at 11:43, Stephan Eggermont step...@stack.nl wrote:

 Anyone tried Komitter recently in Pharo 3? I get about 4 to 6 debugger 
 windows per change.
 Don't try on an image with lots of open changes…
 
https://pharo.fogbugz.com/f/cases/13539/receiver-of-NodeModel-is-Nil

There is even a fix, but it needs to be reviewed and back ported.





Re: [Pharo-dev] Komitter in 30852?

2014-07-24 Thread Thierry Goubier
Stephan,

can you describe how you get it? I immediately had errors on 4.0 when
writing this fix (
https://pharo.fogbugz.com/f/cases/13539/receiver-of-NodeModel-is-Nil), but
it wasn't reproduced on 3.0.

Thierry


2014-07-24 11:43 GMT+02:00 Stephan Eggermont step...@stack.nl:

 Anyone tried Komitter recently in Pharo 3? I get about 4 to 6 debugger
 windows per change.
 Don't try on an image with lots of open changes...

 Stephan






Re: [Pharo-dev] Komitter in 30852?

2014-07-24 Thread Stephan Eggermont
Marcus wrote
https://pharo.fogbugz.com/f/cases/13539/receiver-of-NodeModel-is-Nil

There is even a fix, but it needs to be reviewed and back ported. 

Thanks, I somehow missed that. I was a bit annoyed that I had just
yesterday answered a question about closing lots of inspectors
and then ran into the situation myself...

Thierry wrote:
can you describe how you get it? I immediately had errors on 4.0 
when writing this fix 
(https://pharo.fogbugz.com/f/cases/13539/receiver-of-NodeModel-is-Nil), but it 
wasn't reproduced on 3.0.

Open a fresh 30852 with 355 (Mac Mavericks 10.9.4).
Open a Nautilus browser, create class Bla in category Bla.
Open Komitter, 6 MNUs
Close MNUs and Komitter
add a class Blah in category Bla
Open Komitter, 10 MNUs

I tried it originally on an image that took over a minute to produce the MNUs...

Stephan


Re: [Pharo-dev] Komitter in 30852?

2014-07-24 Thread Thierry Goubier
2014-07-24 12:19 GMT+02:00 Stephan Eggermont step...@stack.nl:

 Open a fresh 30852 with 355 (Mac Mavericks 10.9.4).
 Open a Nautilus browser, create class Bla in category Bla.
 Open Komitter, 6 MNUs
 Close MNUs and Komitter
 add a class Blah in category Bla
 Open Komitter, 10 MNUs

 I tried it originally on an image that took over a minute to produce the
 MNUs...

 Stephan


Can you try with slice 13680 loaded? I backported the fix.

Do I need to unsubscribe an object listening to MorphDeleted or not?

Thierry


Re: [Pharo-dev] Komitter in 30852?

2014-07-24 Thread Stephan Eggermont
Works for me. Thank you Thierry!

Stephan



[Pharo-dev] Komitter does not display correctly

2014-03-14 Thread Serge Stinckwich
In the last version of Pharo, Komitter does not work correctly.
Modifications done under packages are not displayed.

Apparently the problem appears at #30789:
https://github.com/pharo-project/pharo-core/commit/802360955460a9a8d9284c8727e2ac3f88d2bc01

I guess something related to this spec fix:
https://pharo.fogbugz.com/f/cases/13040

Regards,
-- 
Serge Stinckwich
UCBN  UMI UMMISCO 209 (IRD/UPMC)
Every DSL ends up being Smalltalk
http://www.doesnotunderstand.org/



Re: [Pharo-dev] Komitter does not display correctly

2014-03-14 Thread Benjamin
Reported here: https://pharo.fogbugz.com/default.asp?13077
Fix on its way :)

Ben

On 14 Mar 2014, at 11:53, Serge Stinckwich serge.stinckw...@gmail.com wrote:

 In the last version of Pharo, Komitter does not work correctly.
 Modifications done under packages are not displayed.
 
 Apparently the problem appears at #30789:
 https://github.com/pharo-project/pharo-core/commit/802360955460a9a8d9284c8727e2ac3f88d2bc01
 
 I guess something related to this spec fix:
 https://pharo.fogbugz.com/f/cases/13040
 
 Regards,
 -- 
 Serge Stinckwich
 UCBN  UMI UMMISCO 209 (IRD/UPMC)
 Every DSL ends up being Smalltalk
 http://www.doesnotunderstand.org/
 



Re: [Pharo-dev] Komitter does not display correctly

2014-03-14 Thread Benjamin
Fixed

Ben

On 14 Mar 2014, at 11:53, Serge Stinckwich serge.stinckw...@gmail.com wrote:

 In the last version of Pharo, Komitter does not work correctly.
 Modifications done under packages are not displayed.
 
 Apparently the problem appears at #30789:
 https://github.com/pharo-project/pharo-core/commit/802360955460a9a8d9284c8727e2ac3f88d2bc01
 
 I guess something related to this spec fix:
 https://pharo.fogbugz.com/f/cases/13040
 
 Regards,
 -- 
 Serge Stinckwich
 UCBN  UMI UMMISCO 209 (IRD/UPMC)
 Every DSL ends up being Smalltalk
 http://www.doesnotunderstand.org/
 



Re: [Pharo-dev] Komitter does not display correctly

2014-03-14 Thread Serge Stinckwich
Fast ;-)

On Fri, Mar 14, 2014 at 12:18 PM, Benjamin
benjamin.vanryseghem.ph...@gmail.com wrote:
 Fixed

 Ben

 On 14 Mar 2014, at 11:53, Serge Stinckwich serge.stinckw...@gmail.com
 wrote:

 In the last version of Pharo, Komitter does not work correctly.
 Modifications done under packages are not displayed.

 Apparently the problem appears at #30789:
 https://github.com/pharo-project/pharo-core/commit/802360955460a9a8d9284c8727e2ac3f88d2bc01

 I guess something related to this spec fix:
 https://pharo.fogbugz.com/f/cases/13040

 Regards,
 --
 Serge Stinckwich
 UCBN  UMI UMMISCO 209 (IRD/UPMC)
 Every DSL ends up being Smalltalk
 http://www.doesnotunderstand.org/





-- 
Serge Stinckwich
UCBN  UMI UMMISCO 209 (IRD/UPMC)
Every DSL ends up being Smalltalk
http://www.doesnotunderstand.org/



[Pharo-dev] Komitter

2013-12-04 Thread Yuriy Tymchuk
Hi guys,

I’m very impressed with the new Komitter tool that I’ve found in Pharo today. 
It’s a really important tool that we really need. It’s amazing that you can at 
last see what is changed and pick what you want to commit. Also the startup 
gear animation is cool. Only one question: should I complain about getting 
MCKomitSubmitter(Object)doesNotUnderstand: #repository” when trying to 
commit, or it’s work in progress and everything is changing each day?

Also why can’t I access anything else when Komitter window is open?

Uko


Re: [Pharo-dev] Komitter

2013-12-04 Thread Pavel Krivanek
Hi,

I think that you need firstly to open Monticello and add your user name and
password to the Pharo Inbox repository settings.

-- Pavel


2013/12/4 Yuriy Tymchuk yuriy.tymc...@me.com

 Hi guys,

 I’m very impressed with the new Komitter tool that I’ve found in Pharo
 today. It’s a really important tool that we really need. It’s amazing that
 you can at last see what is changed and pick what you want to commit. Also
 the startup gear animation is cool. Only one question: should I complain
 about getting MCKomitSubmitter(Object)doesNotUnderstand: #repository”
 when trying to commit, or it’s work in progress and everything is changing
 each day?

 Also why can’t I access anything else when Komitter window is open?

 Uko



Re: [Pharo-dev] Komitter

2013-12-04 Thread Roberto Minelli
I am actually using it since 2 days. Cool work!

Cheers,
R

On Dec 4, 2013, at 2:42 PM, Benjamin benjamin.vanryseghem.ph...@gmail.com 
wrote:

 I did not annonce it yet since some features are missing, and few bugs needs 
 to be fixed (actually the slice are waiting to be integrated :P)
 the repository problem is an issue with the credentials.
 The slice is in the issue tracker. If you want to not bump this, set your 
 credentials from MC browser once and for all :P
 
 The window is modal since otherwise, it needs to be kept in sync with the 
 system, which is a pain.
 We already discuss the fact it’s modal, so maybe it will disappear soon since 
 we are still not strongly convinced in one way or the other :P
 
 Ben
 
 On 04 Dec 2013, at 14:35, Yuriy Tymchuk yuriy.tymc...@me.com wrote:
 
 Hi guys,
 
 I’m very impressed with the new Komitter tool that I’ve found in Pharo 
 today. It’s a really important tool that we really need. It’s amazing that 
 you can at last see what is changed and pick what you want to commit. Also 
 the startup gear animation is cool. Only one question: should I complain 
 about getting MCKomitSubmitter(Object)doesNotUnderstand: #repository” 
 when trying to commit, or it’s work in progress and everything is changing 
 each day?
 
 Also why can’t I access anything else when Komitter window is open?
 
 Uko
 




Re: [Pharo-dev] Komitter

2013-12-04 Thread Yuriy Tymchuk

On 04 Dec 2013, at 14:42, Benjamin benjamin.vanryseghem.ph...@gmail.com wrote:

 I did not annonce it yet since some features are missing, and few bugs needs 
 to be fixed (actually the slice are waiting to be integrated :P)
 the repository problem is an issue with the credentials.
 The slice is in the issue tracker. If you want to not bump this, set your 
 credentials from MC browser once and for all :P
 
 The window is modal since otherwise, it needs to be kept in sync with the 
 system, which is a pain.

Yes, true. You can just add refresh button. E.i. for me it’s easier to press 
button rather then closing and opening window.

Uko

 We already discuss the fact it’s modal, so maybe it will disappear soon since 
 we are still not strongly convinced in one way or the other :P
 
 Ben
 
 On 04 Dec 2013, at 14:35, Yuriy Tymchuk yuriy.tymc...@me.com wrote:
 
 Hi guys,
 
 I’m very impressed with the new Komitter tool that I’ve found in Pharo 
 today. It’s a really important tool that we really need. It’s amazing that 
 you can at last see what is changed and pick what you want to commit. Also 
 the startup gear animation is cool. Only one question: should I complain 
 about getting MCKomitSubmitter(Object)doesNotUnderstand: #repository” 
 when trying to commit, or it’s work in progress and everything is changing 
 each day?
 
 Also why can’t I access anything else when Komitter window is open?
 
 Uko
 



Re: [Pharo-dev] Komitter

2013-12-04 Thread Benjamin
I will give a try later today :P

Ben

On 04 Dec 2013, at 14:47, Yuriy Tymchuk yuriy.tymc...@me.com wrote:

 
 On 04 Dec 2013, at 14:42, Benjamin benjamin.vanryseghem.ph...@gmail.com 
 wrote:
 
 I did not annonce it yet since some features are missing, and few bugs needs 
 to be fixed (actually the slice are waiting to be integrated :P)
 the repository problem is an issue with the credentials.
 The slice is in the issue tracker. If you want to not bump this, set your 
 credentials from MC browser once and for all :P
 
 The window is modal since otherwise, it needs to be kept in sync with the 
 system, which is a pain.
 
 Yes, true. You can just add refresh button. E.i. for me it’s easier to press 
 button rather then closing and opening window.
 
 Uko
 
 We already discuss the fact it’s modal, so maybe it will disappear soon 
 since we are still not strongly convinced in one way or the other :P
 
 Ben
 
 On 04 Dec 2013, at 14:35, Yuriy Tymchuk yuriy.tymc...@me.com wrote:
 
 Hi guys,
 
 I’m very impressed with the new Komitter tool that I’ve found in Pharo 
 today. It’s a really important tool that we really need. It’s amazing that 
 you can at last see what is changed and pick what you want to commit. Also 
 the startup gear animation is cool. Only one question: should I complain 
 about getting MCKomitSubmitter(Object)doesNotUnderstand: #repository” 
 when trying to commit, or it’s work in progress and everything is changing 
 each day?
 
 Also why can’t I access anything else when Komitter window is open?
 
 Uko
 
 



Re: [Pharo-dev] Komitter

2013-12-04 Thread Yuriy Tymchuk
Thanks once more for your effort. This is a really important tool for me.

Uko

On 04 Dec 2013, at 14:52, Benjamin benjamin.vanryseghem.ph...@gmail.com wrote:

 I will give a try later today :P
 
 Ben
 
 On 04 Dec 2013, at 14:47, Yuriy Tymchuk yuriy.tymc...@me.com wrote:
 
 
 On 04 Dec 2013, at 14:42, Benjamin benjamin.vanryseghem.ph...@gmail.com 
 wrote:
 
 I did not annonce it yet since some features are missing, and few bugs 
 needs to be fixed (actually the slice are waiting to be integrated :P)
 the repository problem is an issue with the credentials.
 The slice is in the issue tracker. If you want to not bump this, set your 
 credentials from MC browser once and for all :P
 
 The window is modal since otherwise, it needs to be kept in sync with the 
 system, which is a pain.
 
 Yes, true. You can just add refresh button. E.i. for me it’s easier to press 
 button rather then closing and opening window.
 
 Uko
 
 We already discuss the fact it’s modal, so maybe it will disappear soon 
 since we are still not strongly convinced in one way or the other :P
 
 Ben
 
 On 04 Dec 2013, at 14:35, Yuriy Tymchuk yuriy.tymc...@me.com wrote:
 
 Hi guys,
 
 I’m very impressed with the new Komitter tool that I’ve found in Pharo 
 today. It’s a really important tool that we really need. It’s amazing that 
 you can at last see what is changed and pick what you want to commit. Also 
 the startup gear animation is cool. Only one question: should I complain 
 about getting MCKomitSubmitter(Object)doesNotUnderstand: #repository” 
 when trying to commit, or it’s work in progress and everything is changing 
 each day?
 
 Also why can’t I access anything else when Komitter window is open?
 
 Uko
 
 
 



Re: [Pharo-dev] Komitter

2013-12-04 Thread Esteban Lorenzano
On Wed, Dec 4, 2013 at 2:47 PM, Yuriy Tymchuk yuriy.tymc...@me.com wrote:


 On 04 Dec 2013, at 14:42, Benjamin benjamin.vanryseghem.ph...@gmail.com
 wrote:

 I did not annonce it yet since some features are missing, and few bugs
 needs to be fixed (actually the slice are waiting to be integrated :P)
 the repository problem is an issue with the credentials.
 The slice is in the issue tracker. If you want to not bump this, set your
 credentials from MC browser once and for all :P

 The window is modal since otherwise, it needs to be kept in sync with the
 system, which is a pain.


 Yes, true. You can just add refresh button. E.i. for me it’s easier to
 press button rather then closing and opening window.


I was thinking on that too, yep :)



 Uko

 We already discuss the fact it’s modal, so maybe it will disappear soon
 since we are still not strongly convinced in one way or the other :P

 Ben

 On 04 Dec 2013, at 14:35, Yuriy Tymchuk yuriy.tymc...@me.com wrote:

 Hi guys,

 I’m very impressed with the new Komitter tool that I’ve found in Pharo
 today. It’s a really important tool that we really need. It’s amazing that
 you can at last see what is changed and pick what you want to commit. Also
 the startup gear animation is cool. Only one question: should I complain
 about getting MCKomitSubmitter(Object)doesNotUnderstand: #repository”
 when trying to commit, or it’s work in progress and everything is changing
 each day?

 Also why can’t I access anything else when Komitter window is open?

 Uko






Re: [Pharo-dev] Komitter

2013-12-04 Thread Yuriy Tymchuk

On 04 Dec 2013, at 14:56, Esteban Lorenzano esteba...@gmail.com wrote:

 
 
 
 On Wed, Dec 4, 2013 at 2:47 PM, Yuriy Tymchuk yuriy.tymc...@me.com wrote:
 
 On 04 Dec 2013, at 14:42, Benjamin benjamin.vanryseghem.ph...@gmail.com 
 wrote:
 
 I did not annonce it yet since some features are missing, and few bugs needs 
 to be fixed (actually the slice are waiting to be integrated :P)
 the repository problem is an issue with the credentials.
 The slice is in the issue tracker. If you want to not bump this, set your 
 credentials from MC browser once and for all :P
 
 The window is modal since otherwise, it needs to be kept in sync with the 
 system, which is a pain.
 
 Yes, true. You can just add refresh button. E.i. for me it’s easier to press 
 button rather then closing and opening window.
 
 I was thinking on that too, yep :)

SourceTree works like that and none complains. Of course it has some 
auto-refresh, but we can survive without that.

Uko

  
 
 Uko
 
 We already discuss the fact it’s modal, so maybe it will disappear soon 
 since we are still not strongly convinced in one way or the other :P
 
 Ben
 
 On 04 Dec 2013, at 14:35, Yuriy Tymchuk yuriy.tymc...@me.com wrote:
 
 Hi guys,
 
 I’m very impressed with the new Komitter tool that I’ve found in Pharo 
 today. It’s a really important tool that we really need. It’s amazing that 
 you can at last see what is changed and pick what you want to commit. Also 
 the startup gear animation is cool. Only one question: should I complain 
 about getting MCKomitSubmitter(Object)doesNotUnderstand: #repository” 
 when trying to commit, or it’s work in progress and everything is changing 
 each day?
 
 Also why can’t I access anything else when Komitter window is open?
 
 Uko
 
 
 



Re: [Pharo-dev] Komitter

2013-12-04 Thread Stéphane Ducasse
+1

 Thanks once more for your effort. This is a really important tool for me.
 
 Uko
 




Re: [Pharo-dev] Komitter

2013-12-04 Thread Nicolas Cellier
Does Kommitter enables partial commits (cherry picking) for a package?
If so, my question is how does it deal with MC ancestry?

Imagine I have a package- A.247 from my-trunk.
I merge some A.312 from my-work repository with work in progress.
Now I want to cherry pick the changes which are OK, and publish only those
to my-trunk.
I do so in my-trunk/A.313.
Will A.312 be in the ancestry of A.313?
Logically as MC is working, yes, because it is in the ancestry of in-image
working copy.

What if I later download A.313 from my-trunk in a fresh image and try to
merge A.312 to finish the work in progress?
IMO, this is not possible, A312 being an ancestor, no change will happen.

So, it sounds like when I committed my-trunk/A.313 with partial changes, I
should have commited my-work/A.314 immediately after with the rest of
pending changes...
If I forgot to do so and threw my image away, from a fresh image, it is
still possible to load A.312, merge A.313, and publish A.314 in my-work
repo.

But then it rather complicates the flow... If we commit/merge carelessly,
we might throw away some valuable work in progress.
The fear of such scenario prevented us to integrate a change from Bert in
Squeak/trunk enabling such partial commits (directly from MC UI in Squeak
case).


2013/12/4 Stéphane Ducasse stephane.duca...@inria.fr

 +1

  Thanks once more for your effort. This is a really important tool for me.
 
  Uko
 





Re: [Pharo-dev] Komitter

2013-12-04 Thread Stéphane Ducasse
Nicolas

From what I understand Kommitter just filters the entities that will be passed 
as modified and as such does not change the 
ancestry of a package. 

Stef


On Dec 4, 2013, at 8:12 PM, Nicolas Cellier 
nicolas.cellier.aka.n...@gmail.com wrote:

 Does Kommitter enables partial commits (cherry picking) for a package?
 If so, my question is how does it deal with MC ancestry?
 
 Imagine I have a package- A.247 from my-trunk.
 I merge some A.312 from my-work repository with work in progress.
 Now I want to cherry pick the changes which are OK, and publish only those to 
 my-trunk.
 I do so in my-trunk/A.313.
 Will A.312 be in the ancestry of A.313?
 Logically as MC is working, yes, because it is in the ancestry of in-image 
 working copy.
 
 What if I later download A.313 from my-trunk in a fresh image and try to 
 merge A.312 to finish the work in progress?
 IMO, this is not possible, A312 being an ancestor, no change will happen.
 
 So, it sounds like when I committed my-trunk/A.313 with partial changes, I 
 should have commited my-work/A.314 immediately after with the rest of pending 
 changes...
 If I forgot to do so and threw my image away, from a fresh image, it is still 
 possible to load A.312, merge A.313, and publish A.314 in my-work repo.
 
 But then it rather complicates the flow... If we commit/merge carelessly, we 
 might throw away some valuable work in progress.
 The fear of such scenario prevented us to integrate a change from Bert in 
 Squeak/trunk enabling such partial commits (directly from MC UI in Squeak 
 case).
 
 
 2013/12/4 Stéphane Ducasse stephane.duca...@inria.fr
 +1
 
  Thanks once more for your effort. This is a really important tool for me.
 
  Uko
 
 
 
 



Re: [Pharo-dev] Komitter

2013-12-04 Thread Nicolas Cellier
Err, from a fresh image, we should not merge A.313 but adopt it in our
ancestry, else merging will remove all the pending changes...


2013/12/4 Nicolas Cellier nicolas.cellier.aka.n...@gmail.com

 Does Kommitter enables partial commits (cherry picking) for a package?
 If so, my question is how does it deal with MC ancestry?

 Imagine I have a package- A.247 from my-trunk.
 I merge some A.312 from my-work repository with work in progress.
 Now I want to cherry pick the changes which are OK, and publish only those
 to my-trunk.
 I do so in my-trunk/A.313.
 Will A.312 be in the ancestry of A.313?
 Logically as MC is working, yes, because it is in the ancestry of in-image
 working copy.

 What if I later download A.313 from my-trunk in a fresh image and try to
 merge A.312 to finish the work in progress?
 IMO, this is not possible, A312 being an ancestor, no change will happen.

 So, it sounds like when I committed my-trunk/A.313 with partial changes, I
 should have commited my-work/A.314 immediately after with the rest of
 pending changes...
 If I forgot to do so and threw my image away, from a fresh image, it is
 still possible to load A.312, merge A.313, and publish A.314 in my-work
 repo.

 But then it rather complicates the flow... If we commit/merge carelessly,
 we might throw away some valuable work in progress.
 The fear of such scenario prevented us to integrate a change from Bert in
 Squeak/trunk enabling such partial commits (directly from MC UI in Squeak
 case).


 2013/12/4 Stéphane Ducasse stephane.duca...@inria.fr

 +1

  Thanks once more for your effort. This is a really important tool for
 me.
 
  Uko
 






Re: [Pharo-dev] Komitter

2013-12-04 Thread Benjamin
On 04 Dec 2013, at 20:12, Nicolas Cellier nicolas.cellier.aka.n...@gmail.com 
wrote:

 Does Kommitter enables partial commits (cherry picking) for a package?
 If so, my question is how does it deal with MC ancestry?
 
 Imagine I have a package- A.247 from my-trunk.
 I merge some A.312 from my-work repository with work in progress.
 Now I want to cherry pick the changes which are OK, and publish only those to 
 my-trunk.
 I do so in my-trunk/A.313.
 Will A.312 be in the ancestry of A.313?
 Logically as MC is working, yes, because it is in the ancestry of in-image 
 working copy.
 
 What if I later download A.313 from my-trunk in a fresh image and try to 
 merge A.312 to finish the work in progress?
 IMO, this is not possible, A312 being an ancestor, no change will happen.

This is indeed what is happening.

A solution would be to allow to merge with an ancestor.
After some investigation, it’s doable.

The “problem” is I do not know how to detect that a version has been 
“fully-merged already or not.
But with the patch is juste made, you can merge with your ancestors.

Another approach would be the git one. When you merge, you commit automatically 
the merge.

Ben


 
 So, it sounds like when I committed my-trunk/A.313 with partial changes, I 
 should have commited my-work/A.314 immediately after with the rest of pending 
 changes...
 If I forgot to do so and threw my image away, from a fresh image, it is still 
 possible to load A.312, merge A.313, and publish A.314 in my-work repo.
 
 But then it rather complicates the flow... If we commit/merge carelessly, we 
 might throw away some valuable work in progress.
 The fear of such scenario prevented us to integrate a change from Bert in 
 Squeak/trunk enabling such partial commits (directly from MC UI in Squeak 
 case).
 
 
 2013/12/4 Stéphane Ducasse stephane.duca...@inria.fr
 +1
 
  Thanks once more for your effort. This is a really important tool for me.
 
  Uko