Re: [Pharo-dev] Performances of source code search on latest Pharo

2018-03-18 Thread Cyril Ferlicot
On dim. 18 mars 2018 at 11:18, Sven Van Caekenberghe wrote: > > > > On 18 Mar 2018, at 11:16, Guillermo Polito > wrote: > > > > Yes, looking at the stack in the profiler, there is a buffered stream > missing in there. The thing is that source/changes

Re: [Pharo-dev] Performances of source code search on latest Pharo

2018-03-18 Thread Sven Van Caekenberghe
> On 18 Mar 2018, at 11:16, Guillermo Polito wrote: > > Yes, looking at the stack in the profiler, there is a buffered stream missing > in there. The thing is that source/changes file reading/writing required > special attention in the migration (or the image

Re: [Pharo-dev] Performances of source code search on latest Pharo

2018-03-18 Thread Guillermo Polito
Yes, looking at the stack in the profiler, there is a buffered stream missing in there. The thing is that source/changes file reading/writing required special attention in the migration (or the image became unusable :)). I'll fix it tomorrow first thing in the morning, if you can wait a couple of

Re: [Pharo-dev] Performances of source code search on latest Pharo

2018-03-18 Thread Sven Van Caekenberghe
> On 18 Mar 2018, at 00:03, Cyril Ferlicot wrote: > > Time to execute: SystemNavigation new browseMethodsWithSourceString: > 'Method source with it' matchCase: false > > Pharo 6.1: 2480ms > > Pharo 7: 132041ms You didn't type a digit too much, did you ? That is 2

Re: [Pharo-dev] Performances of source code search on latest Pharo

2018-03-17 Thread Cyril Ferlicot
On Sun, Mar 18, 2018 at 12:56 AM, Eliot Miranda wrote: > Hi Cyril, > Hi Eliot, > > can you use the profiler (either MessageTally, or better still, > AndreasSystemProfiler) to get a better understanding? > > e.g. > > AndreasSystemProfiler spyOn: >

Re: [Pharo-dev] Performances of source code search on latest Pharo

2018-03-17 Thread Eliot Miranda
Hi Cyril, can you use the profiler (either MessageTally, or better still, AndreasSystemProfiler) to get a better understanding? e.g. AndreasSystemProfiler spyOn: [SystemNavigation new browseMethodsWithSourceString: 'Method source with it' matchCase: false] On Sat, Mar 17, 2018 at

Re: [Pharo-dev] Performances of source code search on latest Pharo

2018-03-17 Thread Cyril Ferlicot
Here some new precisions: Time to execute: SystemNavigation new browseMethodsWithSourceString: 'Method source with it' matchCase: false Pharo 6.1: 2480ms Pharo 7: 132041ms The difference seems to come from SourceFileArray>>sourceCodeAt: Pharo 6.1: sourceCodeAt: sourcePointer "Retrieves the

[Pharo-dev] Performances of source code search on latest Pharo

2018-03-17 Thread Cyril Ferlicot
HI, We have a regression on source code search performances in latest Pharo. I am on Windows 10. With Pharo 6.1 it takes a few seconds to look for a string in all the image source code. With the latest Pharo 7 it takes minutes. To reproduce: - Open a playground - Type something - Select the