Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/openssl/openssl.c branches/PHP_5_4/NEWS branches/PHP_5_4/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2012-02-23 Thread Pierre Joye
hi! Thanks for applying the patch! Please add the test case as well. Btw, did you check with Stas and David about 5.4? Not sure if it is OK at this stage, but we may need another RC already anyway (commits done since last RC). On Thu, Feb 23, 2012 at 2:26 AM, Scott MacVicar scott...@php.net

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/openssl/openssl.c branches/PHP_5_4/NEWS branches/PHP_5_4/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2012-02-22 Thread Scott MacVicar
scottmac Thu, 23 Feb 2012 01:26:46 + Revision: http://svn.php.net/viewvc?view=revisionrevision=323440 Log: Fixed bug #61124 (Crash when decoding an invalid base64 encoded string). Bug: https://bugs.php.net/61124 (Assigned) Segmentation fault Changed

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/openssl/openssl.c branches/PHP_5_4/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2011-06-16 Thread Pierre Joye
pajoye Thu, 16 Jun 2011 13:06:41 + Revision: http://svn.php.net/viewvc?view=revisionrevision=312209 Log: - did I not kill that already? (do not use rand_screen, pointless on server and not TS) Changed paths: U

[PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/openssl/ openssl.c xp_ssl.c

2011-04-25 Thread Martin Jansen
mj Mon, 25 Apr 2011 16:51:12 + Revision: http://svn.php.net/viewvc?view=revisionrevision=310477 Log: MFH: The project calls itself OpenSSL and not openSSL, so let's keep it that way in our code as well. Changed paths: U

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/openssl/openssl.c branches/PHP_5_3/ext/openssl/xp_ssl.c trunk/ext/openssl/openssl.c trunk/ext/openssl/xp_ssl.c

2011-04-24 Thread Rasmus Lerdorf
rasmus Sun, 24 Apr 2011 23:27:48 + Revision: http://svn.php.net/viewvc?view=revisionrevision=310458 Log: SSLV2 patch cleanup Changed paths: U php/php-src/branches/PHP_5_3/ext/openssl/openssl.c U php/php-src/branches/PHP_5_3/ext/openssl/xp_ssl.c

[PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/openssl/ openssl.c

2011-02-21 Thread Pierre Joye
pajoye Mon, 21 Feb 2011 10:09:50 + Revision: http://svn.php.net/viewvc?view=revisionrevision=308532 Log: - fix test 025 Changed paths: U php/php-src/branches/PHP_5_3/ext/openssl/openssl.c Modified: php/php-src/branches/PHP_5_3/ext/openssl/openssl.c

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2010-12-02 Thread Pierre Joye
pajoye Thu, 02 Dec 2010 11:37:43 + Revision: http://svn.php.net/viewvc?view=revisionrevision=305902 Log: - not TS and useless on server, also not required anymore with the supported windows versions Changed paths: U

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2010-10-13 Thread Adam Harvey
aharvey Wed, 13 Oct 2010 09:23:39 + Revision: http://svn.php.net/viewvc?view=revisionrevision=304368 Log: Fix vim marker folds. Changed paths: U php/php-src/branches/PHP_5_3/ext/openssl/openssl.c U php/php-src/trunk/ext/openssl/openssl.c

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2010-10-07 Thread Ilia Alshanetsky
iliaaThu, 07 Oct 2010 12:32:00 + Revision: http://svn.php.net/viewvc?view=revisionrevision=304179 Log: Fixed extrenous warning inside openssl_encrypt() for cases where iv not provided, but algo does not require an iv Changed paths: U

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2010-05-20 Thread Antony Dovgal
tony2001 Thu, 20 May 2010 11:20:44 + Revision: http://svn.php.net/viewvc?view=revisionrevision=299520 Log: fix ZTS build Changed paths: U php/php-src/branches/PHP_5_3/ext/openssl/openssl.c U php/php-src/trunk/ext/openssl/openssl.c Modified:

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2010-05-11 Thread Ilia Alshanetsky
iliaaTue, 11 May 2010 14:31:00 + Revision: http://svn.php.net/viewvc?view=revisionrevision=299244 Log: Removed double allocation of buffer inside openssl_random_pseudo_bytes() and cleanup code Changed paths: U

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2010-04-23 Thread Andrey Hristov
More info about the segfaults? Tests that show the segfaults and thus keep us from regressions? Andrey Antony Dovgal wrote: tony2001 Thu, 22 Apr 2010 15:59:44 + Revision: http://svn.php.net/viewvc?view=revisionrevision=298331 Log: revert most of the

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2010-04-23 Thread Pierre Joye
hi, On Fri, Apr 23, 2010 at 12:14 PM, Andrey Hristov p...@hristov.com wrote:  More info about the segfaults? Tests that show the segfaults and thus keep us from regressions? The tests we have in ext/openssl/tests crash. However we were wondering why you did these changes and I did not see any

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2010-04-23 Thread Andrey Hristov
Pierre, Pierre, + if (SSL_CTX_use_PrivateKey_file(ctx, resolved_path_buff, SSL_FILETYPE_PEM) != 1) { this is what the revert gives back, if you go and check what this function does: The SSL_CTX_use_PrivateKey_file function loads the private key for use with Secure Sockets Layer (SSL)

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2010-04-23 Thread Pierre Joye
On Fri, Apr 23, 2010 at 1:05 PM, Andrey Hristov p...@hristov.com wrote: So, I am going to revert the revert and reintroduce the code that fixes a bug. No. Don't do that. If you have found a bug in SSL please report a bug with a SSL specific test case and a patch if you have one. Thanks, --

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2010-04-23 Thread Johannes Schlüter
On Fri, 2010-04-23 at 13:05 +0200, Andrey Hristov wrote: Pierre, Pierre, + if (SSL_CTX_use_PrivateKey_file(ctx, resolved_path_buff, SSL_FILETYPE_PEM) != 1) { this is what the revert gives back, if you go and check what this function does: The SSL_CTX_use_PrivateKey_file function

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2010-04-23 Thread Antony Dovgal
On 23.04.2010 15:05, Andrey Hristov wrote: The SSL_CTX_use_PrivateKey_file function loads the private key for use with Secure Sockets Layer (SSL) sessions using a specific context (CTX) structure. However, what gets passed is path to a certificate, not to a private key. So you

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2010-04-23 Thread Andrey Hristov
Antony Dovgal wrote: On 23.04.2010 15:05, Andrey Hristov wrote: The SSL_CTX_use_PrivateKey_file function loads the private key for use with Secure Sockets Layer (SSL) sessions using a specific context (CTX) structure. However, what gets passed is path to a certificate, not to a private key.

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2010-04-23 Thread Andrey Hristov
Tony, Antony Dovgal wrote: On 23.04.2010 15:05, Andrey Hristov wrote: The SSL_CTX_use_PrivateKey_file function loads the private key for use with Secure Sockets Layer (SSL) sessions using a specific context (CTX) structure. However, what gets passed is path to a certificate, not to a

Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2010-04-23 Thread Pierre Joye
Please open a new bug with the details + reproduce script. Thanks. On Fri, Apr 23, 2010 at 2:42 PM, Andrey Hristov p...@hristov.com wrote: Tony, Antony Dovgal wrote: On 23.04.2010 15:05, Andrey Hristov wrote: The SSL_CTX_use_PrivateKey_file function loads the private key for use with

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2010-04-22 Thread Antony Dovgal
tony2001 Thu, 22 Apr 2010 11:56:08 + Revision: http://svn.php.net/viewvc?view=revisionrevision=298314 Log: initialize variable. this code still segfaults in OpenSSL, no idea why Changed paths: U php/php-src/branches/PHP_5_3/ext/openssl/openssl.c U

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2010-04-22 Thread Antony Dovgal
tony2001 Thu, 22 Apr 2010 15:59:44 + Revision: http://svn.php.net/viewvc?view=revisionrevision=298331 Log: revert most of the Andrey's patch that causes segfaults (as agreed with Pierre) Changed paths: U

[PHP-CVS] svn: /php/php-src/branches/PHP_5_3/ext/openssl/ openssl.c tests/sni_001.phpt xp_ssl.c

2009-11-30 Thread Arnaud Le Blanc
lbarnaud Mon, 30 Nov 2009 13:31:53 + Revision: http://svn.php.net/viewvc?view=revisionrevision=291493 Log: merge from trunk: openssl sni support (rev 289831) Changed paths: U php/php-src/branches/PHP_5_3/ext/openssl/openssl.c A +

[PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/ext/openssl/openssl.c trunk/ext/openssl/openssl.c

2009-11-03 Thread Guenter Knauf
guenter Tue, 03 Nov 2009 21:26:39 + Revision: http://svn.php.net/viewvc?view=revisionrevision=290191 Log: added timezone define for NetWare. Changed paths: U php/php-src/branches/PHP_5_3/ext/openssl/openssl.c U