[PHP-CVS] cvs: php4 /ext/session session.c

2002-10-03 Thread Andi Gutmans
andiThu Oct 3 03:23:52 2002 EDT Modified files: /php4/ext/session session.c Log: - Fix ZTS build Index: php4/ext/session/session.c diff -u php4/ext/session/session.c:1.329 php4/ext/session/session.c:1.330 --- php4/ext/session/session.c:1.329Thu

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2002-10-11 Thread Andi Gutmans
I don't think this is a good idea. I'd definitely change the name to GD_something but it still doesn't make so much sense to me. When would people use this and not function_exists()? Andi At 09:49 AM 10/11/2002 +, Derick Rethans wrote: derick Fri Oct 11 05:49:38 2002 EDT

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2002-10-11 Thread Andi Gutmans
At 02:50 PM 10/11/2002 +0200, Derick Rethans wrote: On Fri, 11 Oct 2002, Andi Gutmans wrote: I don't think this is a good idea. I'd definitely change the name to GD_something but it still doesn't make so much sense to me. When would people use this and not function_exists()? Because some

Re: [PHP-CVS] cvs: php4 /ext/standard basic_functions.c php_string.hstring.c

2002-10-18 Thread Andi Gutmans
At 06:42 PM 10/17/2002 -0400, Ilia A. wrote: I'll correct the name of the function I've added, I applogize for the oversight. I do not think we should rename existing functions because it would break BC and force us add to add even more function aliases. We already have 400+ function alises in

Re: [PHP-CVS] cvs: php4 /ext/standard basic_functions.c php_string.hstring.c

2002-10-18 Thread Andi Gutmans
This should follow naming standards and start with str_ Andi At 03:27 AM 10/17/2002 +, Ilia Alshanetsky wrote: iliaa Wed Oct 16 23:27:19 2002 EDT Modified files: /php4/ext/standard basic_functions.c php_string.h string.c Log: Added word_count() function that allows

Re: [PHP-CVS] cvs: php4 /build buildcheck.sh

2002-10-30 Thread Andi Gutmans
Did you test the following?: ? function getFrontendObject() { $a = new $GLOBALS['_PEAR_Command_uiclass']; } ? Andi At 02:00 PM 10/30/2002 +0100, Marcus Boerger wrote: At 22:15 27.10.2002, Andi Gutmans wrote: At 09:10 PM 10/27/2002 +0100, Derick Rethans wrote: On Sun, 27

Re: [PHP-CVS] cvs: php4 /build buildcheck.sh

2002-10-30 Thread Andi Gutmans
value in write context At 17:45 30.10.2002, Andi Gutmans wrote: Did you test the following?: ? function getFrontendObject() { $a = new $GLOBALS['_PEAR_Command_uiclass']; } ? Andi At 02:00 PM 10/30/2002 +0100, Marcus Boerger wrote: At 22:15 27.10.2002, Andi Gutmans wrote

Re: [PHP-CVS] cvs: php4 /build buildcheck.sh

2002-10-30 Thread Andi Gutmans
- Can't use method return value in write context At 17:45 30.10.2002, Andi Gutmans wrote: Did you test the following?: ? function getFrontendObject() { $a = new $GLOBALS['_PEAR_Command_uiclass']; } ? Andi At 02:00 PM 10/30/2002 +0100, Marcus Boerger wrote: At 22:15 27.10.2002

Re: [PHP-CVS] cvs: php4 /ext/standard string.c

2002-11-01 Thread Andi Gutmans
I'm not sure this is the right thing to do. UNIX and Windows are diffferent and that's what DEFAULT_SLASH is for. Andi At 12:53 AM 11/1/2002 +, Ilia Alshanetsky wrote: iliaa Thu Oct 31 19:53:28 2002 EDT Modified files: /php4/ext/standard string.c Log: Fixed bug #18710.

Re: [PHP-CVS] cvs: php4 /ext/standard string.c

2002-11-02 Thread Andi Gutmans
/ and not \. Ilia On November 1, 2002 03:01 am, Andi Gutmans wrote: I'm not sure this is the right thing to do. UNIX and Windows are diffferent and that's what DEFAULT_SLASH is for. Andi At 12:53 AM 11/1/2002 +, Ilia Alshanetsky wrote: iliaa Thu Oct 31 19:53:28 2002 EDT

Re: [PHP-CVS] cvs: TSRM / tsrm_virtual_cwd.c

2002-11-04 Thread Andi Gutmans
At 02:41 PM 11/4/2002 -0500, Ilia A. wrote: On November 4, 2002 03:36 am, you wrote: I'll check it out tomorrow. Your code is problematic in any case as you're returning a pointer to the stack which is a no-no in C. I'll see if there's a way to do what you need without adding this

[PHP-CVS] cvs: TSRM / tsrm_virtual_cwd.c tsrm_virtual_cwd.h

2002-11-04 Thread Andi Gutmans
andiMon Nov 4 15:45:29 2002 EDT Modified files: /TSRM tsrm_virtual_cwd.c tsrm_virtual_cwd.h Log: - Clean up mess made by netware guys. There's no reason not to abstract - the macro a tiny bit more allowing the code to look cleaner. The more -

Re: [PHP-CVS] cvs: TSRM / tsrm_virtual_cwd.c

2002-11-04 Thread Andi Gutmans
the symlink situation. Attached is a patch that I believe should resolve the problem. Ilia On November 4, 2002 02:53 pm, Ilia A. wrote: On November 4, 2002 03:43 am, Andi Gutmans wrote: At 02:41 PM 11/4/2002 -0500, Ilia A. wrote: On November 4, 2002 03:36 am, you wrote: I'll check it out

[PHP-CVS] cvs: php4 /ext/tokenizer tokenizer.c

2002-11-05 Thread Andi Gutmans
andiTue Nov 5 14:01:36 2002 EDT Modified files: /php4/ext/tokenizer tokenizer.c Log: - Fix Engine 2 build Index: php4/ext/tokenizer/tokenizer.c diff -u php4/ext/tokenizer/tokenizer.c:1.10 php4/ext/tokenizer/tokenizer.c:1.11 ---

[PHP-CVS] cvs: php4 /ext/tokenizer tokenizer.c

2002-11-05 Thread Andi Gutmans
andiTue Nov 5 14:02:38 2002 EDT Modified files: /php4/ext/tokenizer tokenizer.c Log: - Arghh... Change #ifdef to #ifndef Index: php4/ext/tokenizer/tokenizer.c diff -u php4/ext/tokenizer/tokenizer.c:1.11 php4/ext/tokenizer/tokenizer.c:1.12 ---

Re: [PHP-CVS] cvs: php4 /ext/standard credits.c

2002-11-11 Thread Andi Gutmans
, Stig Bakken, Sascha Schumann); CREDIT_LINE(Win32 Port, Shane Caraveo, Zeev Suraski); CREDIT_LINE(Server API (SAPI) Abstraction Layer, Andi Gutmans, Shane Caraveo, Zeev Suraski); + CREDIT_LINE(Streams Support and Development, Wez Furlong

RE: [PHP-CVS] cvs: php4 /ext/standard credits.c

2002-11-11 Thread Andi Gutmans
Streams Abstraction Layer? Andi At 09:56 PM 11/11/2002 +, James Cox wrote: That works for me -- didn't want it to be too short, however. (could say Streams Support and API Dev...?) -Original Message- From: Andi Gutmans [mailto:andi;zend.com] Sent: Monday, November 11, 2002 8:25

Re: [PHP-CVS] cvs: php4 /ext/standard flock_compat.c flock_compat.h

2002-11-11 Thread Andi Gutmans
At 11:40 PM 11/11/2002 +, Marcus Boerger wrote: helly Mon Nov 11 18:40:33 2002 EDT Modified files: /php4/ext/standard flock_compat.c flock_compat.h Log: make flock() a function again when it is missing Index: php4/ext/standard/flock_compat.c diff -u

RE: [PHP-CVS] cvs: php4 /ext/standard credits.c

2002-11-11 Thread Andi Gutmans
: Andi Gutmans [mailto:andi;zend.com] Why not just Streams support? The and development is already contained in support and it could be put on almost every end of line :) + CREDIT_LINE(Streams Support and Development, Wez Furlong); -- PHP CVS Mailing List (http://www.php.net

Re: [PHP-CVS] cvs: TSRM / tsrm_virtual_cwd.h

2002-11-15 Thread Andi Gutmans
Ilia, This patch isn't correct. The reason is that IS_ABSOLUTE_PATH() is often followed by COPY_WHEN_ABSOLUTE(). i.e absolute paths on Windows are supposed to start with c: and then always two chars are copied. I'm aware there might be a problem which needs fixing but this definitely doesn't

Re: [PHP-CVS] cvs: php4 /sapi/cgi cgi_main.c

2002-11-15 Thread Andi Gutmans
Why is this needed? Looks pretty ugly to me to check specifically for run-tests.php. Andi At 04:37 PM 11/12/2002 +, Hartmut Holzgraefe wrote: hholzgraTue Nov 12 11:37:47 2002 EDT Modified files: /php4/sapi/cgi cgi_main.c Log: Index: php4/sapi/cgi/cgi_main.c

Re: [PHP-CVS] cvs: php4 /sapi/cgi cgi_main.c

2002-11-15 Thread Andi Gutmans
Forget my previous Email :) Andi At 04:41 PM 11/12/2002 +, Hartmut Holzgraefe wrote: hholzgraTue Nov 12 11:41:15 2002 EDT Modified files: /php4/sapi/cgi cgi_main.c Log: reverting accidential commit Index: php4/sapi/cgi/cgi_main.c diff -u

Re: [PHP-CVS] cvs: CVSROOT / avail

2002-11-20 Thread Andi Gutmans
Ouch, thanks. But I see it's already been fixed. Andi At 11:35 AM 11/20/2002 +0100, Derick Rethans wrote: On Wed, 20 Nov 2002, Andi Gutmans wrote: andi Wed Nov 20 00:39:02 2002 EDT Modified files: /CVSROOT avail Log: - Give James cvsroot access Index: CVSROOT

[PHP-CVS] cvs: php4 /ext/bcmath bcmath.c /ext/bcmath/libbcmath/src bcmath.h init.c output.c raise.c raisemod.c recmul.c sqrt.c str2num.c zero.c

2002-11-20 Thread Andi Gutmans
andiWed Nov 20 14:48:13 2002 EDT Modified files: /php4/ext/bcmathbcmath.c /php4/ext/bcmath/libbcmath/src bcmath.h init.c output.c raise.c raisemod.c recmul.c sqrt.c str2num.c

[PHP-CVS] cvs: php4 /ext/bcmath bcmath.c /ext/bcmath/libbcmath/src bcmath.h init.c output.c raise.c raisemod.c recmul.c sqrt.c str2num.c zero.c

2002-11-20 Thread Andi Gutmans
andiWed Nov 20 15:03:02 2002 EDT Modified files: /php4/ext/bcmathbcmath.c /php4/ext/bcmath/libbcmath/src bcmath.h init.c output.c raise.c raisemod.c recmul.c sqrt.c str2num.c

[PHP-CVS] cvs: php4 /ext/bcmath config.m4

2002-11-20 Thread Andi Gutmans
andiWed Nov 20 16:16:40 2002 EDT Modified files: /php4/ext/bcmathconfig.m4 Log: - CVS nuked number.* so we'll nuke it from the build:) Index: php4/ext/bcmath/config.m4 diff -u php4/ext/bcmath/config.m4:1.14 php4/ext/bcmath/config.m4:1.15 ---

Re: [PHP-CVS] cvs: php4 /main SAPI.c SAPI.h /sapi/apache mod_php4.c/sapi/thttpd thttpd.c

2002-11-27 Thread Andi Gutmans
I would have prefered you to leave STANDARD_SAPI_MODULE_PROPERTIES. Why didn't you put fd earlier? I don't think BC is much of an issue here. Or am I missing something? Andi At 05:15 AM 11/26/2002 +, Sascha Schumann wrote: sas Tue Nov 26 00:15:55 2002 EDT Modified files:

Re: [PHP-CVS] cvs: php4 /main SAPI.c SAPI.h /sapi/apache mod_php4.c/sapi/thttpd thttpd.c

2002-11-27 Thread Andi Gutmans
Default initializations? Andi At 07:42 PM 11/27/2002 +0100, Sascha Schumann wrote: On Wed, 27 Nov 2002, Andi Gutmans wrote: I would have prefered you to leave STANDARD_SAPI_MODULE_PROPERTIES. Why didn't you put fd earlier? I don't think BC is much of an issue here. Or am I missing something

Re: [PHP-CVS] cvs: php4 /main SAPI.c SAPI.h /sapi/apache mod_php4.c/sapi/thttpd thttpd.c

2002-11-29 Thread Andi Gutmans
At 08:07 PM 11/27/2002 +0100, Sascha Schumann wrote: On Wed, 27 Nov 2002, Andi Gutmans wrote: At 07:57 PM 11/27/2002 +0100, Sascha Schumann wrote: On Wed, 27 Nov 2002, Andi Gutmans wrote: Default initializations? The compiler does that just fine. Hmm, I'm either very tired or I

Re: [PHP-CVS] cvs: php4 /ext/imap php_imap.c

2002-12-07 Thread Andi Gutmans
Hey, Unless you are sure there can't be a buffer overrun in this strcat() call please use strlcat(). In any case, I think using strlcat() should be prefered. Andi At 10:52 PM 12/6/2002 +, Frank M. Kromann wrote: fmk Fri Dec 6 17:52:31 2002 EDT Modified files:

Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c

2002-12-14 Thread Andi Gutmans
This doesn't look right to me. We always use CONST_PERSISTENT in all of PHP. What is the problem? Andi At 10:24 AM 12/11/2002 +, Edin Kadribasic wrote: edink Wed Dec 11 05:24:03 2002 EDT Modified files: /php4/sapi/cli php_cli.c Log: Fix for #20539 (patch by

Re: [PHP-CVS] cvs: php4 /sapi/cli php_cli.c

2002-12-15 Thread Andi Gutmans
resources are destructed, as php_stream_open_wrapper_ex() doesn't return persistent resources. Moriyoshi Andi Gutmans [EMAIL PROTECTED] wrote: This doesn't look right to me. We always use CONST_PERSISTENT in all of PHP. What is the problem? Andi At 10:24 AM 12/11/2002 +, Edin Kadribasic

Re: [PHP-CVS] cvs: php4 /ext/ncurses ncurses_fe.c ncurses_functions.c

2002-12-24 Thread Andi Gutmans
At 05:20 PM 12/24/2002 +, Ilia Alshanetsky wrote: * Change strcpy() to strncpy() to prevent possible buffer overflows. Please change to strlcpy(). Andi -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-CVS] cvs: php4 /ext/ncurses ncurses_functions.c

2002-12-24 Thread Andi Gutmans
http://www.courtesan.com/todd/papers/strlcpy.html It should be strlcpy(temp, blah, sizeof(temp)); That's one of the advantages of strlcpy(). It's much easier to use. Andi At 05:30 PM 12/24/2002 +, Ilia Alshanetsky wrote: iliaa Tue Dec 24 12:30:48 2002 EDT Modified files:

Re: [PHP-CVS] cvs: php4 /ext/standard basic_functions.c php_var.h var.c

2003-01-18 Thread Andi Gutmans
This should follow our naming conventions and be called memory_get_usage(). Andi At 06:26 PM 1/14/2003 +, Andrey Hristov wrote: andrey Tue Jan 14 13:26:47 2003 EDT Modified files: /php4/ext/standard basic_functions.c php_var.h var.c Log: added function

Re: [PHP-CVS] cvs: php4(PHP_4_3) /main SAPI.h

2003-01-18 Thread Andi Gutmans
At 06:42 PM 1/15/2003 +0100, Derick Rethans wrote: On Wed, 15 Jan 2003, Shane Caraveo wrote: Edin Kadribasic wrote: I think that we should relax this contraint a bit on PHP_4_3 due to the fact that head is not likely going to see realeased version for some time to come due to the move to

Re: [PHP-CVS] cvs: php4 /sapi/cgi cgi_main.c

2003-01-25 Thread Andi Gutmans
Please try not to mix whitespace and functionality patches. I'm having a hard time looking at two of your patches because too much has changed and most of it is whitespace. Thanks, Andi At 10:01 PM 1/25/2003 +, Shane Caraveo wrote: shane Sat Jan 25 17:01:54 2003 EDT Modified

Re: [PHP-CVS] cvs: php4 /ext/ftp ftp.c ftp.h php_ftp.c php_ftp.h

2003-01-26 Thread Andi Gutmans
This is a wonderful opportunity for a buffer overflow attack. There's a reason zend_parse_parameters() in PHP_FUNCTION(ftp_chmod) forces you to retrieve filename_len. Please fix it. Thanks, Andi At 02:54 AM 1/27/2003 +, Sara Golemon wrote: +ftp_chmod(ftpbuf_t *ftp, const int mode, const

[PHP-CVS] cvs: php4 /ext/bcmath bcmath.c

2003-02-04 Thread Andi Gutmans
andiTue Feb 4 16:07:40 2003 EDT Modified files: /php4/ext/bcmathbcmath.c Log: - Please follow coding standards (this isn't java :) Index: php4/ext/bcmath/bcmath.c diff -u php4/ext/bcmath/bcmath.c:1.49 php4/ext/bcmath/bcmath.c:1.50 ---

Re: [PHP-CVS] cvs: php4 /ext/bcmath bcmath.c

2003-02-04 Thread Andi Gutmans
At 10:13 PM 2/4/2003 +0100, Marcus Börger wrote: At 22:07 04.02.2003, Andi Gutmans wrote: andiTue Feb 4 16:07:40 2003 EDT Modified files: /php4/ext/bcmathbcmath.c Log: - Please follow coding standards (this isn't java :) I only corrected this... I know. It wasn't

Re: [PHP-CVS] cvs: php4 /ext/yp yp.c

2003-02-26 Thread Andi Gutmans
Please use strlcpy() instead of strncpy(). At 01:35 PM 2/24/2003 +, Hartmut Holzgraefe wrote: hholzgraMon Feb 24 08:35:06 2003 EDT Modified files: /php4/ext/ypyp.c Log: key has to be zero-delimited Index: php4/ext/yp/yp.c diff -u php4/ext/yp/yp.c:1.34

Re: [PHP-CVS] cvs: php4 /ext/curl multi.c ZendEngine2 zend_list.c zend_list.h

2003-04-02 Thread Andi Gutmans
I didn't quite understand what you did here. Can you please explain? Is it absolutely necessary to add this hack just for curl? Andi At 04:58 PM 4/2/2003 +, Sterling Hughes wrote: sterlingWed Apr 2 11:58:52 2003 EDT Modified files: /ZendEngine2zend_list.c

Re: [PHP-CVS] cvs: php4 /ext/curl multi.c ZendEngine2 zend_list.c zend_list.h

2003-04-02 Thread Andi Gutmans
At 01:21 PM 4/2/2003 -0500, Sterling Hughes wrote: I didn't quite understand what you did here. Can you please explain? Is it absolutely necessary to add this hack just for curl? I added the ability to find a resource identifier from a resource. Something I think is generally pretty useful. :)

Re: [PHP-CVS] cvs: php4 /ext/exif exif.c

2003-04-02 Thread Andi Gutmans
I don't have time to look through this in a thorough way but I think it could leak now. Maybe it's best if you move this function to getParameters() and convert_to_string() w/o _ex. Andi At 10:07 PM 4/2/2003 +, Rasmus Lerdorf wrote: rasmus Wed Apr 2 17:07:22 2003 EDT Modified

Re: [PHP-CVS] cvs: php4 /ext/bcmath bcmath.c

2003-04-02 Thread Andi Gutmans
I agree with him. We have standards and people have worked hard to indent the source code in a consistent manner (especially people like Jani). It doesn't take more time to indent nicely. Andi At 06:54 PM 4/2/2003 -0800, Rasmus Lerdorf wrote: Oh, give me a break Jani. A space here or there

Re: [PHP-CVS] cvs: php4 /main output.c

2003-04-04 Thread Andi Gutmans
I don't think we should back-out these kind of whitespace fixes. I tend to agree with Jani and I think he's doing a good job whitespacing code. I also think that Rasmus reasoning for not commiting correctly whitespaced code because we have lots of broken code in PHP, is not very strong. Let's

Re: [PHP-CVS] cvs: php4 /main php.h ZendEngine2 zend_API.h

2003-04-04 Thread Andi Gutmans
What's the difference between ZEND_ME() and ZEND_METHOD()? (i.e. what does ME stand for?) At 03:38 PM 4/4/2003 +, Andrei Zmievski wrote: andrei Fri Apr 4 10:38:20 2003 EDT Modified files: /ZendEngine2zend_API.h /php4/main php.h Log: Introduce ZEND_ME() and

Re: [PHP-CVS] cvs: php4 /ext/gd gd.c

2003-04-05 Thread Andi Gutmans
At 08:52 PM 4/4/2003 +0300, Jani Taskinen wrote: On Fri, 4 Apr 2003, Rasmus Lerdorf wrote: Jani, it is not just me. I think there is pretty much universal agreement that this error_docref stuff is crap. We already decided to disable it by default in 4.3.2. We haven't discussed it yet, but

[PHP-CVS] cvs: CVSROOT / avail

2003-06-10 Thread Andi Gutmans
andiTue Jun 10 15:26:03 2003 EDT Modified files: /CVSROOTavail Log: - Add imajes to Zend. License commit coming up Index: CVSROOT/avail diff -u CVSROOT/avail:1.685 CVSROOT/avail:1.686 --- CVSROOT/avail:1.685 Thu Jun 5 12:42:06 2003 +++ CVSROOT/avail

Re: [PHP-CVS] cvs: php-src /ext/sqlite php_sqlite.h sqlite.c /ext/sqlite/tests sqlite_oo_016.phpt

2003-06-27 Thread Andi Gutmans
IMO, it doesn't make sense to introduce aliases in a new extension. Andi At 07:26 PM 26/6/2003 +, Marcus Boerger wrote: helly Thu Jun 26 15:26:26 2003 EDT Modified files: /php-src/ext/sqlite php_sqlite.h sqlite.c /php-src/ext/sqlite/tests sqlite_oo_016.phpt Log:

Re: [PHP-CVS] cvs: php-src / README.EXT_SKEL /ext ext_skel ext_skel_win32.php /ext/skeleton .cvsignore CREDITS EXPERIMENTAL create_stubs php_skeleton.h skeleton.c skeleton.dsp skeleton.php /ext/skeleton/tests .cvsignore 001.phpt /scripts/ext_skel_ng BUGS README TODO config_m4.php dummy.gif ext_skel_ng.php extension.dtd extension.xml extension_parser.php license.php license_bsd.php license_lgpl.php license_php.php php_constant.php php_element.php php_function.php php_global.php php_ini.php php_logo.php php_resource.php xml_stream_callback_parser.php xml_stream_parser.php

2003-06-29 Thread Andi Gutmans
Why? I liked ext_skel and it was great a great light weight solution. Why do you remove stuff without consulting the development mailing list? I'd like to see this reverted! Andi At 12:21 PM 29/6/2003 +, Hartmut Holzgraefe wrote: hholzgraSun Jun 29 08:21:58 2003 EDT

Re: [PHP-CVS] cvs: php-src / README.EXT_SKEL /ext ext_skel ext_skel_win32.php /ext/skeleton CREDITS EXPERIMENTAL create_stubs php_skeleton.h skeleton.c skeleton.dsp skeleton.php /ext/skeleton/tests .cvsignore 001.phpt

2003-06-29 Thread Andi Gutmans
Didn't see this when I wrote my previous email :) At 04:07 PM 29/6/2003 +, Hartmut Holzgraefe wrote: hholzgraSun Jun 29 12:07:18 2003 EDT Modified files: /php-srcREADME.EXT_SKEL /php-src/extext_skel ext_skel_win32.php /php-src/ext/skeleton

[PHP-CVS] cvs: CVSROOT / avail

2003-06-30 Thread Andi Gutmans
andiMon Jun 30 15:58:02 2003 EDT Modified files: /CVSROOTavail Log: - ZE2 Karma for George Schlossnagle Index: CVSROOT/avail diff -u CVSROOT/avail:1.700 CVSROOT/avail:1.701 --- CVSROOT/avail:1.700 Wed Jun 25 20:16:54 2003 +++ CVSROOT/avail Mon

Re: [PHP-CVS] cvs: php-src /ext/simplexml simplexml.c

2003-07-05 Thread Andi Gutmans
Sterling, Extensions shouldn't really be using stuff like PZVAL_UNLOCK(). Can you explain what you are trying to accomplish? Andi At 12:33 AM 5/7/2003 +, Sterling Hughes wrote: sterlingFri Jul 4 20:33:13 2003 EDT Modified files: /php-src/ext/simplexml

Re: [PHP-CVS] cvs: php-src /ext/sqlite sqlite.c

2003-07-19 Thread Andi Gutmans
Why not use zend_list_find() (without the _)? Andi At 05:52 AM 14/7/2003 +, Sebastian Bergmann wrote: sebastian Mon Jul 14 01:52:57 2003 EDT Modified files: /php-src/ext/sqlite sqlite.c Log: ZTS fix. Index: php-src/ext/sqlite/sqlite.c diff -u

RE: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/standard basic_functions.c /ext/standard/tests/network ip.phpt

2007-08-20 Thread Andi Gutmans
There are some convenience functions in zend_operators.h which would save having to repeat this logic (I think they are called zend_binary_strcmp() and zend_binary_zval_strcmp()). Andi -Original Message- From: Antony Dovgal [mailto:[EMAIL PROTECTED] Sent: Thursday, August 16, 2007

[PHP-CVS] cvs: CVSROOT / avail

2007-09-12 Thread Andi Gutmans
andiWed Sep 12 21:57:30 2007 UTC Modified files: /CVSROOTavail Log: - Enable Stas to help with CVS accounts http://cvs.php.net/viewvc.cgi/CVSROOT/avail?r1=1.1302r2=1.1303diff_format=u Index: CVSROOT/avail diff -u CVSROOT/avail:1.1302

RE: [PHP-CVS] cvs: php-src(PHP_5_2_WITH_DRCP) /ext/oci8 READMEoci8.c oci8_interface.c php_oci8_int.h /ext/oci8/tests debug.phptpassword.phpt password_2.phpt password_new.phpt password_old.phpt

2007-10-05 Thread Andi Gutmans
Weird, I'm pretty sure I created the branch for Chris in PECL. This is intentionally in a branch so that people can play around with it but without risking the stable branch. Chris, did you checkout pecl/oci8 or php-src/ext/oci8 before you commited? Andi -Original Message- From: Jani

RE: [PHP-CVS] cvs: php-src(PHP_5_2_WITH_DRCP) /ext/oci8 READMEoci8.c oci8_interface.c php_oci8_int.h /ext/oci8/tests debug.phptpassword.phpt password_2.phpt password_new.phpt password_old.phpt

2007-10-05 Thread Andi Gutmans
Yeah I also got confused for a sec :) -Original Message- From: Jani Taskinen [mailto:[EMAIL PROTECTED] Sent: Friday, October 05, 2007 4:38 PM To: Andi Gutmans Cc: Christopher Jones; php-cvs@lists.php.net Subject: Re: [PHP-CVS] cvs: php-src(PHP_5_2_WITH_DRCP) /ext/oci8 READMEoci8.c

RE: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqli mysqli.c /ext/mysqlnd mysqlnd_priv.h

2007-10-27 Thread Andi Gutmans
Hi Andrey, Are you sure it's a good idea to replicate these macros? It kind of breaks the ability to tweak them in a central place. What's the reasoning for it? Andi -Original Message- From: Andrey Hristov [mailto:[EMAIL PROTECTED] Sent: Tuesday, October 16, 2007 1:56 PM To:

Re: [PHP-CVS] cvs: php-src /ext/unicode unicode.c /main main.c /main/streams filter.c streams.c ZendEngine2 zend.c zend_constants.c zend_globals.h zend_unicode.c zend_unicode.h

2006-03-26 Thread Andi Gutmans
We should namespaces these and all other unicode constants... + REGISTER_MAIN_LONG_CONSTANT(FROM_UNICODE, ZEND_FROM_UNICODE, CONST_PERSISTENT | CONST_CS); + REGISTER_MAIN_LONG_CONSTANT(TO_UNICODE, ZEND_TO_UNICODE, CONST_PERSISTENT | CONST_CS); At 05:48 PM 3/25/2006, Andrei

Re: [PHP-CVS] cvs: php-src(PHP_5_1) /sapi/apache php_apache.c

2006-04-27 Thread Andi Gutmans
Shouldn't you use ZEND_DLIMPORT? It'd be much nicer and save us those #ifdef's Andi At 02:31 AM 4/26/2006, Edin Kadribasic wrote: edink Wed Apr 26 09:31:23 2006 UTC Modified files: (Branch: PHP_5_1) /php-src/sapi/apachephp_apache.c Log: Correctly

Re: [PHP-CVS] cvs: php-src(PHP_5_1) /ext/standard php_smart_str.h

2006-05-02 Thread Andi Gutmans
Does smart_str realloc at the end? If not, then this patch can lead to much higher memory use. From our tests we found 5.1 to use more memory and this was part of the reason for some slowdown. Even if a micro benchmark can show this to be faster, for real world apps and the various CPUs we are

Re: [PHP-CVS] cvs: php-src / NEWS /ext/standard basic_functions.c file.c file.h

2006-05-07 Thread Andi Gutmans
Hartmut, This is a very odd name to be using and doesn't follow our naming conventions. Maybe something like sys_get_tmpdir()? Andi At 02:59 AM 5/6/2006, Hartmut Holzgraefe wrote: hholzgraSat May 6 09:59:02 2006 UTC Modified files: /php-srcNEWS

Re: [PHP-CVS] cvs: php-src / NEWS /ext/standard basic_functions.c file.c file.h

2006-05-07 Thread Andi Gutmans
Either of these works for me. At 11:02 AM 5/7/2006, Pierre wrote: On 5/7/06, Antony Dovgal [EMAIL PROTECTED] wrote: On 07.05.2006 21:26, Wez Furlong wrote: sys_tmpdir()? I vote for sys_ as the prefix, as we've started down that path with sys_getloadavg(). Yeah, sys_tmpdir() sounds good.

[PHP-CVS] cvs: php-src(PHP_5_2) / NEWS

2006-05-30 Thread Andi Gutmans
andiWed May 31 03:43:17 2006 UTC Modified files: (Branch: PHP_5_2) /php-srcNEWS Log: - Fix typo http://cvs.php.net/viewcvs.cgi/php-src/NEWS?r1=1.2027.2.547.2.66r2=1.2027.2.547.2.67diff_format=u Index: php-src/NEWS diff -u

Re: [PHP-CVS] cvs: php-src / README.NEW-OUTPUT-API /ext/pgsql pgsql.c /ext/session session.c /ext/soap soap.c /ext/standard basic_functions.c head.c info.c url_scanner_ex.c url_scanner_ex.re var.c

2006-06-02 Thread Andi Gutmans
Can you give a short summary of what the essence of the change is and how the APIs have changed (Both the ones available to the PHP developer and to the extension writer?) Thanks! Andi At 12:51 PM 6/2/2006, Michael Wallner wrote: mikeFri Jun 2 19:51:43 2006 UTC Added files:

Re: [PHP-CVS] cvs: php-src / README.NEW-OUTPUT-API /ext/pgsql pgsql.c /ext/session session.c /ext/soap soap.c /ext/standard basic_functions.c head.c info.c url_scanner_ex.c url_scanner_ex.re var.c

2006-06-02 Thread Andi Gutmans
Btw, any reason why we need all those redefinition of functions? If it's just to save having to write TSRMLS_C then I'd prefer to remove those macros. They just make debugging harder, there's no real benefit and we've tried to be explicit in other places. The patch looks nice though although I

Re: [PHP-CVS] cvs: php-src /ext/session session.c /ext/soap soap.c /ext/standard basic_functions.c head.c info.c url_scanner_ex.c url_scanner_ex.re var.c /ext/tidy tidy.c /ext/zlib zlib.c /main S

2006-06-03 Thread Andi Gutmans
Thanks! I missed the original email you sent with the patch which is why I didn't catch it earlier. At 04:19 AM 6/3/2006, Michael Wallner wrote: mikeSat Jun 3 11:19:44 2006 UTC Modified files: /php-src/ext/sessionsession.c /php-src/ext/soap soap.c

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /sapi/cgi cgi_main.c /sapi/cli php_cli.c

2006-06-03 Thread Andi Gutmans
Hey, I must have missed the discussion around this one. Why is it useless? How long has this feature existed? Thx. Andi At 03:02 PM 6/3/2006, Johannes Schlüter wrote: johannesSat Jun 3 22:02:02 2006 UTC Modified files: (Branch: PHP_5_2) /php-src/sapi/cli

Re: [PHP-CVS] cvs: php-src /ext/unicode config.m4 config.w32 php_transform.h transform.c unicode.c

2006-06-13 Thread Andi Gutmans
Please fix the naming conventions... At 04:46 PM 6/13/2006, Andrei Zmievski wrote: andrei Tue Jun 13 23:46:04 2006 UTC Added files: /php-src/ext/unicodephp_transform.h transform.c Modified files: /php-src/ext/unicodeconfig.m4 config.w32 unicode.c Log:

Re: [PHP-CVS] cvs: php-src /ext/unicode config.m4 config.w32 php_transform.h transform.c unicode.c

2006-06-13 Thread Andi Gutmans
. Thx. At 07:49 PM 6/13/2006, Andrei Zmievski wrote: What do you mean? -Andrei On Jun 13, 2006, at 5:45 PM, Andi Gutmans wrote: Please fix the naming conventions... -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- PHP CVS Mailing List

Re: [PHP-CVS] cvs: php-src /ext/unicode config.m4 config.w32 php_transform.h transform.c unicode.c

2006-06-14 Thread Andi Gutmans
. text_transliterate()? str_transliterate()? We've abandoned the idea of i18n_ prefix and unicode_ doesn't fit here either.. -Andrei On Jun 13, 2006, at 8:41 PM, Andi Gutmans wrote: As you know our naming conventions are module_function, e.g. unicode_transliterate, i18n_transliterate

Re: [PHP-CVS] cvs: php-src /ext/unicode php_transform.h transform.c unicode.c

2006-06-15 Thread Andi Gutmans
Thanks! At 10:37 AM 6/15/2006, Andrei Zmievski wrote: andrei Thu Jun 15 17:37:48 2006 UTC Modified files: /php-src/ext/unicodephp_transform.h transform.c unicode.c Log: Rename to str_transliterate().

[PHP-CVS] RE: [PHP-DEV] Re: [PHP-CVS] New Memory Manager (Was: [PHP-CVS] cvs: php-src(PHP_5_2) / NEWS /ext/standard var.c /main main.c /sapi/apache mod_php5.c /sapi/apache2filter sapi_apache2.c /

2006-07-18 Thread Andi Gutmans
Didn't see this but I did :) Andi -Original Message- From: Andrei Zmievski [mailto:[EMAIL PROTECTED] Sent: Tuesday, July 18, 2006 10:13 AM To: Dmitry Stogov Cc: php-cvs@lists.php.net; internals@lists.php.net Subject: [PHP-DEV] Re: [PHP-CVS] New Memory Manager (Was: [PHP-CVS]

RE: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/zip php_zip.c

2006-08-26 Thread Andi Gutmans
I missed the discussion about this. Is there a bug in VCWD_REALPATH()? Can you explain? Thanks. -Original Message- From: Pierre-Alain Joye [mailto:[EMAIL PROTECTED] Sent: Saturday, August 26, 2006 5:24 AM To: php-cvs@lists.php.net Subject: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/zip

RE: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/bz2 bz2.c php_bz2.h /ext/ctype ctype.c php_ctype.h /ext/json json.c php_json.h /ext/pspell php_pspell.h pspell.c /ext/tidy php_tidy.h tidy.c /ext/zlib php

2006-08-26 Thread Andi Gutmans
Why is this important? We never defined these as static. As long as you move them to the .c file (for whatever reason you have that might be justified) you really don't have to define them as static IMO. -Original Message- From: Nuno Lopes [mailto:[EMAIL PROTECTED] Sent: Monday,

RE: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/bz2 bz2.c php_bz2.h /ext/ctype ctype.c php_ctype.h /ext/json json.c php_json.h /ext/pspell php_pspell.h pspell.c /ext/tidy php_tidy.h tidy.c /ext/zlib php

2006-08-26 Thread Andi Gutmans
in handly with dlls. Andi -Original Message- From: Ilia Alshanetsky [mailto:[EMAIL PROTECTED] On Behalf Of Ilia Alshanetsky Sent: Saturday, August 26, 2006 9:59 AM To: Andi Gutmans Cc: 'Nuno Lopes'; php-cvs@lists.php.net Subject: Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/bz2 bz2.c

[PHP-CVS] cvs: CVSROOT / avail

2009-03-22 Thread Andi Gutmans
andiMon Mar 23 02:32:49 2009 UTC Modified files: /CVSROOTavail Log: - Give ericstewart commit access to php-src for INI and test work http://cvs.php.net/viewvc.cgi/CVSROOT/avail?r1=1.1503r2=1.1504diff_format=u Index: CVSROOT/avail diff -u

[PHP-CVS] cvs: CVSROOT / avail

2008-08-11 Thread Andi Gutmans
andiMon Aug 11 19:41:57 2008 UTC Modified files: /CVSROOTavail Log: - Karma to commit tests for CURL. http://cvs.php.net/viewvc.cgi/CVSROOT/avail?r1=1.1433r2=1.1434diff_format=u Index: CVSROOT/avail diff -u CVSROOT/avail:1.1433 CVSROOT/avail:1.1434

[PHP-CVS] cvs: CVSROOT / avail

2008-11-02 Thread Andi Gutmans
andiSun Nov 2 16:46:02 2008 UTC Modified files: /CVSROOTavail Log: - Karma to Zend Engine tests for Felix De Vliegher http://cvs.php.net/viewvc.cgi/CVSROOT/avail?r1=1.1461r2=1.1462diff_format=u Index: CVSROOT/avail diff -u CVSROOT/avail:1.1461

RE: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/standard basic_functions.c /main SAPI.h main.c /sapi/cgi cgi_main.c /sapi/cli php_cli.c /sapi/embed php_embed.c

2009-01-01 Thread Andi Gutmans
Hi Marcus, I think dl() should also be disabled for FastCGI. It may require a bit of reordering of the code to make this work but I think it's the right thing. If you bump into any problems then maybe Dmitry could help out but he's on vacation for the next couple of weeks. Thanks! Andi

[PHP-CVS] cvs: php-src(PHP_5_3) /ext/pcre config.w32

2009-01-01 Thread Andi Gutmans
andiFri Jan 2 04:59:41 2009 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/pcre config.w32 Log: - Remove NO_RECURSE as it causes a huge performance impact. Up to 50% with Wordpress. Stack size is not really anymore of an issue than on Linux with

[PHP-CVS] cvs: php-src /ext/pcre config.w32

2009-01-01 Thread Andi Gutmans
andiFri Jan 2 05:00:04 2009 UTC Modified files: /php-src/ext/pcre config.w32 Log: - MF PHP_5_2 http://cvs.php.net/viewvc.cgi/php-src/ext/pcre/config.w32?r1=1.18r2=1.19diff_format=u Index: php-src/ext/pcre/config.w32 diff -u

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/pcre config.w32

2009-01-01 Thread Andi Gutmans
andiFri Jan 2 05:00:35 2009 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/pcre config.w32 Log: - MF PHP_5_3 http://cvs.php.net/viewvc.cgi/php-src/ext/pcre/config.w32?r1=1.4.2.5.2.8r2=1.4.2.5.2.9diff_format=u Index: php-src/ext/pcre/config.w32 diff

RE: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext/standard basic_functions.c /main SAPI.h main.c /sapi/cgi cgi_main.c /sapi/cli php_cli.c /sapi/embed php_embed.c

2009-01-02 Thread Andi Gutmans
Ok will ask him to take a look when he's back. Cheers, Andi -Original Message- From: Marcus Boerger [mailto:he...@php.net] Sent: Friday, January 02, 2009 4:04 AM To: Andi Gutmans Cc: Marcus Boerger; php-cvs@lists.php.net Subject: Re: [PHP-CVS] cvs: php-src(PHP_5_3) / NEWS /ext

RE: [PHP-CVS] cvs: php-src(PHP_5_3) /main network.c

2009-01-02 Thread Andi Gutmans
Does this mean you should be using WSASetLastError() on Windows? Andi -Original Message- From: Felipe Pena [mailto:fel...@php.net] Sent: Friday, January 02, 2009 1:43 PM To: php-cvs@lists.php.net Subject: [PHP-CVS] cvs: php-src(PHP_5_3) /main network.c felipeFri

[PHP-CVS] cvs: php-src / configure.in /main php_version.h ZendEngine2 zend.h

2005-07-12 Thread Andi Gutmans
andiTue Jul 12 15:59:53 2005 EDT Modified files: /php-srcconfigure.in /ZendEngine2zend.h /php-src/main php_version.h Log: - Beta 3 http://cvs.php.net/diff.php/php-src/configure.in?r1=1.570r2=1.571ty=u Index:

Re: [PHP-CVS] cvs: php-src / NEWS

2005-07-12 Thread Andi Gutmans
Hmm, I wonder where I got that from :) Good catch. At 10:33 PM 7/12/2005 +0200, Derick Rethans wrote: On Tue, 12 Jul 2005, Andi Gutmans wrote: http://cvs.php.net/diff.php/php-src/NEWS?r1=1.1993r2=1.1994ty=u Index: php-src/NEWS diff -u php-src/NEWS:1.1993 php-src/NEWS:1.1994 --- php-src

[PHP-CVS] cvs: php-src / NEWS

2005-07-12 Thread Andi Gutmans
andiTue Jul 12 16:40:11 2005 EDT Modified files: /php-srcNEWS Log: - Update Beta 3 date http://cvs.php.net/diff.php/php-src/NEWS?r1=1.1994r2=1.1995ty=u Index: php-src/NEWS diff -u php-src/NEWS:1.1994 php-src/NEWS:1.1995 --- php-src/NEWS:1.1994 Tue

Re: [PHP-CVS] cvs: php-src /ext/mysqli mysqli_fe.c php_mysqli.h

2005-07-12 Thread Andi Gutmans
Is this a critical patch to include in Beta 3? Andi At 08:38 PM 7/12/2005 +, Antony Dovgal wrote: tony2001Tue Jul 12 16:38:35 2005 EDT Modified files: /php-src/ext/mysqli mysqli_fe.c php_mysqli.h Log: add forgotten ifdefs, fix #33667 (mysqli doesn't compile)

Re: [PHP-CVS] cvs: php-src /ext/mysqli mysqli_fe.c php_mysqli.h

2005-07-12 Thread Andi Gutmans
OK good. I'll reroll. Thanks. Andi At 12:50 AM 7/13/2005 +0400, Antony Dovgal wrote: On Tue, 12 Jul 2005 13:43:39 -0700 Andi Gutmans [EMAIL PROTECTED] wrote: Is this a critical patch to include in Beta 3? Yes, as ext/mysqli just doesn't compile without these ifdefs, if you have MySQL

Re: [PHP-CVS] cvs: php-src /ext/pdo_mysql mysql_statement.c

2005-07-13 Thread Andi Gutmans
Is this a build error in Beta 3? Was just about to post it... Andi At 02:20 AM 7/14/2005 +, Wez Furlong wrote: wez Wed Jul 13 22:20:52 2005 EDT Modified files: /php-src/ext/pdo_mysql mysql_statement.c Log: gah!

[PHP-CVS] cvs: php-src / NEWS configure.in /main php_version.h ZendEngine2 zend.h

2005-07-14 Thread Andi Gutmans
andiThu Jul 14 09:44:03 2005 EDT Modified files: /php-srcNEWS configure.in /ZendEngine2zend.h /php-src/main php_version.h Log: - Beta 3 http://cvs.php.net/diff.php/php-src/NEWS?r1=1.1996r2=1.1997ty=u Index: php-src/NEWS diff

[PHP-CVS] cvs: php-src / configure.in /main php_version.h ZendEngine2 zend.h

2005-07-14 Thread Andi Gutmans
andiThu Jul 14 10:01:02 2005 EDT Modified files: /php-srcconfigure.in /ZendEngine2zend.h /php-src/main php_version.h Log: - Back to -dev http://cvs.php.net/diff.php/php-src/configure.in?r1=1.574r2=1.575ty=u Index:

Re: [PHP-CVS] cvs: php-src /ext/mcve mcve.c php_mcve.h

2005-07-18 Thread Andi Gutmans
Brad, In any case, we are in a complete feature freeze right now. I sent an email about this to [EMAIL PROTECTED] Only bug fixes allowed. Please #if BRAD_0 that code in HEAD. I don't see a problem allowing the addition of such simple wrapper functions after 5.1.0 goes out the door; but I

Re: [PHP-CVS] cvs: php-src /ext/xsl/tests bug33853.phpt

2005-07-25 Thread Andi Gutmans
Never mind my previous email. I see it was the right bug # :) At 08:21 PM 7/25/2005 +, Marcus Boerger wrote: helly Mon Jul 25 16:21:45 2005 EDT Added files: /php-src/ext/xsl/tests bug33853.phpt Log: - Add new test

Re: [PHP-CVS] cvs: php-src /main php_ini.c

2005-07-28 Thread Andi Gutmans
Is this a bug fix? Or added functionality? At 03:12 PM 7/27/2005 +, Hartmut Holzgraefe wrote: hholzgraWed Jul 27 11:12:19 2005 EDT Modified files: /php-src/main php_ini.c Log: php.ini search logic needs to use the absolute path of the running binary when

Re: [PHP-CVS] cvs: php-src /main php_ini.c

2005-07-28 Thread Andi Gutmans
Ok thanks. At 03:18 AM 7/29/2005 +0300, Jani Taskinen wrote: It's a fix. php.ini was looked in php/ when it should have been looked under /path-to-php-binary/ --Jani On Thu, 28 Jul 2005, Andi Gutmans wrote: Is this a bug fix? Or added functionality? At 03:12 PM 7/27/2005 +

Re: [PHP-CVS] cvs: php-src /ext/spl spl_iterators.c /ext/spl/internal recursiveiteratoriterator.inc

2005-08-01 Thread Andi Gutmans
Aren't these RIT constants against our coding standards? Might be too late now if it's in 5.0.x but we should stick to plan. Something like RECURSIVE_ITERATOR_SELF_FIRST Andi At 10:19 PM 7/27/2005 +, Marcus Boerger wrote: helly Wed Jul 27 18:19:02 2005 EDT Modified files:

  1   2   3   4   >