[PHP-CVS] Re: cvs: php-src(PHP_5_3) /ext/standard/tests/general_functions phpinfo.phpt
Zoe Slattery wrote: zoe Wed Mar 4 10:23:01 2009 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/standard/tests/general_functions phpinfo.phpt Log: fixed test http://cvs.php.net/viewvc.cgi/php-src/ext/standard/tests/general_functions/phpinfo.phpt?r1=1.1.2.2.2.8r2=1.1.2.2.2.9diff_format=u Index: php-src/ext/standard/tests/general_functions/phpinfo.phpt diff -u php-src/ext/standard/tests/general_functions/phpinfo.phpt:1.1.2.2.2.8 php-src/ext/standard/tests/general_functions/phpinfo.phpt:1.1.2.2.2.9 --- php-src/ext/standard/tests/general_functions/phpinfo.phpt:1.1.2.2.2.8 Sun Feb 15 21:46:01 2009 +++ php-src/ext/standard/tests/general_functions/phpinfo.phpt Wed Mar 4 10:23:01 2009 @@ -46,27 +46,17 @@ Configuration - -%a - +%A Hi Zoe, Is there documentation on this change? I'm finding it a little bit arbitrary that run-tests keeps changing basic stuff so often, it's making me split tests simply to have a different EXPECTF for php 5.2 vs. 5.3. First it was %s, then %a, and now %A to match multi-line? Thanks, Greg -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] Re: cvs: php-src(PHP_5_3) /ext/standard/tests/general_functions phpinfo.phpt
Hi Zoe, Is there documentation on this change? Hi Greg - you mean the change I made to the phpinfo.phpt test? If so I changed it because it was failing and should not have been. Or do you mean changes to run-tests.php options? I'm finding it a little bit arbitrary that run-tests keeps changing basic stuff so often, it's making me split tests simply to have a different EXPECTF for php 5.2 vs. 5.3. First it was %s, then %a, and now %A to match multi-line? Sure - all the --EXPECTF-- options are documented here http://qa.php.net/expectf_details.php, and, as far as I'm aware all the EXPECTF options should be common to PHP 52, PHP 53 and PHP 6. If they aren't then it's an oversight and I'll be happy to fix. I don't think any of them should require changes to existing tests. Zoe -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
[PHP-CVS] Re: cvs: php-src(PHP_5_3) /ext/standard/tests/general_functions phpinfo.phpt
zoe wrote: Hi Zoe, Is there documentation on this change? Hi Greg - you mean the change I made to the phpinfo.phpt test? If so I changed it because it was failing and should not have been. Or do you mean changes to run-tests.php options? I meant to run-tests.php. I'm finding it a little bit arbitrary that run-tests keeps changing basic stuff so often, it's making me split tests simply to have a different EXPECTF for php 5.2 vs. 5.3. First it was %s, then %a, and now %A to match multi-line? Sure - all the --EXPECTF-- options are documented here http://qa.php.net/expectf_details.php, and, as far as I'm aware all the EXPECTF options should be common to PHP 52, PHP 53 and PHP 6. If they aren't then it's an oversight and I'll be happy to fix. I don't think any of them should require changes to existing tests. Thanks, this is very helpful, and answers all of my questions. Greg -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
