Re: [PHP-CVS] cvs: php-src /ext/mysql php_mysql.c /ext/mysqli mysqli_api.c mysqli_driver.c mysqli_prop.c /ext/pdo_mysql mysql_statement.c

2009-05-20 Thread Kalle Sommer Nielsen
Hi 2009/5/20 Andrey Hristov : > > could you mail me the list of warnings which you see. I try to compile > without any warnings and my latest builds didn't have warnings. So, as long > as I get the list I will try to take care of them. > Thanks ext\mysqlnd\mysqlnd_debug.c(317) : warning C4018: '>

Re: [PHP-CVS] cvs: php-src /ext/mysql php_mysql.c /ext/mysqli mysqli_api.c mysqli_driver.c mysqli_prop.c /ext/pdo_mysql mysql_statement.c

2009-05-20 Thread Andrey Hristov
Kalle Sommer Nielsen wrote: Hi Andrey 2009/5/20 Andrey Hristov : Hi, - if (rc == (my_ulonglong)-1) { + if (rc == (long)-1) { This is not correct. Maybe you have 64bit box, but 32bit machines are still out there and this will be bad. my_ulonglong is 8 byte and -1,

Re: [PHP-CVS] cvs: php-src /ext/mysql php_mysql.c /ext/mysqli mysqli_api.c mysqli_driver.c mysqli_prop.c /ext/pdo_mysql mysql_statement.c

2009-05-20 Thread Kalle Sommer Nielsen
Hi Andrey 2009/5/20 Andrey Hristov : >  Hi, > > > -               if (rc == (my_ulonglong)-1) { > +               if (rc == (long)-1) { > > This is not correct. Maybe you have 64bit box, but 32bit machines are still > out there and this will be bad. my_ulonglong is 8 byte and -1, will be the > max

Re: [PHP-CVS] cvs: php-src /ext/mysql php_mysql.c /ext/mysqli mysqli_api.c mysqli_driver.c mysqli_prop.c /ext/pdo_mysql mysql_statement.c

2009-05-20 Thread Andrey Hristov
Hi, Kalle Sommer Nielsen wrote: kalle Wed May 20 08:29:23 2009 UTC Modified files: /php-src/ext/mysql php_mysql.c /php-src/ext/mysqli mysqli_api.c mysqli_driver.c mysqli_prop.c /php-src/ext/pdo_mysql mysql_statement.c Log: Fix compiler warnings in e