Re: [PHP-DEV] RFC: Small changes in CODING_STANDARD

Zeev Suraski wrote: > At 09:50 18/03/2002, Yasuo Ohgaki wrote: > >> Markus Fischer wrote: >> >>> I wouldn't uset the word Heisenbugs. Not every developer is >>> familiar with it. Do you think it's possible to use a more >>> descriptive sentence? >> >> >> >> Oh. I agree. >> How about >

Re: [PHP-DEV] RFC: Small changes in CODING_STANDARD

At 09:50 18/03/2002, Yasuo Ohgaki wrote: >Markus Fischer wrote: >> I wouldn't uset the word Heisenbugs. Not every developer is >> familiar with it. Do you think it's possible to use a more >> descriptive sentence? > > >Oh. I agree. >How about > > - Do not use assignment in assert cond

Re: [PHP-DEV] RFC: Small changes in CODING_STANDARD

Markus Fischer wrote: > I wouldn't uset the word Heisenbugs. Not every developer is > familiar with it. Do you think it's possible to use a more > descriptive sentence? > Oh. I agree. How about - Do not use assignment in assert condition. If assignment is used, there is risk

Re: [PHP-DEV] Linking to older extension libraries

On Mon, 18 Mar 2002, Sam Minnee wrote: > I'm trying to upgrade from PHP 4.0.1 to anything 4.0.2+ on a Cobalt Qube 3. > I'm doing this to enable CURL support, which didn't arrive until 4.0.2. > > The problem is, that there are two libraries, i18n and cce, on the Cobalt > Qube 3, which exist only

Re: [PHP-DEV] RFC: README.SUBMMITING_PATCH

From past experience, I think that telling people to wait a few weeks before resubmitting it not realistic. If they don't get an answer within 3-4 days, chances are they won't get an answer at all, and they should ping us again... Maybe a small online interface for proposing patches (and not

Re: [PHP-DEV] RFC: Small changes in CODING_STANDARD

I wouldn't uset the word Heisenbugs. Not every developer is familiar with it. Do you think it's possible to use a more descriptive sentence? - Markus On Mon, Mar 18, 2002 at 03:42:21PM +0900, Yasuo Ohgaki wrote : > Hi all, > > Calling function may become a problem also. > Any c

Re: [PHP-DEV] Re: Leaking streams..

Just wondering - Wez, does it make sense to you that the leaks are gone? Didn't you only change the memory allocations to use the relay tracking feature of the memory manager, which should not actually effect the number of leaks? :) Zeev At 02:28 18/03/2002, Wez Furlong wrote: >On 18/03/02,

[PHP-DEV] RFC: README.SUBMMITING_PATCH

Hi all, We get questions like "where to send path?" on occasion. We should have doc for that. Here is a draft. Please fix/add/comment. Thank you. --README.SUBMITTING_PATCH--- Submitting Patch for PHP This document describes how to submit patch for PHP. How to

[PHP-DEV] RFC: Small changes in CODING_STANDARD

Hi all, Calling function may become a problem also. Any comments following changes? Index: CODING_STANDARDS === RCS file: /repository/php4/CODING_STANDARDS,v retrieving revision 1.12 diff -u -r1.12 CODING_STANDARDS --- CODING_STANDA

[PHP-DEV] file.c broken

c:\home\php\php4\ext\standard\file.c(243): warning C4047: 'function': Number of dereferences of 'char **' and 'void ***' different c:\home\php\php4\ext\standard\file.c(243) : warning C4024: '_php_stream_open_wra pper' : Unterschiedliche Typen fuer formalen und uebergebenen Parameter 4 c:\home\ph

[PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/exif exif.c

Hi Wez, Thanks for your comments. After having some problems with the new functions i switched to use php_stream_open_wrapper( STREAM_MUST_SEEK now. If have the following annotations to streams: 1) i do not like the style of how to determine the kine of a stream instead of #define php_stream_is(st

Re: [PHP-DEV] Where to send the patch

You usually send a unified diff to the php-dev@lists and if people are interested things are getting discussed. On Mon, Mar 18, 2002 at 10:34:48AM +0530, S.Murali Krishna wrote : > Dear all, > > If anybody knows perl and its AUTOLOAD method, read the following. > > I have bee

Re: [PHP-DEV] [PATCH] Unsigned Right Shift Operator

Note: there is a slight WS fix in this patch. (A couple of lines had trailing spaces) On Sun, 2002-03-17 at 23:22, Jason Greene wrote: > After a short discussion on the zend-engine-2 list about handling > unsigned values I decided to write a quick patch (Attached) that adds an > unsigned right sh

Re: [PHP-DEV] getting the path to the php executable

At 05:11 18.03.2002, you wrote: >is there a way to get the path of the current php executable for the cli >and cgi sapi implementations? this would be nice so that run-tests.php >could run its subprocesses with the same executable that it was run with >(so you could run the tests with a particular

[PHP-DEV] [PATCH] Unsigned Right Shift Operator

After a short discussion on the zend-engine-2 list about handling unsigned values I decided to write a quick patch (Attached) that adds an unsigned right shift operator, and an unsigned right shift assign operator (Similar to Java). The following code/output displays the difference: Code: > 31;

[PHP-DEV] Where to send the patch

Dear all, If anybody knows perl and its AUTOLOAD method, read the following. I have been in search for the above feauture in PHP quite long time. Even I tried with ErrorHandler settings but it didn't worked for me. so I modified zend engine source code to meet my req

[PHP-DEV] getting the path to the php executable

is there a way to get the path of the current php executable for the cli and cgi sapi implementations? this would be nice so that run-tests.php could run its subprocesses with the same executable that it was run with (so you could run the tests with a particular php executable without having to ma

[PHP-DEV] Linking to older extension libraries

I'm trying to upgrade from PHP 4.0.1 to anything 4.0.2+ on a Cobalt Qube 3. I'm doing this to enable CURL support, which didn't arrive until 4.0.2. The problem is, that there are two libraries, i18n and cce, on the Cobalt Qube 3, which exist only in a binary form .so. Now, when I try and upgrade

Re: [PHP-DEV] 1 byte overflow in wordwrap

On Mon, Mar 18, 2002 at 12:34:12AM +, Wez Furlong wrote: > debug("wordwrap: char=" . ord($char) . " cut=" . $cut); you must be using a multi-character linebreak (probably "\r\n"). otherwise the allocation that is being overflown would not be made ('cause it is in the multi-character-line-en

Re: [PHP-DEV] 1 byte overflow in wordwrap

On 18/03/02, "Jim Winstead" <[EMAIL PROTECTED]> wrote: > the easiest way to track it down would be to insert some debugging > statements in the wordwrap() function to print out the text being > wrapped, the newtextlen that gets calculated, and then value of > newtextlen at the end of the function.

Re: [PHP-DEV] Re: Leaking streams..

On 18/03/02, "Jani Taskinen" <[EMAIL PROTECTED]> wrote: > Well..with latest CVS I don't get any leak log entries. Great! --Wez. -- PHP Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: [PHP-CVS] cvs: php4 /main network.c

Read previous posts for the reason and proper fixes. Jim Winstead wrote: > please knock off this pointless ranting about ANSI compliance. > > jim Feel free to change CODING_STANDARD :) But, one _MUST_ change rule frist. Don't argue it was broken for a long time. ;) -- Yasuo Ohgaki -- PHP D

Re: [PHP-DEV] Re: Leaking streams..

Well..with latest CVS I don't get any leak log entries. --Jani On Sun, 17 Mar 2002, Wez Furlong wrote: >Jani, > >I've made the streams code use the memory manager in a more >clever way; could you try with latest CVS and report the >leak output again. > >Thanks! > >--Wez.

[PHP-DEV] Re: Leaking streams..

Jani, I've made the streams code use the memory manager in a more clever way; could you try with latest CVS and report the leak output again. Thanks! --Wez. On 17/03/02, "Jani Taskinen" <[EMAIL PROTECTED]> wrote: > I get these leaks with even this script: > > -- PHP Development

Re: [PHP-DEV] Bug #16128

On Sun, 17 Mar 2002, Stefan Esser wrote: > The problem is, that php_checkuid was broken since PHP 4.? > > move_uploaded_file doesn't check openbasedir restriction > should we add that? We should IMO. Derick ---

Re: [PHP-DEV] Bug #16128

> The problem is, that php_checkuid was broken since PHP 4.? Yeah, silly typo. > move_uploaded_file doesn't check openbasedir restriction > should we add that? I think so. -Rasmus -- PHP Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Bug #16128

Hi, The problem is, that php_checkuid was broken since PHP 4.? move_uploaded_file doesn't check openbasedir restriction should we add that? Stefan -- PHP Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] 1 byte overflow in wordwrap

On 18/03/02, "Jim Winstead" <[EMAIL PROTECTED]> wrote: > Wez Furlong <[EMAIL PROTECTED]> wrote: > > I'll see if I can force it to happen in isolation. > are you passing a fourth parameter to wordwrap? Yes; it's always 0. > the easiest way to track it down would be to insert some debugging > sta

Re: [PHP-DEV] 1 byte overflow in wordwrap

Wez Furlong <[EMAIL PROTECTED]> wrote: > I'll see if I can force it to happen in isolation. are you passing a fourth parameter to wordwrap? the easiest way to track it down would be to insert some debugging statements in the wordwrap() function to print out the text being wrapped, the newtextlen

Re: [PHP-DEV] 1 byte overflow in wordwrap

Hi Derick, I'm afraid I can't; it's part of this web based email system and it's just a bit too complicated. It's only occasional, and it seems to be only when it actually does the wrapping. A bit lame I'm afraid :-/ I'll see if I can force it to happen in isolation. --Wez. On 18/03/02, [E

[PHP-DEV] RFC: CLI alone

The following patch enables a CLI build without having CGI. Any suggestions? marcus diff -u -w -r1.163 acinclude.m4 --- acinclude.m413 Mar 2002 16:59:49 - 1.163 +++ acinclude.m417 Mar 2002 17:14:09 - @@ -126,6 +126,14 @@ ]) dnl +dnl Disable building CGI +dnl +AC

[PHP-DEV] CVS Account Request: paulr

[16:53] apply for CVS, say I sent you / for qa... then stuff can get added as documents, and then some serious programming will happen -- PHP Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] RFC: user-space streams ?

That would be really cool!!! +398473 on this! One small point: I think it would be better if the function names have more descriptive names, like stream_open(), stream_close(), etc. Sander On 2002.03.17 15:37 Wez Furlong wrote: > I thought it might be nice to allow people writing class > librar

Re: [PHP-DEV] [PATCH] ftp extension safe_mode awareness patch

On Sun, 17 Mar 2002 [EMAIL PROTECTED] wrote: > On Sun, Mar 17, 2002 at 03:12:27PM +0100, [EMAIL PROTECTED] wrote: > > > > Do you mean 'uploaded' or 'downloaded' here? > > > > depends on your point of view ;) downloaded to the php server, uploaded onto > the php server. (anyway meant are files

Re: [PHP-DEV] [PATCH] ftp extension safe_mode awareness patch

On Sun, Mar 17, 2002 at 03:12:27PM +0100, [EMAIL PROTECTED] wrote: > > Do you mean 'uploaded' or 'downloaded' here? > depends on your point of view ;) downloaded to the php server, uploaded onto the php server. (anyway meant are files retrieved with ftp_get) stefan -- PHP Development Mailin

[PHP-DEV] BSDi 4.x compatibility updates (BUG #14048)

Hi, after some digging, I've modified configure.in against PHP_4_2_0. The patch resolves all issues mentioned in the bugreport. I saw something fly by in configure, which checks the include type of make, but that isn't working correctly or overridden by the hardcoded section, so that fix should

Re: [PHP-DEV] 1 byte overflow in wordwrap

Hey, can you send me/the list a small reproducing example? Derick On Sun, 17 Mar 2002, Wez Furlong wrote: > Can anyone else verify this: > > /home/wez/src/php/PHPDEV/Zend/zend_execute_API.c(274) : Block 0x08C56B88 status: > /home/wez/src/php/PHPDEV/Zend/zend_variables.c(44) : Actual location

[PHP-DEV] 1 byte overflow in wordwrap

Can anyone else verify this: /home/wez/src/php/PHPDEV/Zend/zend_execute_API.c(274) : Block 0x08C56B88 status: /home/wez/src/php/PHPDEV/Zend/zend_variables.c(44) : Actual location (location was relayed) Beginning: OK (allocated on /home/wez/src/php/PHPDEV/ext/standard/string.c:670, 142 byte

[PHP-DEV] Re: Leaking streams..

I can't reproduce it :-/ I don't suppose you could run through that script with a debugger and find out where the stream was opened could you? (I know it's a PITA - sorry!). I'll see if I can make the streams use the debug memory manager stuff to make this easier. --Wez. On 17/03/02, "Jani Tas

[PHP-DEV] IGNORE_URL_WIN

Is there are reason why the wrappers are ignored only for windows in gd.c and main.c:php_fopen_wrapper_for_zend ? If so, does it still apply, and should it be more widely used? --Wez. -- PHP Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Leaking streams..

I get these leaks with even this script: --Jani On Sun, 17 Mar 2002, Wez Furlong wrote: >Hmmm; I don't have leaks here with normal stuff. >Which sapi are you using? > >Can you give me a script that reproduces it? > >--Wez. > >On 17/03/02, "Jani Taskinen" <[EMAIL PROT

[PHP-DEV] RFC: user-space streams ?

I thought it might be nice to allow people writing class libraries in PHP/PEAR to be able to roll-their-own streams using PHP code. It would be implemented something like the user-mode session module handler, but a bit more OO; they would declare a class (see below) and register it as a wrapper u

Re: [PHP-DEV] [PATCH] ftp extension safe_mode awareness patch

On Sun, 17 Mar 2002 [EMAIL PROTECTED] wrote: > Hi, > > I want your comments. This patch adds safe_mode awareness to the > ftp extension. It was done against the 4.2.0 tree because there > must be some changes in the extension because of streams and so > i wanted to ensure that it is working firs

[PHP-DEV] [PATCH] ftp extension safe_mode awareness patch

Hi, I want your comments. This patch adds safe_mode awareness to the ftp extension. It was done against the 4.2.0 tree because there must be some changes in the extension because of streams and so i wanted to ensure that it is working first. This patch modifies: is_uploaded_file : works now als

Re: [PHP-DEV] Re: memory streams

On 17/03/02, "Marcus Börger" <[EMAIL PROTECTED]> wrote: > they do an auto resize so append will work but you can also use > seek to overwrite in a memory stream. Great! > >I'm planning an API that will give you back a seekable stream > >so the logic to determine when and what type of alternativ

Re: [PHP-DEV] Re: ext/ming doesn't compile..r

Hmmm; I don't have leaks here with normal stuff. Which sapi are you using? Can you give me a script that reproduces it? --Wez. On 17/03/02, "Jani Taskinen" <[EMAIL PROTECTED]> wrote: > Those leaks weren't ming related at all. > Just 'normal' stuff in PHP. ie. file(), fopen(), > include(

[PHP-DEV] Re: memory streams

Thanks! --Wez. On 17/03/02, "Marcus Börger" wrote: > Found it. The error was in the register function: the size was incorrect > because > > only the pointer has to be stored and not a copy of the wrapper > itself. > > > - return > zend_hash_add(&url_stream_wrappers_hash, protoc

[PHP-DEV] Re: memory streams

Found it. The error was in the register function: the size was incorrect because only the pointer has to be stored and not a copy of the wrapper itself. -   return zend_hash_add(&url_stream_wrappers_hash, protocol, strlen(protocol), wrapper, sizeof(wrapper), NULL); +   retu

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/standard fsock.c

Sebastian Bergmann wrote: > The > > c:\home\php\php4\ext\standard\fsock.c(196): warning C4761: > Size conflict in argument > > warning persists, the others are gone. Fixed now. Thanks, Sebastian -- Sebastian Bergmann http://sebastian-bergmann.de/ http://phpOpen