On Sat, 28 Sep 2002, Zeev Suraski wrote:
> At 19:27 26/09/2002, David Viner wrote:
> >If the term "include" is not a good keyword, I'm also happy to rework the
> >patch to use any keyword the group prefers. "additional_ini" sounds good to
> >me, and probably doesn't carry the other control-struc
At 19:27 26/09/2002, David Viner wrote:
>If the term "include" is not a good keyword, I'm also happy to rework the
>patch to use any keyword the group prefers. "additional_ini" sounds good to
>me, and probably doesn't carry the other control-structure baggage.
I don't think that additional_ini c
I'd vote with Rasmus here. Adding an "include" statement (whatever it's
called) looks to be very low risk for inclusion in the 4.3 release.
I am a little uncomfortable with the auto-magic function to "include all
files in directory". I've been bitten more than a few times by "magic" that
didn't
> > + }
> > + }
> > +
> > +
> > + /* now free the resources we allocated to handle this include */
> > + if (php_included_ini_opened_path != NULL) {
> > + efree(php_included_ini_opened_path);
> > + }
> > +
> > +
}
> - strcat(php_ini_search_path, ".");
> - }
> -#endif
> -
> - /* Add binary directory */
> -#ifdef PHP_WIN32
> - binary_location = (char *) emalloc(MAXPATHLEN);
> - if (GetModuleFileName
orf'; 'Edin Kadribasic'
Subject: RE: [PHP-DEV] [PATCH] include statement in php.ini file
In general I agree with this proposal but I have some concerns, as I am
not familiar with the ini code these may be unfounded, introducing it
may well
1) Introduce Security Concerns depending
In general I agree with this proposal but I have some concerns, as I am
not familiar with the ini code these may be unfounded, introducing it
may well
1) Introduce Security Concerns depending on the time the ini file is
loaded (IF I have safe_mode = on then you include an ini file with
safe_mod
}
- strcat(php_ini_search_path, default_location);
-#endif
- }
+ /* build the search path */
+ free_ini_search_path = php_prepare_ini_search_path(&php_ini_search_path);
PG(safe_mode) = 0;
PG(open_basedir) = NULL;
@@ -333,7 +612,7 @@
> > I'm not very concerned either way on the .ini extension
> restriction.
> > Let's go ahead and commit this with the "include" to
> "additional_ini" name
> > change. Perhaps the commit will stir up more feedback since there
> has
> > been so little.
>
> Some feedback:
>
> +1 for additional_ini=
> I'm not very concerned either way on the .ini extension
restriction.
> Let's go ahead and commit this with the "include" to
"additional_ini" name
> change. Perhaps the commit will stir up more feedback since there
has
> been so little.
Some feedback:
+1 for additional_ini=/path/to/new/additio
d probably doesn't carry the other control-structure baggage.
>
>
> dave
>
> -Original Message-
> From: Rasmus Lerdorf [mailto:[EMAIL PROTECTED]]
> Sent: Thursday, September 26, 2002 5:17 AM
> To: Zeev Suraski
> Cc: David Viner; Php-Dev@lists. php. net
>
---Original Message-
From: Rasmus Lerdorf [mailto:[EMAIL PROTECTED]]
Sent: Thursday, September 26, 2002 5:17 AM
To: Zeev Suraski
Cc: David Viner; Php-Dev@lists. php. net
Subject: RE: [PHP-DEV] [PATCH] include statement in php.ini file
I suppose using a PHP keyword like include may lead to a
I suppose using a PHP keyword like include may lead to a desire for other
PHP keywords, perhaps something like:
additional_ini = /some/dir
additional_ini = /some/file.ini
Not sure why you want to limit it to one. Also, they can be nested, so in
/some/dir/foo.ini you might have:
additional_ini
I'm concerned that adding this directive will make lead to control
structures requirements. However, it is quite useful for modular
deployment; So, my suggestion is:
- Don't introduce 'include'
- Introduce a special 'additional_ini_directory' (name subject to change)
which will be read after
I don't see any obvious problems with this patch except for a couple of
extrananeos changes. I was a bit indisposed last week and didn't really
follow the discussion leading up to this, but I have read the archive. I
agree that going full out with PHP-parsed .ini files is going too far, but
being
prepare_ini_search_path(&php_ini_search_path);
PG(safe_mode) = 0;
PG(open_basedir) = NULL;
@@ -333,7 +605,7 @@
struct stat statbuf;
if (!VCWD_STAT(sapi_module.php_ini_path_override, &statbuf)) {
- if (!((statbuf.st_mode &am
Hi,
I've been working with Brian France on a patch that will allow users to
include other ini files from the php.ini (see
http://marc.theaimsgroup.com/?t=10317976671&r=1&w=2 for earlier
discussions). This patch allows the following functionality from the
php.ini file:
include = file
17 matches
Mail list logo
