Re: [PHP-DEV] emalloc() troubles

In mail.php.internals, Ari Pollak <[EMAIL PROTECTED]> wrote: > Hi there, I'm trying to hack mail.c to automatically pass a -f argument > to qmail with a return address, so that the Return-path of the message > is not always root@blah. Anyway, I seem to have been successful in this > endeavor, bu

Re: [PHP-DEV] emalloc() troubles

I didn't know you have cvs access. Then I'll leave the problem alone :) -- Yasuo Ohgaki Ari Pollak wrote: Again, I told you that I already fixed the problem from within PHP, but there's just one memory leak that I can't track down. On Sun, Dec 29, 2002 at 06:39:18PM +0900, Yasuo Ohgaki wrote:

Re: [PHP-DEV] emalloc() troubles

Again, I told you that I already fixed the problem from within PHP, but there's just one memory leak that I can't track down. On Sun, Dec 29, 2002 at 06:39:18PM +0900, Yasuo Ohgaki wrote: > I realized that now. Anyway, if there is problem with qmail, > I'll fix it iff I think it's really a proble

Re: [PHP-DEV] emalloc() troubles

Derick Rethans wrote: On Sat, 28 Dec 2002, Yasuo Ohgaki wrote: PHP shouldn't leak memory even if output/input from/to external program differs. It seems it's a PHP problem for this matter. If you had read the thread you would have seen that the memory leak is only there in his patch. I rea

Re: [PHP-DEV] emalloc() troubles

On Sat, 28 Dec 2002, Yasuo Ohgaki wrote: > PHP shouldn't leak memory even if output/input from/to external program > differs. It seems it's a PHP problem for this matter. If you had read the thread you would have seen that the memory leak is only there in his patch. Derick > Ari Pollak wrote:

Re: [PHP-DEV] emalloc() troubles

Ari Pollak wrote: PHP isn't leaking memory, my modification to the mail() function is leaking memory, as said earlier in this thread, which is what's troubling me because I can't track down what's leaking. Ah. I see. I'm using qmail, but I don't realize problem you have mentioned. What kind of a

Re: [PHP-DEV] emalloc() troubles

PHP isn't leaking memory, my modification to the mail() function is leaking memory, as said earlier in this thread, which is what's troubling me because I can't track down what's leaking. Yasuo Ohgaki said: > PHP shouldn't leak memory even if output/input from/to external program > differs. It see

Re: [PHP-DEV] emalloc() troubles

PHP shouldn't leak memory even if output/input from/to external program differs. It seems it's a PHP problem for this matter. Are you sure your input to mail() is RFC compliant? Even if input is not RFC compliant, PHP shouldn't leak memory, though. -- Yasuo Ohgaki Ari Pollak wrote: Unless you c

Re: [PHP-DEV] emalloc() troubles

Unless you come up with a way to migrate 500+ virtualhosts to some other MTA, no, that is not feasible. You can think of qmail like minix in both author and license, in that the author is really arrogant about changing the way his software behaves even though it's not standards-compliant, and yo

Re: [PHP-DEV] emalloc() troubles

qmail devs == djb, right? If his support doesn't suffice (and you cant find it in the enormous un-merged patch contributions that seem to litter the qmail community websites), might I suggest a new MTA? Exim works quite nicely. George On Friday, December 27, 2002, at 10:49 AM, Ari Pollak wro

Re: [PHP-DEV] emalloc() troubles

On Fri, 27 Dec 2002, Ari Pollak wrote: > The problem is that there are no "qmail devs", and it's easier to fix > in PHP than in qmail. uhm, isn't qmail djb's "replacement for sendmail"? So I assume he wrote it right? I would be against adding hacks to PHP to work around bugs in qmail (or any o

Re: [PHP-DEV] emalloc() troubles

The problem is that there are no "qmail devs", and it's easier to fix in PHP than in qmail. -- PHP Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] emalloc() troubles

On Fri, 27 Dec 2002, Daniel Lorch wrote: > hi, > > > This works perfectly, there's just a single memory leak that keeps > > happening that I can't get rid of. > > My version doesn't leak :) At least I think it doesn't. If you're bored, have > a look at it: > > http://marc.theaimsgroup.com/?l

Re: [PHP-DEV] emalloc() troubles

hi, > This works perfectly, there's just a single memory leak that keeps > happening that I can't get rid of. My version doesn't leak :) At least I think it doesn't. If you're bored, have a look at it: http://marc.theaimsgroup.com/?l=php-dev&m=103927629711494&w=2 But your version has the adv

Re: [PHP-DEV] emalloc() troubles

This works perfectly, there's just a single memory leak that keeps happening that I can't get rid of. On Fri, Dec 27, 2002 at 02:33:37AM +0100, Daniel Lorch wrote: > hi, > > > Hi there, I'm trying to hack mail.c to automatically pass a -f argument > > to qmail with a return address, so that the

Re: [PHP-DEV] emalloc() troubles

hi, > Hi there, I'm trying to hack mail.c to automatically pass a -f argument > to qmail with a return address, so that the Return-path of the message > is not always root@blah. Anyway, I seem to have been successful in this > endeavor, but I have a slight problem - whenever my code gets execut

Re: [PHP-DEV] emalloc() troubles

Doh, I hadn't even thought of that, because it was called the same way earlier in the function, but I just realized that line assigned it to one of the function parameters, so it doesn't actually overwrite the original pointer (call by value). That got rid of one of the memleak errors, but the

Re: [PHP-DEV] emalloc() troubles

On Thu, 26 Dec 2002, Ari Pollak wrote: > Nope, the only thing between the emalloc() and the efree()s are strcpy, > strcat, and php_escape_shell_cmd calls. ah, the escape_shell thing duplicates your string. Derick -- - D

Re: [PHP-DEV] emalloc() troubles

In case it helps anyone to have the entire code to look at, attached is a patch against mail.c that contains all my changes. > On Thu, 26 Dec 2002, Ari Pollak wrote: > > > Hi there, I'm trying to hack mail.c to automatically pass a -f argument > > to qmail with a return address, so that the Ret

Re: [PHP-DEV] emalloc() troubles

Nope, the only thing between the emalloc() and the efree()s are strcpy, strcat, and php_escape_shell_cmd calls. On Thu, Dec 26, 2002 at 11:48:40AM +0100, Derick Rethans wrote: > Most likely you return from the function before you efree the variables > (with RETURN_* or return for example). > ---

Re: [PHP-DEV] emalloc() troubles

On Thu, 26 Dec 2002, Ari Pollak wrote: > Hi there, I'm trying to hack mail.c to automatically pass a -f argument > to qmail with a return address, so that the Return-path of the message > is not always root@blah. Anyway, I seem to have been successful in this > endeavor, but I have a slight pro