Fwd: [PHP-DEV] Bug id #11998 - source code patch - Dont Use Previous (fwd)
Guys, I commited the patch which is supposed to fix some file upload problems. I want to merge it into 4.0.7. Can a few of you please check the file upload in the latest CVS and mail us if it still works or not? I'll merge it once I get a couple of answers. Thanks, Andi Date: Fri, 21 Sep 2001 18:18:30 +0300 To: [EMAIL PROTECTED] From: Andi Gutmans [EMAIL PROTECTED] Subject: Fwd: [PHP-DEV] Bug id #11998 - source code patch - Dont Use Previous (fwd) Guys, I think this is the last problem which is holding up RC3 and hopefully 4.0.7. Does anyone here know the code in rfc1867? I don't know it well enough in order to decide if this patch is OK or not. If no one answers I'll apply it and we should as the QA guys to test file uploads extensively in RC3. Andi Date: Tue, 18 Sep 2001 17:22:41 +0200 (CEST) From: Jani Taskinen [EMAIL PROTECTED] Sender: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [PHP-DEV] Bug id #11998 - source code patch - Dont Use Previous (fwd) Could someone who knows the current code better check this out and apply this patch? My work for the other issues is not done yet..and it's too big of a change for this release. --Jani -- Forwarded message -- Date: Tue, 18 Sep 2001 03:21:52 +0200 (MEST) From: Ralf Bolte [EMAIL PROTECTED] To: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Subject: Bug id #11998 - source code patch - Dont Use Previous Sorry Sorry Sorry, about an hour ago i send you my patch for the critical BUG with the ID 11998. Unfourtunately, i sent a totally fucked up patch (file). DO NOT APPLY it. Here is the correct patch, with some additional checks and with the header end check finally working. Sorry for my mistake ;) My only apology is, that it is deep midnight here in germany *g* Yours, Ralf PS: as a side effect of my patch, the 30 files crash bug is fixed, too :) --- Weitergeleitete Nachricht / Forwarded Message --- Date: Tue, 18 Sep 2001 02:05:42 +0200 (MEST) From: Ralf Bolte [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Bug id #11998 - source code patch Hello, today i browsed through the php bug database on the search for critical bugs. I then saw Bug id #11998 which speaks of some bugs in rfc1867.c. Due to the fact i saw several flaws in the source code some time ago, i patched my version. I now send you my patch and the patch applied to the cvs snapshot of today, that fixes several bugs... first and foremost the fix that went into 4.0.6 was not only broken, but also implemented a possible NULL pointer dereference. The main problem with that fix was, that it applied the search end of headers functionality to the wrong place. The array upload was also crashable by simply using a name like invalid][ as var name. I fixed it by correcting the IF clause that decides if it is an array upload or not. In fact my fix consists of several stability fixes that also make the upload more robust against browsers that are not 100% rfc conform. Hope my patch helps you to improve php even more. I really like the whole idea of php and would be lucky if my contribution helps to make it even better than it already is. Yours, Ralf Bolte -- GMX - Die Kommunikationsplattform im Internet. http://www.gmx.net -- GMX - Die Kommunikationsplattform im Internet. http://www.gmx.net -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED] -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED] -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Fwd: [PHP-DEV] Bug id #11998 - source code patch - Dont Use Previous (fwd)
Guys, I think this is the last problem which is holding up RC3 and hopefully 4.0.7. Does anyone here know the code in rfc1867? I don't know it well enough in order to decide if this patch is OK or not. If no one answers I'll apply it and we should as the QA guys to test file uploads extensively in RC3. Andi Date: Tue, 18 Sep 2001 17:22:41 +0200 (CEST) From: Jani Taskinen [EMAIL PROTECTED] Sender: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [PHP-DEV] Bug id #11998 - source code patch - Dont Use Previous (fwd) Could someone who knows the current code better check this out and apply this patch? My work for the other issues is not done yet..and it's too big of a change for this release. --Jani -- Forwarded message -- Date: Tue, 18 Sep 2001 03:21:52 +0200 (MEST) From: Ralf Bolte [EMAIL PROTECTED] To: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Subject: Bug id #11998 - source code patch - Dont Use Previous Sorry Sorry Sorry, about an hour ago i send you my patch for the critical BUG with the ID 11998. Unfourtunately, i sent a totally fucked up patch (file). DO NOT APPLY it. Here is the correct patch, with some additional checks and with the header end check finally working. Sorry for my mistake ;) My only apology is, that it is deep midnight here in germany *g* Yours, Ralf PS: as a side effect of my patch, the 30 files crash bug is fixed, too :) --- Weitergeleitete Nachricht / Forwarded Message --- Date: Tue, 18 Sep 2001 02:05:42 +0200 (MEST) From: Ralf Bolte [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Bug id #11998 - source code patch Hello, today i browsed through the php bug database on the search for critical bugs. I then saw Bug id #11998 which speaks of some bugs in rfc1867.c. Due to the fact i saw several flaws in the source code some time ago, i patched my version. I now send you my patch and the patch applied to the cvs snapshot of today, that fixes several bugs... first and foremost the fix that went into 4.0.6 was not only broken, but also implemented a possible NULL pointer dereference. The main problem with that fix was, that it applied the search end of headers functionality to the wrong place. The array upload was also crashable by simply using a name like invalid][ as var name. I fixed it by correcting the IF clause that decides if it is an array upload or not. In fact my fix consists of several stability fixes that also make the upload more robust against browsers that are not 100% rfc conform. Hope my patch helps you to improve php even more. I really like the whole idea of php and would be lucky if my contribution helps to make it even better than it already is. Yours, Ralf Bolte -- GMX - Die Kommunikationsplattform im Internet. http://www.gmx.net -- GMX - Die Kommunikationsplattform im Internet. http://www.gmx.net -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED] rfc1867-real-bugfix.tar.gz -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] Bug id #11998 - source code patch - Dont Use Previous (fwd)
please check bug id 13385, i hope that this is my mistake or inappropriate build, but if i am not wrong, it is a serious thing... in short ? echo nl2br(asd\n\ndsa\r\rqwe\r\n\newq\n\r\r) ? hangs with latest cvs. b. - Original Message - From: Andi Gutmans [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Friday, September 21, 2001 6:18 PM Subject: Fwd: [PHP-DEV] Bug id #11998 - source code patch - Dont Use Previous (fwd) Guys, I think this is the last problem which is holding up RC3 and hopefully 4.0.7. Does anyone here know the code in rfc1867? I don't know it well enough in order to decide if this patch is OK or not. If no one answers I'll apply it and we should as the QA guys to test file uploads extensively in RC3. Andi Date: Tue, 18 Sep 2001 17:22:41 +0200 (CEST) From: Jani Taskinen [EMAIL PROTECTED] Sender: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [PHP-DEV] Bug id #11998 - source code patch - Dont Use Previous (fwd) Could someone who knows the current code better check this out and apply this patch? My work for the other issues is not done yet..and it's too big of a change for this release. --Jani -- Forwarded message -- Date: Tue, 18 Sep 2001 03:21:52 +0200 (MEST) From: Ralf Bolte [EMAIL PROTECTED] To: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Subject: Bug id #11998 - source code patch - Dont Use Previous Sorry Sorry Sorry, about an hour ago i send you my patch for the critical BUG with the ID 11998. Unfourtunately, i sent a totally fucked up patch (file). DO NOT APPLY it. Here is the correct patch, with some additional checks and with the header end check finally working. Sorry for my mistake ;) My only apology is, that it is deep midnight here in germany *g* Yours, Ralf PS: as a side effect of my patch, the 30 files crash bug is fixed, too :) --- Weitergeleitete Nachricht / Forwarded Message --- Date: Tue, 18 Sep 2001 02:05:42 +0200 (MEST) From: Ralf Bolte [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Bug id #11998 - source code patch Hello, today i browsed through the php bug database on the search for critical bugs. I then saw Bug id #11998 which speaks of some bugs in rfc1867.c. Due to the fact i saw several flaws in the source code some time ago, i patched my version. I now send you my patch and the patch applied to the cvs snapshot of today, that fixes several bugs... first and foremost the fix that went into 4.0.6 was not only broken, but also implemented a possible NULL pointer dereference. The main problem with that fix was, that it applied the search end of headers functionality to the wrong place. The array upload was also crashable by simply using a name like invalid][ as var name. I fixed it by correcting the IF clause that decides if it is an array upload or not. In fact my fix consists of several stability fixes that also make the upload more robust against browsers that are not 100% rfc conform. Hope my patch helps you to improve php even more. I really like the whole idea of php and would be lucky if my contribution helps to make it even better than it already is. Yours, Ralf Bolte -- GMX - Die Kommunikationsplattform im Internet. http://www.gmx.net -- GMX - Die Kommunikationsplattform im Internet. http://www.gmx.net -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED] -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED] -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] Bug id #11998 - source code patch - Dont Use Previous (fwd)
Seems like boyer_str_to_str() is buggy. If I change it to php_str_to_str() it seems to work. I think Sascha added this function but I might be wrong. Andi At 06:46 PM 9/21/2001 +0300, Boian Bonev wrote: please check bug id 13385, i hope that this is my mistake or inappropriate build, but if i am not wrong, it is a serious thing... in short ? echo nl2br(asd\n\ndsa\r\rqwe\r\n\newq\n\r\r) ? hangs with latest cvs. b. - Original Message - From: Andi Gutmans [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Friday, September 21, 2001 6:18 PM Subject: Fwd: [PHP-DEV] Bug id #11998 - source code patch - Dont Use Previous (fwd) Guys, I think this is the last problem which is holding up RC3 and hopefully 4.0.7. Does anyone here know the code in rfc1867? I don't know it well enough in order to decide if this patch is OK or not. If no one answers I'll apply it and we should as the QA guys to test file uploads extensively in RC3. Andi Date: Tue, 18 Sep 2001 17:22:41 +0200 (CEST) From: Jani Taskinen [EMAIL PROTECTED] Sender: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [PHP-DEV] Bug id #11998 - source code patch - Dont Use Previous (fwd) Could someone who knows the current code better check this out and apply this patch? My work for the other issues is not done yet..and it's too big of a change for this release. --Jani -- Forwarded message -- Date: Tue, 18 Sep 2001 03:21:52 +0200 (MEST) From: Ralf Bolte [EMAIL PROTECTED] To: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Subject: Bug id #11998 - source code patch - Dont Use Previous Sorry Sorry Sorry, about an hour ago i send you my patch for the critical BUG with the ID 11998. Unfourtunately, i sent a totally fucked up patch (file). DO NOT APPLY it. Here is the correct patch, with some additional checks and with the header end check finally working. Sorry for my mistake ;) My only apology is, that it is deep midnight here in germany *g* Yours, Ralf PS: as a side effect of my patch, the 30 files crash bug is fixed, too :) --- Weitergeleitete Nachricht / Forwarded Message --- Date: Tue, 18 Sep 2001 02:05:42 +0200 (MEST) From: Ralf Bolte [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Bug id #11998 - source code patch Hello, today i browsed through the php bug database on the search for critical bugs. I then saw Bug id #11998 which speaks of some bugs in rfc1867.c. Due to the fact i saw several flaws in the source code some time ago, i patched my version. I now send you my patch and the patch applied to the cvs snapshot of today, that fixes several bugs... first and foremost the fix that went into 4.0.6 was not only broken, but also implemented a possible NULL pointer dereference. The main problem with that fix was, that it applied the search end of headers functionality to the wrong place. The array upload was also crashable by simply using a name like invalid][ as var name. I fixed it by correcting the IF clause that decides if it is an array upload or not. In fact my fix consists of several stability fixes that also make the upload more robust against browsers that are not 100% rfc conform. Hope my patch helps you to improve php even more. I really like the whole idea of php and would be lucky if my contribution helps to make it even better than it already is. Yours, Ralf Bolte -- GMX - Die Kommunikationsplattform im Internet. http://www.gmx.net -- GMX - Die Kommunikationsplattform im Internet. http://www.gmx.net -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED] -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED] -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] Bug id #11998 - source code patch - Dont Use Previous(fwd)
On Fri, 21 Sep 2001, Andi Gutmans wrote: Seems like boyer_str_to_str() is buggy. If I change it to php_str_to_str() it seems to work. I think Sascha added this function but I might be wrong. I did not change nl2br though. I probably would have noticed that, if the commit message would not have been so tense: revision 1.238 - Fix for bug 11904 #- This is possibly not the best solution... feel free to improve - Sascha Experience IRCG http://schumann.cx/http://schumann.cx/ircg -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] Bug id #11998 - source code patch - Dont Use Previous (fwd)
currently i am rewriting the nl2br stuff. two reasons: 1. current ver does not handle nicely text with mixed dos/unix/mac line endings 2. using generic str_replace for exactly 1 or 2 chars is really slower (IMHO this is used too often to pay the 200-500 bytes code overhead) when it is stable, i'll post a patch b. - Original Message - From: Andi Gutmans [EMAIL PROTECTED] To: Boian Bonev [EMAIL PROTECTED]; [EMAIL PROTECTED] Cc: Sascha Schumann [EMAIL PROTECTED] Sent: Friday, September 21, 2001 7:13 PM Subject: Re: [PHP-DEV] Bug id #11998 - source code patch - Dont Use Previous (fwd) Seems like boyer_str_to_str() is buggy. If I change it to php_str_to_str() it seems to work. I think Sascha added this function but I might be wrong. Andi At 06:46 PM 9/21/2001 +0300, Boian Bonev wrote: please check bug id 13385, i hope that this is my mistake or inappropriate build, but if i am not wrong, it is a serious thing... in short ? echo nl2br(asd\n\ndsa\r\rqwe\r\n\newq\n\r\r) ? hangs with latest cvs. b. - Original Message - From: Andi Gutmans [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Friday, September 21, 2001 6:18 PM Subject: Fwd: [PHP-DEV] Bug id #11998 - source code patch - Dont Use Previous (fwd) Guys, I think this is the last problem which is holding up RC3 and hopefully 4.0.7. Does anyone here know the code in rfc1867? I don't know it well enough in order to decide if this patch is OK or not. If no one answers I'll apply it and we should as the QA guys to test file uploads extensively in RC3. Andi Date: Tue, 18 Sep 2001 17:22:41 +0200 (CEST) From: Jani Taskinen [EMAIL PROTECTED] Sender: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [PHP-DEV] Bug id #11998 - source code patch - Dont Use Previous (fwd) Could someone who knows the current code better check this out and apply this patch? My work for the other issues is not done yet..and it's too big of a change for this release. --Jani -- Forwarded message -- Date: Tue, 18 Sep 2001 03:21:52 +0200 (MEST) From: Ralf Bolte [EMAIL PROTECTED] To: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Subject: Bug id #11998 - source code patch - Dont Use Previous Sorry Sorry Sorry, about an hour ago i send you my patch for the critical BUG with the ID 11998. Unfourtunately, i sent a totally fucked up patch (file). DO NOT APPLY it. Here is the correct patch, with some additional checks and with the header end check finally working. Sorry for my mistake ;) My only apology is, that it is deep midnight here in germany *g* Yours, Ralf PS: as a side effect of my patch, the 30 files crash bug is fixed, too :) --- Weitergeleitete Nachricht / Forwarded Message --- Date: Tue, 18 Sep 2001 02:05:42 +0200 (MEST) From: Ralf Bolte [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Bug id #11998 - source code patch Hello, today i browsed through the php bug database on the search for critical bugs. I then saw Bug id #11998 which speaks of some bugs in rfc1867.c. Due to the fact i saw several flaws in the source code some time ago, i patched my version. I now send you my patch and the patch applied to the cvs snapshot of today, that fixes several bugs... first and foremost the fix that went into 4.0.6 was not only broken, but also implemented a possible NULL pointer dereference. The main problem with that fix was, that it applied the search end of headers functionality to the wrong place. The array upload was also crashable by simply using a name like invalid][ as var name. I fixed it by correcting the IF clause that decides if it is an array upload or not. In fact my fix consists of several stability fixes that also make the upload more robust against browsers that are not 100% rfc conform. Hope my patch helps you to improve php even more. I really like the whole idea of php and would be lucky if my contribution helps to make it even better than it already is. Yours, Ralf Bolte -- GMX - Die Kommunikationsplattform im Internet. http://www.gmx.net -- GMX - Die Kommunikationsplattform im Internet. http://www.gmx.net -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED] --- - -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list
Re: [PHP-DEV] Bug id #11998 - source code patch - Dont Use Previous(fwd)
On Fri, 21 Sep 2001, Andi Gutmans wrote: Seems like boyer_str_to_str() is buggy. If I change it to php_str_to_str() it seems to work. I think Sascha added this function but I might be wrong. When I added some support for MAC line endings, I was told boyer_str_to_Str() was the faster method... so I choose that one. Not knowing that it was still experimental. Maybe place a comment about things being experimental in the source next time would guard against this kind of problems Derick Andi At 06:46 PM 9/21/2001 +0300, Boian Bonev wrote: please check bug id 13385, i hope that this is my mistake or inappropriate build, but if i am not wrong, it is a serious thing... in short ? echo nl2br(asd\n\ndsa\r\rqwe\r\n\newq\n\r\r) ? hangs with latest cvs. b. - Original Message - From: Andi Gutmans [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Friday, September 21, 2001 6:18 PM Subject: Fwd: [PHP-DEV] Bug id #11998 - source code patch - Dont Use Previous (fwd) Guys, I think this is the last problem which is holding up RC3 and hopefully 4.0.7. Does anyone here know the code in rfc1867? I don't know it well enough in order to decide if this patch is OK or not. If no one answers I'll apply it and we should as the QA guys to test file uploads extensively in RC3. Andi Date: Tue, 18 Sep 2001 17:22:41 +0200 (CEST) From: Jani Taskinen [EMAIL PROTECTED] Sender: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [PHP-DEV] Bug id #11998 - source code patch - Dont Use Previous (fwd) Could someone who knows the current code better check this out and apply this patch? My work for the other issues is not done yet..and it's too big of a change for this release. --Jani -- Forwarded message -- Date: Tue, 18 Sep 2001 03:21:52 +0200 (MEST) From: Ralf Bolte [EMAIL PROTECTED] To: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Subject: Bug id #11998 - source code patch - Dont Use Previous Sorry Sorry Sorry, about an hour ago i send you my patch for the critical BUG with the ID 11998. Unfourtunately, i sent a totally fucked up patch (file). DO NOT APPLY it. Here is the correct patch, with some additional checks and with the header end check finally working. Sorry for my mistake ;) My only apology is, that it is deep midnight here in germany *g* Yours, Ralf PS: as a side effect of my patch, the 30 files crash bug is fixed, too :) --- Weitergeleitete Nachricht / Forwarded Message --- Date: Tue, 18 Sep 2001 02:05:42 +0200 (MEST) From: Ralf Bolte [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Bug id #11998 - source code patch Hello, today i browsed through the php bug database on the search for critical bugs. I then saw Bug id #11998 which speaks of some bugs in rfc1867.c. Due to the fact i saw several flaws in the source code some time ago, i patched my version. I now send you my patch and the patch applied to the cvs snapshot of today, that fixes several bugs... first and foremost the fix that went into 4.0.6 was not only broken, but also implemented a possible NULL pointer dereference. The main problem with that fix was, that it applied the search end of headers functionality to the wrong place. The array upload was also crashable by simply using a name like invalid][ as var name. I fixed it by correcting the IF clause that decides if it is an array upload or not. In fact my fix consists of several stability fixes that also make the upload more robust against browsers that are not 100% rfc conform. Hope my patch helps you to improve php even more. I really like the whole idea of php and would be lucky if my contribution helps to make it even better than it already is. Yours, Ralf Bolte -- GMX - Die Kommunikationsplattform im Internet. http://www.gmx.net -- GMX - Die Kommunikationsplattform im Internet. http://www.gmx.net -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED] -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED] -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] Bug id #11998 - source code patch - Dont Use Previous (fwd)
indeed boyer-moore is slower for short strings... anyway i have made a patch that addresses both mac/unix/dos line endings and also works with files that have different endings inside (imagine a file created on *nix edited under windows), which is a very common case. it is slightly slower than current ver (89 seconds before patch/92 seconds after patch for a very big test) but makes stuff more compatible. b. - Original Message - From: Derick Rethans [EMAIL PROTECTED] To: Andi Gutmans [EMAIL PROTECTED] Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED] Sent: Friday, September 21, 2001 8:14 PM Subject: Re: [PHP-DEV] Bug id #11998 - source code patch - Dont Use Previous (fwd) On Fri, 21 Sep 2001, Andi Gutmans wrote: Seems like boyer_str_to_str() is buggy. If I change it to php_str_to_str() it seems to work. I think Sascha added this function but I might be wrong. When I added some support for MAC line endings, I was told boyer_str_to_Str() was the faster method... so I choose that one. Not knowing that it was still experimental. Maybe place a comment about things being experimental in the source next time would guard against this kind of problems Derick Andi At 06:46 PM 9/21/2001 +0300, Boian Bonev wrote: please check bug id 13385, i hope that this is my mistake or inappropriate build, but if i am not wrong, it is a serious thing... in short ? echo nl2br(asd\n\ndsa\r\rqwe\r\n\newq\n\r\r) ? hangs with latest cvs. b. - Original Message - From: Andi Gutmans [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Friday, September 21, 2001 6:18 PM Subject: Fwd: [PHP-DEV] Bug id #11998 - source code patch - Dont Use Previous (fwd) Guys, I think this is the last problem which is holding up RC3 and hopefully 4.0.7. Does anyone here know the code in rfc1867? I don't know it well enough in order to decide if this patch is OK or not. If no one answers I'll apply it and we should as the QA guys to test file uploads extensively in RC3. Andi Date: Tue, 18 Sep 2001 17:22:41 +0200 (CEST) From: Jani Taskinen [EMAIL PROTECTED] Sender: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [PHP-DEV] Bug id #11998 - source code patch - Dont Use Previous (fwd) Could someone who knows the current code better check this out and apply this patch? My work for the other issues is not done yet..and it's too big of a change for this release. --Jani -- Forwarded message -- Date: Tue, 18 Sep 2001 03:21:52 +0200 (MEST) From: Ralf Bolte [EMAIL PROTECTED] To: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Subject: Bug id #11998 - source code patch - Dont Use Previous Sorry Sorry Sorry, about an hour ago i send you my patch for the critical BUG with the ID 11998. Unfourtunately, i sent a totally fucked up patch (file). DO NOT APPLY it. Here is the correct patch, with some additional checks and with the header end check finally working. Sorry for my mistake ;) My only apology is, that it is deep midnight here in germany *g* Yours, Ralf PS: as a side effect of my patch, the 30 files crash bug is fixed, too :) --- Weitergeleitete Nachricht / Forwarded Message --- Date: Tue, 18 Sep 2001 02:05:42 +0200 (MEST) From: Ralf Bolte [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Bug id #11998 - source code patch Hello, today i browsed through the php bug database on the search for critical bugs. I then saw Bug id #11998 which speaks of some bugs in rfc1867.c. Due to the fact i saw several flaws in the source code some time ago, i patched my version. I now send you my patch and the patch applied to the cvs snapshot of today, that fixes several bugs... first and foremost the fix that went into 4.0.6 was not only broken, but also implemented a possible NULL pointer dereference. The main problem with that fix was, that it applied the search end of headers functionality to the wrong place. The array upload was also crashable by simply using a name like invalid][ as var name. I fixed it by correcting the IF clause that decides if it is an array upload or not. In fact my fix consists of several stability fixes that also make the upload more robust against browsers that are not 100% rfc conform. Hope my patch helps you to improve php even more. I really like the whole idea of php and would be lucky if my contribution helps to make it even better than it already is. Yours, Ralf Bolte -- GMX - Die Kommunikationsplattform im Internet. http://www.gmx.net -- GMX - Die
Re: [PHP-DEV] Bug id #11998 - source code patch - Dont Use Previous (fwd)
Is this something which should make it into RC3? Why are there two .tar.gz files attached? Andi At 05:22 PM 9/18/2001 +0200, Jani Taskinen wrote: Could someone who knows the current code better check this out and apply this patch? My work for the other issues is not done yet..and it's too big of a change for this release. --Jani -- Forwarded message -- Date: Tue, 18 Sep 2001 03:21:52 +0200 (MEST) From: Ralf Bolte [EMAIL PROTECTED] To: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Subject: Bug id #11998 - source code patch - Dont Use Previous Sorry Sorry Sorry, about an hour ago i send you my patch for the critical BUG with the ID 11998. Unfourtunately, i sent a totally fucked up patch (file). DO NOT APPLY it. Here is the correct patch, with some additional checks and with the header end check finally working. Sorry for my mistake ;) My only apology is, that it is deep midnight here in germany *g* Yours, Ralf PS: as a side effect of my patch, the 30 files crash bug is fixed, too :) --- Weitergeleitete Nachricht / Forwarded Message --- Date: Tue, 18 Sep 2001 02:05:42 +0200 (MEST) From: Ralf Bolte [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Bug id #11998 - source code patch Hello, today i browsed through the php bug database on the search for critical bugs. I then saw Bug id #11998 which speaks of some bugs in rfc1867.c. Due to the fact i saw several flaws in the source code some time ago, i patched my version. I now send you my patch and the patch applied to the cvs snapshot of today, that fixes several bugs... first and foremost the fix that went into 4.0.6 was not only broken, but also implemented a possible NULL pointer dereference. The main problem with that fix was, that it applied the search end of headers functionality to the wrong place. The array upload was also crashable by simply using a name like invalid][ as var name. I fixed it by correcting the IF clause that decides if it is an array upload or not. In fact my fix consists of several stability fixes that also make the upload more robust against browsers that are not 100% rfc conform. Hope my patch helps you to improve php even more. I really like the whole idea of php and would be lucky if my contribution helps to make it even better than it already is. Yours, Ralf Bolte -- GMX - Die Kommunikationsplattform im Internet. http://www.gmx.net -- GMX - Die Kommunikationsplattform im Internet. http://www.gmx.net -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED] -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
Re: [PHP-DEV] Bug id #11998 - source code patch - Dont Use Previous (fwd)
Yes, it should be in RC3. And no, I don't know why there were too packages. Ralf, can you explain? :) --Jani Ehmm, sorry, with my second mail i sent the fixed fix and the corrupt fix. This was due to the use of this webmailer here. I did not notice that it attached the wrong version again, too. So I hope you understood, that real-bugfix was the correct stuff and that bugfix was again the midnight broken patch ;) thanks, ralf ps: i hope this time i am not sending any attachment ;) after a whole day fighting nimda in the company its time for a beer ;) -- GMX - Die Kommunikationsplattform im Internet. http://www.gmx.net -- PHP Development Mailing List http://www.php.net/ To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] To contact the list administrators, e-mail: [EMAIL PROTECTED]
