This feature request (which seems worth doing) has sat on the back burner
awhile. Probably because, in the words of one commenter, those who can
produce the patch are just using regex instead.
I've got an implementation put together, the patch for which can be viewed
at:
I've got an implementation put together, the patch for which can be
viewed at:
http://169.229.139.97/test/str_ireplace.diff.txt
After some comments on IRC, here's an alternate version to the above
patch. This second approach avoids creating php_memnstri by simply
searching through a copy of
Derick Rethans wrote:
On Wed, 29 Jan 2003, Sara Golemon wrote:
I've got an implementation put together, the patch for which can be
viewed at:
http://169.229.139.97/test/str_ireplace.diff.txt
After some comments on IRC, here's an alternate version to the above
patch. This second approach
I may be wrong since I haven't profiled this, but my understanding is
that str_replace is much faster than doing either of the regex
replacements. For that reason alone, there is a use for it.
Normally it would be quite faster, however once case sensitivity is added to
the mix I believe the
I may be wrong since I haven't profiled this, but my understanding is
that str_replace is much faster than doing either of the regex
replacements. For that reason alone, there is a use for it.
Normally it would be quite faster, however once case sensitivity is
added to the mix I believe
Ilia A. wrote:
I may be wrong since I haven't profiled this, but my understanding is
that str_replace is much faster than doing either of the regex
replacements. For that reason alone, there is a use for it.
Normally it would be quite faster, however once case sensitivity is added to
the mix
whoops, missent just to sascha instead of list...
On a related topic, the 'boyer' option of str_replace isn't even
documented. That alternate method of performing str_replaces look
like it's a bit more efficient (no benchmarkes atm) but I'm wondering
if there's a specific reasons why it
On Thu, 30 Jan 2003 06:48, Ilia A. wrote:
I may be wrong since I haven't profiled this, but my understanding is
that str_replace is much faster than doing either of the regex
replacements. For that reason alone, there is a use for it.
Normally it would be quite faster, however once case
Gah.
I botched that, I didn't reset the timer.
Total Time: 00:00:03.08 //str_replace
Total Time: 00:00:04.32 //preg_replace
Total Time: 00:00:03.05 //str_replace
Total Time: 00:00:03.67 //preg_replace
Total Time: 00:00:03.27 //str_replace
Total Time: 00:00:04.40 //preg_replace
Closer than I
On January 29, 2003 04:35 pm, Shane Caraveo wrote:
What's the benchmark code? How is the benchmark difference on large
text (ie. 100K of text) vs. small text (1K or smaller)?
Attached is the benchmark script that I've used. I've intentionally used
'small' strings, since that is what I imagine
On Thu, 30 Jan 2003 09:09, Ilia A. wrote:
On January 29, 2003 04:35 pm, Shane Caraveo wrote:
What's the benchmark code? How is the benchmark difference on large
text (ie. 100K of text) vs. small text (1K or smaller)?
Attached is the benchmark script that I've used. I've intentionally used
better and better...
Ilia offered up an optimized version of php_str_to_str which skips string
resizing and handles do-no-work scenarios up front.
I've made necessary changes to make this case_optional and made a new patch:
http://169.229.139.97/test/str_ireplace.diff-4.txt
as well as posting
I don't even see the speed difference as an issue as much as (A)
simplicity for the user who hasn't figured out regex yet, (B) consistency
(we have 'i' versions of most other string functions, why not this one?)
+1 for the reasons stated above.
Edin
--
PHP Development Mailing List
At 00:47 30.01.2003, Edin Kadribasic wrote:
I don't even see the speed difference as an issue as much as (A)
simplicity for the user who hasn't figured out regex yet, (B) consistency
(we have 'i' versions of most other string functions, why not this one?)
+1 for the reasons stated above.
+1
better and better...
One last optimization to save memcpys when needle_len == str_len (thanks
again ilia):
Actual Patch:
http://169.229.139.97/test/str_ireplace.diff-5.txt
Resultant string.c for easy reading:
http://169.229.139.97/test/string-5.c
I've heard enough Ayes over Nays (here, in
15 matches
Mail list logo
