Re: [PHPTAL] PHP content in templates
I don't think this behavior was in the older versions, you can download the older version and check it out. On Mon, May 21, 2012 at 4:18 AM, Robert Goldsmith wrote: > Hello :) > > I was actually surprised that the behaviour existed in the first place > simply because it appears to go against the entire ethos of PHPTAL. If I > was to consider such a thing as a 'strict' mode I'd prob. have suggested > instead that there was a 'transitional' mode to allow porting of templates > but which was off by default and not recommended for continued use :) > > Anyhow, that is beside the point and I think a first step might be to at > least mention this in the documentation and possibly supply a pre-filter > for those who don't want to be able to use php within a template :) > > Robert > > > So, you are trying to subtly suggest having a strict mode which uses a > pre-filter to turn this behavior off? However, I like the current behavior > because it allows me to slowly migrate old pages over to phptal. Also, it > allows me to write a pre-filter that allows me to see what code hasn't been > changed. > > > > On Fri, May 18, 2012 at 9:16 AM, Robert Goldsmith < > rgoldsm...@names.co.uk> wrote: > > well, yes, "don't do it" is one approach but we will have a large number > of people with the ability to edit these templates and we intended them to > be pretty idiot-proof (which allowing embedded php is not). > > > > A pre-filter sounds like a good idea. > > > > TBH, we were rather surprised because what's the point in the php: > functionality if you can just embed php? > > > > Robert > > > > Robert Goldsmith > > rgoldsm...@names.co.uk > > > > > > > > > > On 18 May 2012, at 14:10, ajcri...@gmail.com wrote: > > > > > Don't do it? > > > > > > You can create a pre-filter that strips those from the source > > > --Original Message-- > > > From: Robert Goldsmith > > > Sender: phptal-boun...@lists.motion-twin.com > > > To: Template Attribute Language for PHP > > > ReplyTo: Template Attribute Language for PHP > > > Subject: [PHPTAL] PHP content in templates > > > Sent: May 18, 2012 09:07 > > > > > > Hello :) > > > > > > We've noticed you can just drop in a tal template > and it will drop it in the compiled template file and execute it. This is > not something we want to happen so any suggestions on the best way to > prevent it? > > > > > > Robert > > > > > > Robert Goldsmith > > > rgoldsm...@names.co.uk > > > > > > > > > > > > > > > > > > ___ > > > PHPTAL mailing list > > > PHPTAL@lists.motion-twin.com > > > http://lists.motion-twin.com/mailman/listinfo/phptal > > > > > > Sent via BlackBerry by AT&T > > > > > > ___ > > > PHPTAL mailing list > > > PHPTAL@lists.motion-twin.com > > > http://lists.motion-twin.com/mailman/listinfo/phptal > > > > > > ___ > > PHPTAL mailing list > > PHPTAL@lists.motion-twin.com > > http://lists.motion-twin.com/mailman/listinfo/phptal > > > > ___ > > PHPTAL mailing list > > PHPTAL@lists.motion-twin.com > > http://lists.motion-twin.com/mailman/listinfo/phptal > > > ___ > PHPTAL mailing list > PHPTAL@lists.motion-twin.com > http://lists.motion-twin.com/mailman/listinfo/phptal > ___ PHPTAL mailing list PHPTAL@lists.motion-twin.com http://lists.motion-twin.com/mailman/listinfo/phptal
Re: [PHPTAL] PHP content in templates
+1 for additions in documentation and prefilter. On Monday, May 21, 2012, Robert Goldsmith wrote: > Hello :) > > I was actually surprised that the behaviour existed in the first place > simply because it appears to go against the entire ethos of PHPTAL. If I > was to consider such a thing as a 'strict' mode I'd prob. have suggested > instead that there was a 'transitional' mode to allow porting of templates > but which was off by default and not recommended for continued use :) > > Anyhow, that is beside the point and I think a first step might be to at > least mention this in the documentation and possibly supply a pre-filter > for those who don't want to be able to use php within a template :) > > Robert > > > So, you are trying to subtly suggest having a strict mode which uses a > pre-filter to turn this behavior off? However, I like the current behavior > because it allows me to slowly migrate old pages over to phptal. Also, it > allows me to write a pre-filter that allows me to see what code hasn't been > changed. > > > > On Fri, May 18, 2012 at 9:16 AM, Robert Goldsmith < > rgoldsm...@names.co.uk > wrote: > > well, yes, "don't do it" is one approach but we will have a large number > of people with the ability to edit these templates and we intended them to > be pretty idiot-proof (which allowing embedded php is not). > > > > A pre-filter sounds like a good idea. > > > > TBH, we were rather surprised because what's the point in the php: > functionality if you can just embed php? > > > > Robert > > > > Robert Goldsmith > > rgoldsm...@names.co.uk > > > > > > > > > > On 18 May 2012, at 14:10, ajcri...@gmail.com wrote: > > > > > Don't do it? > > > > > > You can create a pre-filter that strips those from the source > > > --Original Message-- > > > From: Robert Goldsmith > > > Sender: phptal-boun...@lists.motion-twin.com > > > To: Template Attribute Language for PHP > > > ReplyTo: Template Attribute Language for PHP > > > Subject: [PHPTAL] PHP content in templates > > > Sent: May 18, 2012 09:07 > > > > > > Hello :) > > > > > > We've noticed you can just drop in a tal template > and it will drop it in the compiled template file and execute it. This is > not something we want to happen so any suggestions on the best way to > prevent it? > > > > > > Robert > > > > > > Robert Goldsmith > > > rgoldsm...@names.co.uk > > > > > > > > > > > > > > > > > > ___ > > > PHPTAL mailing list > > > PHPTAL@lists.motion-twin.com > > > http://lists.motion-twin.com/mailman/listinfo/phptal > > > > > > Sent via BlackBerry by AT&T > > > > > > ___ > > > PHPTAL mailing list > > > PHPTAL@lists.motion-twin.com > > > http://lists.motion-twin.com/mailman/listinfo/phptal > > > > > > ___ > > PHPTAL mailing list > > PHPTAL@lists.motion-twin.com > > http://lists.motion-twin.com/mailman/listinfo/phptal > > > > ___ > > PHPTAL mailing list > > PHPTAL@lists.motion-twin.com > > http://lists.motion-twin.com/mailman/listinfo/phptal > > > ___ > PHPTAL mailing list > PHPTAL@lists.motion-twin.com > http://lists.motion-twin.com/mailman/listinfo/phptal > ___ PHPTAL mailing list PHPTAL@lists.motion-twin.com http://lists.motion-twin.com/mailman/listinfo/phptal
Re: [PHPTAL] PHP content in templates
Hello :) I was actually surprised that the behaviour existed in the first place simply because it appears to go against the entire ethos of PHPTAL. If I was to consider such a thing as a 'strict' mode I'd prob. have suggested instead that there was a 'transitional' mode to allow porting of templates but which was off by default and not recommended for continued use :) Anyhow, that is beside the point and I think a first step might be to at least mention this in the documentation and possibly supply a pre-filter for those who don't want to be able to use php within a template :) Robert > So, you are trying to subtly suggest having a strict mode which uses a > pre-filter to turn this behavior off? However, I like the current behavior > because it allows me to slowly migrate old pages over to phptal. Also, it > allows me to write a pre-filter that allows me to see what code hasn't been > changed. > > On Fri, May 18, 2012 at 9:16 AM, Robert Goldsmith > wrote: > well, yes, "don't do it" is one approach but we will have a large number of > people with the ability to edit these templates and we intended them to be > pretty idiot-proof (which allowing embedded php is not). > > A pre-filter sounds like a good idea. > > TBH, we were rather surprised because what's the point in the php: > functionality if you can just embed php? > > Robert > > Robert Goldsmith > rgoldsm...@names.co.uk > > > > > On 18 May 2012, at 14:10, ajcri...@gmail.com wrote: > > > Don't do it? > > > > You can create a pre-filter that strips those from the source > > --Original Message-- > > From: Robert Goldsmith > > Sender: phptal-boun...@lists.motion-twin.com > > To: Template Attribute Language for PHP > > ReplyTo: Template Attribute Language for PHP > > Subject: [PHPTAL] PHP content in templates > > Sent: May 18, 2012 09:07 > > > > Hello :) > > > > We've noticed you can just drop in a tal template and it > > will drop it in the compiled template file and execute it. This is not > > something we want to happen so any suggestions on the best way to prevent > > it? > > > > Robert > > > > Robert Goldsmith > > rgoldsm...@names.co.uk > > > > > > > > > > > > ___ > > PHPTAL mailing list > > PHPTAL@lists.motion-twin.com > > http://lists.motion-twin.com/mailman/listinfo/phptal > > > > Sent via BlackBerry by AT&T > > > > ___ > > PHPTAL mailing list > > PHPTAL@lists.motion-twin.com > > http://lists.motion-twin.com/mailman/listinfo/phptal > > > ___ > PHPTAL mailing list > PHPTAL@lists.motion-twin.com > http://lists.motion-twin.com/mailman/listinfo/phptal > > ___ > PHPTAL mailing list > PHPTAL@lists.motion-twin.com > http://lists.motion-twin.com/mailman/listinfo/phptal ___ PHPTAL mailing list PHPTAL@lists.motion-twin.com http://lists.motion-twin.com/mailman/listinfo/phptal
Re: [PHPTAL] PHP content in templates
So, you are trying to subtly suggest having a strict mode which uses a pre-filter to turn this behavior off? However, I like the current behavior because it allows me to slowly migrate old pages over to phptal. Also, it allows me to write a pre-filter that allows me to see what code hasn't been changed. On Fri, May 18, 2012 at 9:16 AM, Robert Goldsmith wrote: > well, yes, "don't do it" is one approach but we will have a large number > of people with the ability to edit these templates and we intended them to > be pretty idiot-proof (which allowing embedded php is not). > > A pre-filter sounds like a good idea. > > TBH, we were rather surprised because what's the point in the php: > functionality if you can just embed php? > > Robert > > Robert Goldsmith > rgoldsm...@names.co.uk > > > > > On 18 May 2012, at 14:10, ajcri...@gmail.com wrote: > > > Don't do it? > > > > You can create a pre-filter that strips those from the source > > --Original Message-- > > From: Robert Goldsmith > > Sender: phptal-boun...@lists.motion-twin.com > > To: Template Attribute Language for PHP > > ReplyTo: Template Attribute Language for PHP > > Subject: [PHPTAL] PHP content in templates > > Sent: May 18, 2012 09:07 > > > > Hello :) > > > > We've noticed you can just drop in a tal template and > it will drop it in the compiled template file and execute it. This is not > something we want to happen so any suggestions on the best way to prevent > it? > > > > Robert > > > > Robert Goldsmith > > rgoldsm...@names.co.uk > > > > > > > > > > > > ___ > > PHPTAL mailing list > > PHPTAL@lists.motion-twin.com > > http://lists.motion-twin.com/mailman/listinfo/phptal > > > > Sent via BlackBerry by AT&T > > > > ___ > > PHPTAL mailing list > > PHPTAL@lists.motion-twin.com > > http://lists.motion-twin.com/mailman/listinfo/phptal > > > ___ > PHPTAL mailing list > PHPTAL@lists.motion-twin.com > http://lists.motion-twin.com/mailman/listinfo/phptal > ___ PHPTAL mailing list PHPTAL@lists.motion-twin.com http://lists.motion-twin.com/mailman/listinfo/phptal
Re: [PHPTAL] PHP content in templates
well, yes, "don't do it" is one approach but we will have a large number of people with the ability to edit these templates and we intended them to be pretty idiot-proof (which allowing embedded php is not). A pre-filter sounds like a good idea. TBH, we were rather surprised because what's the point in the php: functionality if you can just embed php? Robert Robert Goldsmith rgoldsm...@names.co.uk On 18 May 2012, at 14:10, ajcri...@gmail.com wrote: > Don't do it? > > You can create a pre-filter that strips those from the source > --Original Message-- > From: Robert Goldsmith > Sender: phptal-boun...@lists.motion-twin.com > To: Template Attribute Language for PHP > ReplyTo: Template Attribute Language for PHP > Subject: [PHPTAL] PHP content in templates > Sent: May 18, 2012 09:07 > > Hello :) > > We've noticed you can just drop in a tal template and it > will drop it in the compiled template file and execute it. This is not > something we want to happen so any suggestions on the best way to prevent it? > > Robert > > Robert Goldsmith > rgoldsm...@names.co.uk > > > > > > ___ > PHPTAL mailing list > PHPTAL@lists.motion-twin.com > http://lists.motion-twin.com/mailman/listinfo/phptal > > Sent via BlackBerry by AT&T > > ___ > PHPTAL mailing list > PHPTAL@lists.motion-twin.com > http://lists.motion-twin.com/mailman/listinfo/phptal ___ PHPTAL mailing list PHPTAL@lists.motion-twin.com http://lists.motion-twin.com/mailman/listinfo/phptal
Re: [PHPTAL] PHP content in templates
Don't do it? You can create a pre-filter that strips those from the source --Original Message-- From: Robert Goldsmith Sender: phptal-boun...@lists.motion-twin.com To: Template Attribute Language for PHP ReplyTo: Template Attribute Language for PHP Subject: [PHPTAL] PHP content in templates Sent: May 18, 2012 09:07 Hello :) We've noticed you can just drop in a tal template and it will drop it in the compiled template file and execute it. This is not something we want to happen so any suggestions on the best way to prevent it? Robert Robert Goldsmith rgoldsm...@names.co.uk ___ PHPTAL mailing list PHPTAL@lists.motion-twin.com http://lists.motion-twin.com/mailman/listinfo/phptal Sent via BlackBerry by AT&T ___ PHPTAL mailing list PHPTAL@lists.motion-twin.com http://lists.motion-twin.com/mailman/listinfo/phptal