Comment #2 on issue 110 by mr0...@mro.name: Syntactical code clean
http://code.google.com/p/piccolo2d/issues/detail?id=110
Let me refer to
Comment #3 on issue 110 by samrreid: Syntactical code clean
http://code.google.com/p/piccolo2d/issues/detail?id=110
I presume that (3) doesn't entail making any classes or non-private methods
final
(none should be). What reasons has allain.lalonde given for not
using 'final' where
Comment #5 on issue 110 by allain.lalonde: Syntactical code clean
http://code.google.com/p/piccolo2d/issues/detail?id=110
(copied form mailing list)
final on parameters protects us from writing to them from within
methods.
FindBugs and PMD (I think) both flag this behaviour as problematic and
Comment #6 on issue 110 by samrreid: Syntactical code clean
http://code.google.com/p/piccolo2d/issues/detail?id=110
If we already have a process in place that flags reassignment to variables
and
arguments (as allain suggested above), then I think inserting 'final' is
unnecessary.
--
You
Comment #7 on issue 110 by heuermh: Syntactical code clean
http://code.google.com/p/piccolo2d/issues/detail?id=110
I thought I did apply the Eclipse formatter at one point in the past?
Checkstyle
doesn't show many whitespace errors.
I would advise to be careful with the final parameter
Comment #8 on issue 110 by mr0...@mro.name: Syntactical code clean
http://code.google.com/p/piccolo2d/issues/detail?id=110
@Michael: you did? the better! So there won't be many ws diffs.
@All:
A process in place is a good thing to have. But if that leads to not using
the
compiler to detect
Comment #9 on issue 110 by mr0...@mro.name: Syntactical code clean
http://code.google.com/p/piccolo2d/issues/detail?id=110
done it, see r599
local mvn build ok, hudson struggles with the checkout.
@Michael: can you clirr this version against 1.2.1?
--
You received this message because you
Updates:
Status: Fixed
Comment #10 on issue 110 by mr0...@mro.name: Syntactical code clean
http://code.google.com/p/piccolo2d/issues/detail?id=110
BTW, r599 also added the Eclipse Code Clean Profile
