[piccolo2d-dev] Re: Issue 144 in piccolo2d: Updates for PSwing
Updates: Status: Fixed Comment #11 on issue 144 by allain.lalonde: Updates for PSwing http://code.google.com/p/piccolo2d/issues/detail?id=144 Implemented in r868 -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en -~--~~~~--~~--~--~---
[piccolo2d-dev] Re: Issue 144 in piccolo2d: Updates for PSwing
Comment #10 on issue 144 by mr0...@mro.name: Updates for PSwing http://code.google.com/p/piccolo2d/issues/detail?id=144 Hi Sam, am I right that your branch is disconnected and isolated? What about making your collegues p2d committers and linking from your repo to google code via svn:externals? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en -~--~~~~--~~--~--~---
[piccolo2d-dev] Re: Issue 144 in piccolo2d: Updates for PSwing
Comment #9 on issue 144 by re...@colorado.edu: Updates for PSwing http://code.google.com/p/piccolo2d/issues/detail?id=144 Yes, both your suggestions sound excellent. Thanks for taking care of this. We might also find a way to alleviate the client having to call updateBounds() in the future, but right now it's rather pervasive in our projects, and a straightforward way to solve the problem. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en -~--~~~~--~~--~--~---
[piccolo2d-dev] Re: Issue 144 in piccolo2d: Updates for PSwing
Comment #8 on issue 144 by allain.lalonde: Updates for PSwing http://code.google.com/p/piccolo2d/issues/detail?id=144 This work for you? - I'll make reshape() public and rename it to updateBounds() - Because I think you're right if I left it there, eventually it'd be replaced by the hierarchy listener approach. Clients shouldn't need to remember to call it. So if you want to add it to the client code for the time being, that's probably best for everyone. Let me know. :) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en -~--~~~~--~~--~--~---
[piccolo2d-dev] Re: Issue 144 in piccolo2d: Updates for PSwing
Updates: Status: Started Comment #7 on issue 144 by re...@colorado.edu: Updates for PSwing http://code.google.com/p/piccolo2d/issues/detail?id=144 Thanks for applying this patch and beautifying it. I noticed that you removed a method computeBounds() and privatized another method componentHierachyChanged(). ComputeBounds() was currently just calling reshape() (though this implementation might change in the future), but reshape() is currently package visible only. So could you add back computeBounds() or make reshape() public? You could also rename computeBounds()->updateBounds() if you like. The long term solution to the componentHierarchyChanged() is to internally attach listeners to the PSwing's jcomponent swing tree and listen for componentAdded, etc. so that new components can have their double buffering disabled. Right now, we're only using this functionality in one of our projects, and I'm happy to write a fix in the client code if you think this method should be omitted from PSwing (it would be a shame to put it in for 1.3 just to deprecate it for 1.3.0_01.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en -~--~~~~--~~--~--~---
