Re: [Piglit] [PATCH] glx: make sure contexts are destroyed before we exit the test

Timothy Arceri writes: > Without this the last two contexts that are created will not > have been destroyed when exiting the test. This creates a race > condition in Mesa between any threads that might be using > glsl_types and the atexit() callback that destroys these types. Revie

Re: [Piglit] [PATCH] cmake: Do not build tests using designated initializers with older GCC.

Vinson Lee writes: > Designated initializers are not supported in older versions of GCC. I don't think we should be doing this. piglit is for development, if you want to run it on old distros, then pull down a new compiler and build it with that. signature.asc Description: PGP signature

Re: [Piglit] [PATCH 2/2] glx: add test for GLX_ARB_create_context_no_error

Adam Jackson writes: > On Thu, 2019-02-07 at 14:53 -0800, Eric Anholt wrote: >> Adam Jackson writes: >> >> > +static void >> > +fold_results(enum piglit_result *a, enum piglit_result b) >> > +{ >> > + if (*a == PIGLIT_FAIL || b == PIGLIT_F

Re: [Piglit] [PATCH 2/2] glx: add test for GLX_ARB_create_context_no_error

Adam Jackson writes: > From: Grigori Goronzy > > --- > .../glx_arb_create_context/CMakeLists.gl.txt | 1 + > tests/spec/glx_arb_create_context/common.h| 1 + > tests/spec/glx_arb_create_context/no-error.c | 159 ++ > 3 files changed, 161 insertions(+) > create mode

Re: [Piglit] [PATCH] tex-miplevel-selection: force compatibility when using 430 shader

Ilia Mirkin writes: > Mesa will only consider the shader a compat shader if it has an explicit > "compatibility" token in the version. Without this, we don't get > gl_TexCoord, used by the test. > > Signed-off-by: Ilia Mirkin Reviewed-by: Eric Anholt signature.asc D

Re: [Piglit] [PATCH v1 1/2] piglit-framework-gl: add possibility to deinit test

Sergii Romantsov writes: > Hello, > is there any chance to get review? > In the goal is idea to get a simple mechanism to control resources freeing > (any extra memory allocations, files etc.) of any piglit-test on the exit. I gave some feedback, and I haven't seen a new version.

Re: [Piglit] Piglit website in sphinx

ebuilt whenever the docs > directory changes on the master branch. > > I guess my point is that by putting the website under the docs > directory of the main branch, maybe it will allow others to contribute > changes (like this) more easily. :) > > Another change th

Re: [Piglit] Piglit website in sphinx

Jordan Justen writes: > Although I doubt it generates much traffic, I wanted to try to convert > the https://piglit.freedesktop.org/ homepage into an 'auto-building' > gitlab branch. > > I think the current site was built by ikiwiki, but I was after > spending way more time that I hoped, I still

Re: [Piglit] [PATCH v1 2/2] test: fix resources usage for depthstencil-render-miplevels

Sergii Romantsov writes: > Usage test 'depthstencil-render-miplevels 200 s=z24_s8' causes core dump on > exit. > Issues: > 1. Allocation of memory many times to the same variable > 2. Not complete array to store pointers > 3. Absence of memory freeing Can you explain how not freeing memory

Re: [Piglit] [PATCH] EGL_EXT_image_dma_buf_import: set RGBA visual for yuv sampling tests

Lionel Landwerlin writes: > Depending on the platform you're running on, the test might fail with > the AYUV format (or another format with alpha channel). To make this > reliable, force to visual to RGBA. > > Signed-off-by: Lionel Landwerlin > Suggested-by: Eric Anholt r-

Re: [Piglit] [PATCH v2] EGL_EXT_image_dma_buf_import: add fbo option to yuv formats with alpha channel

Lionel Landwerlin writes: > Depending on the platform you're running on, the test might fail with > the AYUV format. To make this reliable, force to render to fbo. It should be reliable with just the RGBA change. Separately, I think you should be able to get the -fbo argument (and thus fewer

Re: [Piglit] [PATCH v2] EGL_EXT_image_dma_buf_import: fix error check with unknown drm format

Lionel Landwerlin writes: > According to the EGL_EXT_image_dma_buf_import spec, creating an EGL > image with a DRM format not supported should yield the BAD_MATCH > error : > > " >* If is EGL_LINUX_DMA_BUF_EXT, and the > EGL_LINUX_DRM_FOURCC_EXT > attribute is set to a format

Re: [Piglit] [PATCH] EGL_EXT_image_dma_buf_import: fix error check with unknown drm format

Lionel Landwerlin writes: > According to the EGL_EXT_image_dma_buf_import spec, creating an EGL > image with a DRM format not supported should yield the BAD_MATCH > error : > > " >* If is EGL_LINUX_DMA_BUF_EXT, and the > EGL_LINUX_DRM_FOURCC_EXT > attribute is set to a format

Re: [Piglit] [PATCH 2/2] EGL_EXT_image_dma_buf_import: add fbo option to yuv formats with alpha channel

Lionel Landwerlin writes: > Depending on the platform you're running on, the test might fail with > the AYUV format. To make this reliable, force to render to fbo. While more fbo tests are good, I think you're missing config.window_visual = PIGLIT_GL_VISUAL_RGBA; in sample_yuv.c

Re: [Piglit] [PATCH] glsl-1.10: test some arithmetic on non-existing struct member

Tapani Pälli writes: > Signed-off-by: Tapani Pälli > https://bugs.freedesktop.org/show_bug.cgi?id=108012 Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ Piglit mailing list Piglit@lists.freedesktop.org

[Piglit] [PATCH] glsl-sdl-sincos-accuracy: Add a new test for a vc4 bug with SDL2.

Our sin(0.0) and cos(0.0) were too inaccurate, causing twisting in SDL2's rendering. --- .../glsl-sdl-sincos-accuracy.shader_test | 36 +++ 1 file changed, 36 insertions(+) create mode 100644 tests/shaders/glsl-sdl-sincos-accuracy.shader_test diff --git

Re: [Piglit] [PATCH v2 3/7] wflinfo: Reimplement wflinfo separating the various API's

Dylan Baker writes: > Currently fast skipping is implemented such that it assumes there's a > single version of ES, a single version of desktop, and all extensions > are shared between them. This has basically worked because 1) there are > basically no gles1 tests, and 2) piglit didn't have

Re: [Piglit] [PATCH 1/2] Test glMultiDrawArraysIndirect with non-VBO attribs

Marek Olšák writes: > From: Marek Olšák > > --- > tests/opengl.py | 6 ++ > tests/spec/gl-3.0/multidrawarrays-vertexid.c | 64 +++- > 2 files changed, 56 insertions(+), 14 deletions(-) Both patches are: Reviewed-by: Eric Anhol

Re: [Piglit] [PATCH] tfp: Also test with GL_TEXTURE_RECTANGLE

Jason Ekstrand writes: > --- > tests/glx/glx-tfp.c | 102 +++- > 1 file changed, 62 insertions(+), 40 deletions(-) Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ Piglit mai

Re: [Piglit] [PATCH] mesa_tile_raster_order: Add a test for the extension.

Eric Anholt writes: > This doesn't test repeated copies with TextureBarrier()s in between, > but that doesn't seem like important new behavior in this extension. I still have this test laying around my tree, and I'd like to push it. Ack from someone? signature.asc Description: PGP sig

[Piglit] [PATCH] deqp: Add Mesa version overrides for khr_gl* testlist generation.

The runner will assertion fail if it can't create an appropriate context, so just force the version so that we can get our testlists generated. --- framework/test/deqp.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/framework/test/deqp.py b/framework/test/deqp.py index

Re: [Piglit] [PATCH] framework: Add a PIGLIT_TEST_TIMEOUT environment variable

Jason Ekstrand writes: > This commit adds a new PIGLIT_TESTS_TIMEOUT environment variable which > overrides the pre-test timeout specified by the test runner. > --- > > This is almost certainly not the right solution but it gets the discussion > started. A couple of known issues: > > - No

Re: [Piglit] [PATCH 2/4] README.md: Remove not about .py on profiles

her profiles are only > available as python, so just stop using it. in the subject: "note" Other than that, 1, 2, 3 are: Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ Piglit mailing list Piglit@li

Re: [Piglit] [PATCH 3/4] README.md: Remove PIGLIT_FORCE_GLSLPASER_DESKTOP env variable

Dylan Baker writes: > This is no longer honored, instead use the glslparser_arb_compat > profile. I still see it in the tree here. signature.asc Description: PGP signature ___ Piglit mailing list Piglit@lists.freedesktop.org

Re: [Piglit] [PATCH 5/5] textureGather: Use piglit_probe_rect_rgba_varying

Jason Ekstrand writes: > Instead of doing 900 piglit_proble_pixel_rgba calls (one for each pixel) > which each call glReadPixels, use the new helper which only invokes > glReadPixels once. This series is: Reviewed-by: Eric Anholt signature.asc Description: PGP

Re: [Piglit] [PATCH] Use _exit() instead of exit() in child processes

Michel Dänzer writes: > From: Michel Dänzer > > A child process which doesn't call exec() shouldn't use exit(), as that > will attempt to run any atexit handlers of the parent, which may break. > It actually results in crashing with the Mesa radeonsi driver. Reviewed-

Re: [Piglit] GitLab migration of Piglit

Jason Ekstrand writes: > All, > > Sorry for the mess of GitLab e-mails but there are a lot of questions to > ask as this process moves forward. Today, we're discussing piglit. I've > included both the mesa and piglit list in the hopes that people will > actually see this e-mail. > > Honestly,

Re: [Piglit] [PATCH] glsl-1.10: test loop unrolling when induction variable is inside if branch

dentation > + if (i != 1) { > + j++; > + } > + i++; > +} > + } while (i < 4); > + > + gl_FrontColor = colour; > +} Thanks for making tests for bugs like this! Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] glsl-uniform-initializer-7: Fixed uninitialized uniform.

mathias.froehl...@gmx.net writes: > From: Mathias Fröhlich <mathias.froehl...@gmx.net> > > Hi all, > > please review, and push if ok! > > best > > Mathias > > > > > This fixes a valgrind error in executing shader_runner on this test. Reviewed-by:

Re: [Piglit] [PATCH] piglit-util: use _exit to skip context destruction

Marek Olšák writes: > From: Marek Olšák You should have a "why" in your commit message. signature.asc Description: PGP signature ___ Piglit mailing list Piglit@lists.freedesktop.org

Re: [Piglit] [PATCH] ext_texture_norm16-render: refactor subtest execution

d > duplicate subtest result reporting. Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH v2] ext_texture_norm16-render: test for GL_EXT_texture_norm16

Tapani Pälli writes: > Test includes: >- texture uploads >- mipmap generation >- framebuffer creation >- rendering to >- reading from >- interaction with GL_EXT_copy_image > > v2: code cleanup > > Signed-off-by: Tapani Pälli

Re: [Piglit] [PATCH 7/7] nv_fog_distance: Test interactions with GL_FOG_COORDINATE

? > + > + pass = piglit_check_gl_error(GL_NO_ERROR) && pass; > + > + pass = piglit_probe_rect_rgb(0, 0, piglit_width, piglit_height, > + mix_color); > + > + piglit_present_results(); > + > + return pass ? PIGLIT_PASS : PIGLIT_FAIL; >

Re: [Piglit] [PATCH 6/7] nv_fog_distance: Simple rendering test

= -1.0 + ((2.0 * j) / (n - 1)); > + > + verts[0] = x; > + verts[1] = y; > + verts[2] = z; > + verts += 3; > + } > + } > + > + glUnmapBuffer(GL_ARRAY_BUFFER); This all fe

Re: [Piglit] [PATCH 5/7] nv_fog_distance: Simple touch test for the enums

Ian Romanick writes: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > tests/all.py | 5 + > tests/spec/CMakeLists.txt| 1 + >

Re: [Piglit] [PATCH 1/7] gl-1.0-blend: Fix problems with blend extension detection

Ian Romanick writes: > From: Ian Romanick > > There were two bugs here. First, GL_EXT_blend_color and > GL_EXT_blend_func_separate were only tested if the version is 1.4. This > is unnecessary because those extensions are part of OpenGL 1.4.

Re: [Piglit] [PATCH 2/7] gl-1.0-blend: Enable EXT_blend_subtract tests on implementations that lack EXT_blend_minmax

Ian Romanick writes: > From: Ian Romanick > > And vice versa. > > Signed-off-by: Ian Romanick > --- > tests/spec/gl-1.0/blend.c | 40 ++-- > 1 file changed, 26 insertions(+), 14

Re: [Piglit] [PATCH] draw-vertices-2101010: Don't test BGRA if we don't have the ext.

Ilia Mirkin <imir...@alum.mit.edu> writes: > On Thu, Apr 26, 2018 at 1:21 PM, Eric Anholt <e...@anholt.net> wrote: >> The 2101010 spec says to remove BGRA references if this extension >> isn't present, so don't test them. >> --- >> .../draw-ve

Re: [Piglit] [PATCH] texture-integer-glsl130: Make sure we use usampler for ui textures.

Ilia Mirkin <imir...@alum.mit.edu> writes: > On Thu, Apr 26, 2018 at 1:01 PM, Eric Anholt <e...@anholt.net> wrote: >> Fixes failure on VC5 because we would sign-extend 16ui. Sampling ui >> with isampler is undefined according to the table under "8.7 Texture >&

[Piglit] [PATCH] draw-vertices-2101010: Don't test BGRA if we don't have the ext.

The 2101010 spec says to remove BGRA references if this extension isn't present, so don't test them. --- .../draw-vertices-2101010.c | 22 ++- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git

[Piglit] [PATCH] arb_vertex_type_2_10_10_10: Don't test BGRA if we don't have the ext.

The 2101010 spec says to remove BGRA references if this extension isn't present, so don't test them. --- tests/spec/arb_vertex_type_2_10_10_10_rev/array_types.c | 4 1 file changed, 4 insertions(+) diff --git a/tests/spec/arb_vertex_type_2_10_10_10_rev/array_types.c

[Piglit] [PATCH] texture-integer-glsl130: Make sure we use usampler for ui textures.

Fixes failure on VC5 because we would sign-extend 16ui. Sampling ui with isampler is undefined according to the table under "8.7 Texture Lookup Functions" in the 1.30 spec. --- .../texture-integer-glsl130.c | 40 --- 1 file changed, 26 insertions(+), 14

Re: [Piglit] [PATCH] add tests for using immediates in common operations

Ilia Mirkin <imir...@alum.mit.edu> writes: > On Mon, Apr 23, 2018 at 4:49 PM, Eric Anholt <e...@anholt.net> wrote: >> Ilia Mirkin <imir...@alum.mit.edu> writes: >> >>> NVIDIA hardware has "short" immediates, and some instructions have

Re: [Piglit] [PATCH] framework: update deqp mustpass list for text based mustpass

Dylan Baker <dy...@pnwbakers.com> writes: > The current code has bit-rotted quite a bit, in late 2016 the format was > changed from XML based to txt based, but the code was never updated. > --- I think you can remove the elementtree import now. Other than that, Reviewed-by:

Re: [Piglit] [PATCH 00/35] Serialize profiles into XML at build time

Marek Olšák writes: > Is this use case affected? > > piglit run --deqp-mustpass-list --process-isolation 0 -p gbm -c quick > cts_gl45 deqp_gles2 deqp_gles3 deqp_gles31 > > Yes, that is just 1 command to run all those test suites at the same time. > > I use my personal "deqp"

Re: [Piglit] [PATCH] AMD_performance_monitor: add VC4 specific tests

Boris Brezillon writes: > From: Boris Brezillon > > This adds a specific test for the VC4 GPU. > Right now, it only checks that FEP-valid-quads and > QPU-total-clk-cycles-waiting-TMU are consistent after executing well > know

Re: [Piglit] [PATCH 1/2] fbo-drawbuffers2-blend: fix incorrect comments

Brian Paul <bri...@vmware.com> writes: > --- > tests/fbo/fbo-drawbuffers2-blend.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) These 2 are: Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Descr

Re: [Piglit] [PATCH] AMD_performance_monitor: add VC4 specific tests

Boris Brezillon <boris.brezil...@bootlin.com> writes: > On Fri, 09 Feb 2018 21:12:20 +0000 > Eric Anholt <e...@anholt.net> wrote: > >> Boris Brezillon <boris.brezil...@bootlin.com> writes: >> >> > From: Boris Brezillon <boris.brezil...@free

Re: [Piglit] [PATCH] AMD_performance_monitor: add VC4 specific tests

Boris Brezillon writes: > From: Boris Brezillon > > This adds a specific test for the VC4 GPU. > Right now, it only checks that FEP-valid-quads and > QPU-total-clk-cycles-waiting-TMU are consistent after executing well > know

Re: [Piglit] [PATCH v4] travis: add docker based cmake build job

-by: Juan A. Suarez <jasua...@igalia.com> If this build has proven to be fast enough, I should probably take a look at doing this for the xserver as well. (For xserver, the issue was all the package installs per Travis run, so I have an image I manage on dockerhub instead) Acked-by: Eric

Re: [Piglit] [PATCH v3] travis: add docker based cmake build job

Andres Gomez writes: > Until now we were only running the python unit tests. > > It seems desirable to also check that the CMake based build compiles > successfully. We do that now using docker. > > The docker build can be tweaked with some environment variables and, > also,

Re: [Piglit] [PATCH] gl-1.0-blend-func: skip some blend tests when using LLVM 3.8

Brian Paul <bri...@vmware.com> writes: > On 01/18/2018 01:27 PM, Eric Anholt wrote: >> Brian Paul <bri...@vmware.com> writes: >> >>> To avoid an infinite loop. See code comments for details. >> >> Skipping a failing test and returning pass

Re: [Piglit] [PATCH] gl-1.0-blend-func: skip some blend tests when using LLVM 3.8

Brian Paul writes: > To avoid an infinite loop. See code comments for details. Skipping a failing test and returning pass is wrong to me. signature.asc Description: PGP signature ___ Piglit mailing list

Re: [Piglit] [PATCH 0/3] cleanups for ATI_fs tests

Miklós Máté writes: > Please do so. These are nice cleanups. > > MM I finally got around to pushing these. Once again, thanks for your work on this! signature.asc Description: PGP signature ___ Piglit mailing list

Re: [Piglit] [PATCH] arb_texture_view: fix order of vertices in draw_3d_depth()

0.0, 1.0, > + 1.0, 1.0}; This matches the ordering that other callers of piglit_draw_rect_from_arrays() use. Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH v2] ext_disjoint_timer_query-simple: basic API test

le.test_list.group_manager( > +PiglitGLTest, > +grouptools.join('spec', 'ext_disjoint_timer_query')) as g: > +g(['ext_disjoint_timer_query-simple'], 'query') Can we s/'query'/'simple'/ to match the binary's name? With that fixed, Reviewed-by: Eric Anholt

[Piglit] [PATCH 2/3] ati_fs: Use enums instead of magic numbers in the render tests.

Signed-off-by: Eric Anholt <e...@anholt.net> --- tests/spec/ati_fragment_shader/render-notexture.c | 13 +--- tests/spec/ati_fragment_shader/render-sources.c | 36 +-- 2 files changed, 30 insertions(+), 19 deletions(-) diff --git a/tests/spec/ati_fragment_shader/

[Piglit] [PATCH 3/3] ati_fs: Do some column wrapping in the render tests.

--- tests/spec/ati_fragment_shader/render-constants.c | 25 ++- tests/spec/ati_fragment_shader/render-default.c| 24 ++- tests/spec/ati_fragment_shader/render-fog.c| 28 - tests/spec/ati_fragment_shader/render-notexture.c | 24 ++-

[Piglit] [PATCH 0/3] cleanups for ATI_fs tests

Here are a few little cleanups I made while reviewing the series. Miklós, if you are OK with these, then I'll squash them into your patches and push the whole set. Eric Anholt (3): ati_fs: Wrap some comments in render tests. ati_fs: Use enums instead of magic numbers in the render tests

[Piglit] [PATCH 1/3] ati_fs: Wrap some comments in render tests.

This would be squashed into patch 2. --- tests/spec/ati_fragment_shader/render-default.c| 7 +-- tests/spec/ati_fragment_shader/render-sources.c| 7 +-- tests/spec/ati_fragment_shader/render-textargets.c | 3 ++- 3 files changed, 12 insertions(+), 5 deletions(-) diff --git

Re: [Piglit] [PATCH] fbo-blending-snorm: new test for testing snorm blend behavior

srol...@vmware.com writes: > From: Roland Scheidegger > > The existing fbo-blending-formats test is mostly useless for anything but > unorm formats, since it does not test any values outside [0,1] (neither for > src, dst, intermeidate calculations, blend result). > I tried to

Re: [Piglit] [PATCH 2/4] ATI_fs: add render tests

Miklós Máté <mtm...@gmail.com> writes: > On 21/11/17 21:17, Eric Anholt wrote: >> Miklós Máté <mtm...@gmail.com> writes: >>> diff --git a/tests/spec/ati_fragment_shader/render-notexture.c >>> b/tests/spec/ati_fragment_shader/render-notexture.c >&

Re: [Piglit] [PATCH 1/4] ATI_fs: add api error tests

Miklós Máté <mtm...@gmail.com> writes: > On 21/11/17 21:09, Eric Anholt wrote: >> Miklós Máté <mtm...@gmail.com> writes: >>> + >>> + piglit_report_result(PIGLIT_PASS); >>> +} >>> diff --git a/tests/spec/ati_fragment_shader/error02-inside

Re: [Piglit] [PATCH] ext_disjoint_timer_query-simple: basic API test

Tapani Pälli writes: > Signed-off-by: Tapani Pälli > --- > tests/spec/CMakeLists.txt | 1 + > .../ext_disjoint_timer_query/CMakeLists.gles2.txt | 7 ++ > tests/spec/ext_disjoint_timer_query/CMakeLists.txt | 1 + >

Re: [Piglit] [PATCH 2/4] ATI_fs: add render tests

Miklós Máté writes: > These mainly check the state machine. Compiler checks will come later. > > Signed-off-by: Miklós Máté > --- > tests/spec/ati_fragment_shader/render-constants.c | 98 +++ > tests/spec/ati_fragment_shader/render-default.c

Re: [Piglit] [PATCH 1/4] ATI_fs: add api error tests

Miklós Máté writes: > One for each paragraph in the Errors section of the spec. > > Signed-off-by: Miklós Máté > --- > tests/spec/ati_fragment_shader/error01-genzero.c | 51 > tests/spec/ati_fragment_shader/error02-inside.c| 59 + >

Re: [Piglit] [PATCH 0/4] WIP tests for GL_ATI_fragment_shader

Miklós Máté writes: > This series adds API sanity checks, error checks for the conditions listed in > the specification, and render tests for validating the state machine. > I think this is the point where the test set starts becoming useful. > > I plan to do more API sanity

Re: [Piglit] [PATCH] glx: New test for GLX_EXT_no_config_context

Adam Jackson writes: > Create a no-config context, create one window of every visual, make it > current against each of them. This is a bit of a touch test right now, > this should be extended to create each kind of drawable for each config > and to verify some rendering. It's

[Piglit] [PATCH] glsl-fs-discard-mrt: Fix binding the winsys framebuffer in -fbo mode.

Fixes failure on vc5 where the alpha was forced to 1 due to an rgbx window system buffer. --- tests/shaders/glsl-fs-discard-mrt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/shaders/glsl-fs-discard-mrt.c b/tests/shaders/glsl-fs-discard-mrt.c index

Re: [Piglit] Piglit test results

Dan Allen writes: > Hi, > > I reported a bug in relation to the R600 driver and have since found the > piglit tests. I ran the shader.py test and receive approximately 500 > errors when this test is run (it varies slightly between each run). > > Are these test results of

Re: [Piglit] [PATCH] framework: specify GL_NEAREST filter for FBO textures

Brian Paul <bri...@vmware.com> writes: > By setting the min/mag filters, we give a hint to the OpenGL driver > that we probaby don't want mipmapped textures. This results in the > Mesa state tracker allocating single-level textures here instead of > full mipmaps. Reviewed-

Re: [Piglit] [PATCH] OES_required_internalformat: Add a test for renderbuffer sizing.

Eric Anholt <e...@anholt.net> writes: > [ Unknown signature status ] > Eric Anholt <e...@anholt.net> writes: > >> dEQP provides some coverage for texture and renderbuffer formats being >> supported, but doesn't test that the storage reports appropriate >>

Re: [Piglit] [PATCH] glsl-1.00: Add testcases from the spec about redeclarations.

Eric Anholt <e...@anholt.net> writes: > Catches a regression in my recent redeclaration patch series > (allowed-2) and failure I was trying to fix (disallowed-2). I'd still love an ack on this one. signature.asc Description: PGP signature __

Re: [Piglit] [PATCH] framework: Do not run with an empty test list

Dylan Baker writes: > [ Unknown signature status ] > Quoting Martin Peres (2017-10-20 00:38:18) >> On 19/10/17 19:50, Dylan Baker wrote: >> > Quoting Martin Peres (2017-10-19 07:17:25) >> >> On 30/09/17 23:42, Dylan Baker wrote: >> >>> Actually CC'ing him this time >>

Re: [Piglit] [PATCH 0/7] framework, shader_runner: misc fixed and cleanups

Nicolai Hähnle <nhaeh...@gmail.com> writes: > Hi all, > > Mostly no-op changes in comments, but a few functional changes as well. This series is: Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature _

Re: [Piglit] [PATCH 4/4] simple-readbuffer: simplify a conditional

Brian Paul <bri...@vmware.com> writes: > I find this slightly easier to read. Series is: Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ Piglit mailing list Piglit@lists.freede

Re: [Piglit] [PATCH 1/5] all.py: remove run_concurrent=False from most 1.1 tests

['texsubimage-depth-formats'], run_concurrent=False) > -g(['texture-al'], run_concurrent=False) > +g(['texsubimage-depth-formats']) > +g(['texture-al']) > g(['triangle-guardband-viewport']) > g(['getteximage-targets', '1D']) > g(['getteximage-targets', '2D']) &g

Re: [Piglit] [PATCH] glx: Rerun failing tests in auto mode if there is a pending expose event

ion and optionally rerun the test. Did this resolve your unstable test results? Could you mention which tests were failing, and your environment (a window manager, a compositing manager, or none)? With that, Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc De

Re: [Piglit] [PATCH 2/2] glean: remove pointless switch statements from fbo test

Brian Paul <bri...@vmware.com> writes: > All switch cases did the same thing. Spotted by Eric Anholt. Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ Piglit mailing list Piglit@lists.freede

Re: [Piglit] [PATCH] OES_required_internalformat: Add a test for renderbuffer sizing.

Eric Anholt <e...@anholt.net> writes: > dEQP provides some coverage for texture and renderbuffer formats being > supported, but doesn't test that the storage reports appropriate > sizes. We can't test textures easily becase GetTexLevelParameter > doesn't exist, but GetRenderb

Re: [Piglit] [PATCH] glean: remove line drawing code from fbo test

Brian Paul writes: > The glean fbo test exercises rendering to 1D, 2D, 3D and cube images > attached to FBOs. For the 1D texture case, the rendering is done with > a line, rather than a polygon. Since the 1D image is one pixel high, > the slightest mis-rasterization of the

[Piglit] [PATCH] no-op-paths: Clear between each test.

This matches the behavior of the old glean test. Without it, the always-pass subtests would all pass if the first one had passed, and if a single always-fail subtest failed then the rest would also fail. --- tests/spec/gl-1.0/no-op-paths.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

Re: [Piglit] [PATCH] arb_clear_texture-errors: add more error tests

Brian Paul <bri...@vmware.com> writes: > Check for errors clearing other mipmap levels. > Test clearing with a texture view. > Update/add comments. Nice. Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature _

[Piglit] [PATCH] util: Avoid asking GL to transpose the ortho_uniform matrix.

From the GLES2 spec: If the transpose parameter to any of the UniformMatrix* commands is not FALSE, an INVALID_VALUE error is generated, and no uniform values are changed. Fixes spurious failures in draw-vertices-half-float_gles2. --- tests/util/piglit-util-gl.c | 10 +- 1

Re: [Piglit] [PATCH v3 0/8] Add tests for EGL_ANDROID_native_fence_sync.

Rafael Antognolli <rafael.antogno...@intel.com> writes: > This time, reuse most of the code from egl_khr_fence_sync test. > > Cc: Eric Anholt <e...@anholt.net> > > Rafael Antognolli (8): > egl_khr_fence_sync: Prepare to support android native_sync. > egl_khr_

Re: [Piglit] [PATCH v3 4/8] egl_khr_fence_sync: Add test to create fence from fd.

Rafael Antognolli writes: > Add a test that creates a sync file using sw_sync, and then creates an > EGL fence sync from that sync file. It also verify that the fence sync > EGL_SYNC_CONDITION_KHR is set to EGL_SYNC_NATIVE_FENCE_SIGNALED_ANDROID, > and that

Re: [Piglit] [PATCH] piglit_drm_dma_buf: fix GPU offsets and strides

ath for non-zero > planes. GBM doesn't seem to have the capability to map a specific plane > for CPU access. Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ Piglit mailing list Piglit@lists.freedesktop

Re: [Piglit] [PATCH] piglit_drm_dma_buf: fix the stride

stride fields of the switch (fourcc) down below, you can add: Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH v2 10/12] egl_android_native_fence_sync: Test for wait with zero timeout.

> > +/** > + * Verify that eglClientWaitSyncKHR() correctly handles zero timeout before > and > + * after glFinish(). Here and in the error messages below, s/glFinish()/sw_sync_timeline_inc()/ With that, patches 7-12 are: Reviewed-by: Eric Anholt <e...@anholt.net> I h

Re: [Piglit] [PATCH v2 06/12] egl_android_native_fence_sync: Create fence from other display.

Rafael Antognolli writes: > Verify that EGL_NO_SYNC_KHR is returned and EGL_BAD_MATCH error is > generated. > > Signed-off-by: Rafael Antognolli > --- > .../egl_android_native_fence_sync.c| 98 > +- >

Re: [Piglit] [PATCH v2 05/12] egl_android_native_fence_sync: Create fence from invalid display.

Rafael Antognolli <rafael.antogno...@intel.com> writes: > Verify that EGL_NO_SYNC_KHR is returned and an EGL_BAD_DISPLAY error is > generated. Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ P

Re: [Piglit] [PATCH v2 04/12] egl_android_native_fence_sync: Verify eglDupNativeFenceFDANDROID.

+ goto cleanup; > + } > + > + glFlush(); > + > + if (result == PIGLIT_FAIL) > + goto cleanup; This check looks like it's unreachable. Other than that, patches 3-4 are: Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Desc

Re: [Piglit] [PATCH v2 02/12] egl_android_native_fence_sync: Add sw_sync lib.

Rafael Antognolli writes: > Add a small library that helps manipulating software fences. They are > useful for testing EGL Android fences, since the latter can be created > out of them. > > Signed-off-by: Rafael Antognolli > --- >

Re: [Piglit] [PATCH] util: call fflush() after printf() calls

Brian Paul writes: > Otherwise, on Windows, we don't see the printf() output until the program > exits. That's fine with the -auto option, but a problem w/out -auto. That's pretty broken. Could we just wrap printf/fprintf on windows to call down and then fflush(), instead

Re: [Piglit] [PATCH] drawoverhead: new microbenchmark

Marek Olšák writes: > From: Marek Olšák > > Based on a benchmark from mesa/demos, but rewritten and extended. > It's a benchmark expected to be run separately, not a piglit test. > So why piglit? Because it's a good framework for writing apps like this. >

[Piglit] [PATCH] glsl-1.00: Add testcases from the spec about redeclarations.

Catches a regression in my recent redeclaration patch series (allowed-2) and failure I was trying to fix (disallowed-2). --- .../compiler/redeclaration-allowed-1.vert | 26 ++ .../compiler/redeclaration-allowed-2.vert | 23 +++

[Piglit] [PATCH] OES_required_internalformat: Add a test for renderbuffer sizing.

dEQP provides some coverage for texture and renderbuffer formats being supported, but doesn't test that the storage reports appropriate sizes. We can't test textures easily becase GetTexLevelParameter doesn't exist, but GetRenderbufferParameter can let us test renderbuffers at least. ---

Re: [Piglit] [PATCH v2] gl30basic: add some extra suspected extension

Sandra Koroniewska writes: > This fixes > spec/gl30basic test on Windows Intel or Nvidia driver according to page 693 > of openGL 4.4 spec ("In additional to OpenGL extensions, there are also ARB > extensions to the related GLX and WGL APIs."). I'm reading that

Re: [Piglit] [PATCH] framework/test/shader_test: use -fbo option for shader tests

, piglit-run.py -t built-in-functions drops from 19 > minutes to 15 minutes. > > No regressions found with VMware driver in Windows VM and Linux VM. Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature _

Re: [Piglit] faster piglit start-up

Brian Paul writes: > When we run piglit the all.py script traverses the entire tests/ and > generated/tests/ directories looking for *.shader_test, *.vert, *.frag, > etc. shaders to run. In the generated_tests/ directory, there's about > 60,000 entries to scan (ls -R

  1   2   3   4   5   6   >