Re: [Piglit] [PATCH] arb_copy_buffer-intra-buffer-copy: new GL_ARB_copy_buffer test

2016-06-29 Thread Marek Olšák
Reviewed-by: Marek Olšák <marek.ol...@amd.com> Marek On Tue, Jun 21, 2016 at 7:18 PM, Brian Paul <bri...@vmware.com> wrote: > To exercise copying within a single buffer. > --- > tests/all.py | 1 + > tests/spec/arb_copy_buffer/

[Piglit] [PATCH] initialized-texmemory: report WARN on failure

2016-06-29 Thread Marek Olšák
From: Marek Olšák <marek.ol...@amd.com> The tested behavior is not required by the spec and the test itself claims it reports WARN, so this is a typo. --- tests/security/initialized-texmemory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/security/initi

[Piglit] [PATCH 3/4] shader_runner: use enum piglit_result in piglit_display

2016-06-28 Thread Marek Olšák
From: Marek Olšák <marek.ol...@amd.com> --- tests/shaders/shader_runner.c | 36 +++- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index 2f90fee..45ba103 100644 --- a/tests/s

[Piglit] [PATCH 4/4] fs-dfdx/y-accuracy: report warn on failure

2016-06-28 Thread Marek Olšák
From: Marek Olšák <marek.ol...@amd.com> --- tests/shaders/shader_runner.c | 6 ++ tests/spec/glsl-1.10/execution/fs-dfdx-accuracy.shader_test | 4 +++- tests/spec/glsl-1.10/execution/fs-dfdy-accuracy.shader_test | 4 +++- 3 files changed, 12 insertions

[Piglit] [PATCH 2/4] ext_framebuffer_multisample_blit_scaled: report warn on failure

2016-06-28 Thread Marek Olšák
From: Marek Olšák <marek.ol...@amd.com> --- tests/spec/ext_framebuffer_multisample_blit_scaled/blit-scaled.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/spec/ext_framebuffer_multisample_blit_scaled/blit-scaled.cpp b/test

[Piglit] [PATCH 1/4] oes_fixed_point-attribute-arrays: set window_visual to fix the test under GBM

2016-06-28 Thread Marek Olšák
From: Marek Olšák <marek.ol...@amd.com> --- tests/spec/oes_fixed_point/oes_fixed_point-attribute-arrays.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/spec/oes_fixed_point/oes_fixed_point-attribute-arrays.c b/tests/spec/oes_fixed_point/oes_fixed_point-attribute-arrays.c

Re: [Piglit] [PATCH] arb_texture_barrier: add an arb_texture_barrier test

2016-06-24 Thread Marek Olšák
Acked-by: Marek Olšák <marek.ol...@amd.com> Marek On Fri, Jun 24, 2016 at 10:55 AM, Alejandro Piñeiro <apinhe...@igalia.com> wrote: > Allow to configure: > * texture resolution > * number of blend passes > * number of draw passes (calls to DrawRangeElements) >

Re: [Piglit] [PATCH] Add glsl-1.30/execution/fs-fwidth-color.shader_test

2016-06-13 Thread Marek Olšák
Reviewed-by: Marek Olšák <marek.ol...@amd.com> Marek On Mon, Jun 13, 2016 at 12:19 PM, Nicolai Hähnle <nhaeh...@gmail.com> wrote: > Based on the test in https://bugs.freedesktop.org/show_bug.cgi?id=95130 > which exposed an error in radeonsi non-monolithic fragment shaders. >

Re: [Piglit] Nearly finished: shader_runner running THOUSANDS of tests per process

2016-05-27 Thread Marek Olšák
On Fri, May 27, 2016 at 7:53 PM, Dylan Baker <dy...@pnwbakers.com> wrote: > Quoting Marek Olšák (2016-04-16 15:16:34) >> Hi, >> >> This makes shader_runner very fast. The expected result is 40% >> decrease in quick.py running time, or a 12x faster piglit run

Re: [Piglit] Nearly finished: shader_runner running THOUSANDS of tests per process

2016-05-27 Thread Marek Olšák
On Fri, May 27, 2016 at 3:18 AM, Mark Janes <mark.a.ja...@intel.com> wrote: > Marek Olšák <mar...@gmail.com> writes: > >> On Mon, Apr 18, 2016 at 6:45 PM, Dylan Baker <baker.dyla...@gmail.com> wrote: >>> Quoting Marek Olšák (2016-04-16 15:16:34) >>&

Re: [Piglit] [PATCH] shader_runner: allow GL_MAX_VERTEX_ATTRIBS in requirements (v2)

2016-04-29 Thread Marek Olšák
Reviewed-by: Marek Olšák <marek.ol...@amd.com> Marek On Fri, Apr 29, 2016 at 2:20 PM, Andres Gomez <ago...@igalia.com> wrote: > v2: Just use the same query for GL or GLS 2.0 and 3.0 as noted by > Marek Olšák. > > Signed-off-by: Andres Gomez <ago...@igalia.

Re: [Piglit] [PATCH] shader_runner: allow GL_MAX_VERTEX_ATTRIBS in requirements

2016-04-26 Thread Marek Olšák
On Mon, Apr 25, 2016 at 4:03 PM, Andres Gomez wrote: > Signed-off-by: Andres Gomez > --- > tests/shaders/shader_runner.c | 17 - > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/tests/shaders/shader_runner.c

[Piglit] [PATCH 2/2] Fix asprintf warnings

2016-04-21 Thread Marek Olšák
From: Marek Olšák <marek.ol...@amd.com> --- tests/general/clipflat.c | 2 +- tests/general/object-namespace-pollution.c | 4 ++-- tests/shaders/built-in-constants.c | 4 ++-- tests/shaders/version-mi

[Piglit] [PATCH 1/2] util: fix warnings

2016-04-21 Thread Marek Olšák
From: Marek Olšák <marek.ol...@amd.com> --- tests/util/piglit-framework-gl/piglit_wfl_framework.c | 4 +++- tests/util/piglit-shader.c| 1 + tests/util/piglit-util-gl.c | 5 + 3 files changed, 9 insertions(+), 1 deletion(-) diff

[Piglit] [PATCH] util: fix regression with ubyte probing

2016-04-21 Thread Marek Olšák
From: Marek Olšák <marek.ol...@amd.com> clearbuffer-mixed-format regressed, because GL_RED_BITS doesn't have anything to do with the read buffer. --- tests/util/piglit-util-gl.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/tests/util/pigli

Re: [Piglit] Nearly finished: shader_runner running THOUSANDS of tests per process

2016-04-18 Thread Marek Olšák
On Mon, Apr 18, 2016 at 6:45 PM, Dylan Baker <baker.dyla...@gmail.com> wrote: > Quoting Marek Olšák (2016-04-16 15:16:34) >> Hi, >> >> This makes shader_runner very fast. The expected result is 40% >> decrease in quick.py running time, or a 12x faster piglit run

[Piglit] Nearly finished: shader_runner running THOUSANDS of tests per process

2016-04-16 Thread Marek Olšák
Hi, This makes shader_runner very fast. The expected result is 40% decrease in quick.py running time, or a 12x faster piglit run if you run shader tests alone. Branch: https://cgit.freedesktop.org/~mareko/piglit/log/?h=shader-runner Changes: 1) Any number of test files can be specified as

[Piglit] [PATCH] util: probe pixel rectangles as ubyte if possible (v2)

2016-04-16 Thread Marek Olšák
From: Marek Olšák <marek.ol...@amd.com> v2: int -> bool, unify all new functions into one --- tests/util/piglit-util-gl.c | 94 + 1 file changed, 94 insertions(+) diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c inde

[Piglit] [PATCH] util: probe pixel rectangles as ubyte if possible

2016-04-11 Thread Marek Olšák
From: Marek Olšák <marek.ol...@amd.com> --- tests/util/piglit-util-gl.c | 154 1 file changed, 154 insertions(+) diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c index dbdfb13..99a396b 100644 --- a/tests/util/piglit-uti

[Piglit] [PATCH 1/3] shader_runner: use static keyword

2016-04-11 Thread Marek Olšák
From: Marek Olšák <marek.ol...@amd.com> --- tests/shaders/shader_runner.c | 170 +- 1 file changed, 85 insertions(+), 85 deletions(-) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index 8d2a9bd..65f26a0 100644 --- a

[Piglit] [PATCH 3/3] shader_runner: fix a may-be-used-uninitialized warning

2016-04-11 Thread Marek Olšák
From: Marek Olšák <marek.ol...@amd.com> --- tests/shaders/shader_runner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index 3d2ab9d..c41f9d2 100644 --- a/tests/shaders/shader_runner.c +++ b/tests/s

[Piglit] [PATCH 2/3] shader_runner: remove unused variable "path"

2016-04-11 Thread Marek Olšák
From: Marek Olšák <marek.ol...@amd.com> --- tests/shaders/shader_runner.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index 65f26a0..3d2ab9d 100644 --- a/tests/shaders/shader_runner.c +++ b/tests/shaders/shader_ru

[Piglit] [PATCH 2/2] Remove fs-discard-exit-3

2016-04-08 Thread Marek Olšák
From: Marek Olšák <marek.ol...@amd.com> The test is wrong and the GLSL 1.30 citation in the test states very clearly that discard can cause non-uniform control flow for any code that follows. --- .../execution/fs-discard-exit-3.shader_test| 76 -- 1 file chang

[Piglit] [PATCH 1/2] arb_shader_image_size/builtin: don't report subtests that are never run

2016-04-08 Thread Marek Olšák
From: Marek Olšák <marek.ol...@amd.com> this removes a lot of skipped subtests from results --- tests/spec/arb_shader_image_size/builtin.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/tests/spec/arb_shader_image_size/builtin.c b/test

Re: [Piglit] Is piglit not portable? Unicode errors

2016-03-26 Thread Marek Olšák
On Fri, Mar 25, 2016 at 8:29 PM, Dylan Baker <baker.dyla...@gmail.com> wrote: > errr, sorry for the typo, "that should be which version of piglit you're > running" > > On Fri, Mar 25, 2016 at 12:26 PM, Dylan Baker <baker.dyla...@gmail.com> > wrote: >>

Re: [Piglit] [PATCH 2/2] framework/summary/html_.py: Write output files as utf-8 bytes streams

2016-03-26 Thread Marek Olšák
Thank you very much. This fixes the Unicode error for me. For the series: Tested-by: Marek Olšák <marek.ol...@amd.com> Please let me know if you still need the problematic results file. Marek On Fri, Mar 25, 2016 at 10:28 PM, Dylan Baker <baker.dyla...@gmail.com> wrote: >

[Piglit] Is piglit not portable? Unicode errors

2016-03-25 Thread Marek Olšák
Hi, I received piglit results from somebody else and can't generate html. Any idea what is wrong? Traceback (most recent call last): File "../piglit/piglit-summary-html.py", line 28, in html(sys.argv[1:]) File "/home/marek/dev/piglit/framework/exceptions.py", line 50, in _inner

Re: [Piglit] [PATCH 04/11] framework/test/opengl.py: Add FastSkipMixin which checks extensions

2016-02-10 Thread Marek Olšák
On Mon, Jan 4, 2016 at 7:04 PM, Dylan Baker wrote: > Okay. I'm going to push the patch Jose reviewed, and I'll send out a patch > (and CC both of you) that adds an environment variable to turn fast skipping > off. > > If you could, I'd appreciate the output of wflinfo

Re: [Piglit] [Mesa-dev] [PATCH] Add (un)packHalf tests which don't fail on GCN

2016-02-05 Thread Marek Olšák
On Fri, Feb 5, 2016 at 3:56 PM, Roland Scheidegger <srol...@vmware.com> wrote: > Am 05.02.2016 um 15:44 schrieb Marek Olšák: >> On Fri, Feb 5, 2016 at 10:57 AM, Marek Olšák <mar...@gmail.com> wrote: >>> On Fri, Feb 5, 2016 at 1:55 AM, Matt Turner <matts...@gma

Re: [Piglit] [Mesa-dev] [PATCH] Add (un)packHalf tests which don't fail on GCN

2016-02-05 Thread Marek Olšák
On Fri, Feb 5, 2016 at 7:11 PM, Roland Scheidegger <srol...@vmware.com> wrote: > Am 05.02.2016 um 17:04 schrieb Marek Olšák: >> On Fri, Feb 5, 2016 at 4:48 PM, Roland Scheidegger <srol...@vmware.com> >> wrote: >>> Am 05.02.2016 um 16:08 schrieb Marek Olšák:

Re: [Piglit] [Mesa-dev] [PATCH] Add (un)packHalf tests which don't fail on GCN

2016-02-05 Thread Marek Olšák
On Fri, Feb 5, 2016 at 10:57 AM, Marek Olšák <mar...@gmail.com> wrote: > On Fri, Feb 5, 2016 at 1:55 AM, Matt Turner <matts...@gmail.com> wrote: >> On Thu, Feb 4, 2016 at 10:50 AM, Marek Olšák <mar...@gmail.com> wrote: >>> From: Marek Olšák <marek.

Re: [Piglit] [PATCH 04/11] framework/test/opengl.py: Add FastSkipMixin which checks extensions

2016-01-03 Thread Marek Olšák
On Sun, Jan 3, 2016 at 12:44 AM, Dylan Baker wrote: > Not off the top of my head. But I do have a patch Jose reviewed that would > probably cover the problem, (falling back to not fast skipping). What test > is it you're running? The issue seems to happen with all shader

Re: [Piglit] [PATCH 04/11] framework/test/opengl.py: Add FastSkipMixin which checks extensions

2016-01-01 Thread Marek Olšák
Hi Dylan, -p gbm seems to be broken: Traceback (most recent call last):ail: 62 / File "/home/marek/dev/piglit/framework/test/base.py", line 181, in execute self.run() File "/home/marek/dev/piglit/framework/test/base.py", line 235, in run self.is_skip() File

Re: [Piglit] [PATCH] Replace vs-tes-tessinner-tessouter-inputs with two new tests.

2015-12-19 Thread Marek Olšák
Reviewed-by: Marek Olšák <marek.ol...@amd.com> On Thu, Dec 17, 2015 at 9:06 PM, Kenneth Graunke <kenn...@whitecape.org> wrote: > (This is commit 42587e6d4bc8dd79be02b for the !TCS case.) > > vs-tes-tessinner-tessouter-inputs tried to verify that all vector > components

Re: [Piglit] [PATCH] fbo-depth-array: Fix reporting the piglit_result

2015-11-30 Thread Marek Olšák
Reviewed-by: Marek Olšák <marek.ol...@amd.com> On Nov 30, 2015 1:19 PM, "Neil Roberts" <n...@linux.intel.com> wrote: > test_once was ignoring the return value of draw_and_test_layer so the > test would report a pass even if it failed. > > Reported-by: Marek Olšák

Re: [Piglit] [PATCH] fbo-depth-array: Don't create an enormous color render target

2015-11-27 Thread Marek Olšák
Hi Neil, This patch breaks the test. Now it always reports "pass" even when it clearly prints failures. Marek On Thu, Oct 29, 2015 at 12:32 PM, Neil Roberts wrote: > When the -fbo option is given to the fbo-depth-array test it tries to > render to a range of different

Re: [Piglit] non-concurrent piglit tests

2015-11-21 Thread Marek Olšák
On Fri, Nov 20, 2015 at 11:19 PM, Ilia Mirkin wrote: > Right... so I'm looking for concrete things I can look for in tests to > determine whether the run_concurrent=False is set incorrectly. I know > the *approximate* reasons, but I'd like to be certain and then go grep > it

[Piglit] [PATCH 2/2] arb_clear_buffer_object-formats: use non-byte clear value

2015-11-08 Thread Marek Olšák
From: Marek Olšák <marek.ol...@amd.com> This exercises 16-bit and larger clear values which can't be lowered to 8-bit clears. The array was also insanely large for no reason. --- tests/spec/arb_clear_buffer_object/formats.c | 41 +--- 1 file changed, 7 insertions(

[Piglit] [PATCH 1/2] arb_clear_buffer_object-unaligned: new test for unaligned byte clears

2015-11-08 Thread Marek Olšák
From: Marek Olšák <marek.ol...@amd.com> --- tests/all.py | 1 + .../spec/arb_clear_buffer_object/CMakeLists.gl.txt | 1 + tests/spec/arb_clear_buffer_object/unaligned.c | 110 + 3 files changed, 112 insertions(+) creat

Re: [Piglit] [PATCH] Implement piglet to test GL_EXT_buffer_storage.

2015-11-03 Thread Marek Olšák
OR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL > + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OT

Re: [Piglit] [PATCH] Replace vs-tcs-tes-tessinner-tessouter-inputs with two new tests.

2015-10-21 Thread Marek Olšák
other uses >> triangles, but only probes the 3/1 components that are actually defined. >> >> Testing both types of domains is especially useful for i965, which >> stores the data in different layouts depending on the domain. > > I think r600 might have a s

Re: [Piglit] [PATCH 3/3] framework/sumamry/common.py: Fix subtest handling in non-all groups

2015-10-20 Thread Marek Olšák
Thanks. It works like a charm. Tested-by: Marek Olšák <marek.ol...@amd.com> Marek On Tue, Oct 20, 2015 at 12:34 AM, <baker.dyla...@gmail.com> wrote: > From: Dylan Baker <baker.dyla...@gmail.com> > > The gist of the problem is that we handle lookup for subtests i

[Piglit] "Problems" page doesn't show subtest failures

2015-10-17 Thread Marek Olšák
That's right. If you have a failing test with subtests, you won't see it on that page. Marek ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH] glsl-1.30/sampler-bug: test an existing GLSL or st/mesa compiler bug

2015-10-10 Thread Marek Olšák
From: Marek Olšák <marek.ol...@amd.com> --- .../spec/glsl-1.30/linker/sampler-bug.shader_test | 37 ++ 1 file changed, 37 insertions(+) create mode 100644 tests/spec/glsl-1.30/linker/sampler-bug.shader_test diff --git a/tests/spec/glsl-1.30/linker/sampler-bug.shade

Re: [Piglit] [PATCH] tests/general: add draw-sync to all.py

2015-10-09 Thread Marek Olšák
Thanks, I'm going to push this in a moment. Marek On Sun, Sep 6, 2015 at 10:58 AM, Albert Freeman wrote: > The draw-sync test (from 2011) was never placed in all.py. > > Signed-off-by: Albert Freeman > --- > Changed "!opengl 1.5" to

Re: [Piglit] [PATCH] tests/general: add draw-sync to all.py

2015-10-09 Thread Marek Olšák
Pushed, thanks. Marek On Sun, Sep 6, 2015 at 10:58 AM, Albert Freeman wrote: > The draw-sync test (from 2011) was never placed in all.py. > > Signed-off-by: Albert Freeman > --- > Changed "!opengl 1.5" to "!Opengl 1.1" as suggested by Eric

Re: [Piglit] [PATCH] tess/fp64: add some basic cross over tests

2015-09-30 Thread Marek Olšák
Reviewed-by: Marek Olšák <marek.ol...@amd.com> Marek On Wed, Sep 30, 2015 at 10:20 AM, Dave Airlie <airl...@gmail.com> wrote: > From: Dave Airlie <airl...@redhat.com> > > CTS tests this a lot better than piglit, but this is a good place > to start, I've got a

[Piglit] [PATCH] interpolate-at-sample-position: test center and centroid at the same time

2015-09-28 Thread Marek Olšák
From: Marek Olšák <marek.ol...@amd.com> This covers more cases. --- .../execution/interpolate-at-sample-position.cpp | 54 +++--- 1 file changed, 38 insertions(+), 16 deletions(-) diff --git a/tests/spec/arb_sample_shading/execution/interpolate-at-sample-position.cpp b

Re: [Piglit] gl_PointSize, vs-point_size-zero test

2015-09-22 Thread Marek Olšák
The point size clamping should take place after transform feedback, i.e. not in the shader. Marek On Tue, Sep 22, 2015 at 5:20 AM, Tapani Pälli wrote: > Hi; > > I noticed that i965 driver currently fails vs-point-size-zero test. > > I have a fix for this where I clamp

Re: [Piglit] [PATCH] arb_copy_image: add new format swizzle test

2015-09-04 Thread Marek Olšák
Hi Brian, You don't need to spend more time on the swizzling for ARB_copy_image if you don't want to. I have it almost done: http://cgit.freedesktop.org/~mareko/mesa/commit/?h=arb-copy-image Marek On Tue, Sep 1, 2015 at 4:14 PM, Brian Paul wrote: > Check that copies between

Re: [Piglit] [PATCH] arb_copy_image: add new format swizzle test

2015-09-04 Thread Marek Olšák
On Fri, Sep 4, 2015 at 8:56 PM, Brian Paul wrote: > Nice, though, I'd like my first patch of the series which reworks the dd > interface to go in. It also cleans up some questionable/unneeded temporary > texture creating/binding code. Yeah, I've been waiting for that. Marek

Re: [Piglit] [PATCH] winsys-framework Default to showing window

2015-08-21 Thread Marek Olšák
Hi Alex, The tests which don't specifically test the behavior of the default framebuffer should use -fbo. I think this is done by marking a test as concurrent in all.py. A lot of tests don't do that, because nobody had the time to update all.py and check if it doesn't break them and if it's okay

[Piglit] [PATCH] ext_depth_bounds_test: new test for the extension

2015-08-13 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/spec/CMakeLists.txt | 1 + tests/spec/ext_depth_bounds_test/CMakeLists.gl.txt | 14 ++ tests/spec/ext_depth_bounds_test/CMakeLists.txt| 1 + tests/spec/ext_depth_bounds_test/depth_bounds.c| 160

Re: [Piglit] [PATCH] ext_depth_bounds_test: new test for the extension

2015-08-13 Thread Marek Olšák
On Thu, Aug 13, 2015 at 10:17 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Thu, Aug 13, 2015 at 4:11 PM, Marek Olšák mar...@gmail.com wrote: From: Marek Olšák marek.ol...@amd.com --- tests/spec/CMakeLists.txt | 1 + tests/spec/ext_depth_bounds_test

Re: [Piglit] [PATCH] ext_depth_bounds_test: new test for the extension

2015-08-13 Thread Marek Olšák
Also this: diff --git a/tests/all.py b/tests/all.py index 07cf557..03d7617 100644 --- a/tests/all.py +++ b/tests/all.py @@ -1853,6 +1853,10 @@ with profile.group_manager( 'PROGRAM_BINARY_RETRIEVABLE_HINT') with profile.group_manager( +PiglitGLTest, grouptools.join('spec',

Re: [Piglit] [PATCH] tess: avoid reading past the end of the gl_in array

2015-08-07 Thread Marek Olšák
It would be nice to keep these tests under names that say they test out-of-bounds accesses. Marek On Wed, Jul 29, 2015 at 5:45 PM, Ilia Mirkin imir...@alum.mit.edu wrote: Reading off the end causes out-of-bounds errors on nouveau, and one might think that it's somehow barrier-related given the

Re: [Piglit] [PATCH] arb_transform_feedback3: test for an incorrect assert in mesa/st

2015-07-30 Thread Marek Olšák
that: Reviewed-by: Marek Olšák marek.ol...@amd.com Marek ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 08/10] arb_tessellation_shader: add tests for partial output writes

2015-07-28 Thread Marek Olšák
On Tue, Jul 28, 2015 at 2:32 AM, Ilia Mirkin imir...@alum.mit.edu wrote: On Mon, Jul 27, 2015 at 8:02 PM, Marek Olšák mar...@gmail.com wrote: From: Chris Forbes chr...@ijw.co.nz These cases are interesting for i965 because writemasks for URB writes require careful code generation

[Piglit] [PATCH] arb_tessellation_shader: Test large uniforms arrays. (v3)

2015-07-28 Thread Marek Olšák
From: Fabian Bieler fabianbie...@fastmail.fm Test uniform arrays of maximal size as well as arrays of uniform blocks. Also test for the required linking errors if too large uniform arrays are requested. v2: Marek - removed commented out code v3: added missing TCS and TES Reviewed-by: Marek

[Piglit] [PATCH] compressedteximage: bump the texture size to reproduce a radeonsi bug

2015-07-27 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/texturing/compressedteximage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/texturing/compressedteximage.c b/tests/texturing/compressedteximage.c index e2ed202..cec492e 100644 --- a/tests/texturing/compressedteximage.c

[Piglit] [PATCH] compressedteximage: bump the texture size to reproduce a radeonsi bug (v2)

2015-07-27 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com v2: for some reason, the bigger size has more precision issues --- tests/texturing/compressedteximage.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/texturing/compressedteximage.c b/tests/texturing/compressedteximage.c index

[Piglit] [PATCH 08/10] arb_tessellation_shader: add tests for partial output writes

2015-07-27 Thread Marek Olšák
Forbes chr...@ijw.co.nz Reviewed-by: Marek Olšák marek.ol...@amd.com --- .../execution/patch-partial-write.shader_test | 64 ++ .../execution/vertex-partial-write.shader_test | 64 ++ 2 files changed, 128 insertions(+) create mode 100644 tests

[Piglit] [PATCH 05/10] arb_tessellation_shader: Add various simple cases for TCS input reads

2015-07-27 Thread Marek Olšák
From: Chris Forbes chr...@ijw.co.nz v2: fixed by Marek Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Marek Olšák marek.ol...@amd.com --- .../tcs-input-read-array-interface.shader_test | 70 + .../execution/tcs-input-read-mat.shader_test | 68

[Piglit] [PATCH 09/10] gen_builtin_uniform_tests.py: Add tessellation control shader tests.

2015-07-27 Thread Marek Olšák
From: Fabian Bieler fabianbie...@fastmail.fm v2: fixed by Marek Reviewed-by: Marek Olšák marek.ol...@amd.com --- generated_tests/gen_builtin_uniform_tests.py | 137 ++- tests/shaders/shader_runner.c| 9 ++ 2 files changed, 142 insertions(+), 4 deletions

[Piglit] [PATCH 10/10] arb_tessellation_shader: Test large uniforms arrays.

2015-07-27 Thread Marek Olšák
From: Fabian Bieler fabianbie...@fastmail.fm Test uniform arrays of maximal size as well as arrays of uniform blocks. Also test for the required linking errors if too large uniform arrays are requested. v2: Marek - removed commented out code Reviewed-by: Marek Olšák marek.ol...@amd.com

[Piglit] [PATCH 04/10] arb_tessellation_shader: Add yet another fairly minimal case

2015-07-27 Thread Marek Olšák
. v2: fixed by Marek Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Marek Olšák marek.ol...@amd.com --- .../execution/patch-pair-verts.shader_test | 50 ++ 1 file changed, 50 insertions(+) create mode 100644 tests/spec/arb_tessellation_shader/execution/patch

[Piglit] [PATCH 07/10] arb_tessellation_shader: Simplify tcs-input tests.

2015-07-27 Thread Marek Olšák
From: Chris Forbes chr...@ijw.co.nz The purpose of these tests is not to exercise the compiler's optimization of writes from the TCS -- we'll explore that in other tests. Reviewed-by: Marek Olšák marek.ol...@amd.com --- generated_tests/gen_tcs_input_tests.py | 11 +-- 1 file changed, 5

[Piglit] [PATCH 03/10] arb_tessellation_shader: add tests for correct set of invocations

2015-07-27 Thread Marek Olšák
From: Chris Forbes chr...@ijw.co.nz These are interesting basic cases for i965, even without per-vertex outputs. v2: fixed by Marek Signed-off-by: Chris Forbes chr...@ijw.co.nz Reviewed-by: Marek Olšák marek.ol...@amd.com --- .../execution/invocation-counting-even.shader_test | 60

[Piglit] [PATCH 01/10] all.py: don't add unsupported texwrap test combinations

2015-07-27 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/all.py | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/all.py b/tests/all.py index de0342f..fbba3b9 100644 --- a/tests/all.py +++ b/tests/all.py @@ -153,8 +153,9 @@ def add_vpfpgeneric(adder, name): def

[Piglit] [PATCH 00/10] Last tessellation tests

2015-07-27 Thread Marek Olšák
Hi, These are Chris Forbes's patches mostly. Pretty much every patch had some bugs which had to be fixed. The first patch also disables some invalid texwrap tests. Please review. Marek ___ Piglit mailing list Piglit@lists.freedesktop.org

[Piglit] [PATCH 06/10] arb_tessellation_shader: add tests to exercise gl_PrimitiveID

2015-07-27 Thread Marek Olšák
From: Chris Forbes chr...@ijw.co.nz v2: fixed by Marek Reviewed-by: Marek Olšák marek.ol...@amd.com --- .../execution/tcs-primitiveid.shader_test | 72 ++ .../execution/tes-primitiveid.shader_test | 68 2 files changed, 140 insertions

Re: [Piglit] Weekly 10 Picks from Patchwork for review and friendly reminder to clean out your old patches

2015-06-25 Thread Marek Olšák
It would be nice if patchwork could filter patches according to touched files. Marek On Tue, Jun 23, 2015 at 11:53 AM, Daniel Vetter dan...@ffwll.ch wrote: On Fri, Jun 19, 2015 at 09:12:15PM +0100, Jose Fonseca wrote: On 19/06/15 20:45, Ilia Mirkin wrote: On Fri, Jun 19, 2015 at 3:39 PM, Jose

Re: [Piglit] Weekly 10 Picks from Patchwork for review and friendly reminder to clean out your old patches

2015-06-21 Thread Marek Olšák
On Fri, Jun 19, 2015 at 10:12 PM, Jose Fonseca jfons...@vmware.com wrote: On 19/06/15 20:45, Ilia Mirkin wrote: On Fri, Jun 19, 2015 at 3:39 PM, Jose Fonseca jfons...@vmware.com wrote: On 19/06/15 13:32, Timothy Arceri wrote: Hi all, Unfortunately since its introduction patchwork hasn't

Re: [Piglit] [PATCH] gl-1.5-vertex-buffer-offsets: test unusual vertex offsets/strides

2015-06-19 Thread Marek Olšák
I don't see a point in calling piglit_present_results(). Other than that: Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Fri, Jun 19, 2015 at 4:39 PM, Brian Paul bri...@vmware.com wrote: The draw-vertices tests exercises unusual vertex sizes and strides, but not with interleaved arrays

Re: [Piglit] [PATCH 9/9] arb_separate_shader_objects: new test for SSO, GS and tessellation combined

2015-06-16 Thread Marek Olšák
On Tue, Jun 16, 2015 at 11:06 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Tue, Jun 16, 2015 at 4:57 PM, Marek Olšák mar...@gmail.com wrote: From: Marek Olšák marek.ol...@amd.com --- tests/all.py | 2 + .../arb_separate_shader_objects

[Piglit] [PATCH 8/9] piglit_util: allow calling piglit_draw_rect with separate shader objects

2015-06-16 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/util/piglit-util-gl.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c index 0ffb82c..04915be 100644 --- a/tests/util/piglit-util-gl.c +++ b/tests/util/piglit-util-gl.c

[Piglit] [PATCH 7/9] built-in-constants: fix tessellation compile failures

2015-06-16 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/shaders/built-in-constants.c | 8 1 file changed, 8 insertions(+) diff --git a/tests/shaders/built-in-constants.c b/tests/shaders/built-in-constants.c index dc428db..9eeb0d1 100644 --- a/tests/shaders/built-in-constants.c +++ b/tests

[Piglit] [PATCH 6/9] arb_program_interface_query/resource-query: tess tests need subroutines

2015-06-16 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/spec/arb_program_interface_query/resource-query.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/spec/arb_program_interface_query/resource-query.c b/tests/spec/arb_program_interface_query/resource-query.c index 1db5585

[Piglit] [PATCH 1/9] glslparsertest: fix tessellation shader tests by adding all required shaders

2015-06-16 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/glslparsertest/glslparsertest.c | 9 + 1 file changed, 9 insertions(+) diff --git a/tests/glslparsertest/glslparsertest.c b/tests/glslparsertest/glslparsertest.c index b969eff..924d322 100644 --- a/tests/glslparsertest/glslparsertest.c

[Piglit] [PATCH 9/9] arb_separate_shader_objects: new test for SSO, GS and tessellation combined

2015-06-16 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/all.py | 2 + .../arb_separate_shader_objects/CMakeLists.gl.txt | 1 + .../rendezvous_by_location-5-stages.c | 218 + 3 files changed, 221 insertions(+) create mode 100644

[Piglit] [PATCH 3/9] arb_tessellation_shader: test indirect writes to TCS outputs before a barrier

2015-06-16 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- ...array-float-index-wr-before-barrier.shader_test | 223 + ...-array-vec2-index-wr-before-barrier.shader_test | 223 + ...-array-vec3-index-wr-before-barrier.shader_test | 223 + ...-array-vec4

[Piglit] [PATCH 4/9] arb_tessellation_shader: test gl_TessLevelOuter and gl_TessLevelInner TES inputs

2015-06-16 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- ...-tcs-tes-tessinner-tessouter-inputs.shader_test | 64 ++ .../vs-tes-tessinner-tessouter-inputs.shader_test | 55 +++ 2 files changed, 119 insertions(+) create mode 100644 tests/spec/arb_tessellation_shader

[Piglit] [PATCH 5/9] arb_tessellation_shader/compiler: test gl_out indexing with a writemask

2015-06-16 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- .../compiler/gl_out-indexing-writemask.tesc| 14 ++ 1 file changed, 14 insertions(+) create mode 100644 tests/spec/arb_tessellation_shader/compiler/gl_out-indexing-writemask.tesc diff --git a/tests/spec

[Piglit] [PATCH 2/9] arb_tessellation_shader: test indirect reads from TCS outputs after a barrier

2015-06-16 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- ...-array-float-index-rd-after-barrier.shader_test | 236 + ...t-array-vec2-index-rd-after-barrier.shader_test | 236 + ...t-array-vec3-index-rd-after-barrier.shader_test | 236 + ...t-array

[Piglit] [PATCH] egl-gl-colorspace: new test for the EGL extension

2015-06-10 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/all.py | 7 +++ tests/egl/CMakeLists.gl.txt | 2 + tests/egl/egl-gl-colorspace.c | 107 ++ tests/egl/egl-util.c | 4 +- tests/egl/egl-util.h | 1 + 5 files changed

Re: [Piglit] [PATCH 00/40] Replace vpfp-generic with shader_runner.

2015-06-09 Thread Marek Olšák
The clearing could be done by shader_runner automatically, tests shouldn't have to do it manually. Marek On Tue, Jun 9, 2015 at 1:06 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Mon, Jun 8, 2015 at 9:48 PM, Michel Dänzer mic...@daenzer.net wrote: On 08.06.2015 19:35, Ilia Mirkin wrote: This

Re: [Piglit] [PATCH 00/40] Replace vpfp-generic with shader_runner.

2015-06-08 Thread Marek Olšák
I recently ran into this. A tessellation test passed when it shouldn't. That was pretty weird. The driver or hw was dropping draw calls for some reason, yet most of the time the test passed. The solution: http://cgit.freedesktop.org/piglit/commit/?id=98c92d7bb2b80954912d9f8004e7810e7d21ff20

Re: [Piglit] [PATCH] cmake: Only build GLES tests by default on systems which support EGL.

2015-06-08 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Mon, Jun 8, 2015 at 2:43 PM, Jose Fonseca jfons...@vmware.com wrote: GLES tests require EGL support, so it only make sense that they are on on systems which support EGL, which is Linux ATM. --- CMakeLists.txt | 12 +--- 1 file

Re: [Piglit] [PATCH 2/2] Enable building of GLES tests by default

2015-05-25 Thread Marek Olšák
Ping On Mon, May 18, 2015 at 2:06 PM, Marek Olšák mar...@gmail.com wrote: From: Marek Olšák marek.ol...@amd.com --- CMakeLists.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 2208dc7..9152066 100644 --- a/CMakeLists.txt

[Piglit] [PATCH 2/2] Enable building of GLES tests by default

2015-05-18 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- CMakeLists.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 2208dc7..9152066 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -33,9 +33,9 @@ endif() option(PIGLIT_BUILD_GL_TESTS

[Piglit] [PATCH 1/2] cl: only build interop tests if GLES2 is enabled

2015-05-18 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/cl/interop/CMakeLists.cl.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/cl/interop/CMakeLists.cl.txt b/tests/cl/interop/CMakeLists.cl.txt index d53e986..d8dc73a 100644 --- a/tests/cl/interop/CMakeLists.cl.txt

Re: [Piglit] [PATCH] dispatch: Fix lookup for core OpenGL symbols

2015-04-30 Thread Marek Olšák
Thanks for doing this. Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Thu, Apr 30, 2015 at 4:29 AM, Chad Versace chad.vers...@intel.com wrote: The following commit regressed lookup of some new OpenGL symbols: commit cb334db3f2bb7ddf9b2f43641f898896f99c69b1 Author: Daniel

[Piglit] [PATCH] framework: use the correct executable for GLES parser tests

2015-04-30 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- framework/test/glsl_parser_test.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/framework/test/glsl_parser_test.py b/framework/test/glsl_parser_test.py index 0ab3b0e..964cdb5 100644 --- a/framework/test/glsl_parser_test.py

[Piglit] [PATCH 10/10] arb_tessellation_shader: add tests for indirect addressing of all TES inputs (v2)

2015-04-30 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com i.e. both patch and non-patch types. This tests 64 inputs and outputs - more than any other shader can have. v2: - use do {} while(0) for the macro - only use 120 patch output components --- ...tes-both-input-array-float-index-rd.shader_test | 247

[Piglit] [PATCH 08/10] arb_tessellation_shader: add tests for indirect addressing of TES inputs (v2)

2015-04-30 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com v2: use do {} while(0) for the macro --- .../tes-input-array-float-index-rd.shader_test | 237 + .../tes-input-array-vec2-index-rd.shader_test | 237 + .../tes-input-array-vec3-index-rd.shader_test | 237

[Piglit] [PATCH 04/10] arb_tessellation_shader: add tests for indirect addressing of VS outputs w/ TCS

2015-04-30 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- ...put-array-float-index-wr-before-tcs.shader_test | 224 + ...tput-array-vec2-index-wr-before-tcs.shader_test | 224 + ...tput-array-vec3-index-wr-before-tcs.shader_test | 224 + ...tput-array

[Piglit] [PATCH 03/10] glsl-1.50: add tests for indirect addressing of GS inputs (v2)

2015-04-30 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com v2: - use length() - update the require section --- .../gs-input-array-float-index-rd.shader_test | 218 + .../gs-input-array-vec2-index-rd.shader_test | 218 + .../gs-input-array-vec3-index

[Piglit] [PATCH 06/10] arb_tessellation_shader: add tests for indirect addressing of TCS patch outputs (v2)

2015-04-30 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com v2: - use do {} while(0) for the macro - only use 120 patch output components --- ...s-patch-output-array-float-index-wr.shader_test | 214 + ...cs-patch-output-array-vec2-index-wr.shader_test | 214 + ...cs-patch

[Piglit] [PATCH 01/10] shader_runner: allow GL_MAX_VERTEX_OUTPUT_COMPONENTS in requirements

2015-04-30 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/shaders/shader_runner.c | 9 + 1 file changed, 9 insertions(+) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index 4063bdd..d6d6f55 100644 --- a/tests/shaders/shader_runner.c +++ b/tests/shaders/shader_runner.c

Re: [Piglit] [PATCH 13/14] dispatch: Use dlsym to lookup core symbols for EGL

2015-04-29 Thread Marek Olšák
Correction: Only 2 pipeline statistics tests were broken, so all seems to be good (except those 2 tests). Marek On Tue, Apr 28, 2015 at 3:18 PM, Marek Olšák mar...@gmail.com wrote: Hi Chad, The patch breaks GetProcAddress for libGL, because libGL doesn't export a lot of GL functions

<    1   2   3   4   5   6   >