Re: [Piglit] v3: ext_memory_object: Test sampling memory exported from Vulkan

On Thu, Dec 21, 2017 at 11:55:07AM -0500, Andres Rodriguez wrote: > > I'm not familiar enough with the framework patches to give you a review > there, hopefully someone else can chime in on those. > > Patches 5, 7, 10 are: > > Reviewed-by: Andres Rodriguez > > Other

Re: [Piglit] [v3 06/11] ext_memory_object: Support for setting up vulkan framebuffer

On Thu, Dec 21, 2017 at 11:25:04AM -0500, Andres Rodriguez wrote: > > > On 2017-12-21 07:02 AM, Topi Pohjolainen wrote: > > v2: Store image size in order to know how much memory to import, > > see glImportMemoryFdEXT(). > > > > v3: > > - use "goto fail" for all failure paths (Andres)

Re: [Piglit] [v3 04/11] ext_memory_object: Support for setting up vulkan device

On Thu, Dec 21, 2017 at 11:03:15AM -0500, Andres Rodriguez wrote: > > > On 2017-12-21 07:02 AM, Topi Pohjolainen wrote: > > v2: > > - drop magic number in allocator (Andres) > > - fix indentation (Andres) > > - allow more than one physical device (Andres) > > - fix indentation

Re: [Piglit] [PATCH v2 3/37] glean/tfragprog1: port ADD tests to shader_runner

On Tue, Sep 06, 2016 at 12:20:41PM -0700, Dylan Baker wrote: > This ports the following tests: > - ADD test > - ADD with saturation > - ADD an immediate > - ADD negative immediate > > It does not port ADD negative "immediate (2)", which adds MOV, MUL, and > swizzling. It might be a useful test

Re: [Piglit] [PATCH v2 2/37] glean/tfragprog1: port ABS test to shader_runner

On Tue, Sep 06, 2016 at 12:20:40PM -0700, Dylan Baker wrote: > Possible duplicate tests: > shaders/fp-abs-01.c > shaders/fp-abs-02.c > > Signed-off-by: Dylan Baker > --- > tests/all.py | 2 +- >

Re: [Piglit] [PATCH] arb_shading_language_420pack: Make compatible with 4.30.

On Mon, Jun 06, 2016 at 02:40:15PM -0700, Matt Turner wrote: > 4.30 removes gl_FragColor. In debugging bug 96320, I found it useful to > replace gl_FragColor with a user-defined varying so that the tests could > be run under GLSL 4.30. Reviewed-by: Topi Pohjolainen

Re: [Piglit] [PATCH 03/37] glean/tfragprog1: port ADD tests to shader_runner

On Fri, May 06, 2016 at 01:40:15PM -0700, Dylan Baker wrote: > Quoting Pohjolainen, Topi (2016-05-04 10:25:31) > [sni[ > > Okay, I don't how I mis-read the original tests so badly - CLAMP01 is the > > part > > that defines the expected value. Anyway, if we want ADD_SAT

Re: [Piglit] [PATCH 03/37] glean/tfragprog1: port ADD tests to shader_runner

On Tue, May 03, 2016 at 08:58:15AM -0700, Dylan Baker wrote: > > > On May 3, 2016 4:11:43 AM PDT, "Pohjolainen, Topi" > <topi.pohjolai...@intel.com> wrote: > >On Mon, May 02, 2016 at 02:59:05PM -0700, Dylan Baker wrote: > >> This ports the

Re: [Piglit] [PATCH 03/37] glean/tfragprog1: port ADD tests to shader_runner

On Mon, May 02, 2016 at 02:59:05PM -0700, Dylan Baker wrote: > This ports the following tests: > - ADD test > - ADD with saturation > - ADD an immediate > - ADD negative immediate > > It does not port ADD negative "immediate (2)", which adds MOV, MUL, and > swizzling. It might be a useful test

Re: [Piglit] [PATCH 3/4] Add a fast clear test for non-MSRT surfaces

On Wed, Nov 25, 2015 at 06:11:52PM +0100, Neil Roberts wrote: > ext_framebuffer_multisample-fast-clear can now take a parameter on the > command line to make it test a single-sample buffer instead. This is > worth testing at least on i965 because fast clears are handled > differently when

Re: [Piglit] [PATCH 4/4] Test blending a fast clear color with GL_FRAMEBUFFER_SRGB enabled

On Wed, Nov 25, 2015 at 06:11:53PM +0100, Neil Roberts wrote: > On SKL in the i965 driver there is some special handling of the fast > clear optimisation when GL_FRAMEBUFFER_SRGB is enabled because the > hardware can't cope with the fast clear buffer in that case and the > color buffer needs to be

Re: [Piglit] [PATCH 2/4] multisample-fast-clear: Test out-of-range values

On Wed, Nov 25, 2015 at 06:11:51PM +0100, Neil Roberts wrote: > The test colors now include negative values and values greater than > one. Instead of rendering the results into the window system buffer a > floating point texture is now created so that it can store values that > haven't been

Re: [Piglit] [PATCH 1/4] mulitsample-fast-clear: Test enabling GL_FRAMEBUFFER_SRGB

On Wed, Nov 25, 2015 at 06:11:50PM +0100, Neil Roberts wrote: There is a typo in the subject: "mulitsample-fast-clear" ^ > If ???enable-fb-srgb??? is given on the command line to the fast clear > test it will now enable GL_FRAMEBUFFER_SRGB before clearing the

Re: [Piglit] [PATCH 1/4] mulitsample-fast-clear: Test enabling GL_FRAMEBUFFER_SRGB

On Fri, Nov 27, 2015 at 11:03:05AM +0100, Neil Roberts wrote: > "Pohjolainen, Topi" <topi.pohjolai...@intel.com> writes: > > >>glBindFramebuffer(GL_FRAMEBUFFER, piglit_winsys_fbo); > >>piglit_draw_rect(offset * 16 * 2.0f / piglit_width - 1.

Re: [Piglit] [PATCH 06/25] arb_direct_state_access: Use piglit_reset_gl_error in texunits

On Mon, May 18, 2015 at 01:49:59PM -0700, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com This is also: Reviewed-by: Topi Pohjolainen topi.pohjolai...@intel.com Unfortunately I don't have much input for the rest of the

Re: [Piglit] [PATCH 1/5] arb_uniform_buffer_object: Random test generation infrastructure

On Mon, Nov 03, 2014 at 11:10:25AM +0200, Tapani wrote: On 09/24/2014 07:47 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com This is the core of the random test generation infrastructure. This Python script can be used stand-alone to generate fully random tests, or it

Re: [Piglit] Tests for GL_OES_EGL_image_external

On Sun, Sep 14, 2014 at 04:35:38AM +, Sundareson, Prabindh wrote: Hello Eric, Topi, I was looking for compliance tests for GL_OES_EGL_image_external, and saw a discussion [1] in the archives last year. I could not see any follow ups to this, and it appears unmerged as it is not in the

Re: [Piglit] [PATCH] ext_image_dma_buf_import: update ownership_transfer test

On Fri, Aug 08, 2014 at 02:50:26PM +0300, Pekka Paalanen wrote: From: Pekka Paalanen pekka.paala...@collabora.co.uk The EGL_EXT_image_dma_buf_import specification was revised (according to its revision history) on Dec 5th, 2013, for EGL to not take ownership of the file descriptors.

Re: [Piglit] [PATCH 1/7] ARB_explicit_uniform_location: test for uniform location boundary values

On Thu, Mar 13, 2014 at 11:24:46AM -0700, Anuj Phogat wrote: On Thu, Mar 13, 2014 at 5:41 AM, Tapani Pälli tapani.pa...@intel.com wrote: Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- tests/all.py | 1 + .../CMakeLists.gl.txt

Re: [Piglit] [PATCH 2/7] ARB_explicit_uniform_location: test sequential array elements

On Thu, Mar 13, 2014 at 02:41:44PM +0200, Tapani P?lli wrote: Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- tests/all.py | 1 + .../CMakeLists.gl.txt | 1 + .../arb_explicit_uniform_location/array-elements.c |

Re: [Piglit] [V2 2/8] ARB_explicit_uniform_location: test sequential array elements

On Fri, Mar 14, 2014 at 01:23:23PM +0200, Tapani P?lli wrote: v2: set values directly to shader, simplify overall (Topi) fix style issues, use asprintf (Anuj) Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- tests/all.py | 1 +

Re: [Piglit] [PATCH 1/7] ARB_explicit_uniform_location: test for uniform location boundary values

On Thu, Mar 13, 2014 at 02:41:43PM +0200, Tapani P?lli wrote: Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- tests/all.py | 1 + .../CMakeLists.gl.txt | 1 + .../arb_explicit_uniform_location/loc-minmax.c |

Re: [Piglit] [PATCH 1/2] arb_gpu_shader5: Add shader tests to verify 'invocations' layout qualifier

On Wed, Feb 12, 2014 at 10:11:20AM -0800, Anuj Phogat wrote: Signed-off-by: Anuj Phogat anuj.pho...@gmail.com Both are: Reviewed-by: Topi Pohjolainen topi.pohjolai...@intel.com --- .../execution/invocations-conflicting.shader_test | 47 ++

Re: [Piglit] [PATCH] Add a rendering test for GL_ARB_stencil_texturing.

On Tue, Feb 11, 2014 at 08:12:27PM -0800, Kenneth Graunke wrote: The GL_ARB_stencil_texturing extension allows sampling from either the depth or stencil components of combined GL_DEPTH_STENCIL textures. To select which component to sample, applications can call TexParameter with a pname of

Re: [Piglit] [PATCH 1/2] Test that continue works properly inside a do-while loop.

On Fri, Jan 31, 2014 at 01:12:09PM -0800, Paul Berry wrote: --- .../glsl-fs-continue-inside-do-while.shader_test | 51 + .../glsl-vs-continue-inside-do-while.shader_test | 52 ++ 2 files changed, 103 insertions(+) create mode 100644

Re: [Piglit] [PATCH 1/8] layered-rendering/blit: use color other than the default red

On Sun, Jan 26, 2014 at 11:29:45PM -0800, Kenneth Graunke wrote: On 01/26/2014 01:34 AM, Topi Pohjolainen wrote: Passes on nvidia and on IVB using blt-engine and mesa fallback path but fails on IVB using blorp (both before and after the recent refactoring): Probe color at (32,0)

Re: [Piglit] [PATCH 5/7] pack_depth_stencil: Create textures with GL_DEPTH_STENCIL base format

On Tue, Jan 14, 2014 at 01:23:10PM -0800, Ian Romanick wrote: On 12/21/2013 03:24 AM, Pohjolainen, Topi wrote: On Thu, Dec 19, 2013 at 11:37:33AM -0800, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Depending on the GL version and extensions supported, this should either

Re: [Piglit] [PATCH 5/7] pack_depth_stencil: Create textures with GL_DEPTH_STENCIL base format

On Thu, Dec 19, 2013 at 11:37:33AM -0800, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Depending on the GL version and extensions supported, this should either work (not generate a GL error) or generate a variety of GL errors. This test passes on NVIDIA (304.64 on GTX

Re: [Piglit] [v4 08/11] arb_transform_feedback3: add test for interleaved in max buffers

On Fri, Nov 22, 2013 at 01:47:23PM -0800, Ian Romanick wrote: On 11/14/2013 04:20 AM, Topi Pohjolainen wrote: Passes on NVIDIA (304.88 on GTX 660) and on Ivy Bridge. v2: - fixed indentation: spaces - tabs (Ian) - require core/compatibility version 3.2 instead of

Re: [Piglit] [RFC 1/3] hack: enable shader runner on 4.2.0 NVIDIA 304.88

On Wed, Oct 16, 2013 at 10:25:00AM -0500, Ken Phillis Jr wrote: On Wed, Oct 16, 2013 at 12:43 AM, Pohjolainen, Topi topi.pohjolai...@intel.com wrote: I don't know why it fixes it, I just tried it without the visual settings and found out that I could run

Re: [Piglit] [RFC 1/3] hack: enable shader runner on 4.2.0 NVIDIA 304.88

On Thu, Oct 17, 2013 at 12:13:06PM +0300, Pohjolainen, Topi wrote: On Wed, Oct 16, 2013 at 10:25:00AM -0500, Ken Phillis Jr wrote: On Wed, Oct 16, 2013 at 12:43 AM, Pohjolainen, Topi topi.pohjolai...@intel.com wrote: I don't know why it fixes it, I just tried it without

Re: [Piglit] [RFC 1/3] hack: enable shader runner on 4.2.0 NVIDIA 304.88

On Tue, Oct 15, 2013 at 09:15:52AM -0600, Brian Paul wrote: On 10/15/2013 05:49 AM, Topi Pohjolainen wrote: Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- tests/shaders/shader_runner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Piglit] [PATCH 0/4] Fix build on systems with Mesa 9.2 or without libdrm

On Tue, Sep 10, 2013 at 11:07:50AM -0700, Chad Versace wrote: Ian recently discovered that Topi's new dma_buf tests break the build on Linux systems with libdrm2.4.28. And I discovered that they broke the build on systems with Mesa 9.2. No surprise, really, since these tests do some wacky

Re: [Piglit] [PATCH 4/4] ext_image_dma_buf_import: Fix build with mesa 9.2

On Tue, Sep 10, 2013 at 11:07:54AM -0700, Chad Versace wrote: The extension EGL_EXT_image_dma_buf_import is a recent extension, published 2013-02-09, and therefore the eglext.h on many systems do not define it. The first Mesa version in which eglext.h defined the extension was was Mesa 9.2.

Re: [Piglit] [PATCH 2/4] cmake, dma_buf: Require xcb-dri2 for dma_buf tests

On Tue, Sep 10, 2013 at 11:07:52AM -0700, Chad Versace wrote: xcb-dri2 is an optional build dependency for the dma_buf tests. If xcb-dri2 is present, then the tests use it to gain DRM authentication. Otherwise, the tests must be ran as root. No one likes running tests as root, so require

Re: [Piglit] [PATCH] gs: Test corner case for triangle strip ordering with primitive restart.

On Wed, Aug 28, 2013 at 12:12:40PM -0700, Paul Berry wrote: Verified using the NVIDIA proprietary driver for linux. --- tests/all.tests| 6 + .../glsl-1.50/execution/geometry/CMakeLists.gl.txt | 1 + .../tri-strip-ordering-with-prim-restart.c |

Re: [Piglit] [PATCH 12/13 v2] glsl: Enhance built-in-constants to test extensions too

On Mon, Aug 26, 2013 at 07:15:27PM -0700, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com v2: Use an array of pointers to char for required_extensions (using strndup) instead of the previous static buffer cleverness. Also replace the previous cleverness for generating the

Re: [Piglit] [v7 07/12] tests: spec: EXT_image_dma_buf_import fd ownership transfer

On Tue, May 28, 2013 at 12:17:37PM -0700, Eric Anholt wrote: Topi Pohjolainen topi.pohjolai...@intel.com writes: Simple test checking that EGL closes the export file handle and the creator can in turn drop its reference. v2: - compile only on platforms that have drm (Eric) -

Re: [Piglit] [v6] Tests for EXT_image_dma_buf_import

On Tue, May 21, 2013 at 12:09:31AM +0200, Daniel Vetter wrote: On Thu, May 16, 2013 at 12:51:13PM +0300, Topi Pohjolainen wrote: Here are some tests for the dma buffer importing. These are mostly things specifically listed down in the spec itself regarding attributes and their values. This

Re: [Piglit] [v5 01/12] util: egl: support for skipping unsupported extension tests

On Tue, May 14, 2013 at 11:23:30AM -0700, Eric Anholt wrote: Chad Versace chad.vers...@linux.intel.com writes: On 05/03/2013 04:26 AM, Topi Pohjolainen wrote: Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- tests/util/piglit-util-egl.c | 9 +

Re: [Piglit] [v4 4/4] tests: spec: tests for EXT_image_dma_buf_import

On Fri, May 03, 2013 at 10:54:12AM +0200, Daniel Vetter wrote: On Thu, May 02, 2013 at 04:57:49PM -0700, Eric Anholt wrote: +#define fourcc_code(a,b,c,d) ((uint32_t)(a) | ((uint32_t)(b) 8) | \ + ((uint32_t)(c) 16) | ((uint32_t)(d) 24)) +#define

Re: [Piglit] [PATCH 2/3] framework: support for creating dma buffers through libdrm

On Wed, Apr 24, 2013 at 03:35:08PM +0200, Chad Versace wrote: On 04/16/2013 12:45 PM, Topi Pohjolainen wrote: In order to test EXT_image_dma_buf_import one needs the capability of creating driver specific buffers. By probing the environment for drm libraries one can decide for which drivers

Re: [Piglit] [v2 1/3] framework: introduce interface for external buffers

On Mon, Mar 11, 2013 at 10:31:33AM -0700, Eric Anholt wrote: Topi Pohjolainen topi.pohjolai...@intel.com writes: In order to test the OES_EGL_image_external with planar formats such as YUV420 or NV12, one needs a way for creating buffers that can be passed to EGL and filling them with