[Piglit] [PATCH] ext_packed_float: Add a test that queries GL_RGBA_SIGNED_COMPONENTS_EXT

2018-05-09 Thread Timothy Arceri
From: Bruce Merry Cc: Brian Paul Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=73096 --- I came across this test when cleaning up bugzilla. Seems we fixed Mesa but never pushed the piglit test. tests/all.py |

[Piglit] [PATCH] piglit-framework-gl: skip compat test when not supported

2018-05-01 Thread Timothy Arceri
OpenGL 3.1 is a little special when it comes to compatibility. If a 3.1 compat profile is requested by piglit and ARB_compatibility not supported waffle will end up creating a core profile for us. Here we make sure ARB_compatibility is supported when explicitly requesting a 3.1 compat profile

[Piglit] [PATCH 2/2] glsl-1.40-compat: add basic compat test for built-in constants

2018-04-23 Thread Timothy Arceri
This test is copied from the glsl-1.10 tests. We just want to be sure that these built-in are still available in a compat profile. This was broken when compat was enabled for OpenGL 3.1 in radeonsi. This test will help us from regressing again in future. ---

[Piglit] [PATCH 1/2] shader_runner: allow compat profiles to be explicitly requested

2018-04-23 Thread Timothy Arceri
Until now compat profile has only been a fallback path if a core profile could not be created. --- tests/shaders/shader_runner.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index

[Piglit] [PATCH 4/4] glsl-1.20: exercise bug in parameter out handling in Mesa

2018-04-09 Thread Timothy Arceri
--- ...ersion-int-to-float-vec4-index.shader_test | 48 +++ 1 file changed, 48 insertions(+) create mode 100644 tests/spec/glsl-1.20/execution/qualifiers/vs-out-conversion-int-to-float-vec4-index.shader_test diff --git

[Piglit] [PATCH 1/4] glsl-1.10: rename function chain test and better test the inout param

2018-04-09 Thread Timothy Arceri
From: Timothy Arceri <t_arc...@yahoo.com.au> The following patch will add a number of variants of this test so we want to give it a more descriptive name. --- .../function-calls/glsl-function-chain16-inout.shader_test} | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) rename

[Piglit] [PATCH 2/4] glsl-1.10: add a number of new function parameter tests

2018-04-09 Thread Timothy Arceri
These all have long function call chains, so that some remain intact when Mesas GLSLOptimizeConservatively flag is set. This allows us to exercise the GLSL IR -> NIR path for functions and NIRs function inlining code. --- ...tion-chain16-in-array-indirect.shader_test | 74 +++

[Piglit] [PATCH 3/4] glsl-1.20: move the parameter out tests to glsl-1.20

2018-04-09 Thread Timothy Arceri
--- .../out-parameter-indexing/fs-inout-index-two-level.shader_test | 0 .../vs-inout-index-inout-float-array.shader_test | 0 .../vs-inout-index-inout-mat2-col-array.shader_test | 0 .../vs-inout-index-inout-mat2-col.shader_test | 0

Re: [Piglit] [PATCH 15/15] arb_tessellation_shader: add a test with an array in a struct in a per-vertex TCS out

2018-04-03 Thread Timothy Arceri
On 27/03/18 10:32, Marek Olšák wrote: From: Nicolai Hähnle This currently hits a bug in Mesa's GLSL-to-TGSI conversion. --- .../tcs-tes-array-in-struct.shader_test| 78 ++ 1 file changed, 78 insertions(+) create mode 100644

[Piglit] [PATCH] glsl: test for LLVM Error: Terminator found in the middle of a basic block

2018-04-02 Thread Timothy Arceri
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105317 --- ...fs-nested-loop-unrolled-with-return.shader_test | 40 ++ 1 file changed, 40 insertions(+) create mode 100644 tests/spec/glsl-1.10/execution/fs-nested-loop-unrolled-with-return.shader_test diff --git

[Piglit] [PATCH] glsl-1.10: test that loop unrolling doesnt create an infinite loop

2018-03-27 Thread Timothy Arceri
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105670 --- ...vs-loop-complex-unroll-nested-break.shader_test | 48 ++ 1 file changed, 48 insertions(+) create mode 100644 tests/spec/glsl-1.10/execution/vs-loop-complex-unroll-nested-break.shader_test diff --git

[Piglit] [PATCH] glsl-1.10: test divide by zero doesn't crash constant evaluation

2018-03-01 Thread Timothy Arceri
Cc: Jason Ekstrand Cc: Mark Janes --- .../fs-loop-unrolled-divide-by-zero.shader_test| 31 ++ 1 file changed, 31 insertions(+) create mode 100644 tests/spec/glsl-1.10/linker/fs-loop-unrolled-divide-by-zero.shader_test diff

Re: [Piglit] [PATCH] ext_transform_feedback-interleaved: disable unneeded printfs()

2017-12-18 Thread Timothy Arceri
Probably should just remove it but I don't really care either way so: Reviewed-by: Timothy Arceri <tarc...@itsqueeze.com> On 19/12/17 09:23, Brian Paul wrote: No need to print passing cases. Reduced log noise. --- tests/spec/ext_transform_feedback/interleaved.c | 3 ++- 1 file chan

Re: [Piglit] Move and rename tests from bugs/ to spec/ directory.

2017-12-17 Thread Timothy Arceri
Thanks for doing this! Series: Reviewed-by: Timothy Arceri <tarc...@itsqueeze.com> On 17/12/17 06:20, Fabian Bieler wrote: Also includes some formatting fixes, updated some comments (particularly added license comments) and corrected value of config.supports_gl_compat_version in some

Re: [Piglit] [PATCH] all.py: add entry for ext_occlusion_query_boolean

2017-12-13 Thread Timothy Arceri
Reviewed-by: Timothy Arceri <tarc...@itsqueeze.com> On 11/12/17 17:19, Tapani Pälli wrote: commit 68a003409 forgot to add this Signed-off-by: Tapani Pälli <tapani.pa...@intel.com> --- tests/all.py | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/all.py b/tests/

Re: [Piglit] [PATCH 2/2] ssbo/linker: move some linker tests to using a fragment shader ssbo

2017-11-17 Thread Timothy Arceri
Series: Reviewed-by: Timothy Arceri <tarc...@itsqueeze.com> On 17/11/17 13:02, Dave Airlie wrote: From: Dave Airlie <airl...@redhat.com> --- .../linker/implicit_size_array_member.shader_test | 7 +++ .../linker/sized_arrays_of_arrays_member

Re: [Piglit] [PATCH 5/5] ssbo/linking: add check for vertex ssbo support.

2017-11-17 Thread Timothy Arceri
Series: Reviewed-by: Timothy Arceri <tarc...@itsqueeze.com> On 17/11/17 12:53, Dave Airlie wrote: From: Dave Airlie <airl...@redhat.com> skip if we don't support and vertex ssbos --- ...stance-matching-shader-storage-blocks-array-size-mismatch.shader_test | 1 + ...matching-sh

Re: [Piglit] [PATCH] arb_enhanced_layouts: add test for location aliasing with non-numerical type

2017-11-09 Thread Timothy Arceri
iasing. Yeah I wrote that code but looking at it now I'm not sure if its correct. The problem with structs is nesting, it could get very complicated trying to figure out packing with a struct. Let's drop this patch for now. Iago On Thu, 2017-11-09 at 12:43 +1100, Timothy Arceri wrote: On 06/11

Re: [Piglit] [PATCH] arb_enhanced_layouts: add test for location aliasing with non-numerical type

2017-11-08 Thread Timothy Arceri
On 06/11/17 23:22, Iago Toral Quiroga wrote: This is not allowed so we check that we produce a linker error. It's not 100% obvious why this wouldn't be allowed. Can we have a spec quote added to the test header? --- .../vs-to-fs-type-not-numerical.shader_test| 52

Re: [Piglit] [PATCH v2] shaders: Test using a bound program after an unsuccessful relink

2017-11-05 Thread Timothy Arceri
On 03/11/17 21:27, Neil Roberts wrote: Timothy Arceri <tarc...@itsqueeze.com> writes: Thanks for the test! The idea is great, the only problem I see is that the minimum GL version seems too high. This test would not run on the i915 driver which is a problem IMO. Can you

Re: [Piglit] [PATCH] shaders: Test using a bound program after an unsuccessful relink

2017-11-02 Thread Timothy Arceri
On 03/11/17 05:42, Neil Roberts wrote: If a bound program is relinked unsuccessfully it is supposed to keep the executable and the program state such as the uniforms. This adds a test for that which updates a uniform, does a failed relink and verifies that a render succeeds with the new uniform

[Piglit] [PATCH] ARB_shader_atomic_counter_ops: fix glsl version

2017-11-01 Thread Timothy Arceri
--- tests/spec/arb_shader_atomic_counter_ops/compiler/functions.frag | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/spec/arb_shader_atomic_counter_ops/compiler/functions.frag b/tests/spec/arb_shader_atomic_counter_ops/compiler/functions.frag index b991fe1c7..637fafa62

Re: [Piglit] [PATCH] minmax: change the glGet functions to accept 64-bit variables

2017-10-24 Thread Timothy Arceri
On 21/10/17 01:07, sandra koroniewska wrote: Is this fix alright now? If so, can anyone push please? Pushed. Thanks for the patch! ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] arb_shader_atomic_counter_ops: declare counters to fix undefined behaviour.

2017-10-10 Thread Timothy Arceri
Reviewed-by: Timothy Arceri <tarc...@itsqueeze.com> On 11/10/17 11:18, Dave Airlie wrote: From: Dave Airlie <airl...@redhat.com> It's undefined (including crashing) behaviour to use atomic counters without having bound enough storage for them. This fixes this test to bind

Re: [Piglit] [PATCH] arrays_of_arrays/atomic_counters: set requirements on atomic counter numbers.

2017-10-10 Thread Timothy Arceri
Reviewed-by: Timothy Arceri <tarc...@itsqueeze.com> On 11/10/17 11:24, Dave Airlie wrote: From: Dave Airlie <airl...@redhat.com> These both use 20 counters so check against the limits before running. Signed-off-by: Dave Airlie <airl...@redhat.com> --- .../execution/atomic_

Re: [Piglit] [PATCH] arrays_of_arrays/atomic_counter: check counters limit on linker test.

2017-10-10 Thread Timothy Arceri
Reviewed-by: Timothy Arceri <tarc...@itsqueeze.com> On 11/10/17 11:28, Dave Airlie wrote: From: Dave Airlie <airl...@redhat.com> Signed-off-by: Dave Airlie <airl...@redhat.com> --- .../arb_arrays_of_arrays/linker/vs-to-fs-atomic-counter.shader_test | 2 ++ 1 file cha

[Piglit] [PATCH v2] arb_enhanced_layouts: test packing of floats in the same slots as an array

2017-10-10 Thread Timothy Arceri
This test causes an assert to be thrown on i965 currently. --- ...fs-array-interleave-single-location.shader_test | 93 ++ 1 file changed, 93 insertions(+) create mode 100644

Re: [Piglit] [PATCH] arb_enhanced_layouts: test packing of floats in the same slots as an array

2017-10-10 Thread Timothy Arceri
On 10/10/17 23:39, Ilia Mirkin wrote: It's traditional for green to mean good, red to mean bad. You have those flipped here. Right. I'd fixed this locally but forgot to commit before sending. On Oct 10, 2017 2:58 AM, "Timothy Arceri" <tarc...@itsqueeze.com <mailto:tarc.

[Piglit] [PATCH] arb_enhanced_layouts: test packing of floats in the same slots as an array

2017-10-10 Thread Timothy Arceri
This test causes an assert to be thrown on i965 currently. --- ...fs-array-interleave-single-location.shader_test | 93 ++ 1 file changed, 93 insertions(+) create mode 100644

[Piglit] [PATCH] glsl-1.10: add some loop unrolling tests with breaks in else branch

2017-09-21 Thread Timothy Arceri
--- ...loop-complex-unroll-with-else-break.shader_test | 71 ++ ...l-else-break-unreachable-then-break.shader_test | 41 + 2 files changed, 112 insertions(+) create mode 100644 tests/spec/glsl-1.10/execution/vs-loop-complex-unroll-with-else-break.shader_test

Re: [Piglit] [PATCH] arb_arrays_of_arrays: remove an unused variable

2017-09-18 Thread Timothy Arceri
Reviewed-by: Timothy Arceri <tarc...@itsqueeze.com> On 19/09/17 00:42, Nicolai Hähnle wrote: From: Nicolai Hähnle <nicolai.haeh...@amd.com> --- .../execution/atomic_counters/fs-indirect-index.shader_test | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [Piglit] [PATCH] draw-pixels: fix KHR_no_error logic

2017-08-24 Thread Timothy Arceri
On 23/08/17 17:23, Samuel Pitoiset wrote: On 08/23/2017 06:11 AM, Timothy Arceri wrote: --- This was my fault. The flaw was in my suggestion from the code review. You probably need to use PIGLIT_HAS_ERRORS as well. I don't think so. This skips testing draws with invalid types

Re: [Piglit] [PATCH 50/50] general: add missing KHR_no_error status

2017-08-21 Thread Timothy Arceri
_DEPTH | PIGLIT_GL_VISUAL_STENCIL; + config.khr_no_error_support = PIGLIT_HAS_ERRORS; I think you should just add a !piglit_khr_no_error to the is_format_type_mismatch(format, type) test rather than skipping the whole thing. With that 46-50 are: Reviewed-by: Timothy Arceri <tarc...@itsq

Re: [Piglit] [PATCH 45/50] gl-3.0: set KHR_no_error status

2017-08-21 Thread Timothy Arceri
You seem to have skipped over 2.1 Reviewed-by: Timothy Arceri <tarc...@itsqueeze.com> ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 43/50] arb_vertex_attrib_64bit: set KHR_no_error status

2017-08-21 Thread Timothy Arceri
Reviewed-by: Timothy Arceri <tarc...@itsqueeze.com> ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 44/50] gl-2.0: set KHR_no_error status

2017-08-21 Thread Timothy Arceri
On 11/08/17 01:22, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- tests/spec/gl-2.0/api/active-sampler-conflict.c | 1 + tests/spec/gl-2.0/api/clip-flag-behavior.c | 33 ++--- You missed: getattriblocation-conventional.c

Re: [Piglit] [PATCH 42/50] arb_texture_view: set KHR_no_error status

2017-08-21 Thread Timothy Arceri
eck_target_array(GL_INVALID_OPERATION, numIllegalTargets, illegalTargets, GL_RG16, tex, levels); } Just to make sure the valid targets don't hit any segfaults or something nasty

Re: [Piglit] [PATCH 33/50] arb_occlusion_query2: set KHR_no_error status

2017-08-21 Thread Timothy Arceri
n_wrong_target() && pass; + pass = test_error_end_wrong_target() && pass; + pass = test_error_begin_while_other_active() && pass; Because you are skipping calling the function here. With that change: Reviewed-by: Timothy Arceri <tarc...@itsqueeze.com

Re: [Piglit] [PATCH 32/50] arb_internalformat_query2: set KHR_no_error status

2017-08-21 Thread Timothy Arceri
31-32: Reviewed-by: Timothy Arceri <tarc...@itsqueeze.com> ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] glsl-es-1.00: constant initializer type mismatch causes an error

2017-08-15 Thread Timothy Arceri
Reviewed-by: Timothy Arceri <tarc...@itsqueeze.com> ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 30/50] arb_framebuffer_no_attachments: set KHR_no_error status

2017-08-14 Thread Timothy Arceri
22-30: Reviewed-by: Timothy Arceri <tarc...@itsqueeze.com> ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 21/50] arb_timer_query: set KHR_no_error status

2017-08-14 Thread Timothy Arceri
16-21: Reviewed-by: Timothy Arceri <tarc...@itsqueeze.com> ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 15/50] arb_transform_feedback_overflow_query: set KHR_no_error status

2017-08-11 Thread Timothy Arceri
11-15: Reviewed-by: Timothy Arceri <tarc...@itsqueeze.com> ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 10/50] ext_texture_format_bgra8888: set KHR_no_error status

2017-08-10 Thread Timothy Arceri
1-10: Reviewed-by: Timothy Arceri <tarc...@itsqueeze.com> ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] arb_bindless_texture: add a test which sets mixed texture units/handles

2017-08-07 Thread Timothy Arceri
On 26/07/17 05:31, Samuel Pitoiset wrote: This test currently fails to return the correct 64-bit handle value with Mesa. This is because it ends up by performing the slower ^-- remove this :) Otherwise: Reviewed-by: Timothy Arceri <t

Re: [Piglit] [PATCH] registry: update gl.xml

2017-08-06 Thread Timothy Arceri
Thanks. Acked-by: Timothy Arceri <tarc...@itsqueeze.com> ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCHi V2] ext_memory_object: add some basic api error checks

2017-08-05 Thread Timothy Arceri
s/spec/ext_memory_object/api-errors.c b/tests/spec/ext_memory_object/api-errors.c new file mode 100644 index 0..df413c5ed --- /dev/null +++ b/tests/spec/ext_memory_object/api-errors.c @@ -0,0 +1,235 @@ +/* + * Copyright (c) 2017 Timothy Arceri + * + * Permission is hereby granted, free of charge,

Re: [Piglit] [PATCH 2/2] ext_memory_object: add some basic api error checks

2017-08-04 Thread Timothy Arceri
On 04/08/17 18:56, Samuel Pitoiset wrote: 1/2 got lost? Yeah its in moderation (to big). See https://github.com/tarceri/Piglit/compare/memobj On 08/04/2017 03:43 AM, Timothy Arceri wrote: This only tests for errors when is 0, but its a start. --- tests/all.py

Re: [Piglit] RFC [PATCH] shader: Test to check conditional component access in loops

2017-08-03 Thread Timothy Arceri
On 04/08/17 00:15, Gert Wollny wrote: Hi Brian, thanks for the comments. +u.z = 0.0; +} while (a <= n); Does the body of the loop need to be that complicated? The test must achieve two things: On one hand, at least one component of a temporary register must be written

[Piglit] [PATCH 2/2] ext_memory_object: add some basic api error checks

2017-08-03 Thread Timothy Arceri
) 2017 Timothy Arceri + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the "Software"), + * to deal in the Software without restriction, including without limitation + * on the rights to use, copy, mod

Re: [Piglit] [PATCH] egl: Add test for EGL_KHR_create_context_no_error

2017-08-03 Thread Timothy Arceri
On 03/08/17 20:48, Emil Velikov wrote: On 3 August 2017 at 01:10, Timothy Arceri <tarc...@itsqueeze.com> wrote: One thing that is missing is a check that an error is generated (or the context is created successfully) when a shared context is created. Depending on whether the no error attr

Re: [Piglit] [PATCH] egl: Add test for EGL_KHR_create_context_no_error

2017-08-02 Thread Timothy Arceri
One thing that is missing is a check that an error is generated (or the context is created successfully) when a shared context is created. Depending on whether the no error attributes match. I've got a partial Mesa implementation for the GLX version, so I'm keen to port this test to GLX.

[Piglit] [PATCH] arb_arrays_of_arrays: test struct member offset calculation

2017-07-31 Thread Timothy Arceri
Simple test to make sure we calculate struct member offsets correctly when the array contains an opaque member that maybe not have any backing storage. This triggers a recent regression in radeonsi. --- ...-struct-nonconst-non-opaque-members.shader_test | 68 ++ 1 file

Re: [Piglit] [PATCH 1/2] arb_shader_group_vote: Prefix tests with "cs-"

2017-07-20 Thread Timothy Arceri
Reviewed-by: Timothy Arceri <tarc...@itsqueeze.com> On 21/07/17 09:54, Matt Turner wrote: Going to add tests for other shader stages. --- tests/spec/arb_shader_group_vote/{all.shader_test => cs-all.shader_test} | 0 tests/spec/arb_shader_group_vote/{any.shader_test => cs-any.shad

Re: [Piglit] [PATCH 2/2] arb_shader_group_vote: Add simple vertex shader tests

2017-07-20 Thread Timothy Arceri
llInvocationsEqualARB(!val)) +color = vec4(0.0, 1.0, 0.0, 1.0); + else +color = vec4(1.0, 0.0, 0.0, 1.0); +} + +[fragment shader] +in vec4 color; +out vec4 frag_color; + +void main() +{ + frag_color = color; +} + +[test] +uniform int val 1 +draw rect -1 -1 2 2 +probe all rgba 0.0 1.

Re: [Piglit] [PATCH] glsl-1.50: add linker test for unused in out blocks

2017-07-18 Thread Timothy Arceri
On 15/07/17 06:21, Józef Kucia wrote: On Tue, May 30, 2017 at 4:23 PM, Józef Kucia wrote: This test exposes a Mesa GLSL linker bug. The test fails with the following error message: error: Input block `blk' is not an output of the previous stage Section 4.3.4

[Piglit] [PATCH] arb_texture_buffer_object: set KHR_no_error support

2017-07-05 Thread Timothy Arceri
Here we also move some of the config setup to the top of the file as this is the layout of piglit tests everywhere else in piglit. --- tests/spec/arb_texture_buffer_object/bufferstorage.c| 11 ++- tests/spec/arb_texture_buffer_object/data-sync.c| 1 +

[Piglit] [PATCH 8/8] ext_transform_feedback: set KHR_no_error status

2017-07-05 Thread Timothy Arceri
--- tests/spec/ext_transform_feedback/alignment.c | 1 + tests/spec/ext_transform_feedback/api-errors.c | 1 + tests/spec/ext_transform_feedback/buffer-usage.c | 1 + tests/spec/ext_transform_feedback/builtin-varyings.c | 1

[Piglit] [PATCH 7/8] texturing: set KHR_no_error status

2017-07-05 Thread Timothy Arceri
--- tests/texturing/1-1-linear-texture.c| 1 + tests/texturing/array-depth-roundtrip.c | 1 + tests/texturing/array-texture.c | 1 + tests/texturing/copyteximage-border.c | 1 + tests/texturing/copyteximage-clipping.c | 1 +

[Piglit] [PATCH 2/8] arb_shader_texture_lod: set KHR_no_error status

2017-07-05 Thread Timothy Arceri
--- tests/spec/arb_shader_texture_lod/execution/texgrad.c | 1 + tests/spec/arb_shader_texture_lod/execution/texgradcube.c | 1 + 2 files changed, 2 insertions(+) diff --git a/tests/spec/arb_shader_texture_lod/execution/texgrad.c b/tests/spec/arb_shader_texture_lod/execution/texgrad.c index

[Piglit] [PATCH 6/8] texturing: remove empty test

2017-07-05 Thread Timothy Arceri
Cc: Ian Romanick --- tests/texturing/rg-teximage-03.c | 35 --- 1 file changed, 35 deletions(-) delete mode 100644 tests/texturing/rg-teximage-03.c diff --git a/tests/texturing/rg-teximage-03.c b/tests/texturing/rg-teximage-03.c deleted

[Piglit] [PATCH 4/8] arb_texture_multisample: set KHR_no_error status

2017-07-05 Thread Timothy Arceri
--- tests/spec/arb_texture_multisample/clear.c | 1 + tests/spec/arb_texture_multisample/errors.c | 1 + tests/spec/arb_texture_multisample/fb-completeness.c | 1 + tests/spec/arb_texture_multisample/minmax.c | 1 +

[Piglit] [PATCH 3/8] arb_texture_barrier: set KHR_no_error status

2017-07-05 Thread Timothy Arceri
--- tests/spec/arb_texture_barrier/blending-in-shader-arb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/spec/arb_texture_barrier/blending-in-shader-arb.c b/tests/spec/arb_texture_barrier/blending-in-shader-arb.c index 2b10791..0ec28ee 100644 ---

[Piglit] [PATCH 5/8] texelFetch: set KHR_no_error status

2017-07-05 Thread Timothy Arceri
--- tests/texturing/shaders/texelFetch.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/texturing/shaders/texelFetch.c b/tests/texturing/shaders/texelFetch.c index 2e1d223..1e3a0dc 100644 --- a/tests/texturing/shaders/texelFetch.c +++ b/tests/texturing/shaders/texelFetch.c @@ -87,6

Re: [Piglit] [PATCH] es3: add tests for verifying overloading behavior

2017-07-05 Thread Timothy Arceri
Thanks! Reviewed-by: Timothy Arceri <tarc...@itsqueeze.com> On 06/07/17 10:05, Ilia Mirkin wrote: An existing bug in mesa made it so that overloads of any functions that might be builtins in any language version or extension would not be overridable in ESSL 3.00 shaders. This adds

[Piglit] [PATCH 10/10] glsl-1.50: set KHR_no_error status

2017-07-04 Thread Timothy Arceri
--- .../glsl-1.50/execution/geometry/end-primitive.c | 1 + ...ometry-end-primitive-optional-with-points-out.c | 1 + .../execution/geometry/getshaderiv-may-return-GS.c | 1 + .../execution/geometry/gs-emits-too-few-verts.c| 1 + .../geometry/gs-input-layout-qualifiers.c | 1 +

[Piglit] [PATCH 01/10] arb_shader_atomic_counters: fix KHR_no_error support for buffer binding test

2017-07-04 Thread Timothy Arceri
--- tests/spec/arb_shader_atomic_counters/buffer-binding.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/spec/arb_shader_atomic_counters/buffer-binding.c b/tests/spec/arb_shader_atomic_counters/buffer-binding.c index 7eeaae9..de4e9d1 100644 ---

[Piglit] [PATCH 08/10] glsl-1.30: set KHR_no_error status

2017-07-04 Thread Timothy Arceri
--- tests/spec/glsl-1.30/execution/clipping/max-clip-distances.c | 1 + tests/spec/glsl-1.30/execution/fs-discard-exit-2.c | 1 + tests/spec/glsl-1.30/execution/fs-execution-ordering.c | 1 + tests/spec/glsl-1.30/execution/fs-texelFetch-2D.c| 1 +

[Piglit] [PATCH 06/10] arb_sample_shading: set KHR_no_error status

2017-07-04 Thread Timothy Arceri
--- tests/spec/arb_sample_shading/execution/api.c| 1 + tests/spec/arb_sample_shading/execution/builtin-gl-num-samples.cpp | 1 + tests/spec/arb_sample_shading/execution/builtin-gl-sample-id.cpp | 1 +

[Piglit] [PATCH 04/10] arb_color_buffer_float: set KHR_no_error status

2017-07-04 Thread Timothy Arceri
--- tests/spec/arb_color_buffer_float/common.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/spec/arb_color_buffer_float/common.h b/tests/spec/arb_color_buffer_float/common.h index da59df9..c354303 100644 --- a/tests/spec/arb_color_buffer_float/common.h +++

[Piglit] [PATCH 09/10] glsl-1.40: set KHR_no_error status

2017-07-04 Thread Timothy Arceri
--- tests/spec/glsl-1.40/tf-no-position.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/spec/glsl-1.40/tf-no-position.c b/tests/spec/glsl-1.40/tf-no-position.c index 85abcc5..eed67f1 100644 --- a/tests/spec/glsl-1.40/tf-no-position.c +++ b/tests/spec/glsl-1.40/tf-no-position.c @@

[Piglit] [PATCH 03/10] hiz: set KHR_no_error status

2017-07-04 Thread Timothy Arceri
--- tests/hiz/hiz-depth-read-fbo-d24-s0.c | 1 + tests/hiz/hiz-depth-read-fbo-d24-s8.c | 1 + tests/hiz/hiz-depth-read-fbo-d24s8.c | 1 + tests/hiz/hiz-depth-read-window-stencil0.c| 1 + tests/hiz/hiz-depth-read-window-stencil1.c| 1 +

[Piglit] [PATCH 07/10] glsl-1.30: alphabetise build list

2017-07-04 Thread Timothy Arceri
--- tests/spec/glsl-1.30/execution/CMakeLists.gl.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/spec/glsl-1.30/execution/CMakeLists.gl.txt b/tests/spec/glsl-1.30/execution/CMakeLists.gl.txt index 9cf2586..2aadedc 100644 ---

[Piglit] [PATCH 02/10] fast_color_clear: set KHR_no_error status

2017-07-04 Thread Timothy Arceri
--- tests/fast_color_clear/blit-between-clears.c | 1 + tests/fast_color_clear/front-buffer-distraction.c | 1 + tests/fast_color_clear/read-after-clear.c | 1 + tests/fast_color_clear/read-to-pbo-after-clear.c | 1 + 4 files changed, 4 insertions(+) diff --git

[Piglit] [PATCH 05/10] arb_gpu_shader5: set KHR_no_error status

2017-07-04 Thread Timothy Arceri
--- tests/spec/arb_gpu_shader5/execution/emitstreamvertex_nodraw.c | 1 + tests/spec/arb_gpu_shader5/execution/invocation-id.c| 1 + tests/spec/arb_gpu_shader5/execution/xfb-streams-without-invocations.c | 1 + tests/spec/arb_gpu_shader5/execution/xfb-streams.c

Re: [Piglit] [RFC] glean: remove pixel formats test

2017-07-02 Thread Timothy Arceri
On 30/06/17 23:11, Brian Paul wrote: On 06/29/2017 11:01 PM, Timothy Arceri wrote: On 30/06/17 14:49, Timothy Arceri wrote: In the bug for porting glean tests to piglit this is listed as "covered by Piglit" "Check & Remove". Since that list was made we al

Re: [Piglit] [RFC] glean: remove pixel formats test

2017-06-29 Thread Timothy Arceri
On 30/06/17 14:49, Timothy Arceri wrote: In the bug for porting glean tests to piglit this is listed as "covered by Piglit" "Check & Remove". Since that list was made we also now have a public CTS. This is another of the extra slow glean tests. Can we assume this i

[Piglit] [RFC] glean: remove pixel formats test

2017-06-29 Thread Timothy Arceri
In the bug for porting glean tests to piglit this is listed as "covered by Piglit" "Check & Remove". Since that list was made we also now have a public CTS. This is another of the extra slow glean tests. Can we assume this is all covered and remove?

[Piglit] [PATCH] glsl-1.20: better test indirect indexing of literal array of structs

2017-06-29 Thread Timothy Arceri
This exposes some existing bugs in gallium and also provides more coverage for when we start packing uniforms. --- ...iteral-array-of-structs-vec4-member.shader_test | 39 +++ ...s-with-multiple-members-large-array.shader_test | 57 ++

[Piglit] [PATCH] ARB_blend_func_extended: set KHR_no_error status

2017-06-29 Thread Timothy Arceri
--- .../api/bindfragdataindexed-invalid-parameters.c | 1 + tests/spec/arb_blend_func_extended/api/blend-api.c| 1 + tests/spec/arb_blend_func_extended/api/builtins.c | 1 + .../spec/arb_blend_func_extended/api/error-at-begin.c | 1 +

[Piglit] [PATCH] gl-1.0: set KHR_no_error support for remaining gl-1.0 tests

2017-06-29 Thread Timothy Arceri
--- tests/spec/gl-1.0/blend.c | 1 + tests/spec/gl-1.0/dlist-bitmap.c| 1 + tests/spec/gl-1.0/dlist-shademodel.c| 1 + tests/spec/gl-1.0/drawpixels-color-index.c | 1 + tests/spec/gl-1.0/edgeflag-const.c |

[Piglit] [PATCH] bugs: set KHR_no_error support for remaining bugs tests

2017-06-28 Thread Timothy Arceri
--- tests/bugs/crash-cubemap-order.c| 1 + tests/bugs/crash-texparameter-before-teximage.c | 1 + tests/bugs/drawbuffer-modes.c | 1 + tests/bugs/fdo10370.c | 1 + tests/bugs/fdo14575.c | 1 +

Re: [Piglit] [PATCH] ARB_point_parameters: port glean test pointatten to piglit

2017-06-28 Thread Timothy Arceri
Ping. Any comments on this? If not I'll probably push this soon as its one of the bigger bottle necks in my piglit runs. On 21/06/17 10:33, Timothy Arceri wrote: --- tests/all.py | 6 +- tests/glean/CMakeLists.gl.txt | 1

Re: [Piglit] [PATCH] ext_packed_depth_stencil: set KHR_no_error compatibility

2017-06-27 Thread Timothy Arceri
amp; pass; - pass = test_readpixels() && pass; + if (!piglit_khr_no_error) { + pass = test_drawpixels() && pass; + pass = test_readpixels() && pass; + } I'm not sure the 3rd test belongs here, but it's already there so: Re

Re: [Piglit] [PATCH] fbo: set KHR_no_error compatibility for remaining fbo tests

2017-06-27 Thread Timothy Arceri
On 27/06/17 17:58, Samuel Pitoiset wrote: On 06/27/2017 02:19 AM, Timothy Arceri wrote: On 26/06/17 19:04, Samuel Pitoiset wrote: Looks like you forgot to update fbo-storage-formats.c. It's updated. Did you mean something else? I meant, there is a GL_INVALID_ENUM which is not handled

Re: [Piglit] [PATCH] fbo: set KHR_no_error compatibility for remaining fbo tests

2017-06-26 Thread Timothy Arceri
On 26/06/17 19:04, Samuel Pitoiset wrote: Looks like you forgot to update fbo-storage-formats.c. It's updated. Did you mean something else? With that fixed, patch is: Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> Thanks! On 06/26/2017 08:00 AM, Timothy Arceri

[Piglit] [PATCH] fbo: set KHR_no_error compatibility for remaining fbo tests

2017-06-26 Thread Timothy Arceri
--- tests/fbo/fbo-1d.c | 1 + tests/fbo/fbo-3d.c | 1 + tests/fbo/fbo-alpha.c | 1 + tests/fbo/fbo-alphatest-formats.c | 1 + tests/fbo/fbo-alphatest-nocolor-ff.c | 1 +

Re: [Piglit] [PATCH 3/3] arb_viewport_array: set KHR_no_error compatibility

2017-06-24 Thread Timothy Arceri
Thanks! Series: Reviewed-by: Timothy Arceri <tarc...@itsqueeze.com> On 24/06/17 00:23, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_viewport_array/bounds.c | 53 -- tests/spec/arb_viewport_a

[Piglit] [PATCH] ARB_point_parameters: port glean test pointatten to piglit

2017-06-20 Thread Timothy Arceri
--- tests/all.py | 6 +- tests/glean/CMakeLists.gl.txt | 1 - tests/glean/tpointatten.cpp| 294 - tests/glean/tpointatten.h | 78 -- tests/llvmpipe.py

Re: [Piglit] [PATCH 3/3] arb_gpu_shader5: interpolateAt* must reject inputs in structs

2017-06-18 Thread Timothy Arceri
Can we add a spec quote to these? Otherwise series: Reviewed-by: Timothy Arceri <tarc...@itsqueeze.com> On 17/06/17 06:34, Nicolai Hähnle wrote: From: Nicolai Hähnle <nicolai.haeh...@amd.com> --- .../fs-interpolateAtCentroid-struct.frag| 17 ++

Re: [Piglit] [PATCH] arb_bindless_texture: set KHR_no_error compatibility

2017-06-15 Thread Timothy Arceri
Reviewed-by: Timothy Arceri <tarc...@itsqueeze.com> On 10/06/17 00:27, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_bindless_texture/border-color.c | 7 +++ tests/spec/arb_bindless_texture/conversions.c| 1 +

Re: [Piglit] Status of Glean test rewrites?

2017-06-14 Thread Timothy Arceri
reason for not sending a new series? As far as I can see it shouldn't be too much work to get these commit worthy. Dylan Quoting Timothy Arceri (2017-06-14 17:48:24) Hi All, I recently got a cpu with more than 2 cores \o/ and it's become even more obvious just how much of a bottle neck

[Piglit] Status of Glean test rewrites?

2017-06-14 Thread Timothy Arceri
Hi All, I recently got a cpu with more than 2 cores \o/ and it's become even more obvious just how much of a bottle neck the glean tests are. Anyway what is the currently status of the rewrite? Have all the current patches landed or are there still patchs waiting review/yet to be finished?

Re: [Piglit] [PATCH 3/4] texturing/tex3d-maxsize: set KHR_no_error status

2017-06-04 Thread Timothy Arceri
On 05/06/17 10:19, Timothy Arceri wrote: --- tests/texturing/tex3d-maxsize.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/texturing/tex3d-maxsize.c b/tests/texturing/tex3d-maxsize.c index 60c9c63..781ac27 100644 --- a/tests/texturing/tex3d-maxsize.c +++ b/tests/texturing/tex3d

[Piglit] [PATCH 4/4] TexSubImage1D tests: set KHR_no_error status

2017-06-04 Thread Timothy Arceri
--- tests/fbo/fbo-generatemipmap-1d.c | 1 + tests/spec/arb_texture_view/lifetime_format.c | 1 + tests/spec/arb_texture_view/rendering_target.c | 1 + tests/texturing/max-texture-size.c | 1 + tests/texturing/teximage-errors.c | 1 + 5 files changed, 5

[Piglit] [PATCH 3/4] texturing/tex3d-maxsize: set KHR_no_error status

2017-06-04 Thread Timothy Arceri
--- tests/texturing/tex3d-maxsize.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/texturing/tex3d-maxsize.c b/tests/texturing/tex3d-maxsize.c index 60c9c63..781ac27 100644 --- a/tests/texturing/tex3d-maxsize.c +++ b/tests/texturing/tex3d-maxsize.c @@ -26,20 +26,21 @@ * Tests 3D

[Piglit] [PATCH 1/4] ARB_invalidate_subdata: set KHR_no_error status

2017-06-04 Thread Timothy Arceri
--- tests/spec/arb_invalidate_subdata/buffer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/spec/arb_invalidate_subdata/buffer.c b/tests/spec/arb_invalidate_subdata/buffer.c index 637596a..dedb937 100644 --- a/tests/spec/arb_invalidate_subdata/buffer.c +++

[Piglit] [PATCH 2/4] gl-3.2/layered-rendering: set KHR_no_error status

2017-06-04 Thread Timothy Arceri
--- tests/spec/gl-3.2/layered-rendering/blit.c | 1 + tests/spec/gl-3.2/layered-rendering/clear-color-all-types.c| 1 + .../layered-rendering/clear-color-mismatched-layer-count.c | 1 + tests/spec/gl-3.2/layered-rendering/clear-color.c | 1 +

Re: [Piglit] [PATCH] arb_shader_image_load_store: set KHR_no_error compatibility

2017-05-30 Thread Timothy Arceri
Looks good to me: Reviewed-by: Timothy Arceri <tarc...@itsqueeze.com> On 26/05/17 06:21, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_shader_image_load_store/atomicity.c | 1 + tests/spec/arb_shader_image_load_sto

Re: [Piglit] [PATCH 2/7] gl-4.4: set KHR_no_error compatibility

2017-05-29 Thread Timothy Arceri
On 19/05/17 19:08, Samuel Pitoiset wrote: On 05/18/2017 04:00 AM, Timothy Arceri wrote: --- tests/spec/gl-4.4/gl_max_vertex_attrib_stride.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/tests/spec/gl-4.4/gl_max_vertex_attrib_stride.c b/tests/spec/gl-4.4

<    1   2   3   4   5   6   7   >