Re: [Piglit] [PATCH] generator: clear before rendering with the builtin tests

2015-04-06 Thread Eric Anholt
Eric Anholt e...@anholt.net writes: Dave Airlie airl...@gmail.com writes: From: Dave Airlie airl...@redhat.com Otherwise there is a chance you'll get the contents from the last test which are green, and if this test fails to renderer you'll pass. Signed-off-by: Dave Airlie

Re: [Piglit] [PATCH] generator: clear before rendering with the builtin tests

2015-04-06 Thread Eric Anholt
Dave Airlie airl...@gmail.com writes: From: Dave Airlie airl...@redhat.com Otherwise there is a chance you'll get the contents from the last test which are green, and if this test fails to renderer you'll pass. Signed-off-by: Dave Airlie airl...@redhat.com This probably slightly improves

Re: [Piglit] [PATCH] generator: clear before rendering with the builtin tests

2015-04-06 Thread Ian Romanick
On 04/05/2015 04:00 PM, Dave Airlie wrote: On 27 March 2015 at 12:18, Ilia Mirkin imir...@alum.mit.edu wrote: Can we just make shader_runner do a clear automatically? This has happened to me a number of times. I'm not sure we should do that though, I don't really like the idea of shader

Re: [Piglit] [PATCH] generator: clear before rendering with the builtin tests

2015-04-05 Thread Dave Airlie
On 27 March 2015 at 12:18, Ilia Mirkin imir...@alum.mit.edu wrote: Can we just make shader_runner do a clear automatically? This has happened to me a number of times. I'm not sure we should do that though, I don't really like the idea of shader runner doing an implicit behavioural change, but

Re: [Piglit] [PATCH] generator: clear before rendering with the builtin tests

2015-03-26 Thread Ilia Mirkin
Can we just make shader_runner do a clear automatically? This has happened to me a number of times. On Thu, Mar 26, 2015 at 9:58 PM, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com Otherwise there is a chance you'll get the contents from the last test which are

[Piglit] [PATCH] generator: clear before rendering with the builtin tests

2015-03-26 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com Otherwise there is a chance you'll get the contents from the last test which are green, and if this test fails to renderer you'll pass. Signed-off-by: Dave Airlie airl...@redhat.com --- generated_tests/gen_builtin_uniform_tests.py | 2 ++