[Piglit] glsl-render-after-bad-attach.c not built

2013-01-09 Thread Brian Paul
I happened to notice that the program tests/spec/glsl-1.10/execution/glsl-render-after-bad-attach.c which Eric added last April (b859d0c) isn't getting built. Adding a piglit_add_executable() line in the directory's CMakeLists.txt file didn't work. -Brian

Re: [Piglit] [PATCH 1/2] Add [require] section to .shader_test files missing it.

2013-01-09 Thread Chad Versace
On 12/21/2012 11:27 AM, Stuart Abercrombie wrote: The only content is GLSL = 1.10. This is part of the effort to get closer to GLES support. --- .../fs-bool-less-compare-false.shader_test |3 +++ .../fs-bool-less-compare-true.shader_test |3 +++

Re: [Piglit] [PATCH 2/2] Remove .shader_test #version / GLSL = mismatches.

2013-01-09 Thread Chad Versace
On 12/21/2012 11:27 AM, Stuart Abercrombie wrote: Make GLSL reflect what the shader source specifies. Remove the explicit #version directives, as these will be inserted based on GLSL =. This is part of the effort to get closer to GLES support. ---

Re: [Piglit] glsl-render-after-bad-attach.c not built

2013-01-09 Thread Paul Berry
On 9 January 2013 09:30, Brian Paul bri...@vmware.com wrote: I happened to notice that the program tests/spec/glsl-1.10/** execution/glsl-render-after-**bad-attach.c which Eric added last April (b859d0c) isn't getting built. Adding a piglit_add_executable() line in the directory's

Re: [Piglit] [PATCH 0/6] Porting MSAA tests to GL 2.1

2013-01-09 Thread Paul Berry
On 6 January 2013 06:16, Marek Olšák mar...@gmail.com wrote: Since we now have a GL 2.1 driver with MSAA support - r300g, I had to port most MSAA tests to GL 2.1, while not affecting the tests that *really* need GL 3. I have verified that the expected and reported precision of the accuracy

Re: [Piglit] [PATCH] arb_es2_compatibility-releaseshadercompiler-ge7: test glReleaseShaderCompiler crash

2013-01-09 Thread Eric Anholt
Brian Paul bri...@vmware.com writes: On 01/07/2013 10:17 PM, Matt Turner wrote: On Tue, Dec 18, 2012 at 2:43 PM, Brian Paulbri...@vmware.com wrote: create mode 100644 tests/spec/arb_es2_compatibility/ge7.frag create mode 100644 tests/spec/arb_es2_compatibility/ge7.vert [snip] + * The

Re: [Piglit] [PATCH 0/2] gles2: add minmax + invalid-es3-queries

2013-01-09 Thread Eric Anholt
Tom Gall tom.g...@linaro.org writes: In this patch series: Add invalidate-es3-queries_gles2 to all.tests as well as make it follow naming conventions for the binary with _gles2 as the suffix. Add minmax for gles2. Changes based on Eric Anholt's feedback, removes a number of queries

[Piglit] [PATCH 1/2] shader_runner_gles2: Remove unused variable warnings

2013-01-09 Thread Chad Versace
The function macros in shader_runner_gles_workarounds.h cause many unused variable warnings. The function macros have form #define glMapBuffer(...) UNDEFINED_FUNCTION(glMapBuffer, 0) and get expanded to the call unsupported_function(glMapBuffer, 0) Observe that the original arguments to

Re: [Piglit] [PATCH] texture-integer-glsl130: fix random failures with wrong expected alpha values

2013-01-09 Thread Brian Paul
On 01/09/2013 01:44 PM, srol...@vmware.com wrote: From: Roland Scheideggersrol...@vmware.com The logic failed whenever the random number was 0 for formats which don't have an alpha channel. In this case all of expected/bias/value were 0 but the actual correct read back value is 1.0 (default

Re: [Piglit] [PATCH] texture-integer-glsl130: fix random failures with wrong expected alpha values

2013-01-09 Thread Jose Fonseca
Reviewed-by: Jose Fonseca jfons...@vmware.com - Original Message - From: Roland Scheidegger srol...@vmware.com The logic failed whenever the random number was 0 for formats which don't have an alpha channel. In this case all of expected/bias/value were 0 but the actual correct

Re: [Piglit] [PATCH 2/2] shader_runner_gles2: Remove cast warning

2013-01-09 Thread Tom Gall
Looks good! Reviewed-by: Tom Gall tom.g...@linaro.org On Wed, Jan 9, 2013 at 2:31 PM, Chad Versace chad.vers...@linux.intel.com wrote: Removes the warning: shader_runner.c:1078:7: warning: assignment makes pointer from integer without a cast [enabled by default]

Re: [Piglit] [PATCH 1/2] shader_runner_gles2: Remove unused variable warnings

2013-01-09 Thread Tom Gall
Also looks good. I'll test it out this evening, but I'm sure it's fine. Reviewed-by: Tom Gall tom.g...@linaro.org On Wed, Jan 9, 2013 at 2:31 PM, Chad Versace chad.vers...@linux.intel.com wrote: The function macros in shader_runner_gles_workarounds.h cause many unused variable warnings. The

Re: [Piglit] [PATCH 1/2] shader_runner_gles2: Remove unused variable warnings

2013-01-09 Thread Tom Gall
Works fine. There is one more warning to squash that is the result of the recent addition of piglit_gen_ortho_uniform. Tested-by: Tom Gall tom.g...@linaro.org On Wed, Jan 9, 2013 at 6:53 PM, Tom Gall tom.g...@linaro.org wrote: Also looks good. I'll test it out this evening, but I'm sure it's

[Piglit] [PATCH 1/1] gles2: squash warning

2013-01-09 Thread Tom Gall
In the newly added piglit_gen_ortho_uniform it introduced a warning due to float *[4] being passed instead of the expected const GLfloat * as the type of the 4th param. Change the array of floats to const GLfloat [4][4] and provide the cast. Signed-off-by: Tom Gall tom.g...@linaro.org ---

[Piglit] [PATCH 1/2] util: Add utility to simulate GLSL packing functions

2013-01-09 Thread Chad Versace
In order to generate tests for the GLSL packing functions (packSnorm2x16 and friends), we must be able to simulate them. This patch adds a C executable that does exactly that. I originally tried to write this tool in Python, but manipulating 16-bit unsigned integers is not one of Python's

[Piglit] [PATCH 2/2] glsl-es-3.00: Generate tests for builtin packing functions

2013-01-09 Thread Chad Versace
for stage in const vs fs: for d in pack unpack: for type in Snorm Unorm Half: generate ${stage}-${d}${type}2x16.shader_test The tests are generated by a new Python script, gen_builtin_packing_tests.py, and placed into directory spec/glsl-es-3.00/execution/built-in-functions.