new one. So I started by cleaning it up a bit.
In the end I decided to write a new test anyway (already reviewed on the
list), but figured the cleanups are worthwhile anyway.
Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freed
1.0, 1.0, 1.0)
Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
On 09/24/2012 05:35 PM, Paul Berry wrote:
The behaviour specified by OpenGL for blits involving sRGB is
self-contradictory--it is unclear whether blits should perform sRGB
encoding/decoding, and if so, whether this encoding/decoding should be
dependent upon the setting of the GL_FRAMEBUFFER_SRGB
From: Brian Paul
---
tests/texturing/teximage-errors.c | 60 +---
1 files changed, 22 insertions(+), 38 deletions(-)
diff --git a/tests/texturing/teximage-errors.c
b/tests/texturing/teximage-errors.c
index 5f0497d..a5acc56 100644
--- a/tests/texturing
From: Brian Paul
Fix incorrect texture height (16, not 15).
Fix incorrect width, height for glCopyTexSubImage2D() test.
Add two new SubImage tests for non-existant mipmap levels.
---
tests/texturing/teximage-errors.c | 15 +--
1 files changed, 13 insertions(+), 2 deletions
If someone's looking for something simple to do in piglit...
There's about 150 instances of this in the tests:
assert(glGetError() == 0);
I think that quite a few of them should be replaced with:
if (!piglit_check_gl_error(GL_NO_ERROR))
fail;
Some seem to be development sanity checks but s
---
tests/util/piglit-util-gl-common.c | 85
tests/util/piglit-util-gl-common.h | 13 ++
2 files changed, 98 insertions(+), 0 deletions(-)
diff --git a/tests/util/piglit-util-gl-common.c
b/tests/util/piglit-util-gl-common.c
index 03d7420..7a5b2c7 1006
---
tests/texturing/compressedteximage.c | 52 ++---
1 files changed, 22 insertions(+), 30 deletions(-)
diff --git a/tests/texturing/compressedteximage.c
b/tests/texturing/compressedteximage.c
index dd83a7b..7bcac9f 100644
--- a/tests/texturing/compressedteximage.c
---
tests/texturing/s3tc-errors.c | 90 +++--
1 files changed, 15 insertions(+), 75 deletions(-)
diff --git a/tests/texturing/s3tc-errors.c b/tests/texturing/s3tc-errors.c
index 2f6ef89..8a6546d 100644
--- a/tests/texturing/s3tc-errors.c
+++ b/tests/texturing
s are accepted by certain API functions. Those
are the cases where piglit_check_gl_error() would be a better choice.
-Brian
On 09/30/2012 08:42 PM, Chris Forbes wrote:
Hi Brian,
I'll take this. Patches shortly.
-- Chris
On Sat, Sep 29, 2012 at 1:45 AM, Brian Paul wrote:
If someone
Zero-sized tex images and sub images should not generate an error.
Full images which are not multiples of the block size should also be legal.
Verified w/ NVIDIA's driver.
---
tests/texturing/s3tc-errors.c | 38 ++
1 files changed, 38 insertions(+), 0 deletio
On 10/02/2012 09:37 AM, Neil Roberts wrote:
Hi,
Rob Bradford was discussing a bug in Mesa where the fast path code for
uploading texture data to BGRA textures on Sandybridge does not work
with a subregion of the buffer using GL_UNPACK_SKIP_*. Here is a test
for Piglit that exposes this bug on GL
---
tests/util/piglit-shader.c |2 +-
tests/util/piglit-shader.h |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/util/piglit-shader.c b/tests/util/piglit-shader.c
index f097512..d04247d 100644
--- a/tests/util/piglit-shader.c
+++ b/tests/util/piglit-shader.c
@@
---
tests/util/piglit-util-gl.c |2 +-
tests/util/piglit-util.c|2 +-
tests/util/piglit-util.h|2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c
index 96f6258..cb697d8 100644
--- a/tests/util/piglit-ut
---
tests/util/piglit-util-gl-common.c |4 ++--
tests/util/piglit-util-gl-common.h |4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/util/piglit-util-gl-common.c
b/tests/util/piglit-util-gl-common.c
index a447a0f..62b5312 100644
--- a/tests/util/piglit-util-gl-
l_version()< 15) {
- fprintf(stderr, "OpenGL 1.5 required.\n");
- piglit_report_result(PIGLIT_SKIP);
- }
+ piglit_require_gl_version(15);
piglit_require_GLSL();
piglit_require_transform_feedback();
Reviewed-by
(!piglit_check_gl_error(GL_NO_ERROR))
piglit_report_result(PIGLIT_FAIL);
- }
piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
}
Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
/util/writeimg.h
LGTM. Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
; pass;
> piglit_present_results();
> - piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
> return pass ? PIGLIT_PASS : PIGLIT_FAIL;
> }
For the series, Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
On Mon, Oct 8, 2012 at 6:17 PM, Jordan Justen wrote:
> Signed-off-by: Jordan Justen
> Cc: Brian Paul
> Cc: Chad Versace
> ---
> tests/util/piglit-util-gl-common.c |7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/tests/util/piglit-util-gl-common.c
&g
].test; i++) {
glBindBuffer(GL_ARRAY_BUFFER, 0);
Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
a performance test (several glean
tests are perf tests).
The focus of piglit has been correctness but I think it would be nice
to develop a suite of performance measurement tests too. But that's a
whole other discussion.
I'm fine with this patch though.
Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
On 10/10/2012 12:27 PM, Chad Versace wrote:
On 10/08/2012 06:23 PM, Brian Paul wrote:
On Mon, Oct 8, 2012 at 6:17 PM, Jordan Justen wrote:
Signed-off-by: Jordan Justen
Cc: Brian Paul
Cc: Chad Versace
---
tests/util/piglit-util-gl-common.c |7 +++
1 file changed, 7 insertions
On 10/10/2012 01:26 PM, Chad Versace wrote:
On 10/10/2012 12:00 PM, Brian Paul wrote:
On 10/10/2012 12:27 PM, Chad Versace wrote:
On 10/08/2012 06:23 PM, Brian Paul wrote:
On Mon, Oct 8, 2012 at 6:17 PM, Jordan Justen
wrote:
Signed-off-by: Jordan Justen
Cc: Brian Paul
Cc: Chad Versace
e
+#ifndef PIGLIT_GL_FRAMEWORK_H
+#define PIGLIT_GL_FRAMEWORK_H
#include
@@ -80,3 +82,5 @@ piglit_gl_framework_init(struct piglit_gl_framework *gl_fw,
void
piglit_gl_framework_teardown(struct piglit_gl_framework *gl_fw);
+
+#endif /* PIGLIT_GL_FRAMEWORK_H */
Reviewed-by:
L_UNPACK_BUFFER, TEX_DATA_SIZE, tex_data,
+ GL_STATIC_DRAW);
+ }
+
+ if (!piglit_check_gl_error(GL_NO_ERROR))
+ piglit_report_result(PIGLIT_FAIL);
+}
+
+enum piglit_result
+piglit_display(void)
+{
+ bool pass = true;
+ const int num_subtests = 256;
+ int i;
+
+ /* We reset the random seed for each call to piglit_display() so that
+* the testrun is consistent.
+*/
+ srand(rand_seed);
+
+ for (i = 0; i< num_subtests; ++i) {
+ logd("subtest %d:\n", i);
+ pass&= run_subtest();
+ }
+
+ return pass ? PIGLIT_PASS : PIGLIT_FAIL;
+}
Looks good. The comments are very helpful.
Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
previous conditions were satisfied, then
# the given dispatch set is not supported by the implementation,
# so we want to call the unsupported() function.
I'm not too familiar with this code but this looks OK to me.
Reviewed-by: Brian Paul
_
On 10/13/2012 08:55 PM, Chris Forbes wrote:
Updated for new test config macros; added all.tests plumbing.
Just a couple style comments-
Piglit generally used tab-8 indentation.
Some function calls have extra spaces, ex: "f( x )" instead of "f(x)".
-Brian
_
, DSTYMIN + 7, // stretch x y
+ GL_NEAREST,
+ },
+
+
+ /*
* Clip
*/
Looks OK to me.
Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo
On 10/15/2012 02:37 AM, Chad Versace wrote:
Waffle 1.1.0 is now available. Downloads and documentation are available at
http://people.freedesktop.org/~chadversary/waffle/releases.html#1.1.0
Waffle is a cross-platform library that allows one to defer selection of GL
API and of window system
The glutInit() function in the original GLUT expects argv[0] to be the
program name (as from main()), not a NULL pointer. A strrchr() call
crashes on NULL.
For now, set argv[0]="piglit". Previously, glutInit would get the
program path/name and it would appear in the window title.
This seems to
On 10/15/2012 11:10 AM, Marek Olšák wrote:
The test visualizes the stencil buffer (unlike some other tests),
which is very useful for debugging.
Unfortunately, it doesn't work with Mesa. There seems to be a bogus GL error.
The problem can be reproduced by running:
./fbo-clear-formats GL_EXT_pac
On 10/15/2012 12:08 PM, Chad Versace wrote:
On 10/15/2012 10:30 AM, Brian Paul wrote:
The glutInit() function in the original GLUT expects argv[0] to be the
program name (as from main()), not a NULL pointer. A strrchr() call
crashes on NULL.
For now, set argv[0]="piglit".
On 10/15/2012 12:13 PM, Chad Versace wrote:
On 10/15/2012 07:57 AM, Brian Paul wrote:
On 10/15/2012 02:37 AM, Chad Versace wrote:
I unpacked the .xz file, then
$ cd waffle-1.1.0
$ export WAFFLE_SOURCE_DIR=$PWD/src
$ cmake \
-DCMAKE_LIBRARY_PATH=$(echo $LIBRARY_PATH | sed 's/
On 10/15/2012 12:42 PM, Chad Versace wrote:
On 10/15/2012 11:20 AM, Brian Paul wrote:
On 10/15/2012 12:13 PM, Chad Versace wrote:
On 10/15/2012 07:57 AM, Brian Paul wrote:
On 10/15/2012 02:37 AM, Chad Versace wrote:
I unpacked the .xz file, then
$ cd waffle-1.1.0
$ export
On 10/16/2012 04:40 PM, Chad Versace wrote:
Waffle 1.1.1 - 16 Oct 2012
==
Waffle 1.1.1 is a bugfix release. It fixes bugs discovered since 1.1.0.
Downloads and documentation are available at:
http://people.freedesktop.org/~chadversary/waffle/releases.html#1.1.1
For
1 0
Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
1. Do a simple test that glClear(GL_DEPTH_BUFFER_BIT) works as expected.
2. Display the depth buffer contents as a grayscale image when not
running in automatic mode to aid debugging.
---
tests/general/readpix-z.c | 116 ++--
1 files changed, 100 inserti
On 10/17/2012 05:43 PM, Eric Anholt wrote:
Brian Paul writes:
1. Do a simple test that glClear(GL_DEPTH_BUFFER_BIT) works as expected.
2. Display the depth buffer contents as a grayscale image when not
running in automatic mode to aid debugging.
Since we've got lots of tests that
On 10/18/2012 08:42 AM, Brian Paul wrote:
On 10/17/2012 05:43 PM, Eric Anholt wrote:
Brian Paul writes:
1. Do a simple test that glClear(GL_DEPTH_BUFFER_BIT) works as
expected.
2. Display the depth buffer contents as a grayscale image when not
running in automatic mode to aid debugging
sed fragments
returned %d\n",
+ result[0]);
+ pass = false;
+ }
+
+ if (result[1] != GL_FALSE) {
+ fprintf(stderr, "GL_ANY_SAMPLES_PASSED with no rendering returned
%d\n",
+ result[1]
effectively makes the rest of the macro's characters go away,
and hence, produces a compilation error.
Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
On 10/27/2012 02:55 PM, Vinson Lee wrote:
This patch fixes build failures on Mac OS X since commit
68de5fb435e6e1cb0caedddff0fd0a9c221b0005.
Signed-off-by: Vinson Lee
---
tests/shaders/fp-fragment-position.c | 4
tests/spec/arb_shader_texture_lod/execution/texgrad.c | 4
To remove dependency on glu.h
---
.../arb_shader_texture_lod/execution/texgrad.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/tests/spec/arb_shader_texture_lod/execution/texgrad.c
b/tests/spec/arb_shader_texture_lod/execution/texgrad.c
index 0f3761f..e502ecd 1006
To remove dependency on glu.h
---
tests/spec/gl-2.0/api/clip-flag-behavior.c | 38 +---
1 files changed, 12 insertions(+), 26 deletions(-)
diff --git a/tests/spec/gl-2.0/api/clip-flag-behavior.c
b/tests/spec/gl-2.0/api/clip-flag-behavior.c
index ecc8328..8f9d8a6 100644
To remove dependency on glu.h
---
tests/shaders/fp-fragment-position.c |9 +
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/tests/shaders/fp-fragment-position.c
b/tests/shaders/fp-fragment-position.c
index 7ccd6ee..c8bfe7b 100644
--- a/tests/shaders/fp-fragment-positio
On 10/29/2012 11:35 AM, Ian Romanick wrote:
On 10/29/2012 08:04 AM, Brian Paul wrote:
I think any implementation that can do ARB_fragment_program can also
do OpenGL 1.4.
ARB_fp only requires GL 1.3.
Does this remove all of the GLU dependencies?
Looks like tests/glean/glwrap.h includes
On 10/29/2012 11:44 AM, Brian Paul wrote:
On 10/29/2012 11:35 AM, Ian Romanick wrote:
On 10/29/2012 08:04 AM, Brian Paul wrote:
Does this remove all of the GLU dependencies?
Looks like tests/glean/glwrap.h includes glu.h but I haven't looked if
any GLU functions are actually used by
On 10/29/2012 05:05 PM, srol...@vmware.com wrote:
From: Roland Scheidegger
Make sure clipping is needed sometimes, and more often use small index counts,
to expose issues and excercise more paths in mesa's draw module.
---
tests/spec/arb_robustness/draw-vbo-bounds.c |4 ++--
1 file change
iglit_add_executable (crossbar crossbar.c)
piglit_add_executable (cubemap cubemap.c)
piglit_add_executable (depth-level-clamp depth-level-clamp.c)
piglit_add_executable (depthstencil-render-miplevels
depthstencil-render-miplevels.cpp)
Reviewed-by: Brian Paul
__
On 10/29/2012 06:33 PM, Roland Scheidegger wrote:
Am 30.10.2012 00:22, schrieb Brian Paul:
On 10/29/2012 05:05 PM, srol...@vmware.com wrote:
From: Roland Scheidegger
Make sure clipping is needed sometimes, and more often use small index
counts,
to expose issues and excercise more paths in
GLenum frontStencilFail,
+ GLenum backStencilFail,
+ GLenum frontZFail,
+ GLenum backZFail,
+ GLenum frontZPass,
+ GLenum backZPass,
+
n pass ? PIGLIT_PASS : PIGLIT_FAIL;
+}
+
+void
+piglit_init(int argc, char **argv)
+{
+ glMatrixMode(GL_PROJECTION);
+ glLoadIdentity();
+
+ glMatrixMode(GL_MODELVIEW);
+ glLoadIdentity();
+}
Reviewed-by: Brian Paul
___
Piglit mailing list
I think I've brought this up in the past. On Windows, the minimum
width of a window is 116 pixels (at least in my current Win7 setup).
A lot of piglit tests create 100x100 pixels and when piglit creates
the window, Win7 resizes it to 116x100. The framework code detects
this change and repor
On 11/02/2012 10:52 AM, Paul Berry wrote:
On 2 November 2012 09:32, Brian Paul mailto:bri...@vmware.com>> wrote:
I think I've brought this up in the past. On Windows, the minimum
width of a window is 116 pixels (at least in my current Win7
setup). A lot of piglit t
On Win7 windows get resized to the min size of 116x100 pixels (which
might depend on the Aero theme, etc). This resize is detected by
the piglit framework:
Got spurious window resize in automatic run (100,100 to 116,100)
PIGLIT: {'result': 'warn'}
so we get a 'warn' result instead of actually ru
Use the default from piglit-framework-gl.h
No regressions seen with new size.
---
tests/general/array-stride.c |2 --
tests/general/depthrange-clear.c |2 --
tests/general/dlist-clear.c |2 --
tests/general/dlist-color-material.c |
These tests had window sizes other than 100x100.
No regressions seen with new size.
---
tests/general/copy-pixels.c |2 --
tests/general/copypixels-draw-sync.c|2 --
tests/general/copypixels-sync.c |2 --
tests/general/depth-clamp-range.c |2 --
tests/
---
tests/texturing/lodclamp-between.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tests/texturing/lodclamp-between.c
b/tests/texturing/lodclamp-between.c
index 4d8e50e..787e601 100644
--- a/tests/texturing/lodclamp-between.c
+++ b/tests/texturing/lodclamp-between.c
Use the default window size.
No regressions seen with new size.
---
tests/texturing/1-1-linear-texture.c|2 --
tests/texturing/copyteximage-clipping.c |2 --
tests/texturing/getteximage-luminance.c |2 --
tests/texturing/getteximage-simple.c|
Instead of sizes less than 150x150.
No regressions seen with new size.
---
tests/fbo/fbo-1d.c |2 --
tests/fbo/fbo-alphatest-nocolor-ff.c |2 --
tests/fbo/fbo-alphatest-nocolor.c |2 --
tests/fbo/fbo-bind-renderbuffer.c
The size of the window and the size of the FBO were mixed up in a few
places. Add missing FBO binding calls so the window can be resized.
Use an rb_size variable instead of hard-coded 100.
---
tests/fbo/fbo-gl_pointcoord.c | 23 +++
1 files changed, 15 insertions(+), 8 delet
---
tests/security/initialized-vbo.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/tests/security/initialized-vbo.c b/tests/security/initialized-vbo.c
index bed6ff2..6d2ff0e 100644
--- a/tests/security/initialized-vbo.c
+++ b/tests/security/initialized-vbo.c
@@ -40,8 +4
---
tests/shaders/activeprogram-bad-program.c |2 --
tests/shaders/activeprogram-get.c |2 --
tests/shaders/attribute0.c |2 --
.../shaders/createshaderprogram-attached-shaders.c |2 --
tests/shaders/createshaderprogram-bad-type.c
---
tests/shaders/fp-fog.c|2 --
tests/shaders/fp-incomplete-tex.c |2 --
tests/shaders/fp-long-alu.c |2 --
tests/shaders/getuniform-01.c |2 --
tests/shaders/getuniform-02.c |2 --
tests/shaders/glsl-explicit-l
---
tests/bugs/crash-cubemap-order.c|2 --
tests/bugs/crash-texparameter-before-teximage.c |2 --
tests/bugs/drawbuffer-modes.c |2 --
tests/bugs/fdo10370.c |2 --
tests/bugs/fdo14575.c |2 --
IT_FAIL;
+}
+
+void
+piglit_init(int argc, char **argv)
+{
+ glMatrixMode(GL_PROJECTION);
+ glLoadIdentity();
+
+ glMatrixMode(GL_MODELVIEW);
+ glLoadIdentity();
+}
Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
---
.../map_buffer_range_error_check.c |2 --
.../arb_map_buffer_range/map_buffer_range_test.c |2 --
2 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/tests/spec/arb_map_buffer_range/map_buffer_range_error_check.c
b/tests/spec/arb_map_buffer_range/map_buffe
---
tests/spec/arb_copy_buffer/copybuffersubdata.c |2 --
tests/spec/arb_copy_buffer/dlist.c |2 --
tests/spec/arb_copy_buffer/get.c |2 --
tests/spec/arb_copy_buffer/negative-bound-zero.c |2 --
tests/spec/arb_copy_buffer/negative-bounds.c |
---
.../spec/arb_texture_float/texture-float-formats.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/tests/spec/arb_texture_float/texture-float-formats.c
b/tests/spec/arb_texture_float/texture-float-formats.c
index edb6bc3..0a23736 100644
--- a/tests/spec/arb_texture_f
---
tests/spec/ext_fog_coord/modes.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/tests/spec/ext_fog_coord/modes.c b/tests/spec/ext_fog_coord/modes.c
index d21b3ed..5ed3b62 100644
--- a/tests/spec/ext_fog_coord/modes.c
+++ b/tests/spec/ext_fog_coord/modes.c
@@ -37,8 +3
---
tests/spec/arb_texture_storage/texture-storage.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/tests/spec/arb_texture_storage/texture-storage.c
b/tests/spec/arb_texture_storage/texture-storage.c
index e8bbd88..6d55fe6 100644
--- a/tests/spec/arb_texture_storage/tex
---
.../spec/arb_sampler_objects/sampler-incomplete.c |2 --
tests/spec/arb_sampler_objects/sampler-objects.c |2 --
2 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/tests/spec/arb_sampler_objects/sampler-incomplete.c
b/tests/spec/arb_sampler_objects/sampler-incomplete.c
---
tests/spec/ext_texture_array/maxlayers.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/tests/spec/ext_texture_array/maxlayers.c
b/tests/spec/ext_texture_array/maxlayers.c
index 4ac8b07..d17aaed 100644
--- a/tests/spec/ext_texture_array/maxlayers.c
+++ b/tests/spec/
Two of the tests had the prefix, two others didn't.
---
tests/spec/arb_sampler_objects/CMakeLists.gl.txt |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/spec/arb_sampler_objects/CMakeLists.gl.txt
b/tests/spec/arb_sampler_objects/CMakeLists.gl.txt
index c58f6f4..2
On 11/04/2012 01:11 PM, Eric Anholt wrote:
Brian Paul writes:
On 11/02/2012 10:52 AM, Paul Berry wrote:
On 2 November 2012 09:32, Brian Paulmailto:bri...@vmware.com>> wrote:
I think I've brought this up in the past. On Windows, the minimum
width of a window is 116
earColor(0.1, 0.1, 0.1, 1.0);
shaderSetup();
- setup_texcoords();
+ setup_texcoords(1.0);
}
enum piglit_result
Looks alright to me. For both: Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
h
I don't see any need for libpng either.
-Brian
On 11/05/2012 12:17 PM, Chad Versace wrote:
Brian and Jose,
Is libpng needed for the Windows build? It is unused on Linux.
On 10/24/2012 06:11 AM, gro...@gmail.com wrote:
From: Adrian Marius Negreanu
I haven't found any references to png, exce
This updates and renames the fdo9833.c test.
---
tests/all.tests|2 +-
tests/bugs/CMakeLists.gl.txt |1 -
tests/bugs/fdo9833.c | 47
tests/general/CMakeLists.gl.txt|1 +
tests/general/push-po
Two of the tests had the prefix, two others didn't.
---
tests/spec/arb_sampler_objects/CMakeLists.gl.txt |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/spec/arb_sampler_objects/CMakeLists.gl.txt
b/tests/spec/arb_sampler_objects/CMakeLists.gl.txt
index c58f6f4..2
---
piglit-print-commands.py | 14 +-
1 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/piglit-print-commands.py b/piglit-print-commands.py
index 951206b..5536856 100755
--- a/piglit-print-commands.py
+++ b/piglit-print-commands.py
@@ -42,6 +42,10 @@ def usage():
On 11/07/2012 10:16 AM, Eric Anholt wrote:
Brian Paul writes:
Two of the tests had the prefix, two others didn't.
---
tests/spec/arb_sampler_objects/CMakeLists.gl.txt |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/spec/arb_sampler_ob
Two of the tests had the prefix, two others didn't.
v2: update all.tests too
---
tests/all.tests |4 ++--
tests/spec/arb_sampler_objects/CMakeLists.gl.txt |4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/all.tests b/tests/all.t
On 11/07/2012 10:23 AM, Eric Anholt wrote:
Brian Paul writes:
On 11/04/2012 01:11 PM, Eric Anholt wrote:
Brian Paul writes:
On 11/02/2012 10:52 AM, Paul Berry wrote:
On 2 November 2012 09:32, Brian Paulmailto:bri...@vmware.com>> wrote:
I think I've brought this up
---
tests/all.tests |1 +
tests/general/CMakeLists.gl.txt |1 +
tests/general/vbo-map-unsync.c | 173 +++
3 files changed, 175 insertions(+), 0 deletions(-)
create mode 100644 tests/general/vbo-map-unsync.c
diff --git a/tests/all.test
On 11/11/2012 05:47 AM, Marek Olšák wrote:
With this patch committed, these tests are now broken:
glsl-arb-fragment-coord-conventions
glsl-kwin-blur-1
glsl-kwin-blur-2
glsl-orangebook-ch06-bump
OK, I've fixed these...
-Brian
___
Piglit mailing list
These tests probe specific pixel locations so the 100x100 size can't
be changed. Let the window be larger, but just draw to a 100x100 region.
---
tests/shaders/glsl-kwin-blur-1.c | 29 +++--
tests/shaders/glsl-kwin-blur-2.c | 29 +++--
2 files c
The pixel probing is very sensitive to the size of the rendering so
limit it to 100x100 regardless of window size.
---
tests/shaders/glsl-orangebook-ch06-bump.c | 17 ++---
1 files changed, 14 insertions(+), 3 deletions(-)
diff --git a/tests/shaders/glsl-orangebook-ch06-bump.c
b/te
The test requires a 100x100 rendering. Adjust the viewport and
probes to accomodate larger window sizes.
---
.../shaders/glsl-arb-fragment-coord-conventions.c | 44 ++--
1 files changed, 31 insertions(+), 13 deletions(-)
diff --git a/tests/shaders/glsl-arb-fragment-coord-conve
On 11/12/2012 11:33 AM, Stuart Abercrombie wrote:
Is this OK to go in?
Yeah, I thought I replied with an R-b.
-Brian
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
As we do glxinfo on Linux.
---
framework/core.py |9 +++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/framework/core.py b/framework/core.py
index 48771cf..5a97dba 100644
--- a/framework/core.py
+++ b/framework/core.py
@@ -29,6 +29,7 @@ import platform
import re
import
On 11/09/2012 10:54 AM, Eric Anholt wrote:
Brian Paul writes:
---
tests/all.tests |1 +
tests/general/CMakeLists.gl.txt |1 +
tests/general/vbo-map-unsync.c | 173 +++
3 files changed, 175 insertions(+), 0 deletions(-)
create
v2:
Remove some trailing whitespace.
Remove glFlushMappedBufferRange() code.
Require GL_ARB_map_buffer_range
Run as concurrent test.
---
tests/all.tests |1 +
tests/general/CMakeLists.gl.txt |1 +
tests/general/vbo-map-unsync.c | 170 ++
MPONENT, GL_FLOAT)&& pass;
+ pass = test_bad_readpixels(GL_STENCIL_INDEX, GL_FLOAT)&& pass;
+ glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0,
+ GL_RENDERBUFFER, 0);
+
+ piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
+}
Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
On 11/13/2012 03:13 PM, Anuj Phogat wrote:
It does error checking for glGenerateMipmap() with integer and
packed depth-stencil texture internal formats.
V2: Don't test formats which generate no error. They are covered
in other piglit tests.
Signed-off-by: Anuj Phogat
---
tests/all.tests
guess one more nitpick would be to add a glDeleteTextures() call,
but it's not a big deal for this kind of test.
Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
On 11/13/2012 04:59 PM, Chad Versace wrote:
CC: Brian Paul
Signed-off-by: Chad Versace
---
tests/util/wglew.h | 1363
1 file changed, 1363 deletions(-)
delete mode 100644 tests/util/wglew.h
I can't find any use of that header e
har **argv)
{
+ int i;
+
piglit_require_gl_version(20);
+ for (i = 0; i< argc; i++) {
+ if (strcmp(argv[i], "--exceed-limits") == 0)
+ exceed_limits = true;
+ }
+
printf("Vertical axis: Increasing numbers of varyings.\n");
printf("Horizontal axis: Which of the varyings contains the color.\n");
}
Reviewed-by: Brian Paul
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
ying-ff')
add_plain_test(shaders, 'glsl-mat-attribute')
-add_plain_test(shaders, 'glsl-max-varyings')
+shaders['glsl-max-varyings'] = concurrent_test('glsl-max-varyings')
add_plain_test(shaders, 'glsl-orangebook-ch06-bump')
return bool
instead of int.
+ piglit_width/2, piglit_height, green);
+
+ piglit_present_results();
+
+ return pass ? PIGLIT_PASS : PIGLIT_FAIL;
+}
+
+void
+piglit_init(int argc, char **argv)
+{
+}
Looks good otherwise.
Reviewed-by: Brian Paul
___
801 - 900 of 1411 matches
Mail list logo
