[Piglit] [PATCH 11/15] shader_runner: Build shader_runner_gles3

2012-12-07 Thread Chad Versace
Finally, all the prerequisite work is done. We can build shader_runner against GLES3. Unfortunately, until piglit-dispatch gains support for GLES3, we need separate binaries for the GL and GLES3 shader_runner. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/shaders

[Piglit] [PATCH 13/15] framework: New module shader_test.py

2012-12-07 Thread Chad Versace
This patch is a small refactor. It moves add_shader_test_dir() from all.tests into a new module, shader_test.py. Follow-on commits will expand the role of the new module. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- framework/shader_test.py | 45

[Piglit] [PATCH] shader_runner: Replace some macros with real functions

2012-12-11 Thread Chad Versace
For some GL functions that are not present in GLES3, in shader_runner_gles_workarounds.h I defined silly macros to suppress unused-variable warnings. This patch replaces the silly macros with less silly things: real functions. CC: Eric Anholt e...@anholt.net Signed-off-by: Chad Versace chad.vers

Re: [Piglit] [PATCH 10/15] shader_runner: Add GLES workarounds (v2)

2012-12-11 Thread Chad Versace
On 12/11/2012 04:00 PM, Eric Anholt wrote: Chad Versace chad.vers...@linux.intel.com writes: diff --git a/tests/shaders/shader_runner_gles_workarounds.h b/tests/shaders/shader_runner_gles_workarounds.h new file mode 100644 index 000..9a33d21 --- /dev/null +++ b/tests/shaders

Re: [Piglit] [PATCH] framework/shader_test: Assume the api is GL if no requirements are found

2012-12-11 Thread Chad Versace
On 12/11/2012 06:35 PM, Eric Anholt wrote: Chad Versace chad.vers...@linux.intel.com writes: Commit 260f211 caused some shader tests to regress with the message: Failed to find [require] block. This patch changes the python script that drives shader_runner to assume that the test's API

Re: [Piglit] [PATCH 1/4] util: Add piglit_result_to_string() helper

2012-12-12 Thread Chad Versace
On 12/06/2012 04:14 PM, Tom Stellard wrote: From: Tom Stellard thomas.stell...@amd.com --- tests/util/piglit-util.c | 21 + tests/util/piglit-util.h | 1 + 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/tests/util/piglit-util.c

Re: [Piglit] [PATCH 2/4] piglt: Add support for subtests v2

2012-12-12 Thread Chad Versace
-by: Chad Versace chad.vers...@linux.intel.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] Remove #version from variable indexing shader tests.

2012-12-12 Thread Chad Versace
On 12/10/2012 09:06 PM, Stuart Abercrombie wrote: shader_runner will insert #version based on GLSL =. Testing: same number of passes on Sandy Bridge. [This is truncated to pass the 100Kb message size limit] Once this patch lands, what's the next step? Do you have patches queued up that

Re: [Piglit] [PATCH] util: Add piglit_result_to_string() helper v2

2012-12-14 Thread Chad Versace
(-) Thanks for the simplifications. Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] Remove #version from variable indexing shader tests.

2012-12-17 Thread Chad Versace
On 12/17/2012 08:40 AM, Stuart Abercrombie wrote: shader_runner will insert #version based on GLSL =. Testing: same number of passes on Sandy Bridge. Signed-off-by: Stuart Abercrombie sabercrom...@chromium.org Reviewed-by: Chad Versace chad.vers...@linux.intel.com Reviewed-by: Tom Gall

Re: [Piglit] [PATCH 3/6] glsl, gles2: add shader/frag tests for gles2

2012-12-17 Thread Chad Versace
On 12/14/2012 12:01 PM, Tom Gall wrote: This is a set of trivial changes. In the appropriate set of tests/glslparsertests/shaders/*.frag which are targeted for glsl_version 1.10 or 1.20, add glsles_version: 1.00 which identifies the test as appropriate for glsl es 1.0 which lines up

Re: [Piglit] [PATCH 1/6] glsl: gles2: add version 100

2012-12-17 Thread Chad Versace
on implementing GLES2 support, and that's fine. I'm just making a note of where future additional changes. Other than the name change, the patch is: Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ Piglit mailing list Piglit

Re: [Piglit] [PATCH 1/6] glsl: gles2: add version 100

2012-12-19 Thread Chad Versace
On 12/19/2012 11:11 AM, Eric Anholt wrote: Chad Versace chad.vers...@linux.intel.com writes: On 12/14/2012 12:01 PM, Tom Gall wrote: This is a small change in two parts to repair support for gles2 by glslparsertest. To glslparsertest.c, add 100 into the list of versions the switch handles

Re: [Piglit] [PATCH 1/1] gles3: use _${piglit_target_api} for testcase names

2012-12-28 Thread Chad Versace
On 12/17/2012 03:42 PM, Tom Gall wrote: Use _${piglit_target_api} as the suffix of testcase binaries to to be consistant across piglit as suggested by Chad Versace. Signed-off-by: Tom Gall tom.g...@linaro.org --- Ah, you caught my mistake. Reviewed-by and committed

Re: [Piglit] [PATCH 6/7] Allow es3conform tests to run on Sandybridge

2012-12-28 Thread Chad Versace
On 12/22/2012 11:35 AM, Jordan Justen wrote: On Sat, Dec 22, 2012 at 6:19 AM, Carl Worth cwo...@cworth.org wrote: Matt Turner matts...@gmail.com writes: On Fri, Dec 21, 2012 at 5:18 PM, Carl Worth cwo...@cworth.org wrote: Without this, the tests silently do nothing on my Thinkpad X220. ---

Re: [Piglit] piglit-dispatch for gles

2013-01-03 Thread Chad Versace
On 01/02/2013 05:16 PM, Paul Berry wrote: On 2 January 2013 15:28, Tom Gall tom.g...@linaro.org mailto:tom.g...@linaro.org wrote: Hi All, I was looking at some of the piglit-dispatch code experimenting a bit with the intent to implement it for gles and was wondering where did

Re: [Piglit] piglit-dispatch for gles

2013-01-04 Thread Chad Versace
On 01/03/2013 01:31 PM, Tom Gall wrote: On Thu, Jan 3, 2013 at 12:48 PM, Chad Versace chad.vers...@linux.intel.com wrote: On 01/03/2013 10:00 AM, Tom Gall wrote: What if instead of parsing over the c source file, why not run the test with a --tell-me-what-you-support sort of flag? Spit

Re: [Piglit] [PATCH] arb_es2_compatibility-releaseshadercompiler-ge7: test glReleaseShaderCompiler crash

2013-01-07 Thread Chad Versace
that are needed later by the linker. The test passes with NVIDIA's driver. --- Looks good to me. Reviewed-by: Chad Versace chad.vers...@linux.intel.com I'm surprised that you explicitly set config.window_width/height rather than leaving them at the defaults. Did you intend to do

Re: [Piglit] [PATCH 1/1] shader_runner: add gles2 support and simple testcase

2013-01-07 Thread Chad Versace
On 12/28/2012 02:26 PM, Tom Gall wrote: Fix shader_test.py so it uses shader_runner_gles2 when running a shader test with GL 2.00 es in the [required] section. ^^ It should be GL 2.0 es. Though, shader_runner accepts GL 2.00 es because it's sloppy. Otherwise, the

Re: [Piglit] [PATCH 1/2] Add [require] section to .shader_test files missing it.

2013-01-09 Thread Chad Versace
-channels.shader_test |3 +++ ...ltin-global-from-fn-unknown-to-main.shader_test |3 +++ 13 files changed, 39 insertions(+), 0 deletions(-) Stuart, I'm going through my email backlog and found this patch. It is Reviewed-by: Chad Versace chad.vers...@linux.intel.com It's been a while since you

Re: [Piglit] [PATCH 2/2] Remove .shader_test #version / GLSL = mismatches.

2013-01-09 Thread Chad Versace
changed, 5 insertions(+), 14 deletions(-) Stuart, I'm going through my email backlog and found this patch. It is Reviewed-by: Chad Versace chad.vers...@linux.intel.com It's been a while since you submitted it... do you still want me to commit it for you

[Piglit] [PATCH 1/2] shader_runner_gles2: Remove unused variable warnings

2013-01-09 Thread Chad Versace
to glMapBuffer are unused. This patch fixes the warnings by changing the macro form to #define glMapBuffer(...) UNDEFINED_FUNCTION(glMapBuffer, 0, __VA_ARGS__) which gets expanded to the call unsupported_function(glMapBuffer, 0, __VA_ARGS__) CC: Tom Gall tom.g...@linaro.org Signed-off-by: Chad Versace

[Piglit] [PATCH 1/2] util: Add utility to simulate GLSL packing functions

2013-01-09 Thread Chad Versace
strengths. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/CMakeLists.no_api.txt | 3 + tests/util/glsl-packing.c| 799 +++ 2 files changed, 802 insertions(+) create mode 100644 tests/util/glsl-packing.c diff --git a/tests/util

[Piglit] [PATCH 2/2] glsl-es-3.00: Generate tests for builtin packing functions

2013-01-09 Thread Chad Versace
-off-by: Chad Versace chad.vers...@linux.intel.com --- generated_tests/CMakeLists.txt | 7 +- generated_tests/gen_builtin_packing_tests.py | 899 +++ tests/util/glsl-packing.c| 18 +- 3 files changed, 912 insertions(+), 12 deletions

Re: [Piglit] [PATCH] Alter shader_runner GL/GLSL ES version requirement syntax.

2013-01-16 Thread Chad Versace
, 15 insertions(+), 24 deletions(-) Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [RFC PATCH] glsl-es-3.00: Generate tests for builtin packing functions (v2)

2013-01-21 Thread Chad Versace
. On Intel Sandybridge, reduces test generation time from 2m to 2s. CC: Paul Berry stereotype...@gmail.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- This patch lives on my gles3-glsl-packing branch. Tested against my mesa gles3-glsl-packing-branch on Intel gen7

Re: [Piglit] [PATCH 1/2] shader_runner regression with gles

2013-01-21 Thread Chad Versace
On 01/17/2013 03:08 PM, Tom Gall wrote: Augment the parser that examines the shader_test file passed in with the test to determine which brand of shader_running to execute, shader_runner, shader_runner_gles2, etc. This fixes a bug where GLSL ES if first in the [required] section could match

[Piglit] [PATCH] glsl-es-3.00: Generate tests for builtin packing functions (v2)

2013-01-21 Thread Chad Versace
to generate a smaller set of inputs for packHalf2x16 in order to avoid Linux's oom-killer. CC: Paul Berry stereotype...@gmail.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- generated_tests/CMakeLists.txt |6 +- generated_tests/gen_builtin_packing_tests.py

Re: [Piglit] [PATCH] glsl-es-3.00: Generate tests for builtin packing functions (v2)

2013-01-22 Thread Chad Versace
On 01/22/2013 10:24 AM, Paul Berry wrote: On 21 January 2013 15:24, Chad Versace chad.vers...@linux.intel.com wrote: Generate the following test files: {const,vs,fs}-{pack,unpack}{Snorm,Unorm,Half}2x16.shader_test The tests are generated by a new Python script

Re: [Piglit] [PATCH] glsl-es-3.00: Generate tests for builtin packing functions (v2)

2013-01-23 Thread Chad Versace
On 01/22/2013 07:55 PM, Matt Turner wrote: On Mon, Jan 21, 2013 at 3:24 PM, Chad Versace chad.vers...@linux.intel.com wrote: +# +# Inputs for GLSL functions

Re: [Piglit] [PATCH] glsl-es-3.00: Generate tests for builtin packing functions (v2)

2013-01-23 Thread Chad Versace
On 01/23/2013 08:52 AM, Paul Berry wrote: On 21 January 2013 15:24, Chad Versace chad.vers...@linux.intel.com wrote: +def make_inputs_for_pack_half_2x16(): +# The domain of packHalf2x16 is ([-inf, +inf] + {NaN})^2. The function +# does not clamp its input. +# +# We test

Re: [Piglit] [PATCH] ARB_shading_language_packing: Generate tests for builtin packing functions

2013-01-28 Thread Chad Versace
,vs,fs}-{pack,unpack}Half2x16.shader_test --- generated_tests/gen_builtin_packing_tests.py | 339 ++ 1 files changed, 286 insertions(+), 53 deletions(-) Looks good to me. Reviewed-by: Chad Versace chad.vers...@linux.intel.com

Re: [Piglit] [PATCH 1/3] android: piglit-vbo.cpp compile error

2013-01-28 Thread Chad Versace
Thanks. These are reviewed-by me and now committed. By the way, which Piglit branch are you using for Android? ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH 1/2] egl_khr_create_context: Fix for drivers that don't support GL = 2.0

2013-01-28 Thread Chad Versace
: https://bugs.freedesktop.org/show_bug.cgi?id=59510 Reported-by: Lu Hua huax...@intel.com CC: Matt Turner matts...@gmail.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/egl/spec/egl_khr_create_context/default-minor-version-gl.c | 6 -- 1 file changed, 4 insertions(+), 2

[Piglit] [PATCH 2/2] egl_khr_create_context: Explain why context creation must succeed

2013-01-28 Thread Chad Versace
...@gmail.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/egl/spec/egl_khr_create_context/default-major-version-gles.c | 3 +++ tests/egl/spec/egl_khr_create_context/default-minor-version-gles.c | 4 2 files changed, 7 insertions(+) diff --git a/tests/egl/spec

[Piglit] etc1: Fix basic API test

2013-01-29 Thread Chad Versace
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=55147 ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH 1/3] etc1: Fix glTexImage2D call in basic API test

2013-01-29 Thread Chad Versace
to GL_ETC1_RGB8_OES. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=55147 Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- .../oes_compressed_etc1_rgb8_texture-basic.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tests/spec

[Piglit] [PATCH 2/3] etc1: Fix glTexSubImage2D call in basic API test

2013-01-29 Thread Chad Versace
: If the imageSize parameter is not consistent with the format, dimensions, and contents of the compressed image, an INVALID VALUE error results. This patch fixes the size. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=55147 Signed-off-by: Chad Versace chad.vers...@linux.intel.com

[Piglit] [PATCH 3/3] etc1: Document expected errors in basic API test

2013-01-29 Thread Chad Versace
Document why we expect GL_INVALID_OPERATION from gl*TexSubImage2D calls. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- .../oes_compressed_etc1_rgb8_texture-basic.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/spec

Re: [Piglit] [PATCH 3/3] Make shader_runner require [require] and GLSL version requirement.

2013-02-06 Thread Chad Versace
The series looks good to me. I'll add the r-b's and commit. On 02/05/2013 10:42 AM, Stuart Abercrombie wrote: So is this OK to go in? Stuart On Fri, Feb 1, 2013 at 3:26 PM, Stuart Abercrombie sabercrom...@google.comwrote: Re-adding the list I removed by mistake. I agree we might

Re: [Piglit] [PATCH] Using waffle, only prevent X11 windows from taking focus in automatic mode.

2013-02-06 Thread Chad Versace
Michel, thanks for doing this! On 02/06/2013 08:25 AM, Brian Paul wrote: On 02/06/2013 09:09 AM, Michel Dänzer wrote: On Mit, 2013-02-06 at 07:44 -0700, Brian Paul wrote: On 02/06/2013 02:38 AM, Michel Dänzer wrote: From: Michel Dänzermichel.daen...@amd.com Otherwise this prevents any

Re: [Piglit] [PATCH] Revert shader_runner: Require [require] and GLSL version requirement.

2013-02-06 Thread Chad Versace
Do it. On 02/06/2013 02:50 PM, Eric Anholt wrote: This reverts commit de1d4aa0f2f2d14cd0fd04dec593bf151dcbad8a. The commit broke the ARB_fragment_program texturing tests. --- tests/shaders/shader_runner.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git

[Piglit] [PATCH 0/2] shader_runner: Add stricter requirements for [require] section

2013-02-06 Thread Chad Versace
and mesa master. Chad Versace (2): shader_runner: Require [require] section shader_runner: Require either a GLSL version or GL_ARB_fp extension tests/shaders/shader_runner.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) -- 1.8.1.1

Re: [Piglit] [PATCH 0/2] shader_runner: Add stricter requirements for [require] section

2013-02-06 Thread Chad Versace
little 2-patch series is moot. There's no reason now for me to send the missing emails. On Wed, Feb 6, 2013 at 5:37 PM, Chad Versace chad.vers...@linux.intel.comwrote: This 2-patch series is based on Stuart's patch, titled shader_runner: Require [require] and GLSL version requirement I

Re: [Piglit] [PATCH] invalid-es3-queries: Check that GL_MAX_VARYING_COMPONENTS is rejected

2013-02-08 Thread Chad Versace
Reviewed-by: Chad Versace chad.vers...@linux.intel.com On 02/07/2013 04:52 PM, Matt Turner wrote: --- See associated Mesa patch: mesa: Allow glGet* queries of MAX_VARYING_COMPONENTS in ES 3 tests/spec/gles-2.0/invalid-es3-queries.c |1 + 1 files changed, 1 insertions(+), 0

Re: [Piglit] [PATCH] Remove BindBufferRange out-of-range tests.

2013-02-08 Thread Chad Versace
changed, 8 deletions(-) This seems reasonable to me. Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 1/3] Add the shell script identifiers to the tests.

2013-02-08 Thread Chad Versace
The *.tests files are not executables, so they shouldn't contain a shebang (#!) line. I'm not an emacs user, but I believe it should be possible to accomplish your goal by adding information to the `-*-` line. On 02/07/2013 01:10 PM, Kenney Phillis wrote: This is extremely useful for distributed

[Piglit] [PATCH] gles-2.0: Check illegality of attaching multiple shader objects of same type

2013-02-12 Thread Chad Versace
. This test checks that GL_INVALID_OPERATION is generated. CC: Tapani Pälli tapani.pa...@intel.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/all.tests | 1 + tests/spec/gles-2.0/CMakeLists.gles2.txt | 1 + tests/spec/gles-2.0/multiple

Re: [Piglit] Core context tests and ARB_compatibility

2013-02-13 Thread Chad Versace
a84f39fcf8e16f421aeed1fe6b60fc631108c5b9 Author: Chad Versace chad.vers...@linux.intel.com Date: Wed Dec 19 12:04:53 2012 -0800 glx: Add glXCreateContextAttribs workaround for NVidia bug With NVidia, calling glXCreateContextAttribsARB with MAJOR=1 and MINOR=0 returns an OpenGL 2.1

[Piglit] [PATCH 0/3] egl: Add test for eglTerminate

2013-02-15 Thread Chad Versace
. [...] The test segfaults on Mesa with Intel Sandybridge. Chad Versace (3): util: Move EGL utilities from libpiglitutil_gl to libpiglitutil egl: Fix CMake traversal into egl/spec dir egl-1.4: Add test egl-terminate-then-unbind-context tests/all.tests| 1

[Piglit] [PATCH 2/3] egl: Fix CMake traversal into egl/spec dir

2013-02-15 Thread Chad Versace
CMake should add the egl/spec directory even if Piglit is not building desktop GL tests. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/egl/CMakeLists.gl.txt | 2 -- tests/egl/CMakeLists.txt| 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/egl

[Piglit] [PATCH 3/3] egl-1.4: Add test egl-terminate-then-unbind-context

2013-02-15 Thread Chad Versace
-by: Chad Versace chad.vers...@linux.intel.com --- tests/all.tests| 1 + tests/egl/spec/CMakeLists.txt | 1 + tests/egl/spec/egl-1.4/CMakeLists.no_api.txt | 8 ++ tests/egl/spec/egl-1.4/CMakeLists.txt | 1 + .../egl-1.4

Re: [Piglit] [PATCH 1/6] shader_runner and glslparsertest: choose GL version more accurately.

2013-02-20 Thread Chad Versace
On 02/20/2013 07:13 AM, Paul Berry wrote: On 19 February 2013 23:11, Michel Dänzer mic...@daenzer.net mailto:mic...@daenzer.net wrote: On Die, 2013-02-19 at 12:52 +0100, Michel Dänzer wrote: On Mon, 2013-02-18 at 10:14 -0800, Paul Berry wrote: On 18 February 2013 07:53,

Re: [Piglit] New piglit/waffle with older X server

2013-02-20 Thread Chad Versace
On 02/20/2013 12:26 PM, Carl Worth wrote: I recently ran into a bunch of piglit tests not getting run, (returning skip), when they used to work fine. The tests say things like: piglit: info: Failed to create GL 2.0 compatibility context piglit: info: Failed to create any GL

[Piglit] [PATCH 0/3] Fix shader_runner tests for drivers that lack GLX_ARB_create_context

2013-02-20 Thread Chad Versace
please verify that this fix works? I don't have a driver on hand that lacks GLX_ARB_create_context. Chad Versace (3): util/waffle: Print message when falling back to compatibility context util/waffle: Refactor make_context_current() util/waffle: More wisely handle compat context versions 1.0

[Piglit] [PATCH 1/3] util/waffle: Print message when falling back to compatibility context

2013-02-20 Thread Chad Versace
the fallback occurs. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-framework-gl/piglit_wfl_framework.c | 9 + 1 file changed, 9 insertions(+) diff --git a/tests/util/piglit-framework-gl/piglit_wfl_framework.c b/tests/util/piglit-framework-gl

[Piglit] [PATCH 2/3] util/waffle: Refactor make_context_current()

2013-02-20 Thread Chad Versace
This refactor makes the function body more readable. Understanding the function no longer requires the reader to track the value of `ok` throughout the function body. Also, some conditional branches have been removed by using early returns. Signed-off-by: Chad Versace chad.vers

[Piglit] [PATCH 3/3] util/waffle: More wisely handle compat context versions 1.0

2013-02-20 Thread Chad Versace
. If context creation succeeds, Piglit checks that the actual context version satifies the requested version and skips the test accordingly. CC: Paul Berry stereotype...@gmail.com CC: Michel Dänzer mic...@daenzer.net Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-framework

Re: [Piglit] [PATCH 3/3] depthstencil-render-miplevels: Present the results in non-auto mode.

2013-02-27 Thread Chad Versace
On 02/26/2013 12:39 PM, Eric Anholt wrote: I tried to make the presentation be the data that was originally probed -- there's a second readpixels that's unfortunately, but we do ^^ Is that's a typo? use separate textures so that any workaround

Re: [Piglit] [PATCH RESEND 3/3] glslparsertest: Avoid uninitialized vars in parse_glsl_version_number.

2013-02-27 Thread Chad Versace
, but it's not obvious. With that, the series is: Reviewed-by: Chad Versace chad.vers...@linux.intel.com By the way, I do prefer Tom's suggestions to use runtime detection in patches 1 and 2. That would be one less thing to clean up when we switch to unified binaries. But, it doesn't really matter

Re: [Piglit] [RFC 1/3] framework: introduce interface for external buffers

2013-03-01 Thread Chad Versace
On 02/26/2013 05:15 AM, Topi Pohjolainen wrote: In order to test the OES_EGL_image_external with planar formats such as YUV420 or NV12, one needs a way for creating buffers that can be passed to EGL and filling them with YUV-data for the GL-stack to sample. By the nature the extension in

Re: [Piglit] [RFC 2/3] framework: gbm: support for creating external buffers

2013-03-01 Thread Chad Versace
On 02/26/2013 05:15 AM, Topi Pohjolainen wrote: Getting direct access to the gbm device through the waffle display and creating the buffer is rather straightforward thing to do. Writing to the buffer using CPU, however, requires priviledges for the underlying gem-ioctl. Signed-off-by: Topi

Re: [Piglit] [RFC 3/3] tests/spec: add tests for oes image external

2013-03-01 Thread Chad Versace
On 02/26/2013 05:15 AM, Topi Pohjolainen wrote: This consists of tests adapted from Khronos conformance suite and Android surface flinger. While the former deals with getters/setters, enumrations and simple sampling of texture based images, the latter addresses bilinear sampling of non-GPU

Re: [Piglit] [PATCH 1/1] glsl-es-1.00: sanity.shader_test fragment needs default precision

2013-04-09 Thread Chad Versace
On 03/20/2013 11:30 AM, Tom Gall wrote: GLSL ES 1.00 spec 4.5.3 page 36: The fragment language has no default precision qualifier for floating point types. Adding default precision for float in the fragment shader so this sanity testcase doesn't error out. mediump is choosen since according to

Re: [Piglit] [PATCH 1/2] gtf: Upstream appears to have switched to imagefileio off by default.

2013-04-09 Thread Chad Versace
does the patch do? That little extra doesn't help much for patch review, but it does help when reading the git log. Anyways, for both patches Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ Piglit mailing list Piglit@lists.freedesktop.org

Re: [Piglit] [PATCH] Rework the PIGLIT_GL_VISUAL flags, fix RGB vs RGBA vs ALPHA confusion

2013-04-17 Thread Chad Versace
my Reviewed-by: Chad Versace chad.vers...@linux.intel.com On 04/13/2013 01:01 AM, Marek Olšák wrote: OK, but I would like to commit this conversion code instead of hacking the bits: diff --git a/tests/util/piglit-framework-gl/piglit_glut_framework.c b/tests/util/piglit-framework-gl

Re: [Piglit] Requiring Python 3.x for Piglit?

2013-04-17 Thread Chad Versace
On 04/17/2013 05:48 PM, Kenneth Graunke wrote: Does anyone object to porting to Python 3.x (and dropping 2.x support)? Some useful data points: - Debian stable has 3.1, testing/unstable have 3.2 - Fedora 18 and Arch Linux have 3.3 - Windows installers for 3.3 are available on python.org - Mac

Re: [Piglit] [PATCH 1/3] framework: hardware independent interface for dma buffers

2013-04-24 Thread Chad Versace
with that little nitpick, so this patch is Reviewed-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-framework-gl.c | 23 ++ tests/util/piglit-framework-gl.h | 18 + .../util/piglit-framework-gl

Re: [Piglit] [PATCH 2/3] framework: support for creating dma buffers through libdrm

2013-04-24 Thread Chad Versace
On 04/16/2013 12:45 PM, Topi Pohjolainen wrote: In order to test EXT_image_dma_buf_import one needs the capability of creating driver specific buffers. By probing the environment for drm libraries one can decide for which drivers the support is to be built. Signed-off-by: Topi Pohjolainen

Re: [Piglit] [PATCH 3/3] tests: spec: tests for EXT_image_dma_buf_import

2013-04-24 Thread Chad Versace
On 04/16/2013 12:45 PM, Topi Pohjolainen wrote: These are rather simple. Without the capability of creating textures out of the images (glEGLImageTargetTexture2DOES()), one cannot do much with the images as such. Extra attention should be paid to the buffer lifecycle: 3. Does ownership of

Re: [Piglit] [v5 02/12] framework: hardware independent interface for dma buffers

2013-05-07 Thread Chad Versace
); Is it safe to pass NULL to this function, like free()? Please document that. With that documentation, this patch is Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [Piglit] [v5 03/12] framework: support for creating dma buffers through libdrm

2013-05-07 Thread Chad Versace
On 05/03/2013 04:26 AM, Topi Pohjolainen wrote: In order to test EXT_image_dma_buf_import one needs the capability of creating driver specific buffers. By probing the environment for drm libraries one can decide for which drivers the support is to be built. v2 (first five according to Chad's

Re: [Piglit] [v5 02/12] framework: hardware independent interface for dma buffers

2013-05-07 Thread Chad Versace
On 05/07/2013 02:13 PM, Chad Versace wrote: On 05/03/2013 04:26 AM, Topi Pohjolainen wrote: In order to test the EXT_image_dma_buf_import, one needs a way for creating dma buffers that can be imported to EGL and filling them with data for the GL-stack to sample. While dma buffer themselves

Re: [Piglit] [v5 07/12] tests: spec: EXT_image_dma_buf_import fd ownership transfer

2013-05-07 Thread Chad Versace
On 05/03/2013 04:26 AM, Topi Pohjolainen wrote: Simple test checking that EGL can close the export file handle and the creator can in turn can its reference. Without a verb, the second phrase above is a bit too elliptical. How about can in turn $VERB its reference? Signed-off-by: Topi

Re: [Piglit] [v5 04/12] tests: spec: EXT_image_dma_buf_import invalid hints

2013-05-07 Thread Chad Versace
On 05/07/2013 04:04 PM, Eric Anholt wrote: Chad Versace chad.vers...@linux.intel.com writes: On 05/03/2013 02:23 PM, Eric Anholt wrote: Topi Pohjolainen topi.pohjolai...@intel.com writes: diff --git a/tests/spec/ext_image_dma_buf_import/CMakeLists.gles1.txt b/tests/spec

[Piglit] [PATCH] framework: support for creating dma buffers through libdrm (v4)

2013-05-14 Thread Chad Versace
From: Topi Pohjolainen topi.pohjolai...@intel.com In order to test EXT_image_dma_buf_import one needs the capability of creating driver specific buffers. By probing the environment for drm libraries one can decide for which drivers the support is to be built. v2 (first five according to Chad's

Re: [Piglit] [v5 10/12] tests: spec: EXT_image_dma_buf_import sample argb with miptree

2013-05-14 Thread Chad Versace
On 05/03/2013 04:26 AM, Topi Pohjolainen wrote: Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- .../ext_image_dma_buf_import/CMakeLists.gles2.txt | 14 ++ .../ext_image_dma_buf_import/sample_argb.c | 217 + 2 files changed, 231 insertions(+)

Re: [Piglit] [PATCH] util: Don't call exit() after piglit_report_result()

2013-05-30 Thread Chad Versace
On 05/29/2013 02:46 PM, Ian Romanick wrote: On 05/15/2013 11:29 AM, Chad Versace wrote: Any call to exit() that follows piglit_report_result() is nothing more than confusing dead code. piglit_report_result() already calls exit(), and chooses the exit code according to the PIGLIT_$RESULT value

[Piglit] [PATCH] util/x11: Don't spin when waiting for X events

2013-05-30 Thread Chad Versace
); } CC: Eric Anholt e...@anholt.net CC: Paul Berry stereotype...@gmail.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-framework-gl/piglit_x11_framework.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tests/util/piglit-framework-gl

[Piglit] [PATCH] oes_fixed_point: Add ES1 test for fixed-point attribute arrays

2013-06-03 Thread Chad Versace
Test GL_FIXED with glColorPointer and glVertexPointer. Verifies Mesa commit 7a9f4d3e. CC: Kenneth Graunke kenn...@whitecape.org CC: Eric Anholt e...@anholt.net Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/all.tests| 4 + tests/spec

Re: [Piglit] [PATCH 2/3] util/x11: Wait for expose event in manual mode or with front buffer tests.

2013-06-03 Thread Chad Versace
pass consistently. Based on work by Chad Versace. Cc: Chad Versace chad.vers...@linux.intel.com Cc: Eric Anholt e...@anholt.net --- tests/util/piglit-framework-gl/piglit_winsys_framework.c | 15 ++- tests/util/piglit-framework-gl/piglit_x11_framework.c| 5 - 2 files changed

Re: [Piglit] [v7 02/12] framework: support for creating dma buffers through libdrm

2013-06-03 Thread Chad Versace
Reviewed-by: Eric Anholt e...@anholt.net Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [v7 05/12] tests: spec: EXT_image_dma_buf_import invalid attributes

2013-06-03 Thread Chad Versace
On 05/28/2013 02:51 AM, Topi Pohjolainen wrote: v2: - compile only on platforms that have drm (Eric) - use standard drm definitions for fourcc instead of duplicated local (Daniel, Eric) - use helper variables for width, height and cpp instead of repeating the magic

Re: [Piglit] [v7 06/12] tests: spec: EXT_image_dma_buf_import missing attributes

2013-06-03 Thread Chad Versace
On 05/28/2013 02:51 AM, Topi Pohjolainen wrote: v2: - compile only on platforms that have drm (Eric) - use standard drm definitions for fourcc instead of duplicated local (Daniel, Eric) - removed irrelevant quotes of the spec (Eric) - rewritten attribute test vector using a

Re: [Piglit] [v9 01/13] glapi: fix parsing of extensions containing string EGL_

2013-08-19 Thread Chad Versace
-by: Chad Versace chad.vers...@linux.intel.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [v9 02/13] framework: gl-profile style image probe for gles

2013-08-19 Thread Chad Versace
instead be util or util/gl. With those two things fixed, this patch is Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [v9 09/13] tests/spec: EXT_image_dma_buf_import fd ownership transfer

2013-08-19 Thread Chad Versace
On 08/19/2013 10:45 AM, Chad Versace wrote: On 08/09/2013 03:43 AM, Topi Pohjolainen wrote: Simple test checking that EGL closes the export file handle and the creator can in turn drop its reference. v2: - compile only on platforms that have drm (Eric) - use standard drm definitions

Re: [Piglit] [v9 09/13] tests/spec: EXT_image_dma_buf_import fd ownership transfer

2013-08-19 Thread Chad Versace
On 08/19/2013 10:45 AM, Chad Versace wrote: On 08/09/2013 03:43 AM, Topi Pohjolainen wrote: Simple test checking that EGL closes the export file handle and the creator can in turn drop its reference. v2: - compile only on platforms that have drm (Eric) - use standard drm definitions

Re: [Piglit] [v9 09/13] tests/spec: EXT_image_dma_buf_import fd ownership transfer

2013-08-19 Thread Chad Versace
On 08/19/2013 10:45 AM, Chad Versace wrote: On 08/09/2013 03:43 AM, Topi Pohjolainen wrote: Simple test checking that EGL closes the export file handle and the creator can in turn drop its reference. v2: - compile only on platforms that have drm (Eric) - use standard drm definitions

Re: [Piglit] [v9 12/13] tests/spec: EXT_image_dma_buf_import intel dma-buf with img-ext only

2013-08-19 Thread Chad Versace
of determining the driver's vendor into core piglit, into piglit-util*.c. But, using hand-rolled code here in piglit_init() is good for now. With the small typo fixed, this is Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ Piglit mailing list

Re: [Piglit] [v9 13/13] tests/spec: EXT_image_dma_buf_import intel img-ext with dma-buf only

2013-08-19 Thread Chad Versace
the image as target for an external texture, and expects the attempt to fail with GL_INVALID_OPERATION. With that clarification, Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ Piglit mailing list Piglit@lists.freedesktop.org http

Re: [Piglit] [v9 11/13] tests/spec: EXT_image_dma_buf_import intel unsupported format

2013-08-19 Thread Chad Versace
+ .../intel_unsupported_format.c | 114 + 3 files changed, 116 insertions(+) create mode 100644 tests/spec/ext_image_dma_buf_import/intel_unsupported_format.c Reviewed-by: Chad Versace chad.vers...@linux.intel.com

Re: [Piglit] [v9 09/13] tests/spec: EXT_image_dma_buf_import fd ownership transfer

2013-08-19 Thread Chad Versace
On 08/09/2013 03:43 AM, Topi Pohjolainen wrote: Simple test checking that EGL closes the export file handle and the creator can in turn drop its reference. v2: - compile only on platforms that have drm (Eric) - use standard drm definitions for fourcc instead of duplicated local

Re: [Piglit] [v9 10/13] tests/spec: EXT_image_dma_buf_import sample argb

2013-08-19 Thread Chad Versace
On 08/09/2013 03:43 AM, Topi Pohjolainen wrote: Tests that one can sample the given buffer without other mipmap levels by setting texture filtering accordingly. v2: - compile only on platforms that have drm (Eric) - use standard drm definitions for fourcc instead of duplicated

Re: [Piglit] [v10 09/13] tests/spec: EXT_image_dma_buf_import fd ownership transfer

2013-08-23 Thread Chad Versace
On 08/20/2013 03:16 AM, Topi Pohjolainen wrote: Simple test checking that EGL closes the export file handle and the creator can in turn drop its reference. Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ Piglit mailing list Piglit

Re: [Piglit] [v10 10/13] tests/spec: EXT_image_dma_buf_import sample argb

2013-08-23 Thread Chad Versace
On 08/20/2013 03:16 AM, Topi Pohjolainen wrote: Tests that one can sample the given buffer without other mipmap levels by setting texture filtering accordingly. Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ Piglit mailing list Piglit

Re: [Piglit] [PATCH v2 4/5] piglit-util-gl-common: Add Function to clear extensions list.

2013-09-03 Thread Chad Versace
On 08/23/2013 11:51 AM, Kenney Phillis wrote: The default handling of the extensions does not allow for proper fall back of contexts to work as inteded. There is currently no guarantee that any implementations of OpenGL will have the pointer of supported extensions will remain constant after

Re: [Piglit] [PATCH v2 5/5] util/waffle: reinitialize extensions

2013-09-03 Thread Chad Versace
On 08/23/2013 11:51 AM, Kenney Phillis wrote: When context creation fails, Inform piglit to reinitialize the list of supported extensions. --- .../piglit-framework-gl/piglit_wfl_framework.c |2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Piglit] [PATCH v2 1/5] fbo-storage-formats: Fix reporting of invalid formats.

2013-09-03 Thread Chad Versace
On 08/23/2013 11:51 AM, Kenney Phillis wrote: Currently Invalid formats is reported from the formats data structure. This is incorrect because the invalid formats set should not use this system. --- tests/fbo/fbo-storage-formats.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Piglit] [PATCH v2 3/5] fbo-storage-formats:minor improvements to error detection.

2013-09-03 Thread Chad Versace
instead, and this gets Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

<    1   2   3   4   5   6   >